I played around array_func.c
many of the code can be used for multiset data type.
now I imagine multiset as something like one dimension array. (nested is
somehow beyond the imagination...).
* A standard varlena array has the following internal structure:
*- standard varlena header word
*
Tomas Vondra писал 2023-06-22 17:16:
On 6/22/23 13:46, Tomas Vondra wrote:
...
I haven't tried the reproducer, but I think I see the issue - we store
the bitmap as part of the event to be executed later, but the bitmap
is
in per-tuple context and gets reset. So I guess we need to copy it
into
On Thu, Jun 22, 2023 at 09:45:18AM -0700, Andres Freund wrote:
> On 2023-06-21 21:50:39 -0700, Noah Misch wrote:
> > On Wed, Jun 21, 2023 at 03:12:08PM -0700, Andres Freund wrote:
> > > When vac_truncate_clog() returns early
> > ...
> > > we haven't released the lwlock that we acquired earlier
> >
On Tue, Jun 20, 2023 at 06:44:20PM -0500, Justin Pryzby wrote:
> On Tue, Jun 13, 2023 at 02:50:30PM +0900, Michael Paquier wrote:
>> On Mon, Jun 12, 2023 at 02:37:15PM -0700, Nathan Bossart wrote:
>> > Fair enough. I know I've been waffling in the GUC versus function
>> > discussion, but FWIW v7 o
On Tue, Jun 20, 2023 at 01:42:13PM +0200, Jelte Fennema wrote:
Thanks for updating the patch.
> On Tue, 20 Jun 2023 at 06:18, Michael Paquier wrote:
>> The amount of duplication between the describe and close paths
>> concerns me a bit. Should PQsendClose() and PQsendDescribe() be
>> merged int
Hi,
I’ve just stumbled upon this patch and thread and thought I could share an idea
of adding an optional temporary secret to SET SESSION AUTHORIZATION so that it
is only possible to RESET SESSION AUTHORIZATION by providing the same secret
,like:
SET SESSION AUTHORIZATION [role] GUARDED BY ‘[s
On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada wrote:
>
> Hi,
>
> In logical decoding, we don't need to collect decoded changes of
> aborted transactions. While streaming changes, we can detect
> concurrent abort of the (sub)transaction but there is no mechanism to
> skip decoding changes of tran
Nearby I dissed psql's \du command for its incoherent "Attributes"
column [1]. It's too late to think about changing that for v16,
but here's some things I think we should consider for v17:
* It seems weird that some attributes are described in the negative
("Cannot login", "No inheritance"). I
"Jonathan S. Katz" writes:
> On 6/15/23 2:47 PM, David G. Johnston wrote:
>> Robert - can you please comment on what you are willing to commit in
>> order to close out your open item here. My take is that the design for
>> this, the tabular form a couple of emails ago (copied here), is
>> read
On Thu, Jun 22, 2023 at 02:58:14PM +0900, Yugo NAGATA wrote:
> On Mon, 19 Jun 2023 16:49:05 -0700
> "Tristan Partin" wrote:
>> On Mon Jun 19, 2023 at 6:39 AM PDT, Yugo NAGATA wrote:
>>> [1]
>>> https://www.postgresql.org/message-id/flat/CSTU5P82ONZ1.19XFUGHMXHBRY%40c3po
>>
>> The other patch doe
On Thu, Jun 22, 2023 at 08:43:01AM -0700, Nathan Bossart wrote:
> I plan to commit these patches later today.
Committed. I've also marked the related open item for v16 as resolved.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
On Wed, Jun 21, 2023 at 11:48 PM Nathan Bossart
wrote:
>
>On Wed, Jun 21, 2023 at 04:28:43PM -0400, Joseph Koshakow wrote:
>> + roleTup = SearchSysCache1(AUTHOID,
ObjectIdGetDatum(AuthenticatedUserId));
>> + if (!HeapTupleIsValid(roleTup))
>> + ereport(FATAL,
>
On 6/22/23 19:52, Joel Jacobson wrote:
> On Tue, Jun 20, 2023, at 14:10, Tomas Vondra wrote:
>> This is also what the SQL standard does for multisets - there's SQL:20nn
>> draft at http://www.wiscorp.com/SQLStandards.html, and the > predicate> section (p. 475) explains how this should work with NUL
On Thu, Jun 22, 2023 at 08:08:54PM +0200, Peter Eisentraut wrote:
> The message linked to above also says:
>
>> I'm not sure. I don't have a good sense of what OpenSSL versions we
>> claim to support in branches older than PG13. We made a conscious
>> decision for 1.0.1 in PG13, but I seem to re
On Tue, Jun 20, 2023 at 6:48 AM Jeff Davis wrote:
> On Sat, 2023-06-17 at 17:54 +1200, Thomas Munro wrote:
> > > Would it be correct to interpret LC_COLLATE=C.UTF-8 as
> > > LC_COLLATE=C,
> > > but leave LC_CTYPE=C.UTF-8 as-is?
> >
> > Yes. The basic idea, at least for these two OSes, is that eve
>
> So I decided to propose a simple transform extension to pass bytea as
> native Perl octet strings.
Quick review, mostly housekeeping things:
* Needs a rebase, minor failure on Mkvcbuild.pm
* Code needs standardized formatting, esp. bytea_plperl.c
* Needs to be meson-i-fied (i.e. add a "meson
After conducting a further investigation into this issue, I have made
some discoveries. The previous patch successfully resolves the problem
when running the commands `./configure && make && make check` (without
any previous sudo make install or make install). However, it stops at
the 'isolatio
Hi,
On 2023-06-13 11:20:52 +0200, Palle Girgensohn wrote:
> CLANG is used to compile *.bc files during postgresql build. Is it OK to
> have a different compiler for the rest of the build? gcc, or even another
> version of clang?
Yes.
> LLVM is an optional add-on, a package. The default version
On Tue, Feb 14, 2023 at 6:13 AM Kyzer Davis (kydavis) wrote:
> I am happy to see others interested in the improvements provided by UUIDv7!
Thank you for providing the details!
Some small updates as I see them:
- there is revision 7 now in https://github.com/ietf-wg-uuidrev/rfc4122bis
- noticing
On 22.06.23 01:53, Michael Paquier wrote:
Looking at the relevant thread from 2020, this was still at the point
where we did not consider supporting 3.0 for all the stable branches
because 3.0 was in alpha:
https://www.postgresql.org/message-id/3d4afcfc-0930-1389-b9f7-59bdf11fb...@2ndquadrant.com
On Tue, Jun 20, 2023, at 14:10, Tomas Vondra wrote:
> This is also what the SQL standard does for multisets - there's SQL:20nn
> draft at http://www.wiscorp.com/SQLStandards.html, and the predicate> section (p. 475) explains how this should work with NULL.
I've looked again at the paper you menti
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes:
> Tom Lane writes:
>> (Don't we have existing precedents that apply here? I can't offhand
>> think of any existing ALTER commands that would reject no-op requests,
>> but maybe that's not a direct precedent.)
> Since it only supports adding thes
Tom Lane writes:
> Tommy Pavlicek writes:
>
>> Additionally, I wasn't sure whether it was preferred to fail or succeed on
>> ALTERs that have no effect, such as adding hashes on an operator that
>> already allows them or disabling hashes on one that does not. I chose to
>> raise an error when th
Tommy Pavlicek writes:
> I've attached a couple of patches to allow ALTER OPERATOR to add
> commutators, negators, hashes and merges to operators that lack them.
Please add this to the upcoming commitfest [1], to ensure we don't
lose track of it.
> The first patch is create_op_fixes_v1.patch and
Hi,
On 2023-06-21 21:50:39 -0700, Noah Misch wrote:
> On Wed, Jun 21, 2023 at 03:12:08PM -0700, Andres Freund wrote:
> > When vac_truncate_clog() returns early
> ...
> > we haven't released the lwlock that we acquired earlier
>
> > Until there's some cause for the session to call LWLockReleaseAll
Hi,
On 2023-06-22 10:00:01 +0530, Amit Kapila wrote:
> On Wed, Jun 21, 2023 at 11:53 AM Peter Geoghegan wrote:
> >
> > On Tue, Jun 20, 2023 at 10:27 PM Andres Freund wrote:
> > > As far as I can tell 72e78d831a as-is is just bogus. Unfortunately that
> > > likely
> > > also means 3ba59ccc89 is
Hi All,
I've attached a couple of patches to allow ALTER OPERATOR to add
commutators, negators, hashes and merges to operators that lack them.
The need for this arose adding hash functions to the ltree type after the
operator had been created without hash support[1]. There are potential
issues wi
> I'm sorry for not having read (and not reading) the other thread yet,
> but what was the reason we couldn't store that oid in a column in the
> pg_s_p_vacuum-view?
> Could you summarize the other solutions that were considered for this issue?
Thanks for your feedback!
The reason we cannot sti
On Thu, 22 Jun 2023 at 16:45, Imseih (AWS), Sami wrote:
>
> Hi,
>
> [1] is a ready-for-committer enhancement to pg_stat_progress_vacuum which
> exposes
> the total number of indexes to vacuum and how many indexes have been vacuumed
> in
> the current vacuum cycle.
>
> To even further improve vis
On Thu, Jun 22, 2023 at 04:11:08PM +0900, Michael Paquier wrote:
> Sounds good to me. Thanks.
I plan to commit these patches later today.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Hi,
[1] is a ready-for-committer enhancement to pg_stat_progress_vacuum which
exposes
the total number of indexes to vacuum and how many indexes have been vacuumed in
the current vacuum cycle.
To even further improve visibility into index vacuuming, it would be beneficial
to have a
function cal
On 6/22/23 13:46, Tomas Vondra wrote:
> ...
>
> I haven't tried the reproducer, but I think I see the issue - we store
> the bitmap as part of the event to be executed later, but the bitmap is
> in per-tuple context and gets reset. So I guess we need to copy it into
> the proper long-lived context
Ronan Dunklau writes:
> Le jeudi 22 juin 2023, 15:49:36 CEST Tom Lane a écrit :
>> Aren't these same settings controllable via environment variables?
>> I could see adding some docs suggesting that you set thus-and-such
>> values in the postmaster's startup script. Admittedly, the confusion
>> ar
On Wed, Jun 21, 2023 at 9:49 PM Kyotaro Horiguchi
wrote:
> Regarding the second patch, it introduces WAL IO time as a
> IOCONTEXT_NORMAL/IOOBJECT_WAL, but it doesn't seem to follow the
> convention or design of the pgstat_io component, which primarily
> focuses on shared buffer IOs.
I haven't rev
Le jeudi 22 juin 2023, 15:49:36 CEST Tom Lane a écrit :
> This seems like a pretty awful idea, mainly because there's no way
> to have such a GUC mean anything on non-glibc platforms, which is
> going to cause confusion or worse.
I named the GUC glibc_malloc_max_trim_threshold, I hope this is enou
Ronan Dunklau writes:
> Following some conversation with Tomas at PGCon, I decided to resurrect this
> topic, which was previously discussed in the context of moving tuplesort to
> use GenerationContext: https://www.postgresql.org/message-id/
> 8046109.NyiUUSuA9g%40aivenronan
This seems like a
Hello,
Following some conversation with Tomas at PGCon, I decided to resurrect this
topic, which was previously discussed in the context of moving tuplesort to
use GenerationContext: https://www.postgresql.org/message-id/
8046109.NyiUUSuA9g%40aivenronan
The idea for this patch is that the beha
Em qui., 22 de jun. de 2023 às 01:43, David Rowley
escreveu:
> On Thu, 22 Jun 2023 at 00:16, Ranier Vilela wrote:
> > 2. Only compute BITNUM when necessary.
>
> I doubt this will help. The % 64 done by BITNUM will be transformed
> to an AND operation by the compiler which is likely going to be
On 6/22/23 13:07, Alexander Pyhalov wrote:
> Tomas Vondra писал 2023-05-25 17:41:
>
>> The attached patch does this - I realized we actually have estate in
>> ExecGetAllUpdatedCols(), so we don't even need a variant with a
>> different signature. That makes the patch much simpler.
>>
>> The que
On Thu, Jun 22, 2023 at 05:23:33AM +,
fujii.y...@df.mitsubishielectric.co.jp wrote:
> Approach1-3:
> I will add a postgres_fdw option "check_partial_aggregate_support".
> This option is false, default.
> Only if this option is true, postgres_fdw connect to the remote server and
> get the vers
Tomas Vondra писал 2023-05-25 17:41:
The attached patch does this - I realized we actually have estate in
ExecGetAllUpdatedCols(), so we don't even need a variant with a
different signature. That makes the patch much simpler.
The question is whether we need the signature anyway. There might be
On Tue, Jun 13, 2023 at 1:21 PM Michael Paquier wrote:
>
> The patch is made of a lot of one-one mapping between enum structures
> and hardcoded text used in the JSON objects, making it something hard
> to maintain if a node field is added, removed or even updated into
> something else. I have me
On Wed, Jun 21, 2023 at 6:38 PM Jelte Fennema wrote:
>
> (to be clear I only skimmed the end of this thread and did not look at
> all the previous messages)
>
> I took a quick look at the first patch (about deparsing table ddl) and
> it seems like this would also be very useful for a SHOW CREATE T
On Wed, Jun 21, 2023 at 8:12 AM Masahiko Sawada wrote:
>
> On Thu, Jun 15, 2023 at 7:50 PM Amit Kapila wrote:
> >
> > On Tue, Jun 13, 2023 at 2:06 PM Masahiko Sawada
> > wrote:
> > >
> > > On Sun, Jun 11, 2023 at 5:31 AM Andres Freund wrote:
> > > >
> > > > A separate issue is that Transaction
Hello,
On Tue, Jun 20, 2023 at 1:17 PM David Rowley wrote:
> I've adjusted the attached patch to do that.
Thank you for updating the patch. The v4 patch looks good to me.
I ran another experiment. In the experiment, I issued queries of the
Join Order Benchmark [1] and measured its planning time
Hello,
On Thu, Jun 22, 2023 at 1:43 PM David Rowley wrote:
> > 3. Avoid enlargement when nwords is equal wordnum.
> > Can save cycles when in corner cases?
>
> No, you're just introducing a bug here. Arrays in C are zero-based,
> so "wordnum >= a->nwords" is exactly the correct way to check
On Thu, Jun 22, 2023 at 10:02:58AM +0200, Daniel Gustafsson wrote:
> These patches LGTM from reading,
Thanks for double-checking.
> but I think the Discussion link in the commit
> messages should refer to this thread as well.
Of course.
--
Michael
signature.asc
Description: PGP signature
> On 22 Jun 2023, at 01:53, Michael Paquier wrote:
> I have tested the attached patches across 11~13 with various versions
> of OpenSSL (OPENSSL_API_COMPAT exists since 1.1.0), and this is
> working here. Note that I don't have a MSVC environment at hand to
> test this change on Windows, still `
At Wed, 21 Jun 2023 23:41:33 +0900, torikoshia
wrote in
> --v10-0002-Preliminary-refactoring-for-a-subsequent-patch.patch
> + * Also we skip backup history files when --clean-backup-history
> +* is not specified.
> +*/
> + if (!IsXLogFileName(walfile) && !IsPartialXLogFileName(wa
Thanks, Tomas!
> I know, but it makes them harder to read for people. If you want people
> to respond it's generally a good idea to make it easy to understand the
> question. Don't make them waste their time - they'll just skip the
> message entirely.
Fair point.
> So, the optimizer clearly bel
Thanks Tomas for the lengthy write-up!
Pardon the noise in the queries (LATERAL, AND true etc): they were
autogenerated by the library we wrote.
> Because those queries are not doing the same thing. In the first query
> you sort by t3_0 columns, while the "id = 4732455" condition is on the
> othe
On 21/06/2023 01:02, Joe Conway wrote:
On 6/19/23 19:30, Heikki Linnakangas wrote:
On 18/06/2023 21:27, Joe Conway wrote:
With the patch you're proposing, do we now have a coding rule that you
must call "uselocale(LC_GLOBAL_LOCALE)" before every and any call to
setlocale()? If so, you missed a f
On Wed, Jun 21, 2023 at 08:06:06PM -0700, Nathan Bossart wrote:
> On Thu, Jun 22, 2023 at 10:46:41AM +0900, Michael Paquier wrote:
>> - /*
>> -* We already checked that the user has privileges to CLUSTER the
>> -* partitioned table when we locked it earlier, so there's no need
53 matches
Mail list logo
