Re: abi-compliance-checker

2023-05-29 Thread Peter Eisentraut
On 27.05.23 02:52, Peter Geoghegan wrote: Attached is a html report that was generated by a tool called abi-compliance-checker/abi-dumper [1][2] (by using "abi-compliance-checker -l libTest ... ") . I have been using the libabigail library/set of tools (abidiff, abidw) for this. I was not fam

Re: Support logical replication of DDLs

2023-05-29 Thread shveta malik
On Mon, May 29, 2023 at 6:16 PM vignesh C wrote: > > > > > I found few comments while making some changes to the patch: > > 1) Now that objtree is removed, these comments should be modified: > > * Deparse object tree is created by using: > > * a) new_objtree("know contents") where the complete

Re: ERROR: no relation entry for relid 6

2023-05-29 Thread Richard Guo
On Sat, May 27, 2023 at 12:16 AM Tom Lane wrote: > Ah. I realized that we could make the problem testable by adding > assertions that a joinclause we're not removing doesn't contain > any surviving references to the target rel or join. That turns > out to fire (without the bug fix) in half a do

Re: PG 16 draft release notes ready

2023-05-29 Thread Bruce Momjian
On Wed, May 24, 2023 at 04:13:14PM +1200, David Rowley wrote: > On Wed, 24 May 2023 at 15:54, Bruce Momjian wrote: > > First, I need to mention parallel _hash_ join. Second, I think this > > item is saying that the _inner_ side of a parallel hash join can be an > > OUTER or FULL join. How about?

Re: PG 16 draft release notes ready

2023-05-29 Thread Bruce Momjian
On Tue, May 23, 2023 at 11:54:30PM -0400, Bruce Momjian wrote: > On Wed, May 24, 2023 at 08:37:45AM +1200, David Rowley wrote: > > On Mon, 22 May 2023 at 07:05, Jonathan S. Katz wrote: > > > * Parallel execution of queries that use `FULL` and `OUTER` joins > > > > I think this should be `RIGHT` j

Re: PG 16 draft release notes ready

2023-05-29 Thread Bruce Momjian
On Mon, May 29, 2023 at 10:08:41AM -0400, Masahiko Sawada wrote: > On Sun, May 21, 2023 at 10:47 PM Bruce Momjian wrote: > > > > Okay new merged item is: > > > > > > > > > > > > Allow logical decoding on standbys (Bertrand Drouvot, Andres > > Freund, Amit Khande

Re: abi-compliance-checker

2023-05-29 Thread Peter Geoghegan
On Sun, May 28, 2023 at 9:34 AM Peter Geoghegan wrote: > I'll try to come up with a standard abi-compliance-checker Postgres > workflow once I'm back from pgCon. Ideally, we'd be able to produce reports that cover an entire stable release branch at once, including details about how things changed

Re: benchmark results comparing versions 15.2 and 16

2023-05-29 Thread Peter Geoghegan
On Sun, May 28, 2023 at 2:42 PM David Rowley wrote: > c6e0fe1f2 might have helped improve some of that performance, but I > suspect there must be something else as ~3x seems much more than I'd > expect from reducing the memory overheads. Testing versions before > and after that commit might give

Re: PG 16 draft release notes ready

2023-05-29 Thread Masahiko Sawada
On Sun, May 21, 2023 at 10:47 PM Bruce Momjian wrote: > > Okay new merged item is: > > > > > > Allow logical decoding on standbys (Bertrand Drouvot, Andres Freund, > Amit Khandekar, Bertrand Drouvot) > > > > > > New fu

Re: vector search support

2023-05-29 Thread Giuseppe Broccolo
Hi Nathan, I noticed you implemented a closest_vector function which returns the closest vector to a given one using the Euclidean distance: would it make sense to change the implementation in order to include also different distance definitions rather than the Euclidean one (for instance, cosine

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-05-29 Thread Masahiko Sawada
Hi, On Tue, Feb 14, 2023 at 8:15 PM Tatsuo Ishii wrote: > > >> I fixed the above issues and refactored the code. > >> Attached is the updated version of the patch. Thought? > > > > Thank you! Looks good to me. > > Fix pushed. Thank you! In my Mac environment where non-Exuberant ctags and emacs 2

Re: vector search support

2023-05-29 Thread Giuseppe Broccolo
Hi Jonathan, On 5/26/23 3:38 PM, Jonathan S. Katz wrote: > On 4/26/23 9:31 AM, Giuseppe Broccolo wrote: > > We finally opted for ElasticSearch as search engine, considering that it > > was providing what we needed: > > > > * support to store dense vectors > > * support for kNN searches (last ver

Re: BF animal dikkop reported a failure in 035_standby_logical_decoding

2023-05-29 Thread Drouvot, Bertrand
Hi, On 5/29/23 1:03 PM, Tom Lane wrote: "Drouvot, Bertrand" writes: On 5/26/23 9:27 AM, Yu Shi (Fujitsu) wrote: Is it possible that the vacuum command didn't remove tuples and then the conflict was not triggered? The flush_wal table added by Andres should guarantee that the WAL is flushed,

Re: Making Vars outer-join aware

2023-05-29 Thread Anton A. Melnikov
Hello and sorry for the big delay in reply! On 04.05.2023 15:22, Tom Lane wrote: AFAICS the change you propose would serve only to mask bugs. Yes, it's a bad decision. Under what circumstances would you be trying to inject INDEX_VAR into a nullingrel set? Only outer-join relids should ever

Re: BF animal dikkop reported a failure in 035_standby_logical_decoding

2023-05-29 Thread Tom Lane
"Drouvot, Bertrand" writes: > On 5/26/23 9:27 AM, Yu Shi (Fujitsu) wrote: >> Is it possible that the vacuum command didn't remove tuples and then the >> conflict was not triggered? > The flush_wal table added by Andres should guarantee that the WAL is flushed, > so > the only reason I can think

RE: BF animal dikkop reported a failure in 035_standby_logical_decoding

2023-05-29 Thread Yu Shi (Fujitsu)
On Monday, May 29, 2023 5:22 PM Drouvot, Bertrand wrote: > > Hi, > > On 5/26/23 9:27 AM, Yu Shi (Fujitsu) wrote: > > Hi hackers, > > > > I saw a buildfarm failure on "dikkop"[1]. It failed in > > 035_standby_logical_decoding.pl, because the slots row_removal_inactiveslot > and > > row_removal_a

Re: BF animal dikkop reported a failure in 035_standby_logical_decoding

2023-05-29 Thread Drouvot, Bertrand
Hi, On 5/26/23 9:27 AM, Yu Shi (Fujitsu) wrote: Hi hackers, I saw a buildfarm failure on "dikkop"[1]. It failed in 035_standby_logical_decoding.pl, because the slots row_removal_inactiveslot and row_removal_activeslot are not invalidated after vacuum. Thanks for sharing! regress_log_035_st

Re: Cleaning up nbtree after logical decoding on standby work

2023-05-29 Thread Drouvot, Bertrand
Hi, On 5/26/23 7:28 PM, Peter Geoghegan wrote: On Fri, May 26, 2023 at 1:56 AM Alvaro Herrera wrote: I suppose you're not thinking of applying this to current master, but instead just leave it for when pg17 opens, right? I mean, clearly it seems far too invasive to put it in after beta1. I