RE: Support logical replication of DDLs

On Mon, May 22, 2023 1:57 PM shveta malik wrote: > > Please find the new set of patches for object-tree Removal. The new > changes are in patch 0008 only. The new changes address object tree > removal for below commands. > > create sequence > alter sequence > alter object owner to > alter obje

Re: Docs: Encourage strong server verification with SCRAM

On Sun, May 28, 2023 at 02:21:53PM -0400, Jonathan S. Katz wrote: > The above assumes that the reader reviewed the previous paragraph and > followed the guidelines there. However, we can make it explicit. Please see > attached. Yeah, I was under the same impression as Jacob that we don't insist en

Re: contrib/spi/insert_username.c comment typo?

On Mon, May 29, 2023 at 11:31 AM jian he wrote: > hi. > reading through contrib/spi/insert_username.c > https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=contrib/spi/insert_username.c;h=a2e1747ff74c7667665dcc334f54ad368885d83c;hb=HEAD > 36 /* sanity checks from autoinc.c */ > 37

contrib/spi/insert_username.c comment typo?

hi. reading through contrib/spi/insert_username.c https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=contrib/spi/insert_username.c;h=a2e1747ff74c7667665dcc334f54ad368885d83c;hb=HEAD 36

Re: Cleaning up nbtree after logical decoding on standby work

On 29/05/2023 03:31, Michael Paquier wrote: On Fri, May 26, 2023 at 04:48:37PM -0700, Peter Geoghegan wrote: I'd have thought the subject line "Cleaning up nbtree after logical decoding on standby work" made it quite clear that this patch was targeting 16. Hmm, okay. I was understanding that

Re: Implement generalized sub routine find_in_log for tap test

On Sat, 27 May 2023 at 17:32, Andrew Dunstan wrote: > > > On 2023-05-26 Fr 20:35, vignesh C wrote: > > On Fri, 26 May 2023 at 04:09, Michael Paquier wrote: > > On Thu, May 25, 2023 at 06:34:20PM +0100, Dagfinn Ilmari Mannsåker wrote: > > However, none of the other functions in ::Utils know anythi

[16Beta1][doc] Add BackendType for standalone backends

Hi, hackers. In PostgreSQL 16 Beta 1, standalone backend was added to the backend type by this patch [1]. I think this patch will change the value of backend_type column in the pg_stat_activity view, but it's not explained in the documentation. The attached patch fixes monitoring.sgml. [1] Add

Re: Cleaning up nbtree after logical decoding on standby work

On Fri, May 26, 2023 at 04:48:37PM -0700, Peter Geoghegan wrote: > I'd have thought the subject line "Cleaning up nbtree after logical > decoding on standby work" made it quite clear that this patch was > targeting 16. Hmm, okay. I was understanding that as something for v17, honestly. > It's no

Re: benchmark results comparing versions 15.2 and 16

On Tue, 23 May 2023 at 07:40, MARK CALLAGHAN wrote: (pg15) > --- Q2.10k : explain analyze SELECT c FROM sbtest1 WHERE id BETWEEN 1000 > AND 1001 order by c; > QUERY PLAN > -

Re: Docs: Encourage strong server verification with SCRAM

On 5/26/23 6:47 PM, Jacob Champion wrote: On Thu, May 25, 2023 at 6:10 PM Jonathan S. Katz wrote: + To prevent server spoofing from occurring when using + scram-sha-256 password authentication + over a network, you should ensure you are connecting using SSL. seems to backtrack on the

Re: abi-compliance-checker

On Sun, May 28, 2023 at 8:37 AM Tom Lane wrote: > I gather it'd catch things like NodeTag enum assignments changing, > which is something we really need to have a check for. Right. Any ABI break that involves machine-generated translation units seems particularly prone to being overlooked. Just e

Re: abi-compliance-checker

I wrote: > (Which reminds me that I forgot to turn on the ad-hoc check for > that in gen_node_support.pl. I'll go do that, but it'd be better > to have a more general-purpose solution.) Oh, scratch that, it's not supposed to happen until we make the v16 branch. It'd still be better to not need i

Re: abi-compliance-checker

Peter Geoghegan writes: > I tried comparing REL_11_0 to REL_11_20. Attached is the report for that. Nice! > I don't have time to study this in detail today, but the report seems > to have a plausible variety of issues. I noticed that it warns about > the breaking signature change to _bt_pagedel(

Re: abi-compliance-checker

Peter Geoghegan writes: > Attached is a html report that was generated by a tool called > abi-compliance-checker/abi-dumper [1][2] (by using > "abi-compliance-checker -l libTest ... ") . I deliberately introduced > 2 ABI compatibility issues affecting postgres, just to see what the > tool had to s

Re: Large files for relations

On Sun, May 28, 2023 at 2:48 AM Thomas Munro wrote: > (you'd need over 2 billion > directories ... directory *entries* (segment files), I meant to write there.