Re: Should CSV parsing be stricter about mid-field quotes?

2023-05-13 Thread Greg Stark
On Sat, 13 May 2023 at 09:46, Tom Lane wrote: > > Andrew Dunstan writes: > > I could see an argument for a STRICT mode which would disallow partially > > quoted fields, although I'd like some evidence that we're dealing with a > > real problem here. Is there really a CSV producer that produces ou

Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-05-13 Thread Greg Stark
On Thu, 11 May 2023 at 16:41, Peter Geoghegan wrote: > > > I say "exhaustion" or "overload" are meaningless because their meaning > > is entirely dependent on context. It's not like memory exhaustion or > > i/o overload where it's a finite resource and it's just the sheer > > amount in use that ma

Re: Memory leak from ExecutorState context?

2023-05-13 Thread Tomas Vondra
On 5/12/23 23:36, Melanie Plageman wrote: > Thanks for continuing to work on this. > > Are you planning to modify what is displayed for memory usage in > EXPLAIN ANALYZE? > We could do that, but we can do that separately - it's a separate and independent improvement, I think. Also, do you have

Re: Memory leak from ExecutorState context?

2023-05-13 Thread Tomas Vondra
Hi, Thanks for the patches. A couple mostly minor comments, to complement Melanie's review: 0001 I'm not really sure about calling this "hybrid hash-join". What does it even mean? The new comments simply describe the existing batching, and how we increment number of batches, etc. When someone s

Re: Should CSV parsing be stricter about mid-field quotes?

2023-05-13 Thread Tom Lane
Andrew Dunstan writes: > I could see an argument for a STRICT mode which would disallow partially > quoted fields, although I'd like some evidence that we're dealing with a > real problem here. Is there really a CSV producer that produces output > like that you showed in your example? And if so

Re: Should CSV parsing be stricter about mid-field quotes?

2023-05-13 Thread Andrew Dunstan
On 2023-05-13 Sa 04:20, Joel Jacobson wrote: On Fri, May 12, 2023, at 21:57, Andrew Dunstan wrote: Maybe this is unexpected by you, but it's not by me. What other sane interpretation of that data could there be? And what CSV producer outputs such horrible content? As you've noted, ours certa

Re: Order changes in PG16 since ICU introduction

2023-05-13 Thread Alexander Lakhin
Hello Jeff, 09.05.2023 00:59, Jeff Davis wrote: The easiest thing to do is revert it for now, and after we sort out the memcmp() path for the ICU provider, then I can commit it again (after that point it would just be code cleanup and should have no functional impact). On the current master (a

Re: Should CSV parsing be stricter about mid-field quotes?

2023-05-13 Thread Joel Jacobson
On Fri, May 12, 2023, at 21:57, Andrew Dunstan wrote: > Maybe this is unexpected by you, but it's not by me. What other sane > interpretation of that data could there be? And what CSV producer outputs > such horrible content? As you've noted, ours certainly does not. Our rules > are clear: quote