Re: Perform streaming logical transactions by background workers and parallel apply

On Mon, May 8, 2023 at 11:08 AM Masahiko Sawada wrote: > > On Mon, May 8, 2023 at 12:52 PM Zhijie Hou (Fujitsu) > wrote: > > > > On Monday, May 8, 2023 11:08 AM Masahiko Sawada > > > > Hi, > > > > > > > > On Tue, May 2, 2023 at 12:22 PM Amit Kapila > > > wrote: > > > > > > > > On Fri, Apr 28, 2

Re: Perform streaming logical transactions by background workers and parallel apply

On Mon, May 8, 2023 at 12:52 PM Zhijie Hou (Fujitsu) wrote: > > On Monday, May 8, 2023 11:08 AM Masahiko Sawada > > Hi, > > > > > On Tue, May 2, 2023 at 12:22 PM Amit Kapila > > wrote: > > > > > > On Fri, Apr 28, 2023 at 11:48 AM Masahiko Sawada > > wrote: > > > > > > > > While investigating th

Re: PGDOCS - Replica Identity quotes

On Mon, May 08, 2023 at 01:57:33PM +1000, Peter Smith wrote: > I agree. Do you want me to make a new v4 patch to also do that, or > will you handle them in passing? I'll just go handle them on the way, no need to send an updated patch. -- Michael signature.asc Description: PGP signature

Re: PGDOCS - Replica Identity quotes

On Mon, May 8, 2023 at 1:09 PM Michael Paquier wrote: > > On Mon, May 08, 2023 at 10:29:50AM +1000, Peter Smith wrote: > > Thanks for giving some feedback on my patch. > > Looks OK. > > While on it, looking at logical-replication.sgml, it seems to me that > these two are also incorrect, and we sho

RE: Perform streaming logical transactions by background workers and parallel apply

On Monday, May 8, 2023 11:08 AM Masahiko Sawada Hi, > > On Tue, May 2, 2023 at 12:22 PM Amit Kapila > wrote: > > > > On Fri, Apr 28, 2023 at 11:48 AM Masahiko Sawada > wrote: > > > > > > While investigating this issue, I've reviewed the code around > > > callbacks and worker termination etc a

Re: [DOC] Update ALTER SUBSCRIPTION documentation

On Fri, May 5, 2023 at 11:17 PM Robert Sjöblom wrote: > > > Hi, > > We have recently used the PostgreSQL documentation when setting up our > logical replication. We noticed there was a step missing in the > documentation on how to drop a logical replication subscription with a > replication slot a

Re: Add PQsendSyncMessage() to libpq

On Wed, May 03, 2023 at 12:03:57PM +0200, Alvaro Herrera wrote: > We already have 'int' flag masks in PQcopyResult() and > PQsetTraceFlags(). We were using bits32 initially for flag stuff in the > PQtrace facilities, until [1] reminded us that we shouldn't let c.h > creep into app-land, so that wa

Re: PGDOCS - Replica Identity quotes

On Mon, May 08, 2023 at 10:29:50AM +1000, Peter Smith wrote: > Thanks for giving some feedback on my patch. Looks OK. While on it, looking at logical-replication.sgml, it seems to me that these two are also incorrect, and we should use markups: implemented by walsender and apply -- Michael sig

Re: Perform streaming logical transactions by background workers and parallel apply

On Tue, May 2, 2023 at 12:22 PM Amit Kapila wrote: > > On Fri, Apr 28, 2023 at 11:48 AM Masahiko Sawada > wrote: > > > > While investigating this issue, I've reviewed the code around > > callbacks and worker termination etc and I found a problem. > > > > A parallel apply worker calls the before_

Re: [DOC] Update ALTER SUBSCRIPTION documentation

On Fri, May 5, 2023 at 6:47 PM Robert Sjöblom wrote: > > We have recently used the PostgreSQL documentation when setting up our > logical replication. We noticed there was a step missing in the > documentation on how to drop a logical replication subscription with a > replication slot attached. >

Re: Proposal for Prototype Implementation to Enhance C/C++ Interoperability in PostgreSQL

(Sorry, there was a problem with the format of the previous email content. I will send it in plain text format this time > It seems extremely specific to one particular C++ implementation To perform a force unwind during longjmp, the _Unwind_ForcedUnwind function is used. This function is defin

Re: Add two missing tests in 035_standby_logical_decoding.pl

On Sat, May 6, 2023 at 9:33 PM Drouvot, Bertrand wrote: > > On 5/6/23 3:28 PM, Amit Kapila wrote: > > On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand > > wrote: > > > Next steps: > > = > > 1. The first thing is we should verify this theory by adding some LOG > > in KeepLogSeg() to see if

Re: Proposal for Prototype Implementation to Enhance C/C++ Interoperability in PostgreSQL

> It seems extremely specific to one particular C++ implementation To perform a force unwind during longjmp, the _Unwind_ForcedUnwind function is used. This function is defined in the [Itanium C++ ABI Standard](https://itanium-cxx-abi.github.io/cxx-abi/abi-eh.html#base-throw), which is followe

Re: 2023-05-11 release announcement draft

Thanks for working on this. On Sun, 7 May 2023 at 15:37, Jonathan S. Katz wrote: > Please provide any suggestions, corrections, or notable omissions no > later than 2023-05-11 0:00 AoE. For this one: > * Fix partition pruning logic for partitioning on boolean columns when using a > `IS NOT TRUE

Re: Introduce join_info_array for direct lookups of SpecialJoinInfo by ojrelid

On Thu, May 4, 2023 at 4:07 PM Richard Guo wrote: > When working on the improper qual pushdown issue [1], there is a need in > the proposed fix to avoid scanning all the SpecialJoinInfos, since that > is too expensive. I think this might be a common requirement. In the > current codes there are

Re: Add LZ4 compression in pg_dump

On 5/7/23 17:01, gkokola...@pm.me wrote: > > > > On Sat, May 6, 2023 at 04:51, Michael Paquier wrote: >> On Fri, May 05, 2023 at 02:13:28PM +, gkokola...@pm.me wrote: >> > Good point. I thought about it before submitting the patch.

Re: Add LZ4 compression in pg_dump

I wrote: > Michael Paquier writes: >> While testing this patch, I have triggered an error pointing out that >> the decompression path of LZ4 is broken for table data. I can >> reproduce that with a dump of the regression database, as of: >> make installcheck >> pg_dump --format=d --file=dump_lz4

Re: Add LZ4 compression in pg_dump

On Sun, May 07, 2023 at 09:09:25PM -0400, Tom Lane wrote: > Ugh. Reproduced here ... so we need an open item for this. Yep. Already added. -- Michael signature.asc Description: PGP signature

Re: Add LZ4 compression in pg_dump

Michael Paquier writes: > While testing this patch, I have triggered an error pointing out that > the decompression path of LZ4 is broken for table data. I can > reproduce that with a dump of the regression database, as of: > make installcheck > pg_dump --format=d --file=dump_lz4 --compress=lz4 r

Re: 2023-05-11 release announcement draft

On 5/7/23 1:09 AM, Erik Rijkers wrote: Op 5/7/23 om 05:37 schreef Jonathan S. Katz: Attached is a draft of the release announcement for the upcoming update release on May 11, 2023. Please provide any suggestions, corrections, or notable omissions no later than 2023-05-11 0:00 AoE. 'leak in

Re: Add LZ4 compression in pg_dump

On Fri, May 05, 2023 at 02:13:28PM +, gkokola...@pm.me wrote: > Good point. I thought about it before submitting the patch. I > concluded that given the complexity and operations involved in > LZ4Stream_read_internal() and the rest of t he pg_dump/pg_restore > code, the memset() call will be ne

Re: PGDOCS - Replica Identity quotes

On Sat, May 6, 2023 at 5:28 AM David Zhang wrote: > > On 2023-03-16 4:46 p.m., Peter Smith wrote: > > A rebase was needed due to the recent REPLICA IDENTITY push [1]. > > > > PSA v2. > > > > > > - A published table must have a replica identity > > configured in > > + A published table mu

Re: Add LZ4 compression in pg_dump

On Sun, May 07, 2023 at 03:01:52PM +, gkokola...@pm.me wrote: > Thank you but I am not certain I know what that means. Can you please explain? It means that this thread has been added to the following list: https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items#Open_Issues pg_dump/compress

Re: psql: Add role's membership options to the \du+ command

On 05.05.2023 19:51, David G. Johnston wrote: But if it is really a blocker then maybe we should produce 3 separate newline separated columns, one for the member of role, one for the list of attributes, and one with the grantor.  The column headers can be translated more easily as single nouns.

Re: MERGE lacks ruleutils.c decompiling support!?

On 2023-May-07, Tom Lane wrote: > I wrote: > > Ping? The hours grow short, if we're to get this into 15.3. > > I went ahead and pushed v2, since we can't wait any longer if > we're to get reasonable buildfarm coverage before 15.3 wraps. Much appreciated. I wanted to get back to this yesterday

Re: Proposal for Prototype Implementation to Enhance C/C++ Interoperability in PostgreSQL

"=?utf-8?B?55uP5LiA?=" writes: > The proposed implementation can significantly improve the interoperability > between C and C++ code in PostgreSQL. It allows for seamless integration of > C++ code with PostgreSQL, without the need for complex workarounds or > modifications to the existing codeb

Re: MERGE lacks ruleutils.c decompiling support!?

I wrote: > Ping? The hours grow short, if we're to get this into 15.3. I went ahead and pushed v2, since we can't wait any longer if we're to get reasonable buildfarm coverage before 15.3 wraps. regards, tom lane

Re: Add LZ4 compression in pg_dump

On Sat, May 6, 2023 at 04:51, Michael Paquier <[mich...@paquier.xyz](mailto:On Sat, May 6, 2023 at 04:51, Michael Paquier < wrote: > On Fri, May 05, 2023 at 02:13:28PM +, gkokola...@pm.me wrote: >> Good point. I thought about it before submitting the patch. I >> concluded that given the compl

Re: Missing update of all_hasnulls in BRIN opclasses

On 5/7/23 07:08, Julien Rouhaud wrote: > Hi, > > On Sun, May 07, 2023 at 12:13:07AM +0200, Tomas Vondra wrote: >> >> c) ignore the issue - AFAICS this would be an issue only for (external) >> code accessing BrinMemTuple structs, but I don't think we're aware of >> any out-of-core BRIN opclasses

Re: [PATCH] Allow Postgres to pick an unused port to listen

Hi Cary, Thank you so much for the review. It's very valuable, and you caught an important issue with it that I somehow missed (not updating the .pid file with the selected port number). I'm not sure how it escaped me (perhaps I was focusing too much on the log file to validate the behaviour). I'