Re: Issue in postgres_fdw causing unnecessary wait for cancel request reply

2023-04-16 Thread Etsuro Fujita
On Fri, Apr 14, 2023 at 11:28 PM Fujii Masao wrote: > On 2023/04/14 18:59, Etsuro Fujita wrote: > >> The primary message basically should avoid reference to implementation > >> details such as specific structure names like PGcancel, shouldn't it, as > >> per the error message style guide? > > >

Re: Direct I/O

2023-04-16 Thread Mikael Kjellström
On 2023-04-16 20:05, Mikael Kjellström wrote: Oh wait ... this involves a switch from gcc in OpenBSD 5.9 to clang in OpenBSD 7.3, doesn't it?  That isn't something update_personality will handle; you need a new animal if the compiler product is changing. Correct. OK. I registered a new a

Re: allow_in_place_tablespaces vs. pg_basebackup

2023-04-16 Thread Michael Paquier
On Fri, Apr 14, 2023 at 04:11:47PM -0400, Robert Haas wrote: > Do people think it's OK to do that now, or should I wait until we've > branched? I personally think this is bug-fix-ish enough that now is > OK, but I'll certainly forebear if others disagree. FWIW, doing that now rather than the begin

Re: postgres_fdw: wrong results with self join + enable_nestloop off

2023-04-16 Thread Nishant Sharma
Thanks Etsuro for your response! One small typo correction in my answer to "What is the technical issue?" "it is *not* considered a pseudo constant" --> "it is considered a pseudo constant" Regards, Nishant. On Fri, Apr 14, 2023 at 6:21 PM Etsuro Fujita wrote: > Hi Nishant, > > On Fri, Apr 14

Re: Initial Schema Sync for Logical Replication

2023-04-16 Thread Masahiko Sawada
On Fri, Apr 7, 2023 at 6:37 PM Amit Kapila wrote: > > On Thu, Apr 6, 2023 at 6:57 PM Masahiko Sawada wrote: > > > > On Thu, Mar 30, 2023 at 10:11 PM Masahiko Sawada > > wrote: > > > > > > On Thu, Mar 30, 2023 at 12:18 AM Masahiko Sawada > > > wrote: > > > > > > > > > > > > How can we postpone

Re: Allowing parallel-safe initplans

2023-04-16 Thread Richard Guo
On Thu, Apr 13, 2023 at 10:00 PM Tom Lane wrote: > Richard Guo writes: > > * For the diff in standard_planner, I was wondering why not move the > > initPlans up to the Gather node, just as we did before. So I tried that > > way but did not notice the breakage of regression tests as stated in th

Re: Should vacuum process config file reload more often

2023-04-16 Thread Masahiko Sawada
On Wed, Apr 12, 2023 at 12:05 AM Masahiko Sawada wrote: > > On Fri, Apr 7, 2023 at 10:23 PM Daniel Gustafsson wrote: > > > > > On 7 Apr 2023, at 15:07, Melanie Plageman > > > wrote: > > > On Fri, Apr 7, 2023 at 2:53 AM Masahiko Sawada > > > wrote: > > > > > > Definitely seems worth fixing as

Re: longfin missing gssapi_ext.h

2023-04-16 Thread Tom Lane
Stephen Frost writes: > Pushed, thanks again to everyone. > I'll monitor the buildfarm and assuming there isn't anything unexpected > then I'll mark the open item as resolved now. The Debian 7 (Wheezy) members of the buildfarm (lapwing, skate, snapper) are all getting past the gssapi_ext.h check

Re: [PATCH] Add support for postgres:// URIs to PGDATABASE environment variable

2023-04-16 Thread Tom Lane
=?UTF-8?q?R=C3=A9mi=20Lapeyre?= writes: > The PGDATABASE is documented as behaving the same as the dbname connection > parameter but they differ in the support for postgres:// URIs: the > PGDATABASE will never be expanded even thought expand_dbname is set: I think you have misunderstood the docum

Re: Direct I/O

2023-04-16 Thread Michael Paquier
On Sun, Apr 16, 2023 at 04:51:04PM +0200, Mikael Kjellström wrote: > That is what I meant with above. > > I just use the same animal name and secret and then run > "update_personality.pl". > > That should be enough I think? Yes, that should be enough as far as I recall. This has been mentioned

Re: Can we delete the vacuumdb.sgml notes about which version each option was added in?

2023-04-16 Thread David Rowley
On Mon, 17 Apr 2023 at 02:29, Tom Lane wrote: > But +1 for just dropping them. Thanks. I just pushed the patch to drop them all. David

Re: check_strxfrm_bug()

2023-04-16 Thread Thomas Munro
On Sun, Dec 18, 2022 at 10:27 AM Thomas Munro wrote: > With my garbage collector hat on, that made me wonder if there was > some more potential cleanup here: could we require locale_t yet? The > last straggler systems on our target OS list to add the POSIX locale_t > stuff were Solaris 11.4 (2018

[PATCH] Add support for postgres:// URIs to PGDATABASE environment variable

2023-04-16 Thread Rémi Lapeyre
The PGDATABASE is documented as behaving the same as the dbname connection parameter but they differ in the support for postgres:// URIs: the PGDATABASE will never be expanded even thought expand_dbname is set: $ psql postgres://localhost/test -c 'select 1' >/dev/null # Works $ PG

Re: Direct I/O

2023-04-16 Thread Mikael Kjellström
On 2023-04-16 19:59, Andrew Dunstan wrote: On Apr 16, 2023, at 12:16 PM, Tom Lane wrote: Andrew Dunstan writes: On 2023-04-16 Su 10:18, Tom Lane wrote: Actually, as long as it's still OpenBSD I think you can keep using the same animal name ... Andrew, what's the policy on that? update

Re: Direct I/O

2023-04-16 Thread Andrew Dunstan
> On Apr 16, 2023, at 12:16 PM, Tom Lane wrote: > > Andrew Dunstan writes: >>> On 2023-04-16 Su 10:18, Tom Lane wrote: >>> Actually, as long as it's still OpenBSD I think you can keep using >>> the same animal name ... Andrew, what's the policy on that? > >> update_personality.pl lets you u

Re: v16dev: invalid memory alloc request size 8488348128

2023-04-16 Thread Tom Lane
Justin Pryzby writes: > On Sat, Apr 15, 2023 at 11:33:58AM +1200, David Rowley wrote: >> Any chance you could try and come up with a minimal reproducer? > Try this Thanks. I see the problem: finalize_aggregate is no longer forcing a R/W expanded datum returned by the finalfn into R/O form. If

Re: Direct I/O

2023-04-16 Thread Tom Lane
Andrew Dunstan writes: > On 2023-04-16 Su 10:18, Tom Lane wrote: >> Actually, as long as it's still OpenBSD I think you can keep using >> the same animal name ... Andrew, what's the policy on that? > update_personality.pl lets you update the OS version / compiler version > / owner-name / owner-e

Re: idea: multiple arguments to_regclass function

2023-04-16 Thread Pavel Stehule
ne 16. 4. 2023 v 16:23 odesílatel Tom Lane napsal: > Pavel Stehule writes: > > I missing some variants of to_regclass > > > to_regclass(schemaname, objectname) > > to_regclass(catalogname, schemaname, objectname) > > Can do that already: > > to_regclass(quote_ident(schemaname) || '.' || quote_id

Re: Direct I/O

2023-04-16 Thread Andrew Dunstan
On 2023-04-16 Su 10:18, Tom Lane wrote: =?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= writes: On 2023-04-16 00:10, Tom Lane wrote: so curculio should be the only one that's at risk here. Maybe just upgrading it is the right answer. Just let me know if I should switch curculio to OpenBSD 7.3. Yes pleas

Re: Direct I/O

2023-04-16 Thread Mikael Kjellström
On 2023-04-16 16:18, Tom Lane wrote: =?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= writes: On 2023-04-16 00:10, Tom Lane wrote: so curculio should be the only one that's at risk here. Maybe just upgrading it is the right answer. Just let me know if I should switch curculio to OpenBSD 7.3. Yes plea

Re: Can we delete the vacuumdb.sgml notes about which version each option was added in?

2023-04-16 Thread Tom Lane
Justin Pryzby writes: > On Sun, Apr 16, 2023 at 10:14:35PM +1200, David Rowley wrote: >> Does anyone think we should keep these? > I don't know if I'd support removing the notes, but I agree that they > don't need to take up anywhere near as much space as they do (especially > since the note is n

Re: idea: multiple arguments to_regclass function

2023-04-16 Thread Tom Lane
Pavel Stehule writes: > I missing some variants of to_regclass > to_regclass(schemaname, objectname) > to_regclass(catalogname, schemaname, objectname) Can do that already: to_regclass(quote_ident(schemaname) || '.' || quote_ident(objectname)) I'm not eager to build nine more to_reg* functions

Re: Direct I/O

2023-04-16 Thread Tom Lane
=?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= writes: > On 2023-04-16 00:10, Tom Lane wrote: >> so curculio should be the only one that's at risk here. >> Maybe just upgrading it is the right answer. > Just let me know if I should switch curculio to OpenBSD 7.3. Yes please. > I already have a new server s

Re: Can we delete the vacuumdb.sgml notes about which version each option was added in?

2023-04-16 Thread Justin Pryzby
On Sun, Apr 16, 2023 at 10:14:35PM +1200, David Rowley wrote: > I was just looking at the vacuumdb docs and noticed that I had > neglected to follow the tradition of adding a note to mention which > version we added the new option in when I committed the > --buffer-usage-limit patch. > > There are

Re: Can we delete the vacuumdb.sgml notes about which version each option was added in?

2023-04-16 Thread Nathan Bossart
On Sun, Apr 16, 2023 at 10:14:35PM +1200, David Rowley wrote: > There are 3 notes there that read "This option is only available for > servers running PostgreSQL 9.6 and later.". Since 9.6 is a few years > out of support, can we get rid of these 3? +1 > Or better yet, can we just delete them all

Can we delete the vacuumdb.sgml notes about which version each option was added in?

2023-04-16 Thread David Rowley
I was just looking at the vacuumdb docs and noticed that I had neglected to follow the tradition of adding a note to mention which version we added the new option in when I committed the --buffer-usage-limit patch. There are 3 notes there that read "This option is only available for servers runnin

Re: Direct I/O

2023-04-16 Thread Mikael Kjellström
On 2023-04-16 00:10, Tom Lane wrote: so curculio should be the only one that's at risk here. Maybe just upgrading it is the right answer. Just let me know if I should switch curculio to OpenBSD 7.3. I already have a new server setup so only need to switch the "animal" and "secret" and ena