On Thu, Mar 23, 2023 at 01:54:05PM +, Imseih (AWS), Sami wrote:
> Yes, that is possible but we will need to add a libpq API
> that allows the caller to pass in a "fetch size".
> PQsendQueryParams does not take in a "fetch size",
> so it returns all rows, through PQsendQueryParams
>
> https://
On Wed, Mar 29, 2023 at 6:31 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit-san,
>
> > There is no need to break the link line. See attached.
>
> I understood your saying. I think it's better.
>
Pushed.
--
With Regards,
Amit Kapila.
At Wed, 29 Mar 2023 13:21:55 +0900 (JST), Kyotaro Horiguchi
wrote in
> autovacuum.c:2893
> /*
>* If any of the cost delay parameters has been set
> individually for
>* this table, disable the balancing algorithm.
>*/
>
Hi,
On 3/29/23 2:09 AM, Michael Paquier wrote:
On Tue, Mar 28, 2023 at 05:43:26PM +0900, Kyotaro Horiguchi wrote:
No. Fine by me, except that "block read requests" seems to suggest
kernel read() calls, maybe because it's not clear whether "block"
refers to our buffer blocks or file blocks to me
On Wed, Mar 29, 2023 at 3:34 AM Tomas Vondra
wrote:
>
> On 3/28/23 18:34, Masahiko Sawada wrote:
> > On Mon, Mar 27, 2023 at 11:46 PM Tomas Vondra
> > wrote:
> >>
> >>
> >>
> >> On 3/27/23 03:32, Masahiko Sawada wrote:
> >>> Hi,
> >>>
> >>> On Fri, Mar 24, 2023 at 7:26 AM Tomas Vondra
> >>> wrot
On Wed, Mar 29, 2023 at 12:54 AM Yugo NAGATA wrote:
> Hello,
>
>
> Temporary tables are often used to store transient data in
> batch processing and the contents can be accessed multiple
> times. However, frequent use of temporary tables has a problem
> that the system catalog tends to bloat. I k
Hi
st 29. 3. 2023 v 6:54 odesílatel Yugo NAGATA napsal:
> Hello,
>
>
> Temporary tables are often used to store transient data in
> batch processing and the contents can be accessed multiple
> times. However, frequent use of temporary tables has a problem
> that the system catalog tends to bloat
Hi,
I would like to suggest a patch against master (although it may be worth
backporting it) that makes it possible to listen on any unused port.
The main motivation is running colocated instances of Postgres (such as
test benches) without having to coordinate port allocation in an
unnecessarily
Hello,
Temporary tables are often used to store transient data in
batch processing and the contents can be accessed multiple
times. However, frequent use of temporary tables has a problem
that the system catalog tends to bloat. I know there has been
several proposals to attack this problem, but I
Dear my comrade Brar,
> Thanks, I actually was not aware of this.
>
> Also, kudos for capturing the missing id and advocating for consistency
> regarding ids even before this is actively enforced. This nurtures my
> optimism that consistency might actually be achieveable without
> everybody getti
At Wed, 29 Mar 2023 12:09:08 +0900 (JST), Kyotaro Horiguchi
wrote in
> timeing perfectly. I think we might accidentally add a reload
> timing. In that case, the assumption could break. In most cases, I
> think we use snapshotting in various ways to avoid unintended variable
> changes. (And I bei
On Wed, Mar 29, 2023 at 7:44 AM Peter Smith wrote:
>
> A minor review comment for v25-0001.
>
> ==
> src/backend/commands/subscriptioncmds.c
>
> 1.
> @@ -1936,21 +1936,56 @@ fetch_table_list(WalReceiverConn *wrconn, List
> *publications)
> WalRcvExecResult *res;
> StringInfoData cmd;
> T
Hi,
On 2023-03-27 15:32:47 +0900, Kyotaro Horiguchi wrote:
> At Sun, 26 Mar 2023 12:26:59 -0700, Andres Freund wrote
> in
> > Hi,
> >
> > Attached is v5. Lots of comment polishing, a bit of renaming. I extracted
> > the
> > relation extension related code in hio.c back into its own function.
>
Hi,
On 2023-03-26 17:42:45 -0400, Melanie Plageman wrote:
> Below is my review of a slightly older version than you just posted --
> much of it you may have already addressed.
Far from all is already - thanks for the review!
> From 3a6c3f41000e057bae12ab4431e6bb1c5f3ec4b0 Mon Sep 17 00:00:00 20
At Tue, 28 Mar 2023 20:35:28 -0400, Melanie Plageman
wrote in
> On Tue, Mar 28, 2023 at 4:21 AM Kyotaro Horiguchi
> wrote:
> >
> > At Mon, 27 Mar 2023 14:12:03 -0400, Melanie Plageman
> > wrote in
> > > So, I've attached an alternate version of the patchset which takes the
> > > approach of h
Hi,
On 2023-03-28 18:21:02 -0700, Andres Freund wrote:
> Here's a draft patch.
Attached is v2, with a stupid bug fixed and a bit of comment / pgindent
polish.
Greetings,
Andres Freund
>From 6f27018765f167a8d2a52bc7c9068cb09ca8d82c Mon Sep 17 00:00:00 2001
From: Andres Freund
Date: Mon, 24 Oct
A minor review comment for v25-0001.
==
src/backend/commands/subscriptioncmds.c
1.
@@ -1936,21 +1936,56 @@ fetch_table_list(WalReceiverConn *wrconn, List
*publications)
WalRcvExecResult *res;
StringInfoData cmd;
TupleTableSlot *slot;
- Oid tableRow[3] = {TEXTOID, TEXTOID, NAMEARRAYOID};
Hello,
Attached patch introduces a function pg_column_toast_chunk_id
that returns a chunk ID of a TOASTed value.
Recently, one of our clients needed a way to show which columns
are actually TOASTed because they would like to know how much
updates on the original table affects to its toast table
s
On Tue, Mar 28, 2023 at 05:15:25PM +1300, Thomas Munro wrote:
> The commit message explains pretty well, and it seems to work in
> simple testing, and yeah commit c6f2f016 was not a work of art.
> pg_basebackeup --format=plain "worked", but your way is better. I
> guess we should add a test of -Fp
Hi,
On 2023-03-25 11:17:07 -0700, Andres Freund wrote:
> I don't see how that's easily possible with the current lock ordering
> rules. At least without giving up using RBM_ZERO_AND_LOCK for extending or
> stuffing even more things to happen with the the extension lock held, which I
> don't think
Dear Amit-san,
> There is no need to break the link line. See attached.
I understood your saying. I think it's better.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On Sun, 12 Jun 2022 at 21:14, Dmitry Dolgov <9erthali...@gmail.com> wrote:
> I've noticed that JIT performance counter generation_counter seems to include
> actions, relevant for both jit_expressions and jit_tuple_deforming options. It
> means one can't directly see what is the influence of jit_tup
On 3/28/23 00:34, gkokola...@pm.me wrote:
>
> ...
>
>> Got it. In that case I agree it's fine to do that in a single commit.
>
> For what is worth, I think that this patch should get a +1 and get in. It
> solves the empty writes problem and includes a test to a previous untested
> case.
>
Pushe
On Tue, Mar 28, 2023 at 4:21 AM Kyotaro Horiguchi
wrote:
>
> At Mon, 27 Mar 2023 14:12:03 -0400, Melanie Plageman
> wrote in
> > So, I've attached an alternate version of the patchset which takes the
> > approach of having one commit which only enables cost-based delay GUC
> > refresh for VACUUM
On Tue, Mar 28, 2023 at 02:56:28PM +0900, Michael Paquier wrote:
> Hmm. This is a good point. It is true that the patch feels
> incomplete on this side. I don't see why we could not be flexible,
> and allow a value of 0 in a partitioned table's relam to mean that we
> would pick up the database
On Tue, Mar 28, 2023 at 05:43:26PM +0900, Kyotaro Horiguchi wrote:
> No. Fine by me, except that "block read requests" seems to suggest
> kernel read() calls, maybe because it's not clear whether "block"
> refers to our buffer blocks or file blocks to me.. If it is generally
> clear, I'm fine with
On Tue, Mar 28, 2023 at 3:29 PM Andres Freund wrote:
> Why is that? It's as clear a signal of concurrent activity on the buffer
> you're going to get.
Not immediately getting a cleanup lock in VACUUM is informative to the
extent that you only care about what is happening that very
nanosecond. If
On Tue, 2023-03-28 at 10:22 -0400, Dave Cramer wrote:
> OK, IIUC what you are proposing here is that there would be a
> separate pool for
> database, user, and OIDs. This doesn't seem too flexible. For
> instance if I create a UDT and then want it to be returned
> as binary then I have to reconfi
On Tue, 2023-03-28 at 13:55 -0400, Robert Haas wrote:
> Oh, interesting. I hadn't realized we were doing that, and I do think
> that narrows the vulnerability quite a bit.
It's good to know I wasn't missing something obvious.
> bsent logical replication, you don't really need to worry
> about whe
On Tue, Mar 28, 2023 at 11:15:17AM -0700, Peter Geoghegan wrote:
> On Mon, Mar 27, 2023 at 7:47 PM Bharath Rupireddy
> wrote:
>> Hm, agreed. Changed in the attached v7-0002 patch. We can as well
>> write a case statement in the create function SQL to output forkname
>> instead forknumber, but I'd
On Wed, Mar 15, 2023 at 9:50 PM Justin Pryzby wrote:
> On Fri, Mar 10, 2023 at 12:48:13PM -0800, Jacob Champion wrote:
> > It looks like pg_dump's meson.build is missing dependencies on zstd
> > (meson couldn't find the headers in the subproject without them).
>
> I saw that this was added for LZ4
Hi,
On 2023-03-28 13:05:19 -0700, Peter Geoghegan wrote:
> On Tue, Mar 28, 2023 at 12:01 PM Andres Freund wrote:
> > I will probably make that argument - so far I was just trying to understand
> > the intent of the current code. There aren't really comments explaining why
> > we
> > want to mark
On 3/28/23 18:07, gkokola...@pm.me wrote:
>
> --- Original Message ---
> On Friday, March 24th, 2023 at 10:30 AM, gkokola...@pm.me
> wrote:
>
>>
>> --- Original Message ---
>> On Thursday, March 23rd, 2023 at 6:10 PM, Tomas Vondra
>> tomas.von...@enterprisedb.com wrote:
>>
>>>
On Sun, Mar 26, 2023 at 5:22 PM Tom Lane wrote:
> I spent some time looking through this thread to try to get a sense
> of the state of things, and I came away quite depressed. The patchset
> has ballooned to over 2MB, which is a couple orders of magnitude
> larger than anyone could hope to mean
On Mon, Mar 27, 2023 at 4:52 PM Peter Geoghegan wrote:
> This is fine, as far as it goes. Obviously it fixes the immediate problem.
OK, I've committed and back-patched this fix to v14, just like the
erroneous commit that created the issue.
--
Robert Haas
EDB: http://www.enterprisedb.com
On Tue, Mar 28, 2023 at 3:25 PM Isaac Morland
wrote:
> On Mon, 19 Dec 2022 at 17:57, Corey Huinker
> wrote:
>
>>
>> Attached is my work in progress to implement the changes to the CAST()
>> function as proposed by Vik Fearing.
>>
>> CAST(expr AS typename NULL ON ERROR)
>> will use error-safe
On Tue, Mar 28, 2023 at 2:53 PM Gregory Stark (as CFM)
wrote:
> On Tue, 3 Jan 2023 at 14:16, Tom Lane wrote:
> >
> > Vik Fearing writes:
> >
> > > I don't think we should add that syntax until I do get it through the
> > > committee, just in case they change something.
> >
> > Agreed. So this
On Tue, Mar 28, 2023 at 12:01 PM Andres Freund wrote:
> I will probably make that argument - so far I was just trying to understand
> the intent of the current code. There aren't really comments explaining why we
> want to mark currently-pinned empty/new pages all-visible and enter them into
> the
On Tue, 21 Feb 2023 at 22:02, Richard Guo wrote:
> Looking at the codes now I have some concern that what we do in
> create_ordered_paths for partial paths may have already been done in
> generate_useful_gather_paths, especially when query_pathkeys is equal to
> sort_pathkeys. Not sure if this is
On Tue, Mar 28, 2023 at 9:44 PM Gregory Stark (as CFM)
wrote:
> On Wed, 31 Aug 2022 at 20:52, Alexander Korotkov wrote:
> >
> > I'll continue work on this patch. The rebased patch is attached. It
> > implements stop events as configure option (not runtime GUC option).
>
> It looks like this pat
Hi,
Patch v15-0001-ALTER-TABLE-MERGE-PARTITIONS-command.patch
Apply nicely.
One warning on meson compile (configure -Dssl=openssl -Dldap=enabled
-Dauto_features=enabled -DPG_TEST_EXTRA='ssl,ldap,kerberos' -Dbsd_auth=disabled
-Dbonjour=disabled -Dpam=disabled -Dpltcl=disabled -Dsystemd=disabled
Hi
ne 26. 3. 2023 v 19:53 odesílatel Dmitry Dolgov <9erthali...@gmail.com>
napsal:
> > On Sun, Mar 26, 2023 at 07:32:05PM +0800, Julien Rouhaud wrote:
> > Hi,
> >
> > I just have a few minor wording improvements for the various comments /
> > documentation you quoted.
>
> Talking about documentat
Hi,
On Wed, Mar 15, 2023 at 4:28 AM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> > [PATCH v8 1/5] Make minor additions and corrections to meson docs
>
> The last hunk revealed that there is some mixing up between meson setup
> and meson configure. This goes a bit further. For
On Mon, 19 Dec 2022 at 17:57, Corey Huinker wrote:
>
> Attached is my work in progress to implement the changes to the CAST()
> function as proposed by Vik Fearing.
>
> CAST(expr AS typename NULL ON ERROR)
> will use error-safe functions to do the cast of expr, and will return
> NULL if the c
ne 26. 3. 2023 v 13:32 odesílatel Julien Rouhaud
napsal:
> Hi,
>
> I just have a few minor wording improvements for the various comments /
> documentation you quoted.
>
> On Sun, Mar 26, 2023 at 08:53:49AM +0200, Pavel Stehule wrote:
> > út 21. 3. 2023 v 17:18 odesílatel Peter Eisentraut <
> > pe
Hi,
On 2023-03-27 21:51:09 -0700, Peter Geoghegan wrote:
> On Mon, Mar 27, 2023 at 9:32 PM Andres Freund wrote:
> > > You haven't said anything about the leading cause of marking empty
> > > pages all-frozen, by far: lazy_vacuum_heap_page(). Should it also stop
> > > marking empty pages all-froze
Ah, another thread with a bouncing email address...
Please respond to to thread from this point to avoid bounces.
--
Gregory Stark
As Commitfest Manager
It looks like this remaining work isn't going to happen this CF and
therefore this release. There hasn't been an update since January when
Dean Rasheed posted a review.
Unless there's any updates soon I'll move this on to the next
commitfest or mark it returned with feedback.
--
Gregory Stark
As
On Tue, 28 Mar 2023 at 18:13, Robert Haas wrote:
>
> On Mon, Mar 27, 2023 at 6:08 PM Jelte Fennema wrote:
> > For high privileged subscription owners,
> > we downgrade to the permissions of the table owner, but for low
> > privileged ones we care about permissions of the subscription owner
> > it
On Tue, 3 Jan 2023 at 14:16, Tom Lane wrote:
>
> Vik Fearing writes:
>
> > I don't think we should add that syntax until I do get it through the
> > committee, just in case they change something.
>
> Agreed. So this is something we won't be able to put into v16;
> it'll have to wait till there's
FYI I attached this thread to
https://commitfest.postgresql.org/42/3777 which I believe is the same
issue. I mistakenly had this listed as a CF entry with no discussion
for a long time due to that missing link.
--
Gregory Stark
As Commitfest Manager
On Tue, Mar 28, 2023 at 06:40:03PM +0200, Tomas Vondra wrote:
> On 3/28/23 18:07, gkokola...@pm.me wrote:
> > --- Original Message ---
> > On Friday, March 24th, 2023 at 10:30 AM, gkokola...@pm.me
> > wrote:
> >
> >> --- Original Message ---
> >> On Thursday, March 23rd, 2023 at
On 3/28/23 20:03, Kirk Wolak wrote:
> On Tue, Mar 28, 2023 at 12:23 PM Tomas Vondra
> mailto:tomas.von...@enterprisedb.com>>
> wrote:
>
> On 3/27/23 19:28, Justin Pryzby wrote:
> > On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote:
> >> On 3/16/23 05:50, Justin Pryzby wrote:
On Wed, 31 Aug 2022 at 20:52, Alexander Korotkov wrote:
>
> I'll continue work on this patch. The rebased patch is attached. It
> implements stop events as configure option (not runtime GUC option).
It looks like this patch isn't going to be ready this commitfest. And
it hasn't received much di
Alvaro Herrera writes:
> So I'm back home and found a couple more weird errors in the log:
> ERROR: mismatching PartitionPruneInfo found at part_prune_index 0
> DETALLE: plan node relids (b 1), pruneinfo relids (b 36)
This one reproduces for me.
> select
> pg_catalog.pg_stat_get_buf_f
On 3/28/23 18:34, Masahiko Sawada wrote:
> On Mon, Mar 27, 2023 at 11:46 PM Tomas Vondra
> wrote:
>>
>>
>>
>> On 3/27/23 03:32, Masahiko Sawada wrote:
>>> Hi,
>>>
>>> On Fri, Mar 24, 2023 at 7:26 AM Tomas Vondra
>>> wrote:
I merged the earlier "fixup" patches into the relevant parts, an
So I'm back home and found a couple more weird errors in the log:
MERGE INTO public.idxpart2 as target_0
USING (select 1
from
public.xmltest2 as ref_0
inner join public.prt1_l_p1 as sample_0
inner join fkpart4.droppk as ref
On Tue, Mar 28, 2023 at 5:15 PM Thomas Munro wrote:
> I guess we should add a test of -Fp too, to keep it working?
Oops, that was already tested in existing tests, so I take that back.
On Mon, Mar 27, 2023 at 7:47 PM Bharath Rupireddy
wrote:
> Hm, agreed. Changed in the attached v7-0002 patch. We can as well
> write a case statement in the create function SQL to output forkname
> instead forknumber, but I'd stop doing that to keep in sync with
> pg_buffercache.
I just don't see
On Tue, Mar 28, 2023 at 12:23 PM Tomas Vondra
wrote:
> On 3/27/23 19:28, Justin Pryzby wrote:
> > On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote:
> >> On 3/16/23 05:50, Justin Pryzby wrote:
> >>> On Fri, Mar 10, 2023 at 12:48:13PM -0800, Jacob Champion wrote:
> On Wed, Mar 8, 2
On Tue, Mar 28, 2023 at 1:38 AM Jeff Davis wrote:
> > If they do have those things then in
> > theory they might be able to protect themselves, but in practice they
> > are unlikely to be careful enough. I judge that practically every
> > installation where table owners use triggers would be easi
On Fri, 2023-03-24 at 00:17 -0700, Jeff Davis wrote:
> The other patch you posted seems like it makes a lot of progress in
> that direction, and I think that should go in first. That was one of
> the items I suggested previously[2], so thank you for working on
> that.
The above is not a hard objec
On Tue, Mar 28, 2023 at 2:59 AM wangw.f...@fujitsu.com
wrote:
> The scenario of this bug is to subscribe to two publications at the same time,
> and these two publications publish parent table and child table respectively.
> And option via_root is specified in both publications or only in the
> p
On 3/28/23 18:07, gkokola...@pm.me wrote:
>
>
>
>
>
> --- Original Message ---
> On Friday, March 24th, 2023 at 10:30 AM, gkokola...@pm.me
> wrote:
>
>>
>> --- Original Message ---
>> On Thursday, March 23rd, 2023 at 6:10 PM, Tomas Vondra
>> tomas.von...@enterprisedb.com
On Mon, Mar 27, 2023 at 11:46 PM Tomas Vondra
wrote:
>
>
>
> On 3/27/23 03:32, Masahiko Sawada wrote:
> > Hi,
> >
> > On Fri, Mar 24, 2023 at 7:26 AM Tomas Vondra
> > wrote:
> >>
> >> I merged the earlier "fixup" patches into the relevant parts, and left
> >> two patches with new tweaks (deducing
On 3/27/23 19:28, Justin Pryzby wrote:
> On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote:
>> On 3/16/23 05:50, Justin Pryzby wrote:
>>> On Fri, Mar 10, 2023 at 12:48:13PM -0800, Jacob Champion wrote:
On Wed, Mar 8, 2023 at 10:59 AM Jacob Champion
wrote:
> I did some
On Mon, Mar 27, 2023 at 6:08 PM Jelte Fennema wrote:
> Attached is an updated version of your patch with what I had in mind
> (admittedly it needed one more line than "just" the return to make it
> work). But as you can see all previous tests for a lowly privileged
> subscription owner that **cann
Status summary:
Needs review: 116.
Waiting on Author: 30.
Ready for Committer: 32.
Committed: 94.
Moved to next CF: 17.
Returned with Feedback: 6.
Rejected: 6.
Withdrawn: 18.
Total: 319.
Ok, here are the patches that have been stuck in "Waiting
on Author" for a while. I divided t
--- Original Message ---
On Friday, March 24th, 2023 at 10:30 AM, gkokola...@pm.me
wrote:
>
> --- Original Message ---
> On Thursday, March 23rd, 2023 at 6:10 PM, Tomas Vondra
> tomas.von...@enterprisedb.com wrote:
>
> > This leaves the empty-data issue (which we have a f
On Tue, 28 Mar 2023 at 16:54, Denis Laxalde wrote:
> I had a look into your patchset (v16), did a quick review and played a
> bit with the feature.
>
> Patch 2 is missing the documentation about PQcancelSocket() and contains
> a few typos; please find attached a (fixup) patch to correct these.
Th
On 3/28/23 15:17, Jehan-Guillaume de Rorthais wrote:
> On Tue, 28 Mar 2023 00:43:34 +0200
> Tomas Vondra wrote:
>
>> On 3/27/23 23:13, Jehan-Guillaume de Rorthais wrote:
>>> Please, find in attachment a patch to allocate bufFiles in a dedicated
>>> context. I picked up your patch, backpatch'd
On Tue, Mar 28, 2023 at 6:47 PM Amit Kapila wrote:
>
> On Mon, Mar 27, 2023 at 8:17 AM Masahiko Sawada wrote:
> >
> > On Fri, Mar 24, 2023 at 11:51 PM Kumar, Sachin wrote:
> > >
> > > > From: Amit Kapila
> > > > > I think we won't be able to use same snapshot because the transaction
> > > > >
Hi,
Sorry for the late answer, I was reviewing the first patch and it took me some
time to study and dig around.
On Thu, 23 Mar 2023 08:07:04 -0400
Melanie Plageman wrote:
> On Fri, Mar 10, 2023 at 1:51 PM Jehan-Guillaume de Rorthais
> wrote:
> > > So I guess the best thing would be to go thro
Hi Jelte,
I had a look into your patchset (v16), did a quick review and played a
bit with the feature.
Patch 2 is missing the documentation about PQcancelSocket() and contains
a few typos; please find attached a (fixup) patch to correct these.
--- a/src/interfaces/libpq/libpq-fe.h
+++ b/src/int
On 3/27/23 2:37 AM, Amit Kapila wrote:
On Mon, Mar 27, 2023 at 2:52 AM Tom Lane wrote:
And TBH, I don't think that I quite believe the premise in the
first place. The whole point of using logical rather than physical
replication is that the subscriber installation(s) aren't exactly like
the
I wrote:
> The planner is reducing the scan of target_parted to
> a dummy scan, as is reasonable, but it forgets to
> provide ctid as an output from that scan; then the
> parent join node is unhappy because it does have
> a ctid output. So it looks like the problem is some
> shortcut we take while
Hi,
It took me a while but I finally got back to reworking this to use the
bt_info bit, as proposed by Alvaro. And it turned out to work great,
because (a) it's a tuple-level flag, i.e. the right place, and (b) it
does not overload existing flags.
This greatly simplified the code in add_values_to
Greetings,
* Stephen Frost (sfr...@snowman.net) wrote:
> * Greg Stark (st...@mit.edu) wrote:
> > The CFBot says there's a function be_gssapi_get_proxy() which is
> > undefined. Presumably this is a missing #ifdef or a definition that
> > should be outside an #ifdef.
>
> Yup, just a couple of miss
> I think that there are some (possibly) tricky challenges that haven't
> been discussed yet to support replicating global objects.
>
> First, as for publications having global objects (roles, databases,
> and tablespaces), but storing them in database specific tables like
> pg_publication doesn't
On Sun, 26 Mar 2023 at 21:30, Tom Lane wrote:
> Dave Cramer writes:
> > On Sun, 26 Mar 2023 at 18:12, Tom Lane wrote:
> >> I would not expect DISCARD ALL to reset a session-level property.
>
> > Well if we can't reset it with DISCARD ALL how would that work with
> > pgbouncer, or any pool for t
On 28.03.23 13:33, Tom Lane wrote:
While we're here, do we want to adopt some other spelling of "the
root locale" than "und", in view of recent discoveries about the
instability of that on old ICU versions?
That issue was fixed by 3b50275b12, so we can keep using the "und" spelling.
> On 28 Mar 2023, at 15:26, Daniel Gustafsson wrote:
> I think the attached is a good candidate for going in, but I would like to
> see it
> for another spin in the CF bot first.
Another candidate due to a thinko which raised a compiler warning.
--
Daniel Gustafsson
v19-0001-pg_regress-Emit
On Mon, Mar 20, 2023 at 3:16 AM Joseph Koshakow wrote:
>
>
>
> On Sun, Mar 19, 2023 at 5:13 PM Tom Lane wrote:
> >
> >Did you actually write "if TIMESTAMP_IS_NOBEGIN(dt2)" and not
> >"if (TIMESTAMP_IS_NOBEGIN(dt2))"? If the former, I'm not surprised
> >that pgindent gets confused. T
On Sun, Mar 26, 2023 at 1:28 AM Tom Lane wrote:
>
> I think you can take it as read that simple C test programs on modern
> platforms will exhibit IEEE-compliant handling of float infinities.
>
For the record, I tried the attached. It gives a warning at compilation time.
$gcc float_inf.c
float_i
Op 3/27/23 om 20:54 schreef Alvaro Herrera:
Docs amended as I threatened. Other than that, this has required more
> [v12-0001-SQL-JSON-constructors.patch]
> [v12-0001-delta-uniqueifyJsonbObject-bugfix.patch]
In doc/src/sgml/func.sgml, some minor stuff:
'which specify the data type returned'
On Sun, Mar 19, 2023 at 12:18 AM Joseph Koshakow wrote:
>
> The problem is that `secs = rint(secs)` rounds the seconds too early
> and loses any fractional seconds. Do we have an overflow detecting
> multiplication function for floats?
We have float8_mul() which checks for overflow. typedef doubl
On Tue, 2023-03-28 at 08:46 -0400, Joe Conway wrote:
> > As long as we still have to initialize the libc locale fields to
> > some
> > language, I think it would be less confusing to keep the ICU locale
> > on
> > the same language.
>
> I definitely agree with that.
Sounds good -- no changes then
> On 15 Mar 2023, at 11:36, Peter Eisentraut
> wrote:
>
> On 24.02.23 10:49, Daniel Gustafsson wrote:
>> Another rebase on top of 337903a16f. Unless there are conflicting reviews, I
>> consider this patch to be done and ready for going in during the next CF.
>
> I think this is just about as g
On Tue, 28 Mar 2023 00:43:34 +0200
Tomas Vondra wrote:
> On 3/27/23 23:13, Jehan-Guillaume de Rorthais wrote:
> > Please, find in attachment a patch to allocate bufFiles in a dedicated
> > context. I picked up your patch, backpatch'd it, went through it and did
> > some minor changes to it. I hav
I wrote:
> I reduced this down to
> MERGE INTO public.target_parted as target_0
> USING public.itest1 as ref_0
> ON target_0.b = ref_0.a
> WHEN NOT MATCHED
>THEN INSERT VALUES (42, 13);
> The critical moving part seems to just be that the MERGE target
> is a partitioned table
Bumping it to attract some attention.
On Tue, Mar 21, 2023 at 12:51 PM Ashutosh Bapat
wrote:
>
> Hi,
> Hash table scans (seq_scan_table/level) are cleaned up at the end of a
> transaction in AtEOXact_HashTables(). If a hash seq scan continues
> beyond transaction end it will meet "ERROR: no hash_
Alvaro Herrera writes:
> I have to run now so can't dissect it, but while running sqlsmith on the
> SQL/JSON patch after Justin's report, I got $SUBJECT in this query:
I reduced this down to
MERGE INTO public.target_parted as target_0
USING public.itest1 as ref_0
ON target_0.b = ref_0.a
On 3/28/23 06:07, Peter Eisentraut wrote:
On 23.03.23 21:16, Jeff Davis wrote:
Another thought: for ICU, do we want the default collation to be
UNICODE (root collation)? What we have now gets the default from the
environment, which is consistent with the libc provider.
But now that we have the
On Tue, Mar 28, 2023 at 1:00 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit,
>
> Thank you for reviewing! PSA new version.
>
> > Isn't it better to move the link-related part to the next line
> > wherever possible? Currently, it looks bit odd.
>
> Previously I preferred not to add a new line insi
>
> I might misunderstand something, but I believe the v5 patch uses
> copy_generic_opt_list and it does not add IGNORE_DATATYPE_ERRORS as a
> keyword.
> It modifies neither kwlist.h nor gram.y.
>
Sorry, didn't notice that. I think everything is alright now.
Regards,
Damir Belyalov
Postgres Profe
On 2023-03-27 23:28, Damir Belyalov wrote:
Hi!
I made the specified changes and my patch turned out the same as
yours. The performance measurements were the same too.
Thanks for your review and measurements.
The only thing left to do is how not to add IGNORE_DATATYPE_ERRORS as
a keyword. See
On Mon, Dec 19, 2022 at 12:37:19PM +0100, Alvaro Herrera wrote:
> I have created one in the January commitfest,
> https://commitfest.postgresql.org/41/
> and rebased the patch on current master. (I have not reviewed this.)
I have spent some time on that, and here are some comments with an
updated
Alvaro Herrera writes:
> I have to run now so can't dissect it, but while running sqlsmith on the
> SQL/JSON patch after Justin's report, I got $SUBJECT in this query:
Reproduces in HEAD and v15 too (once you replace pg_catalog.system_user
with some function that exists in v15). So it's not the
Peter Eisentraut writes:
> While working on [0], I was wondering why the collations ucs_basic and
> unicode are not in pg_collation.dat. I traced this back through
> history, and I think this was just lost in a game of telephone.
> The initial commit for pg_collation.h (414c5a2ea6) has only the
I have to run now so can't dissect it, but while running sqlsmith on the
SQL/JSON patch after Justin's report, I got $SUBJECT in this query:
MERGE INTO public.target_parted as target_0
USING (select
subq_0.c5 as c0,
subq_0.c0 as c1,
ref_0.a as c2,
s
1 - 100 of 121 matches
Mail list logo
