Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2023-01-01 Thread vignesh C
On Mon, 5 Dec 2022 at 06:53, Michael Paquier wrote: > > On Sat, Dec 03, 2022 at 05:34:57PM +, Matheus Alcantara wrote: > > I've tested your patched on current master and seems to be working properly. > > > > I'm starting reviewing some patches here, let's see what more experience > > hackers

Re: Add index scan progress to pg_stat_progress_vacuum

2023-01-01 Thread Imseih (AWS), Sami
>cfbot is complaining that this patch no longer applies. Sami, would you >mind rebasing it? Rebased patch attached. -- Sami Imseih Amazon Web Services: https://aws.amazon.com v18-0001-Add-2-new-columns-to-pg_stat_progress_vacuum.-Th.patch Description: v18-0001-Add-2-new-columns-to

enable_timeout_every() and fin_time

2023-01-01 Thread Andres Freund
Hi, I was looking using enable_timeout_every() in another place with Lukas just now, and noticed the fin_time argument. It seems odd for an interval firing interface to get an absolute timestamp as an argument. The only in-tree user of enable_timeout_every() computes fin_time explicitly using the

Re: Announcing Release 15 of the PostgreSQL Buildfarm client

2023-01-01 Thread Andrew Dunstan
On 2022-12-31 Sa 21:11, Andrew Dunstan wrote: > On 2022-12-31 Sa 20:55, Noah Misch wrote: >> On Sat, Dec 31, 2022 at 10:02:32AM -0500, Andrew Dunstan wrote: >>> * check if a branch is up to date before trying to run it >>> This only applies if the |branches_to_build| setting is a keyword >>

Re: Add a test to ldapbindpasswd

2023-01-01 Thread Andrew Dunstan
On 2023-01-01 Su 14:02, Thomas Munro wrote: > On Mon, Jan 2, 2023 at 3:04 AM Andrew Dunstan wrote: >> On 2022-12-19 Mo 11:16, Andrew Dunstan wrote: >>> There is currently no test for the use of ldapbindpasswd in the >>> pg_hba.conf file. This patch, mostly the work of John Naylor, remedies that.

Re: postgres_fdw: using TABLESAMPLE to collect remote sample

2023-01-01 Thread Tomas Vondra
On 12/31/22 18:23, Tom Lane wrote: > Tomas Vondra writes: >> On 12/31/22 05:42, Tom Lane wrote: >>> ERROR: TABLESAMPLE clause can only be applied to tables and materialized >>> views >>> I think the patch avoids that, but only accidentally, because >>> reltuples will be 0 or -1 for a view. Mayb

Re: Add a test to ldapbindpasswd

2023-01-01 Thread Andrew Dunstan
> On Jan 1, 2023, at 2:03 PM, Thomas Munro wrote: > > On Mon, Jan 2, 2023 at 3:04 AM Andrew Dunstan wrote: >>> On 2022-12-19 Mo 11:16, Andrew Dunstan wrote: >>> There is currently no test for the use of ldapbindpasswd in the >>> pg_hba.conf file. This patch, mostly the work of John Naylor, r

Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler?

2023-01-01 Thread Thomas Munro
On Sat, Dec 31, 2022 at 6:36 PM Noah Misch wrote: > On Sat, Dec 31, 2022 at 10:06:53AM +1300, Thomas Munro wrote: > > Idea #8 is a realisation that twisting oneself into a pretzel to avoid > > having to change the regexp code or its REG_CANCEL control flow may be > > a bit silly. If the only thin

Re: +infinity for dates and timestamps

2023-01-01 Thread Vik Fearing
On 1/1/23 20:21, Tom Lane wrote: Vik Fearing writes: Hmm. Somehow the .out test files were not included. Fixed with attached. Somehow you'd managed to duplicate some of the other changes, so the cfbot still didn't like that :-( Anyway, pushed with cosmetic changes. Notably, I left out the

Re: +infinity for dates and timestamps

2023-01-01 Thread Tom Lane
Vik Fearing writes: > Hmm. Somehow the .out test files were not included. > Fixed with attached. Somehow you'd managed to duplicate some of the other changes, so the cfbot still didn't like that :-( Anyway, pushed with cosmetic changes. Notably, I left out the documentation changes after obser

Re: Add a test to ldapbindpasswd

2023-01-01 Thread Thomas Munro
On Mon, Jan 2, 2023 at 3:04 AM Andrew Dunstan wrote: > On 2022-12-19 Mo 11:16, Andrew Dunstan wrote: > > There is currently no test for the use of ldapbindpasswd in the > > pg_hba.conf file. This patch, mostly the work of John Naylor, remedies that. > > > > > > This currently has failures on the c

Re: Add a test to ldapbindpasswd

2023-01-01 Thread Andrew Dunstan
On 2022-12-19 Mo 11:16, Andrew Dunstan wrote: > There is currently no test for the use of ldapbindpasswd in the > pg_hba.conf file. This patch, mostly the work of John Naylor, remedies that. > > This currently has failures on the cfbot for meson builds on FBSD13 and Debian Bullseye, but it's not