Hi,
On Mon, Nov 14, 2022 at 02:40:37PM +0900, Michael Paquier wrote:
> On Sat, Nov 12, 2022 at 04:13:53PM +0800, Julien Rouhaud wrote:
> > It's looks good to me. I agree that file name and line number should be
> > enough
> > to diagnose any unexpected error.
>
> Thanks for checking. I have loo
On Sat, Nov 12, 2022 at 1:46 AM Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2022-Oct-06, Amit Langote wrote:
> >> Actually, List of Bitmapsets turned out to be something that doesn't
> >> just-work with our Node infrastructure, which I found out thanks to
> >> -DWRITE_READ_PARSE_PLAN_TREES.
On Mon, Nov 14, 2022 at 12:23 AM Tom Lane wrote:
> Peter Eisentraut writes:
> > On 11.11.22 21:05, Tom Lane wrote:
> >> Attached is a cleaned-up version of Amit's patch v24-0003 at [2].
> >> I fixed the problems with not always tagging Bitmapsets, and changed
> >> the outfuncs/readfuncs logic so
On Mon, Oct 10, 2022 at 9:17 PM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> Taking another look around ecpg to see how this interacts with C-syntax
> integer literals. I'm not aware of any particular issues, but it's
> understandably tricky.
I can find no discussion in the arc
On Mon, Nov 14, 2022 at 12:14 PM Amit Kapila wrote:
>
> On Sat, Nov 12, 2022 at 7:21 PM vignesh C wrote:
> >
> > Few comments:
> > 1) I feel if the user has specified a long delay there is a chance
> > that replication may not continue if the replication slot falls behind
> > the current LSN by m
On 13.11.2022 20:59, Pavel Stehule wrote:
fresh rebase
Hello,
Sorry, I haven't been following this thread, but I'd like to report a
memory management bug. I couldn't apply the latest patches, so I tested
with v20221104-1-* patches applied atop of commit b0284bfb1db.
postgres=# create vari
Hi,
The thread title doesn't really convey the topic under discussion, so
changed it. IIRC, this has been mentioned by others as well in the
thread.
On Sat, Nov 12, 2022 at 7:21 PM vignesh C wrote:
>
> Few comments:
> 1) I feel if the user has specified a long delay there is a chance
> that repl
On Sat, Nov 12, 2022 at 04:13:53PM +0800, Julien Rouhaud wrote:
> It's looks good to me. I agree that file name and line number should be
> enough
> to diagnose any unexpected error.
Thanks for checking. I have looked at 0001 and 0002 again with a
fresh mind, and applied both of them this morni
> Re: Sandro Santilli
> > I'm attaching an updated version of the patch. This time the patch is
> > tested. Nothing changes unless the .control file for the subject
> > extension doesn't have a "wildcard_upgrades = true" statement.
> >
> > When wildcard upgrades are enabled, a file with a "%" symbo
On Sat, Nov 12, 2022 at 4:40 AM Jeff Davis wrote:
>
> On Fri, 2022-11-11 at 17:01 +0530, Bharath Rupireddy wrote:
> > Hi,
> >
> > Inspired by recent commits 9fcdf2c, e813e0e and many small test
> > modules/extensions under src/test/modules, I would like to propose
> > one
> > such test module for
On Tue, Nov 8, 2022 at 8:57 AM David Rowley wrote:
> On Tue, 8 Nov 2022 at 05:24, Andres Freund wrote:
> > I doubtthere's ever a need to realloc such a pointer? Perhaps we could
just
> > elog(ERROR)?
>
> Are you maybe locked into just thinking about your current planned use
> case that we want t
On Mon, Nov 14, 2022 at 1:05 PM Nathan Bossart wrote:
> Yeah, I'm able to sort-of reproduce the problem by sending fewer replies,
> but it's not clear to me why that's the problem. AFAICT all of the code
> paths that write/flush are careful to send a reply shortly afterward, which
> should keep w
On Mon, Oct 17, 2022 at 6:30 PM Amit Langote wrote:
> For a couple of patches that I am working on ([1], [2]), I have needed
> to put Bitmapsets into a List that is in turn part of a Plan tree or a
> Node tree that may be written (using outNode) and read (using
> nodeRead). Bitmapsets not being a
On Tuesday, November 8, 2022 2:27 PM Kuroda, Hayato/黒田 隼人
wrote:
> If you could not allocate a time to discuss this problem because of other
> important tasks or events, we would like to take over the thread and modify
> your patch.
>
> We've planned that we will start to address comments and re
On Mon, Nov 14, 2022 at 12:51:14PM +1300, Thomas Munro wrote:
> On Mon, Nov 14, 2022 at 12:35 PM Thomas Munro wrote:
>> Maybe there is a better way to code this (I mean, who likes global
>> variables?) and I need to test some more, but I suspect the attached
>> is approximately what we missed.
>
On Fri, Nov 04, 2022 at 06:59:46PM -0700, Andres Freund wrote:
> Hi,
>
> On 2022-11-04 18:54:12 -0500, Justin Pryzby wrote:
> > Subject: [PATCH 1/8] meson: PROVE is not required
> > Subject: [PATCH 3/8] meson: rename 'main' tasks to 'regress' and 'isolation'
>
> Pushed, thanks for the patches.
T
On Mon, Nov 14, 2022 at 12:35 PM Thomas Munro wrote:
> Maybe there is a better way to code this (I mean, who likes global
> variables?) and I need to test some more, but I suspect the attached
> is approximately what we missed.
Erm, ENOCOFFEE, sorry that's not quite right, it needs the apply LSN,
On Mon, Nov 14, 2022 at 12:11 PM Thomas Munro wrote:
> On Mon, Nov 14, 2022 at 11:26 AM Nathan Bossart
> wrote:
> > On Sun, Nov 13, 2022 at 05:08:04PM -0500, Tom Lane wrote:
> > > There is something very seriously wrong with this patch.
> > >
> > > On my machine, running "make -j10 check-world" (
On Mon, Nov 14, 2022 at 11:26 AM Nathan Bossart
wrote:
> On Sun, Nov 13, 2022 at 05:08:04PM -0500, Tom Lane wrote:
> > There is something very seriously wrong with this patch.
> >
> > On my machine, running "make -j10 check-world" (with compilation
> > already done) has been taking right about 2 m
On Sun, 13 Nov 2022 at 21:28, Thomas Munro wrote:
>
> On Mon, Nov 14, 2022 at 5:52 AM Simon Riggs
> wrote:
> > The attached patch is a reduced version of the original. It covers only:
> > * deprecation of the promote_trigger_file - there are no tests that
> > use that, hence why there is no test
On Sun, Nov 13, 2022 at 05:08:04PM -0500, Tom Lane wrote:
> There is something very seriously wrong with this patch.
>
> On my machine, running "make -j10 check-world" (with compilation
> already done) has been taking right about 2 minutes for some time.
> Since this patch, it's taking around 2:45
On Mon, Nov 14, 2022 at 11:08 AM Tom Lane wrote:
> There is something very seriously wrong with this patch.
>
> On my machine, running "make -j10 check-world" (with compilation
> already done) has been taking right about 2 minutes for some time.
> Since this patch, it's taking around 2:45 --- I di
Thomas Munro writes:
> And with that change and a pgindent, pushed.
There is something very seriously wrong with this patch.
On my machine, running "make -j10 check-world" (with compilation
already done) has been taking right about 2 minutes for some time.
Since this patch, it's taking around 2:
On Mon, Nov 14, 2022 at 5:52 AM Simon Riggs
wrote:
> The attached patch is a reduced version of the original. It covers only:
> * deprecation of the promote_trigger_file - there are no tests that
> use that, hence why there is no test coverage for the patch
> * changing the sleep time of the start
ne 13. 11. 2022 v 9:58 odesílatel Julien Rouhaud
napsal:
> On Sat, Nov 12, 2022 at 09:35:59PM +0100, Pavel Stehule wrote:
>
> Thanks for the updated patch. Apart from the function comment it looks
> good to
> me.
>
> Justin, did you have any other comment on the patch?
>
> > > I don't fully unde
On Fri, 11 Nov 2022 at 11:13, wangw.f...@fujitsu.com
wrote:
>
> On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
> >
>
> Thanks for your comments. Sorry for not replying in time.
>
> > On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
> > wrote:
> > >
> > > On Wed, Oct 5, 2022 at 11:08
On Thu, 24 Mar 2022 at 16:02, Simon Riggs wrote:
>
> On Thu, 24 Mar 2022 at 15:39, Robert Haas wrote:
> >
> > On Thu, Mar 24, 2022 at 6:59 AM Simon Riggs
> > wrote:
> > > The proposals of this patch are the following, each of which can be
> > > independently accepted/rejected:
> > > 1. fix the s
Peter Eisentraut writes:
> On 11.11.22 21:05, Tom Lane wrote:
>> Attached is a cleaned-up version of Amit's patch v24-0003 at [2].
>> I fixed the problems with not always tagging Bitmapsets, and changed
>> the outfuncs/readfuncs logic so that Bitmapsets still print exactly
>> as they did before (t
On Sat, 12 Nov 2022 at 12:12, Amit Kapila wrote:
> On Fri, Nov 11, 2022 at 2:45 PM Japin Li wrote:
>> Maybe a wrong plural in XidInMvccSnapshot().
>>
>> * Make a quick range check to eliminate most XIDs without looking at the
>> * xip arrays.
>>
>> I think we should use "xip array" in
pá 4. 11. 2022 v 15:28 odesílatel Dmitry Dolgov <9erthali...@gmail.com>
napsal:
> > On Fri, Nov 04, 2022 at 03:17:18PM +0100, Pavel Stehule wrote:
> > > I've stumbled upon something that looks weird to me (inspired by the
> > > example from tests):
> > >
> > > =# create variable v2 as int;
> >
On 11.11.22 21:05, Tom Lane wrote:
Per the discussion at [1], it seems like it'd be a good idea to make
Bitmapsets into full-fledged, tagged Nodes, so that we could do things
like print or copy lists of them without special-case logic. The
extra space for the NodeTag is basically free due to ali
On Thu, 2022-11-10 at 12:17 +0100, Alvaro Herrera wrote:
> On 2022-Nov-10, Laurenz Albe wrote:
> > On Wed, 2022-11-09 at 09:16 -0500, Robert Treat wrote:
> > > > > - If AND CHAIN is specified, a new
> > > > > transaction is
> > > > > + If AND CHAIN is specified, a new unaborted
> > > >
On 09.11.22 13:29, Alvaro Herrera wrote:
+/*
+ * Append a formatted string to the given buffer, after translation. A
+ * newline is automatically appended; the format should not end with a
+ * newline.
+ */
I find the "after translation" bit unclear -- does it mean that the
caller should have
On 09.11.22 19:12, Corey Huinker wrote:
After considering this again, I decided to brute-force this and get rid
of all the trivial wrapper functions and also several of the special
cases. That way, there is less confusion at the call sites about why
this or that style is used in
On 11.11.22 23:28, Jacob Champion wrote:
Consider the case where the server sends a
NegotiateProtocolVersion with a reasonable length, but then runs over
its own message (either by sending an unterminated string as one of the
extension names, or by sending a huge extension number). When I test
th
On Sat, Nov 12, 2022 at 09:35:59PM +0100, Pavel Stehule wrote:
Thanks for the updated patch. Apart from the function comment it looks good to
me.
Justin, did you have any other comment on the patch?
> > I don't fully understand the part about subpatterns, but is that necessary
> > to
> > descri
36 matches
Mail list logo
