Re: 16: Collation versioning and dependency helpers

2022-10-29 Thread Thomas Munro
On Sun, Oct 30, 2022 at 5:41 PM Jeff Davis wrote: > We haven't fully solved the changing collation-provider problem. An > upgrade of the OS may change the version of libc or icu, and that might > affect the collation, which could leave you with various corrupt > database objects including: > > *

16: Collation versioning and dependency helpers

2022-10-29 Thread Jeff Davis
Motivation: We haven't fully solved the changing collation-provider problem. An upgrade of the OS may change the version of libc or icu, and that might affect the collation, which could leave you with various corrupt database objects including: * indexes * constraints * range types or mult

Re: has_wal_read_bug

2022-10-29 Thread Noah Misch
On Tue, May 17, 2022 at 12:15:35AM -0700, Noah Misch wrote: > On Tue, May 17, 2022 at 11:50:51AM +1200, Thomas Munro wrote: > > 027_stream_regress.pl has: > > > > if (PostgreSQL::Test::Utils::has_wal_read_bug) > > { > > # We'd prefer to use Test::More->builder->todo_start, but the bug causes >

resowner "cold start" overhead

2022-10-29 Thread Andres Freund
Hi, As part of [1] I made IOs-in-progress be tracked by resowner.c. Benchmarking unfortunately showed that to have a small impact on workloads that often have to read data, but where that data is guaranteed to be in the kernel cache. I was a bit surprised, given that we also use the resowner.c me

Re: refactoring relation extension and BufferAlloc(), faster COPY

2022-10-29 Thread Andres Freund
Hi, On 2022-10-29 18:33:53 +0530, Bharath Rupireddy wrote: > On Sat, Oct 29, 2022 at 8:24 AM Andres Freund wrote: > > > > Hi, > > > > I'm working to extract independently useful bits from my AIO work, to reduce > > the size of that patchset. This is one of those pieces. > > Thanks a lot for this

Re: warn if GUC set to an invalid shared library

2022-10-29 Thread Justin Pryzby
On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote: > It caused no issue when I changed: > > /* Check that it's acceptable for the indicated > parameter */ > if (!parse_and_validate_value(record, name, value, > -

Re: Fix order of checking ICU options in initdb and create database

2022-10-29 Thread Marina Polyakova
On 2022-10-29 14:33, Marina Polyakova wrote: Hello! This is the last proposed patch on this subject [1] moved to a separate thread for Commitfest.. Also added a patch to export with_icu when running src/bin/scripts tests [1]. The problem can be reproduced as $ meson setup && ninja && meson

Re: refactoring relation extension and BufferAlloc(), faster COPY

2022-10-29 Thread Bharath Rupireddy
On Sat, Oct 29, 2022 at 8:24 AM Andres Freund wrote: > > Hi, > > I'm working to extract independently useful bits from my AIO work, to reduce > the size of that patchset. This is one of those pieces. Thanks a lot for this great work. There are 12 patches in this thread, I believe each of these pa

Fix order of checking ICU options in initdb and create database

2022-10-29 Thread Marina Polyakova
Hello! This is the last proposed patch on this subject [1] moved to a separate thread for Commitfest.. It looks like that the current order of checking ICU options in initdb and create database in PG 15+ is not user-friendly. Examples: 1. initdb reports a missing ICU locale although it may

回复: access method xxx does not exist

2022-10-29 Thread jack...@gmail.com
I'm trying to add a new index, but when I finish it, I use “ create index xxx_index on t1 using xxx(a); ”,it gives me access method "spb" does not exist And I don't know where this message is from, can you grve me its position? jack...@gmail.com

Fix database creation during installchecks for ICU cluster

2022-10-29 Thread Marina Polyakova
Hello! This is a copy of [1] moved to a separated thread for Commitfest.. I discovered an interesting behaviour during installcheck runs on PG 15+ when the cluster was initialized with ICU locale provider: $ initdb --locale-provider icu --icu-locale en-US -D data && pg_ctl -D data -l logfile

Re: Support logical replication of DDLs

2022-10-29 Thread Alvaro Herrera
On 2022-Oct-28, Peter Smith wrote: > Hi, authors on this thread. > > The patch v32-0001 is very large, so it will take some time to review > the code in detail. Yes, and I think there are a few things that should be split out from it. Namely, all the stuff that generates the JSON blob should ap

access method xxx does not exist

2022-10-29 Thread jack...@gmail.com
I'm trying to add a new index, but when I finish it, I use “ create index xxx_index on t1 using xxx(a); ”,it gives me access method "spb" does not exist And I don't know where this message is from, can you grve me its position? jack...@gmail.com

Re: Make EXPLAIN generate a generic plan for a parameterized query

2022-10-29 Thread Laurenz Albe
On Tue, 2022-10-25 at 19:03 +0800, Julien Rouhaud wrote: > On Tue, Oct 25, 2022 at 11:08:27AM +0200, Laurenz Albe wrote: > > Here is a patch that > > implements it with an EXPLAIN option named GENERIC_PLAN. > > I only have a quick look at the patch for now.  Any reason why you don't rely > on the