(Adding Tom in CC, in case.)
On Tue, Oct 18, 2022 at 04:35:33PM -0400, Corey Huinker wrote:
> I agree that we shouldn't spend too much effort on a good error message
> here, but perhaps we should have the message mention that it is
> date/time-related? A person git-grepping for this error message
Hi,
On 2022-Oct-18, Donghang Lin wrote:
> > I have a somewhat-related-but-not-really complaint. I recently had need to
> > have refint.so, autoinc.so and regress.so in the install directory; but it
> > turns out that there's no provision at all to get them installed.
> The current pgsql install
On Tue, Oct 18, 2022 at 02:38:07PM +0530, Bharath Rupireddy wrote:
> 2) Clarifies when the archive module shutdown callback gets called in
> documentation.
I have looked at that, and it was actually confusing as the callback
would also be called on reload if archive_library changes, but the
update
On Wed, Oct 19, 2022 at 8:58 AM Kyotaro Horiguchi
wrote:
>
> Unbounded number of sequential crash-restarts itself is a more serious
> problem..
Agree. The basic_archive module currently leaves temp files around
even for normal restarts of the cluster, which is bad IMO.
> An archive module could
On Wed, Oct 19, 2022 at 2:44 PM shiy.f...@fujitsu.com
wrote:
>
...
>
> +test_sub=# CREATE SUBSCRIPTION sub1
> +test_sub-# CONNECTION 'host=localhost dbname=test_pub'
> +test_sub-# PUBLICATION pub1
> +test_sub-# WITH (slot_name=NONE, enabled=false, create_slot=false);
> +WARNING: subscription was
On Wed, 19 Oct 2022 13:25:17 +0900 (JST)
Tatsuo Ishii wrote:
> > Hi,
> >
> > On Sat, 15 Oct 2022 10:40:29 +0900 (JST)
> > Tatsuo Ishii wrote:
> >
> >> > On Thu, 13 Oct 2022 15:35:09 +0900 (JST)
> >> > Tatsuo Ishii wrote:
> >> >
> >> >> > OK, that sounds good then. I would make a feature req
> Hi,
>
> On Sat, 15 Oct 2022 10:40:29 +0900 (JST)
> Tatsuo Ishii wrote:
>
>> > On Thu, 13 Oct 2022 15:35:09 +0900 (JST)
>> > Tatsuo Ishii wrote:
>> >
>> >> > OK, that sounds good then. I would make a feature request to have a
>> >> > switch that supresses creation of these links, then.
>> >>
On Wed, Oct 19, 2022 at 11:58 AM Masahiko Sawada wrote:
>
> On Tue, Oct 18, 2022 at 9:53 PM Masahiko Sawada wrote:
> >
> > On Tue, Oct 18, 2022 at 7:49 PM Amit Kapila wrote:
> > >
> > > On Tue, Oct 18, 2022 at 1:45 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > >
> > > > > I think because the
On Tue, Oct 18, 2022 5:44 PM Peter Smith wrote:
>
> On Mon, Oct 17, 2022 at 7:11 PM shiy.f...@fujitsu.com
> wrote:
> >
> ...
> >
> > Thanks for your patch. Here are some comments.
> >
> > In Example 2, the returned slot_name should be "myslot".
> >
> > +test_pub=# SELECT * FROM pg_create_logical
+0530, Bharath Rupireddy wrote in
> On Mon, Oct 17, 2022 at 6:45 PM Robert Haas wrote:
> >
> > On Fri, Oct 14, 2022 at 4:45 AM Bharath Rupireddy
> > wrote:
> > > What happens to the left-over temp files after a server crash? Will
> > > they be lying around in the archive directory? I understan
Hi,
On 2022-10-19 00:23:46 +0300, Melih Mutlu wrote:
> Right, setting CHERE_INVOKING and removing all cd's work and look better.
> Thanks for the suggestion.
Agreed, good idea.
> +
> + env:
> +CCACHE_DIR: C:/msys64/ccache
It's a bit odd to separate the CCACHE_* variables from each other
On Tue, Oct 18, 2022 at 06:46:53PM +0200, Peter Eisentraut wrote:
> On 12.10.22 03:08, Michael Paquier wrote:
>> openssl-env allows the use of the environment variable of the same
>> name. This reminds me a bit of the recent interferences with GZIP,
>> for example.
>
> Okay, I see what you meant
On Tue, Oct 18, 2022 at 9:53 PM Masahiko Sawada wrote:
>
> On Tue, Oct 18, 2022 at 7:49 PM Amit Kapila wrote:
> >
> > On Tue, Oct 18, 2022 at 1:45 PM Masahiko Sawada
> > wrote:
> > >
> > > >
> > > > I think because the test case proposed needs all three changes, we can
> > > > push the change-1
On Tue, Oct 18, 2022 at 7:09 AM Justin Pryzby wrote:
>
> On Fri, Oct 14, 2022 at 07:54:37PM +1100, Peter Smith wrote:
> > Hi hackers.
> >
> > This post is about parameter default values. Specifically. it's about
> > the CREATE PUBLICATION and CREATE SUBSCRIPTION syntax, although the
> > same issue
On Tuesday, October 18, 2022 5:50 PM Alvaro Herrera
wrote:
>
> On 2022-Oct-18, Japin Li wrote:
>
> >
> > On Tue, 18 Oct 2022 at 12:00, houzj.f...@fujitsu.com
> wrote:
> >
> > > Agreed. Here is new version patch which changed the error code and
> > > moved the whole command out of the message a
On Wed, Oct 19, 2022 at 12:29 PM Michael Paquier wrote:
>
> On Wed, Oct 19, 2022 at 10:09:12AM +1100, Peter Smith wrote:
> > PSA trivial patch to fix a code comment typo seen during a recent review.
>
> Passing by.. And fixed. Thanks!
> --
Thanks for passing by.
--
Kind Regards,
Peter Smit
On Wed, Oct 19, 2022 at 10:09:12AM +1100, Peter Smith wrote:
> PSA trivial patch to fix a code comment typo seen during a recent review.
Passing by.. And fixed. Thanks!
--
Michael
signature.asc
Description: PGP signature
On Tue, Oct 18, 2022 at 09:14:21AM +0200, Drouvot, Bertrand wrote:
> BTW, what about adding a new TAP test (dedicated patch) to test the behavior
> in case of errors during the regexes compilation in pg_ident.conf and
> pg_hba.conf (not done yet)? (we could add it once this patch series is
> done)
Hi,
Thanks for "fixing" this so quickly.
Greetings,
Andres Freund
PSA trivial patch to fix a code comment typo seen during a recent review.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Fix-typo-instead-just.patch
Description: Binary data
Robert Haas writes:
> On Tue, Oct 18, 2022 at 3:59 PM Tom Lane wrote:
>> Isn't it already the case (or could be made so) that relation file
>> removal happens only in the checkpointer?
> I believe that individual backends directly remove all relation forks
> other than the main fork and all segm
On Tue, Oct 18, 2022 at 3:59 PM Tom Lane wrote:
> Isn't it already the case (or could be made so) that relation file
> removal happens only in the checkpointer? I wonder if we could
> get to a situation where we can interlock file removal just by
> commanding the checkpointer to not do it for awh
Hi Bilal,
Nazir Bilal Yavuz , 18 Eki 2022 Sal, 15:37 tarihinde
şunu yazdı:
> env:
> ...
> CHERE_INVOKING: 1
> BASH_EXE: C:\msys64\usr\bin\bash.exe
>
> 'CHERE_INVOKING: 1' will cause bash.exe to start from current working
> directory(%CIRRUS_WORKING_DIR%).
>
> In this way, there is no
On Wed, Apr 6, 2022 at 10:40 AM Victor Spirin wrote:
> Updated patch: we use the posix semantic features in Windows build 17763
> and up.
> We found an issue with this feature on Windows Server 2016 without
> updates (Windows 1607 Build 14393)
Hi Victor,
I rebased and simplified this, and added
On Fri, Sep 30, 2022 at 2:04 AM Michael Paquier wrote:
> Hi all,
>
> I have bumped a few days ago on the fact that COERCE_SQL_SYNTAX
> (introduced by 40c24bf) and SQLValueFunction are around to do the
> exact same thing, as known as enforcing single-function calls with
> dedicated SQL keywords.
Robert Haas writes:
> On Tue, Oct 18, 2022 at 2:37 PM Stephen Frost wrote:
>> I don't see it as likely to be acceptable, but arranging to not add or
>> remove files while the scan is happening would presumably eliminate the
>> risk entirely. We've not seen this issue recur in the expire command
Hi Alvaro,
> I have a somewhat-related-but-not-really complaint. I recently had need to
> have refint.so, autoinc.so and regress.so in the install directory; but it
> turns out that there's no provision at all to get them installed.
True, we also noticed this build bug described above by copying
On Tue, Oct 18, 2022 at 6:18 AM Dean Rasheed wrote:
> Overall, I'm quite happy with these results. The question is, should
> this be back-patched?
>
> In the past, I think I've only back-patched numeric bug-fixes where
> the digits output by the old code were incorrect or an error was
> thrown, no
On Tue, Oct 18, 2022 at 2:37 PM Stephen Frost wrote:
> While I don't think it's really something that should be happening, it's
> definitely something that's been seen with some networked filesystems,
> as reported.
Do you have clear and convincing evidence of this happening on
anything other tha
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Tue, Oct 18, 2022 at 12:59 PM Tom Lane wrote:
> > There is no text suggesting that it's okay to miss, or to double-return,
> > an entry that is present throughout the scan. So I'd interpret the case
> > you're worried about as "forbidd
On Tue, Oct 18, 2022 at 3:43 AM Anton A. Melnikov wrote:
> It's interesting that prior to this commit, checks were made for freeze
> limits, but the error messages were talking about oldestXmin and oldestMxact.
The problem really is that oldestXmin and oldestMxact are held back,
though. While th
On Tue, Oct 18, 2022 at 12:59 PM Tom Lane wrote:
> There is no text suggesting that it's okay to miss, or to double-return,
> an entry that is present throughout the scan. So I'd interpret the case
> you're worried about as "forbidden by POSIX". Of course, it's known that
> NFS fails to provide
> From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001
> From: Andres Freund
> Date: Wed, 21 Sep 2022 20:36:36 -0700
> Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson
>
> ---
> .cirrus.yml| 92 +-
Robert Haas writes:
> I'd be really interested in knowing whether this happens on a
> mainstream, non-networked filesystem. It's not an irrelevant concern
> even if it happens only on networked filesystems, but a lot more
> people will be at risk if it also happens on ext4 or xfs. It does seem
> a
On 12.10.22 03:08, Michael Paquier wrote:
On Tue, Oct 11, 2022 at 05:06:22PM +0200, Peter Eisentraut wrote:
Various test suites use the "openssl" program as part of their setup. There
isn't a way to override which openssl program is to be used, other than by
fiddling with the path, perhaps. Thi
On Fri, Jun 17, 2022 at 6:31 PM Stephen Frost wrote:
>> Hmm, this sounds pretty bad, and I agree that a workaround should be put
>> in place. But where is pg_basebackup looping around readdir()? I
>> couldn't find it. There's a call to readdir() in FindStreamingStart(),
>> but that doesn't seem
Hi,
On 2022-10-17 23:31:44 -0500, Justin Pryzby wrote:
> On Tue, Oct 18, 2022 at 01:06:15PM +0900, Michael Paquier wrote:
> > On Tue, Oct 18, 2022 at 09:47:37AM +1300, Thomas Munro wrote:
> > > * Server 2019, as used on CI, still uses the traditional NT semantics
> > > (unlink is asynchronous, whe
Hi Wang, all
> And I have another confusion about function
> GetCheapestReplicaIdentityFullPath:
> If rel->pathlist is NIL, could we return NULL directly from this function,
> and
> then set idxoid to InvalidOid in function
> FindUsableIndexForReplicaIdentityFull
> in that case?
>
>
We could, but
On Mon, Oct 17, 2022 at 4:30 PM Andres Freund wrote:
> On 2022-10-17 13:34:02 -0400, Robert Haas wrote:
> > I don't feel quite as confident that not attempting a cleanup lock on
> > the new bucket's primary page is OK. I think it should be fine. The
> > existing comment even says it should be fine
Etsuro Fujita writes:
> On Tue, Oct 18, 2022 at 9:47 AM Richard Guo wrote:
>> On Tue, Oct 18, 2022 at 5:37 AM Tom Lane wrote:
>>> I came across a couple of places in the planner that are checking
>>> for nonempty havingQual; but since these bits run after
>>> const-simplification of the HAVING c
Hello Amit,
In version 14.4 the timeout problem for logical replication happens again
despite the patch provided for this issue in this version. When bulky
materialized views are reloaded it broke logical replication. It is
possible to solve this problem by using your new "streaming" option.
Have
On Mon, Oct 17, 2022 at 6:45 PM Robert Haas wrote:
>
> On Fri, Oct 14, 2022 at 4:45 AM Bharath Rupireddy
> wrote:
> > What happens to the left-over temp files after a server crash? Will
> > they be lying around in the archive directory? I understand that we
> > can't remove such files because we
On Tue, Oct 18, 2022 at 2:57 PM houzj.f...@fujitsu.com
wrote:
>
> On Tuesday, October 18, 2022 2:16 PM Bharath Rupireddy
> wrote:
> >
> > Hi,
> >
> > I have seen 2 patches registered in CF failing on Linux - Debian Bullseye in
> > wait_for_subscription_sync(). It seems like the tables aren't bei
On Tue, Oct 18, 2022 at 5:22 PM Dilip Kumar wrote:
>
> On Thu, Oct 6, 2022 at 1:37 PM Masahiko Sawada wrote:
> >
>
> > While looking at v35 patch, I realized that there are some cases where
> > the logical replication gets stuck depending on partitioned table
> > structure. For instance, there ar
On Tue, Oct 18, 2022 at 7:56 PM Amit Kapila wrote:
>
> On Mon, Oct 17, 2022 at 7:05 AM Masahiko Sawada wrote:
> >
> > On Thu, Oct 13, 2022 at 4:08 PM Amit Kapila wrote:
> > >
> > > --- a/src/backend/replication/logical/decode.c
> > > +++ b/src/backend/replication/logical/decode.c
> > > @@ -113,6
On Tue, Oct 18, 2022 at 7:49 PM Amit Kapila wrote:
>
> On Tue, Oct 18, 2022 at 1:45 PM Masahiko Sawada wrote:
> >
> > >
> > > I think because the test case proposed needs all three changes, we can
> > > push the change-1 without a test case and then as a second patch have
> > > change-2 for HEAD
Hi,
Thanks for the patch!
On 10/18/22 12:49, Melih Mutlu wrote:
You can find the updated patch attached.
Does it makes sense to set these at 'Windows - Server 2019, MinGW64 -
Meson' task:
env:
...
CHERE_INVOKING: 1
BASH_EXE: C:\msys64\usr\bin\bash.exe
'CHERE_INVOKING: 1' wi
On 10/17/22 16:00, Matthias van de Meent wrote:
> On Mon, 17 Oct 2022 at 05:43, Tomas Vondra
> wrote:
>>
>> On 10/16/22 22:17, Matthias van de Meent wrote:
>>> On Sun, 16 Oct 2022 at 16:34, Tomas Vondra
>>> wrote:
Try to formulate the whole algorithm. Maybe I'm missing something.
T
On Thu, Oct 6, 2022 at 1:37 PM Masahiko Sawada wrote:
>
> While looking at v35 patch, I realized that there are some cases where
> the logical replication gets stuck depending on partitioned table
> structure. For instance, there are following tables, publication, and
> subscription:
>
> * On pub
Hi,
A couple days ago I posted a WIP patch [1] implementing "BRIN Sort",
i.e. a node producing sorted output for BRIN minmax indexes. One of the
challenges I mentioned in that thread is costing - that's actually not
specific to that patch, it's an issue affecting BRIN in general, not
just the prop
On Mon, Oct 17, 2022 at 7:05 AM Masahiko Sawada wrote:
>
> On Thu, Oct 13, 2022 at 4:08 PM Amit Kapila wrote:
> >
> > --- a/src/backend/replication/logical/decode.c
> > +++ b/src/backend/replication/logical/decode.c
> > @@ -113,6 +113,15 @@
> > LogicalDecodingProcessRecord(LogicalDecodingContext
On Mon, Oct 17, 2022 at 11:20 AM Michael Paquier wrote:
>
> On Mon, Oct 17, 2022 at 01:46:39PM +0900, Kyotaro Horiguchi wrote:
> > As the code written, when archive library is being added while archive
> > command is already set, archiver first emits seemingly positive
> > message "restarting arch
On Tue, Oct 18, 2022 at 1:45 PM Masahiko Sawada wrote:
>
> >
> > I think because the test case proposed needs all three changes, we can
> > push the change-1 without a test case and then as a second patch have
> > change-2 for HEAD and change-3 for back branches with the test case.
> > Do you have
Hello!
On 31.08.2022 21:38, Peter Geoghegan wrote:
On Tue, Aug 30, 2022 at 8:56 PM Nathan Bossart wrote:
LGTM
Pushed, thanks.
In this commit
https://github.com/postgres/postgres/commit/c3ffa731a5f99c4361203015ce2219d209fea94c
there are checks if oldestXmin and oldestMxact havn't become t
[Moving this to -hackers]
> On 13/10/2022 18:20 CEST Adrian Klaver wrote:
> > select power(10, -18::numeric);
> > power
> >
> > 0.
> >
On Thu, 13 Oct 2022 at 18:17, Tom Lane wrote:
>
> An inexact result isn't surprising, but it shouldn't be *that* inexact.
>
On 2022-Oct-01, Andres Freund wrote:
> Perhaps the END{} routine should call $node->_update_pid(-1); if $exit_code !=
> 0 and _pid is undefined?
Yeah, that sounds reasonable.
> That does seem to reduce the incidence of "leftover" postgres
> instances. 001_start_stop.pl leaves some behind, but th
On Tue, Oct 18, 2022 at 8:06 AM Peter Smith wrote:
>
> Hi, here are my review comments for patch v38-0001.
>
> 3.
>
> + /* Ensure we are reading the data into our memory context. */
> + oldctx = MemoryContextSwitchTo(ApplyMessageContext);
>
> Doesn't something need to switch back to this 'oldctx'
On 2022-Oct-17, Richard Guo wrote:
> On Mon, Oct 17, 2022 at 4:24 PM Alvaro Herrera
> wrote:
>
> > While messing about with Cluster.pm I noticed that we don't need the
> > hack to work around lack of parent.pm in very old Perl versions, because
> > we no longer support those versions (per commit
On 2022-Oct-18, Japin Li wrote:
>
> On Tue, 18 Oct 2022 at 12:00, houzj.f...@fujitsu.com
> wrote:
>
> > Agreed. Here is new version patch which changed the error code and
> > moved the whole command out of the message according to Álvaro's comment.
>
> My bad! The patch looks good to me.
Th
Hi Andres,
Andres Freund , 11 Eki 2022 Sal, 21:23 tarihinde şunu
yazdı:
> I think it might be easier to just set MSYS=winjitdebug
>
> https://www.msys2.org/wiki/JIT-Debugging/#native-windows-processes-started-from-msys2
> and then rely on the existing windows crash reporting stuff.
>
Done.
> Y
On Mon, Oct 17, 2022 at 7:11 PM shiy.f...@fujitsu.com
wrote:
>
...
>
> Thanks for your patch. Here are some comments.
>
> In Example 2, the returned slot_name should be "myslot".
>
> +test_pub=# SELECT * FROM pg_create_logical_replication_slot('myslot',
> 'pgoutput');
> + slot_name |lsn
> +--
Thanks for the feedback.
On Mon, Oct 17, 2022 at 10:14 PM Amit Kapila wrote:
>
> On Mon, Oct 17, 2022 at 7:17 AM Peter Smith wrote:
> >
> >
> > Updated as sugggested.
> >
>
> +
> +Sometimes, either by choice (e.g. create_slot =
> false),
> +or by necessity (e.g. connect = false), the
On Thu, Oct 13, 2022 at 11:46:34AM -0700, Andres Freund wrote:
> Hi,
>
> On 2022-10-07 07:26:08 +0200, Pavel Stehule wrote:
> > I am sending version with handy written parser and meson support
>
> Given this is a new approach it seems inaccurate to have the CF entry marked
> ready-for-committer.
On Tuesday, October 18, 2022 2:16 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> I have seen 2 patches registered in CF failing on Linux - Debian Bullseye in
> wait_for_subscription_sync(). It seems like the tables aren't being synced. I
> have not done any further analysis. I'm not sure if this issue
On Tue, Oct 18, 2022 at 9:47 AM Richard Guo wrote:
> On Tue, Oct 18, 2022 at 5:37 AM Tom Lane wrote:
>> I came across a couple of places in the planner that are checking
>> for nonempty havingQual; but since these bits run after
>> const-simplification of the HAVING clause, that produces the wron
On Tue, Oct 18, 2022 at 9:15 AM Andy Fan wrote:
> On Mon, Oct 10, 2022 at 10:35 AM Richard Guo
> wrote:
>
>> ... I'm asking because
>> PHVs may imply lateral dependencies which may make us have to use
>> nestloop join.
>>
>
> I thought lateral join imply nestloop join, am I missing something?
On Mon, Oct 17, 2022 at 11:17 AM Michael Paquier wrote:
>
> On Mon, Oct 17, 2022 at 02:30:52PM +0900, Kyotaro Horiguchi wrote:
>
> Removing PG_ENSURE_ERROR_CLEANUP() and relying on before_shmem_exit()
> is fine by me, that's what I imply upthread.
Hm. Here's a v2 patch that addresses review comme
On Tue, Oct 18, 2022 at 10:01 PM Devrim Gündüz wrote:
> On Tue, 2022-10-11 at 11:07 +1300, Thomas Munro wrote:
> > OK, I'll wait for the dust to settle on our 15 release and then
> > back-patch this. Then I'll keep working on the opaque pointer
> > support for master, which LLVM 16 will need (I e
Hi Thomas,
On Tue, 2022-10-11 at 11:07 +1300, Thomas Munro wrote:
> OK, I'll wait for the dust to settle on our 15 release and then
> back-patch this. Then I'll keep working on the opaque pointer
> support for master, which LLVM 16 will need (I expect we'll
> eventually want to back-patch that ev
Hi,
As a card-carrying Unix hacker, I think it'd be great to remove the
differences between platforms if possible using newer Windows
facilities, so everything just works the way we expect. Two things
that stopped progress on that front in the past were (1) uncertainty
about OS versioning, fixed
Hi,
On Sat, 15 Oct 2022 10:40:29 +0900 (JST)
Tatsuo Ishii wrote:
> > On Thu, 13 Oct 2022 15:35:09 +0900 (JST)
> > Tatsuo Ishii wrote:
> >
> >> > OK, that sounds good then. I would make a feature request to have a
> >> > switch that supresses creation of these links, then.
> >>
> >> Ok, I hav
Hello Micheal-san,
On Thu, 13 Oct 2022 17:02:06 +0900
Michael Paquier wrote:
> On Fri, Sep 30, 2022 at 10:12:13AM +0900, Yugo NAGATA wrote:
> > Thank you for comment. Do you think it can be marked as Ready for Commiter?
>
> Matviews have been discarded from needing predicate locks since
> 3bf3a
On Tue, Oct 18, 2022 at 1:07 PM Amit Kapila wrote:
>
> On Tue, Oct 18, 2022 at 6:29 AM Masahiko Sawada wrote:
> >
> > On Mon, Oct 17, 2022 at 4:40 PM Amit Kapila wrote:
> > >
> > >
> > > IIUC, here you are speaking of three different changes. Change-1: Add
> > > a check in AssertTXNLsnOrder() to
On Tue, Oct 18, 2022 at 12:01 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> In standby mode, the state machine in WaitForWALToBecomeAvailable()
> reads WAL from pg_wal after failing to read from the archive. This is
> currently implemented in XLogFileReadAnyTLI() by calling
> XLogFileRead() with source
Hi,
On 10/18/22 7:51 AM, Michael Paquier wrote:
On Mon, Oct 17, 2022 at 07:56:02PM +0200, Drouvot, Bertrand wrote:
On 10/14/22 7:30 AM, Michael Paquier wrote:
This approach would not stick with
pg_ident.conf though, as we validate the fields in each line when we
put our hands on ident_user and
75 matches
Mail list logo
