On Wed, Apr 13, 2022 at 8:05 AM Thomas Munro wrote:
> On Wed, Apr 13, 2022 at 3:57 AM Dagfinn Ilmari Mannsåker
> wrote:
> > Simon Riggs writes:
> > > This is a nice feature if it is safe to turn off full_page_writes.
> > > When is it safe to do that? On which platform?
> > >
> > > I am not awar
On Fri, Sep 2, 2022 at 5:42 AM Wolfgang Walther wrote:
>
> Kaiting Chen:
> > I'd like to propose a change to PostgreSQL to allow the creation of a
> > foreign
> > key constraint referencing a superset of uniquely constrained columns.
>
> +1
>
> Tom Lane:
> > TBH, I think this is a fundamentally b
On Thu, Sep 22, 2022 at 5:19 PM James Coleman wrote:
>
> On Mon, Sep 19, 2022 at 4:29 PM Robert Haas wrote:
> >
> > On Mon, Sep 19, 2022 at 3:58 PM James Coleman wrote:
> > > But in the case where there's correlation via LATERAL we already don't
> > > guarantee unique executions for a given set
On Sat, Sep 24, 2022 at 5:13 PM Andres Freund wrote:
> > One more question about this, that wasn't covered by the Wiki page: is
> > there some equivalent to "make installcheck" with meson builds?
>
> Not yet. Nothing impossible, just not done yet. Partially because installcheck
> is so poorly defi
Hi,
On 2022-09-24 16:56:20 -0700, Peter Geoghegan wrote:
> On Thu, Sep 22, 2022 at 2:50 PM Andres Freund wrote:
> > meson:
> >
> > time meson test
> > real0m42.178s
> > user7m8.533s
> > sys 2m17.711s
>
> I find that a more or less comparable test run on my workstation
> (which has a
> On Sat, Sep 24, 2022 at 04:07:14PM +0200, Dmitry Dolgov wrote:
> > On Fri, Sep 16, 2022 at 09:25:13PM +0300, Sergei Kornilov wrote:
> > Hello!
> >
> > Unfortunately the patch needs another rebase due to the recent split of
> > guc.c (0a20ff54f5e66158930d5328f89f087d4e9ab400)
> >
> > I'm reviewin
On Thu, Sep 22, 2022 at 2:50 PM Andres Freund wrote:
> meson:
>
> time meson test
> real0m42.178s
> user7m8.533s
> sys 2m17.711s
I find that a more or less comparable test run on my workstation
(which has a Ryzen 9 5950X) takes just over 38 seconds. I think that
the improvement is far
Hi hackers!
Last patchset has an invalid patch file - v16-0003-toaster-docs.patch.
Here's corrected patchset,
sorry for the noise.
On Sat, Sep 24, 2022 at 3:50 PM Nikita Malakhov wrote:
> Hi hackers!
>
> Cfbot is still not happy with the patchset, so I'm attaching a rebased
> one, rebased onto t
Hi,
On 2022-09-24 16:01:25 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I hit this again while porting cplupluscheck to be invoked by meson as
> > well. ISTM that we should just remove the uses of register.
>
> OK by me.
Done. Thanks Tom, Peter.
Andres Freund writes:
> I hit this again while porting cplupluscheck to be invoked by meson as
> well. ISTM that we should just remove the uses of register.
OK by me.
> I tried to use -Wregister to keep us honest going forward, but unfortunately
> it only works with a C++ compiler...
I think we
On Sat, Sep 24, 2022 at 12:11 PM Andres Freund wrote:
> I hit this again while porting cplupluscheck to be invoked by meson as
> well. ISTM that we should just remove the uses of register. Yes, some very old
> compilers might generate worse code without register, but I don't think we
> need to car
Hi,
On 2022-03-08 10:59:02 -0800, Andres Freund wrote:
> On 2022-03-08 13:46:36 -0500, Tom Lane wrote:
> > Andres Freund writes:
> > > When running cpluspluscheck I get many many complaints like
> > > /tmp/pg-test-repo/src/include/port/atomics/arch-x86.h:143:23: warning:
> > > ISO C++17 does not
... btw, shouldn't the CF entry [1] get closed now?
The cfbot's unhappy that the last patch no longer applies.
regards, tom lane
[1] https://commitfest.postgresql.org/39/3395/
Nathan Bossart writes:
> On Tue, Aug 23, 2022 at 10:29:05AM +0100, Greg Stark wrote:
>> Alternately should pg_stat_activity show the actual temp schema name
>> instead of the id? I don't recall if it's visible outside the backend
>> but if it is, could pg_stat_activity show whether the temp schema
"Anton A. Melnikov" writes:
> [ v4-0001-Fix-logical-replica-assert-on-func-error.patch ]
I took a quick look at this. I think you're solving the
problem in the wrong place. The real issue is why are
we not setting up ActivePortal correctly when running
user-defined code in a logrep worker? The
On Wed, Sep 21, 2022 at 02:10:42PM +0700, a.kozhemya...@postgrespro.ru wrote:
> After analyzing this, I found out why we don't reach that Assert but we have
> coverage shown - firstly, it reached via another test, vacuum; secondly, it
> depends on the gcc optimization flag. We reach that Assert onl
> On Fri, Sep 16, 2022 at 09:25:13PM +0300, Sergei Kornilov wrote:
> Hello!
>
> Unfortunately the patch needs another rebase due to the recent split of guc.c
> (0a20ff54f5e66158930d5328f89f087d4e9ab400)
>
> I'm reviewing a patch on top of a previous commit and noticed a failed test:
>
> # Failed
Hi hackers!
Cfbot is still not happy with the patchset, so I'm attaching a rebased one,
rebased onto the current
master (from today). The third patch contains documentation package, and
the second one contains large
README.toastapi file providing additional in-depth docs for developers.
Comments
On Tue, Sep 20, 2022 at 6:43 PM Robert Haas wrote:
> I disapprove of ignoring the HEAP_COMBOCID flag. Emitting a message
> claiming that the CID has a certain value when that's actually a combo
> CID is misleading, so at least a different message wording is needed
> in such cases. But it's also n
On Thu, Sep 22, 2022 at 3:41 PM Amit Kapila wrote:
>
> On Thu, Sep 22, 2022 at 8:59 AM wangw.f...@fujitsu.com
> wrote:
> >
>
> Few comments on v33-0001
> ===
>
Some more comments on v33-0001
=
1.
+ /* Information from the corresponding LogicalRepWo
20 matches
Mail list logo
