Re: [Commitfest 2022-07] is Done!

On 2022-Aug-01, Jacob Champion wrote: > On Mon, Aug 1, 2022 at 10:34 AM Alvaro Herrera > wrote: > > I hate to suggest even more work, but it would be excellent to have some > > sort of write-up of what you did here, and have it supplant the obsolete > > text currently in the canonical commifest

Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

At Mon, 1 Aug 2022 20:01:00 +0530, Amit Kapila wrote in > On Mon, Aug 1, 2022 at 7:46 AM Masahiko Sawada wrote: > > > > On Fri, Jul 29, 2022 at 3:45 PM Amit Kapila wrote: > > > > > > > I've attached updated patches for all branches. Please review them. > > > > Thanks, the patches look mostly

Re: Progress report removal of temp files and temp relation files using ereport_startup_progress

On Thu, May 5, 2022 at 12:11 PM Bharath Rupireddy wrote: > > On Mon, May 2, 2022 at 6:26 PM Ashutosh Bapat > wrote: > > > > Hi Bharath, > > > > > > On Sat, Apr 30, 2022 at 11:08 AM Bharath Rupireddy > > wrote: > > > > > > Hi, > > > > > > At times, there can be many temp files (under pgsql_tmp) a

Re: COPY TO (FREEZE)?

Hi, On Tue, Aug 02, 2022 at 01:30:46PM +0900, Kyotaro Horiguchi wrote: > I noticed that COPY TO accepts FREEZE option but it is pointless. > > Don't we reject that option as the first-attached does? I agree that we should reject it, +1 for the patch. > By the way, most of the invalid option comb

Re: Pluggable toaster

Hi hackers! Sorry for the delay. I've made changes according to Aleksander comments: >This will produce a patchset with a consistent naming like: >... >Also cfbot [1] will know in which order to apply them. Done. >Unfortunately the three patches in question from this branch don't >pass `make ch

Re: Question about user/database-level parameters

On Tue, 02 Aug 2022 at 13:44, Tom Lane wrote: > Japin Li writes: >> Yeah, the single-user mode works. Thank you very much! >> However, if the database is in production, we cannot go into single-user >> mode, >> should we provide an option to change this behavior on the fly? > > There is not,

Re: fix typos

On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby wrote: > > Here are some others I've been sitting on, mostly in .c files. 0002: weird since c91560defc57f89f7e88632ea14ae77b5cec78ee It was weird long before that, maybe we should instead change most of those tabs in the top comment to single space, a

Re: pgstattuple: add test for coverage

Dong Wook Lee writes: > Hi, hackers > I added some SQL statements to improve test coverage. I do not think it's a great idea to create random dependencies between modules like the pgstattuple -> bloom dependency you casually added here. regards, tom lane

Re: Question about user/database-level parameters

Japin Li writes: > Yeah, the single-user mode works. Thank you very much! > However, if the database is in production, we cannot go into single-user mode, > should we provide an option to change this behavior on the fly? There is not, and never will be, a version of Postgres in which it's imposs

Re: Question about user/database-level parameters

On Tue, 02 Aug 2022 at 13:01, Kyotaro Horiguchi wrote: > At Mon, 01 Aug 2022 18:24:33 +0800, Japin Li wrote in >> >> Hi, hackers >> >> When I try to modify the parameters for all users in the following command >> [1] >> (the library doesn't exist), and I quit the connection, I cannot log in

Re: fix typos

On Tue, Aug 2, 2022 at 1:05 AM Erik Rijkers wrote: > > Recent typos... The part of the sentence inside parentheses is not clear to me, before or after the patch: Dropping an extension causes its component objects, and other explicitly dependent routines (see , - the depends on extensio

Re: remove more archiving overhead

On Sat, Jul 30, 2022 at 11:51:56PM -0700, Noah Misch wrote: > Inviting the administrator to resolve things is more dangerous than just > returning true. I recommend making this text more opinionated and simpler: > libraries must return true. Alternately, if some library has found a good > reason

Re: Question about user/database-level parameters

At Mon, 01 Aug 2022 18:24:33 +0800, Japin Li wrote in > > Hi, hackers > > When I try to modify the parameters for all users in the following command [1] > (the library doesn't exist), and I quit the connection, I cannot log in the > database, how can I bypass this checking? > > I find those pa

Re: Typo in pg_db_role_setting.h

On Mon, Aug 1, 2022 at 9:16 PM Tom Lane wrote: > > John Naylor writes: > > You are correct, but I wonder if it'd be better to just drop the comment > > entirely. I checked a couple other random headers with function > > declarations and they didn't have such a comment, and it's kind of obvious >

Re: Typo in pg_db_role_setting.h

On Tue, 02 Aug 2022 at 11:06, Richard Guo wrote: > On Mon, Aug 1, 2022 at 10:42 PM Japin Li wrote: > >> >> On Mon, 01 Aug 2022 at 22:16, Tom Lane wrote: >> > John Naylor writes: >> >> You are correct, but I wonder if it'd be better to just drop the comment >> >> entirely. I checked a couple o

Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

At Mon, 1 Aug 2022 09:59:49 +0800, Zhang Mingli wrote in > On Jul 29, 2022, 11:24 +0800, Richard Guo , wrote: > > > > > On Thu, Jul 28, 2022 at 9:04 PM Zhang Mingli > > > wrote: > > > > Assertions added. > > > > > > Can we also add assertions to make sure force_quote, force_notnull and > > > f

COPY TO (FREEZE)?

I noticed that COPY TO accepts FREEZE option but it is pointless. Don't we reject that option as the first-attached does? I tempted to add tests for those option combinations that are to be rejected but I didin't come up with a clean way to do that. By the way, most of the invalid option combin

Re: allow building trusted languages without the untrusted versions

On Mon, Aug 01, 2022 at 02:41:21PM -0700, Jacob Champion wrote: > On 7/13/22 12:49, Tom Lane wrote: >> Nathan Bossart writes: >>> Given the discussion in this thread, I intend to mark the commitfest entry >>> as Withdrawn shortly. > > I'll mark this RwF rather than bring it forward; if you'd pref

Re: Typo in pg_db_role_setting.h

On Tue, Aug 2, 2022 at 10:06 AM Richard Guo wrote: > > I'm not sure that we should remove such comments. And a rough search > shows that there are much more places with this kind of comments, such > as below: > > nbtxlog transam readfuncs walreceiver buffile bufmgr fd latch pmsignal > procsignal s

Re: Typo in pg_db_role_setting.h

On Mon, Aug 1, 2022 at 10:42 PM Japin Li wrote: > > On Mon, 01 Aug 2022 at 22:16, Tom Lane wrote: > > John Naylor writes: > >> You are correct, but I wonder if it'd be better to just drop the comment > >> entirely. I checked a couple other random headers with function > >> declarations and they

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

Hi, Thanks for looking into this. On Tue, Aug 2, 2022 at 9:39 AM Andres Freund wrote: > On 2022-07-27 17:01:13 +0900, Amit Langote wrote: > > Here's an updated version of the patch, with mostly cosmetic changes. > > In particular, I added comments describing the new llvm_compile_expr() > > blobs

Missing CFI in iterate_word_similarity()

Hi, For long strings, iterate_word_similarity() can run into long-running tight-loops without honouring interrupts or statement_timeouts. For example: postgres=# set statement_timeout='1s'; SET postgres=# select 1 where repeat('1.1',8) %>> 'Lorem ipsum dolor sit amet'; ?column? -- (0

Re: add test: pg_rowlocks extension

2022년 7월 31일 (일) 오전 6:32, Tom Lane 님이 작성: > > Dong Wook Lee writes: > > I just wrote test about pg_rowlocks extension. > > I added sql and spec test for locking state. > > I think this could be cut down quite a bit. Do we really need > both a SQL test and an isolation test? Seems like you could

Re: Handle infinite recursion in logical replication setup

On Mon, Aug 1, 2022 at 6:52 PM Amit Kapila wrote: > > On Mon, Aug 1, 2022 at 1:32 PM Peter Smith wrote: > > > > On Mon, Aug 1, 2022 at 3:27 PM shiy.f...@fujitsu.com > > wrote: > > > > > > On Fri, Jul 29, 2022 1:22 PM vignesh C wrote: > > > > > > > > > > > > Thanks for the comments, the attached

Re: enable/disable broken for statement triggers on partitioned tables

On Tue, Aug 2, 2022 at 3:58 AM Alvaro Herrera wrote: > On 2022-Aug-01, Amit Langote wrote: > > > On Sat, Jul 30, 2022 at 5:25 AM Tom Lane wrote: > > > > I do not think it's a great idea to have ALTER TABLE scribbling on > > > the source parsetree. > > > > Hmm, I think we already do scribble on th

pgstattuple: add test for coverage

Hi, hackers I added some SQL statements to improve test coverage. As data was inserted, the expected file changed. So should I change all `select *` for a stable expected result? And it's the coverage change as I add 50.6% -> 78.7% --- regards, Lee Dong Wook v1_add_test_pgstattuple.patch Descrip

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

On Tue, Aug 2, 2022 at 3:09 AM Ranier Vilela wrote: > > Em sáb., 16 de jul. de 2022 às 16:54, Ranier Vilela > escreveu: >> >> >> >> Em sáb, 16 de jul de 2022 2:58 AM, Peter Eisentraut >> escreveu: >>> >>> On 11.07.22 21:06, Ranier Vilela wrote: >>> > Em qui., 7 de jul. de 2022 às 14:01, Ranier

Re: pg_buffercache: add sql test

I've been missing what I have to add to the .gitignore file when I write the test. I will refer to it when I write the test code from now on. Thank you. 2022년 7월 31일 (일) 오전 4:39, Tom Lane 님이 작성: > > Dong Wook Lee writes: > > I just wrote a test code for the `pg_buffercache` extension which > > d

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

Hi, On 2022-07-27 17:01:13 +0900, Amit Langote wrote: > Here's an updated version of the patch, with mostly cosmetic changes. > In particular, I added comments describing the new llvm_compile_expr() > blobs. - I've asked a couple times before: Why do we need space for every possible datatype at

Re: [PATCH] postgresql.conf.sample comment alignment.

On Tue, Aug 2, 2022 at 10:03 AM Tom Lane wrote: > > Peter Smith writes: > > This patch tweaks a some tabbing and replaces some spaces with tabs to > > improve slightly the comment alignment in file > > 'postgresql.conf.sample' > > Hmm ... the parts you want to change generally look OK to me. > I

Re: [PATCH] postgresql.conf.sample comment alignment.

Peter Smith writes: > This patch tweaks a some tabbing and replaces some spaces with tabs to > improve slightly the comment alignment in file > 'postgresql.conf.sample' Hmm ... the parts you want to change generally look OK to me. I wonder if you are looking at it with tab stops set to 4 spaces r

Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]

Hi, On 2021-04-05 21:57:12 +0200, Mats Kindahl wrote: >2. In the storage layer, the function RelationDropStorage is called, >which will record the table to be dropped in the pendingDeletes > > When committing (or aborting) the transaction, there are two calls that are > interesting, in th

[DOCS] Stats views and functions not in order?

Hi Hackers. I noticed that there are quite a few items in Chapter 28.2 "The Cumulative Statistics System" [1] which have no obvious order. e.g. - The views (28.2.3 -> 28.2.23) don't seem to be in any order that I could work out. Why not alphabetical? - [2] Table 2.1 "Dynamic Statistics View" vi

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

Hi, On 2022-07-29 14:27:36 -0400, Andrew Dunstan wrote: > this work has been done in response to a complaint from you. Does this > address your concerns satisfactorily? Will look. Was on vacation for the last two weeks... Greetings, Andres Freund

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em seg., 1 de ago. de 2022 às 18:51, Jacob Champion escreveu: > On 5/31/22 11:44, Tomas Vondra wrote: > > I'd argue this is either just noise, and there's no actual difference. > > This could be verified by some sort of statistical testing (e.g. the > > well known t-test). > > Given the conversat

[PATCH] postgresql.conf.sample comment alignment.

This patch tweaks a some tabbing and replaces some spaces with tabs to improve slightly the comment alignment in file 'postgresql.conf.sample' PSA. -- Kind Regards, Peter Smith. Fujitsu Australia v1-0001-Align-the-comments.patch Description: Binary data

Re: [Commitfest 2022-07] is Done!

On 8/1/22 08:40, Jacob Champion wrote: > I've just closed out the July commitfest. I'll be working to clear out > all remaining active patches today. "Today" was slightly optimistic. I'm down to the final stretch of forty patches; I'll come back to those tomorrow with fresh eyes. --Jacob

Re: Is select_outer_pathkeys_for_merge() too strict now we have Incremental Sorts?

On Thu, 21 Jul 2022 at 14:23, Richard Guo wrote: > > On Thu, Jul 21, 2022 at 3:47 AM David Rowley wrote: >> Maybe your idea could be made to work in cases where >> bms_equal(joinrel->relids, root->all_baserels). In that case, we >> should not be processing any further joins and don't need to cons

Re: [Commitfest 2022-07] is Done!

On Mon, Aug 1, 2022 at 10:34 AM Alvaro Herrera wrote: > On 2022-Aug-01, Tom Lane wrote: > > Thanks for all your hard work on this! An active CFM really makes > > things work better. > > Agreed, great work here. Thanks, both of you! > I hate to suggest even more work, but it would be excellent t

Re: using file cloning in create database / initdb

On Tue, Aug 2, 2022 at 6:15 AM Justin Pryzby wrote: > On Sat, Feb 12, 2022 at 07:37:30PM -0800, Andres Freund wrote: > > It could theoretically help linux - but currently I think the filesystem for > > CI is ext4, which doesn't support FICLONE. I assume it'd help macos, but I > > don't know the pe

Re: Add test of pg_prewarm extenion

Dong Wook Lee writes: >>> Couldn't you use $node->wait_for_log() instead? > After trimming the code a little more, I sent the patch again. This is much better, but still has some issues: * The prefetch test might as well not be there, because check_pg_config("#USE_PREFETCH 1") will never succee

Re: Can postgres ever delete the recycled future WAL files to free-up disk space if max_wal_size is reduced or wal_recycle is set to off?

On 5/13/22 05:35, Bharath Rupireddy wrote: > Hi, I'm thinking out loud - can we add all the recycled WAL files to a > sorted list (oldest recycled WAL file to new recycled WAL file) and > then during checkpoint, if the max_wal_size is reduced or wal_recycle > is set to off, then start deleting the

Re: Skip partition tuple routing with constant partition key

On Thu, 28 Jul 2022 at 19:37, Amit Langote wrote: > > On Thu, Jul 28, 2022 at 11:59 AM David Rowley wrote: > > I'd quite like to push this patch early next week, so if anyone else > > is following along that might have any objections, could they do so > > before then? > > I have no more comments

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/31/22 11:44, Tomas Vondra wrote: > I'd argue this is either just noise, and there's no actual difference. > This could be verified by some sort of statistical testing (e.g. the > well known t-test). Given the conversation so far, I'll go ahead and mark this Returned with Feedback. Specificall

Re: allow building trusted languages without the untrusted versions

On 7/13/22 12:49, Tom Lane wrote: > Nathan Bossart writes: >> Given the discussion in this thread, I intend to mark the commitfest entry >> as Withdrawn shortly. I'll mark this RwF rather than bring it forward; if you'd prefer a different status please feel free (or let me know). Thanks, --Jacob

Re: pg15b2: large objects lost on upgrade

On 7/30/22 10:40 AM, Tom Lane wrote: Noah Misch writes: The pg_backend_pid is from "SELECT pg_catalog.pg_backend_pid();" in ~/.psqlrc, so the lack of -X caused that. The latest commit fixes things on a normal GNU/Linux box, so I bet it will fix wrasse. Yup, looks like we're all good now. Th

Re: pgcrypto support for bcrypt $2b$ hashes

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: [PATCH] psql: \dn+ to show size of each schema (and \dA+ for AMs)

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: Improve logging when using Huge Pages

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: Map WAL segment files on PMEM as WAL buffers

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: Showing applied extended statistics in explain

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: [PATCH] New default role allowing to change per-role/database settings

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: Strange behavior with polygon and NaN

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: Making Vars outer-join aware

Zhihong Yu writes: > For v3-0003-label-Var-nullability-in-parser.patch : > + if (rtindex > 0 && rtindex <= list_length(pstate->p_nullingrels)) > + relids = (Bitmapset *) list_nth(pstate->p_nullingrels, rtindex - 1); > + else > + relids = NULL; > + > + /* > +* Merge with any

Re: A problem about partitionwise join

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: Making Vars outer-join aware

On Mon, Aug 1, 2022 at 12:51 PM Tom Lane wrote: > Here's a rebase up to HEAD, mostly to placate the cfbot. > I accounted for d8e34fa7a (s/all_baserels/all_query_rels/ > in those places) and made one tiny bug-fix change. > Nothing substantive as yet. > > regards, tom lane >

Re: [PATCH] Implement INSERT SET syntax

As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest. This is not a rejection, since we don't necessarily think there's anything unacceptable about the entry, but it differs from a standard "Returned with Feedback" in

Re: The "char" type versus non-ASCII characters

Andrew Dunstan writes: > On 2022-07-31 Su 18:25, Tom Lane wrote: >> ... I looked at the SGML docs too, but I don't think there >> is anything to change there. The docs say "single-byte internal type" >> and are silent about "char" beyond that. I think that's exactly where >> we want to be: any m

Re: The "char" type versus non-ASCII characters

On 2022-07-31 Su 18:25, Tom Lane wrote: > I wrote: >> This came up again today [1], so here's a concrete proposal. >> Let's use \ooo for high-bit-set chars, but keep backslash as just >> backslash (so it's only semi-compatible with bytea). > Hearing no howls of protest, here's a fleshed out, pote

Re: Checking pgwin32_is_junction() errors

On 2022-08-01 Mo 01:09, Thomas Munro wrote: > On Thu, Jul 28, 2022 at 9:31 PM Thomas Munro wrote: >> There's one curious change in the draft patch attached: you can't >> unlink() a junction point, you have to rmdir() it. Previously, things >> that traverse directories without ever calling pgwin

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

On Mon, Aug 1, 2022 at 1:33 PM Tom Lane wrote: > On the other hand, I'm quite willing to convert WOA state into RWF > state quickly. The author can always resubmit, or resurrect the > old CF entry, once they have something new for people to look at. Right. This is what I'm on about. -- Robert

Re: [feature]COPY FROM enable FORCE_NULL/FORCE_NOT_NULL on all columns

On 2022-08-01 Mo 15:50, Andrew Dunstan wrote: > On 2022-08-01 Mo 09:56, Zhang Mingli wrote: >> Hi,  >> >> The previous discussion is: >> >> https://www.postgresql.org/message-id/CACJufxEnVqzOFtqhexF2%2BAwOKFrV8zHOY3y%3Dp%2BgPK6eB14pn_w%40mail.gmail.com > > Starting a new thread is pointless and a

Re: pg_auth_members.grantor is bunk

On Mon, Aug 1, 2022 at 1:38 PM Tom Lane wrote: >> I think the latter --- the cfbot thinks the July CF is no longer relevant, > but Jacob hasn't yet moved your patches forward. You could wait for > him to do that, or do it yourself. Done. New patches attached. Changes in v4, for 0001: - Typo fi

Re: [feature]COPY FROM enable FORCE_NULL/FORCE_NOT_NULL on all columns

On 2022-08-01 Mo 09:56, Zhang Mingli wrote: > Hi,  > > The previous discussion is: > > https://www.postgresql.org/message-id/CACJufxEnVqzOFtqhexF2%2BAwOKFrV8zHOY3y%3Dp%2BgPK6eB14pn_w%40mail.gmail.com Starting a new thread is pointless and annoying. As I said in the previous thread, we would nee

Re: enable/disable broken for statement triggers on partitioned tables

Alvaro Herrera writes: > No, actually nothing scribbles on the parsetree, because ATPrepCmd is > working on a copy of the node, so there's no harm done to the original. Oh, okay then. Maybe this needs to be noted somewhere? regards, tom lane

Re: enable/disable broken for statement triggers on partitioned tables

On 2022-Aug-01, Amit Langote wrote: > On Sat, Jul 30, 2022 at 5:25 AM Tom Lane wrote: > > I do not think it's a great idea to have ALTER TABLE scribbling on > > the source parsetree. > > Hmm, I think we already do scribble on the source parse tree even > before this patch, for example, as ATPre

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Looks good to me. The new status of this patch is: Ready for Committ

Re: using file cloning in create database / initdb

On Sat, Feb 12, 2022 at 07:37:30PM -0800, Andres Freund wrote: > On 2022-02-12 20:17:46 -0600, Justin Pryzby wrote: > > On Sat, Feb 12, 2022 at 06:00:44PM -0800, Andres Freund wrote: > > > I bet using COW file copies would speed up our own regression tests > > > noticeably > > > - on slower system

Re: fix typos

On Mon, Aug 01, 2022 at 08:04:54PM +0200, Erik Rijkers wrote: > Recent typos... LGTM, thanks. Here are some others I've been sitting on, mostly in .c files. -- Justin >From 19f320438476aff2773440447f167d06051a0a47 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Tue, 5 Jul 2022 14:12:26 -050

fix typos

Recent typos... --- ./doc/src/sgml/ref/drop_extension.sgml.orig 2022-08-01 19:38:18.249729884 +0200 +++ ./doc/src/sgml/ref/drop_extension.sgml 2022-08-01 19:40:33.312359069 +0200 @@ -32,7 +32,7 @@ DROP EXTENSION removes extensions from the database. Dropping an extension causes its

Re: pg_auth_members.grantor is bunk

Robert Haas writes: > On Sun, Jul 31, 2022 at 2:34 PM Tom Lane wrote: >> Indeed. I've not read the patch, but I just wanted to mention that >> the cfbot shows it as failing regression tests on all platforms. >> Possibly a conflict with some recent commit? > I can't see this on cfbot - either I

Re: [Commitfest 2022-07] is Done!

On 2022-Aug-01, Tom Lane wrote: > Jacob Champion writes: > > I've just closed out the July commitfest. I'll be working to clear out > > all remaining active patches today. > > Thanks for all your hard work on this! An active CFM really makes > things work better. Agreed, great work here. I ha

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

Robert Haas writes: > Maybe so, but we routinely have situations where a patch hasn't been > updated in 3-6 months and we tentatively ask the author if it would be > OK to mark it RwF, and they often say something like "please keep it > alive for one more CF to see if I have time to work on it."

Re: pg_auth_members.grantor is bunk

On Sun, Jul 31, 2022 at 2:34 PM Tom Lane wrote: > Indeed. I've not read the patch, but I just wanted to mention that > the cfbot shows it as failing regression tests on all platforms. > Possibly a conflict with some recent commit? I can't see this on cfbot - either I don't know how to use it pro

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

On Mon, Aug 1, 2022 at 12:56 PM Tom Lane wrote: > Yeah, I don't want to introduce make-work into the process; there's > more than enough real work involved. At minimum, a patch that's > shown signs of life since the previous CF should be auto-advanced > to the next one. Maybe so, but we routinel

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Em sáb., 16 de jul. de 2022 às 16:54, Ranier Vilela escreveu: > > > Em sáb, 16 de jul de 2022 2:58 AM, Peter Eisentraut < > peter.eisentr...@enterprisedb.com> escreveu: > >> On 11.07.22 21:06, Ranier Vilela wrote: >> > Em qui., 7 de jul. de 2022 às 14:01, Ranier Vilela > >

Re: pg_auth_members.grantor is bunk

On Sun, Jul 31, 2022 at 2:18 PM Stephen Frost wrote: > Thanks for working on this. Thanks for the review. > > Previously, only the superuser could specify GRANTED BY with a user > > other than the current user. Relax that rule to allow the grantor > > to be any role whose privileges the current

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

Jacob Champion writes: > On 8/1/22 09:33, Robert Haas wrote: >> We really need to move to a system where it's the patch author's job >> to take some action if the patch is alive, rather than having the CM >> (or any other human being) pinging to find out whether it's dead.> Having >> the default

Re: [Commitfest 2022-07] is Done!

Jacob Champion writes: > I've just closed out the July commitfest. I'll be working to clear out > all remaining active patches today. Thanks for all your hard work on this! An active CFM really makes things work better. regards, tom lane

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

On 8/1/22 09:33, Robert Haas wrote: > We really need to move to a system where it's the patch author's job > to take some action if the patch is alive, rather than having the CM > (or any other human being) pinging to find out whether it's dead.> Having the > default action for a patch be to carry

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

On Mon, Aug 1, 2022 at 12:30 PM Jacob Champion wrote: > Maybe this is something to look into once we've implemented some more of > the low-hanging usability features that people have asked for. But if we > started doing it now, I'd expect the CFM's job to simply change from > moving patches ahead

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

On 8/1/22 08:51, Justin Pryzby wrote: > @Jacob: Is there any reason why it's necessary to do anything at all ? > Does something bad happen if the patches are left in the current CF ? > Why make not let patch authors (re) submit the patch for review when they're > ready? Someone went to the effort

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

Hi, As far as I can see, the following is the answer to the only remaining open discussion in this thread. Let me know if anything is missed. (b) it appears to me that the patch decides > >> which index to use the first time it opens the rel (or if the rel gets > >> invalidated) on subscriber and

Re: Dump/Restore of non-default PKs

On Thu, 28 Apr 2022 at 15:09, Peter Eisentraut wrote: > > On 22.04.22 16:14, Tom Lane wrote: > > That analogy would be compelling if exclusion constraints were a > > SQL-standard feature; but they aren't so their clause syntax is > > fully under our control. The scenario that worries me is that >

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

On Thu, Jul 28, 2022 at 08:58:31AM -0700, Jacob Champion wrote: > On Thu, Jul 28, 2022 at 4:46 AM Andrey Borodin wrote: > > Daniil is working on this, but currently he's on vacation. > > I think we should not mark patch as RwF and move it to next CF instead. > > Is there a downside to marking it

[Commitfest 2022-07] is Done!

Hi all, I've just closed out the July commitfest. I'll be working to clear out all remaining active patches today. Final statistics: Needs review: 142 Waiting on Author: 44 Ready for Committer: 19 Committed: 76 Moved to next CF: 6 Returned

Re: Hash index build performance tweak from sorting

On Fri, 29 Jul 2022 at 13:49, Simon Riggs wrote: > > On Thu, 28 Jul 2022 at 19:50, Tom Lane wrote: > > > > Simon Riggs writes: > > > Thanks for the nudge. New version attached. > > > > I also see a speed improvement from this > > --- > > DROP TABLE IF EXISTS hash_speed; > > CREATE unlogged TABL

Re: support for MERGE

On 2022-Aug-01, Justin Pryzby wrote: > On Tue, Jun 14, 2022 at 11:27:06AM +0200, Álvaro Herrera wrote: > > @@ -448,9 +448,9 @@ COMMIT; > > and execute the first one that succeeds. > > If MERGE attempts an INSERT > > and a unique index is present and a duplicate row is concurrently >

Re: Add test of pg_prewarm extenion

2022년 8월 1일 (월) 오후 11:33, Dong Wook Lee 님이 작성: > > Thank you for letting me know. > I edited my patch with `wait_for_log()`. > > 2022년 8월 1일 (월) 오후 6:55, Julien Rouhaud 님이 작성: > > > > On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote: > > > > > > > Keep in mind also that the logfile accumulates o

Re: support for MERGE

On Tue, Jun 14, 2022 at 11:27:06AM +0200, Álvaro Herrera wrote: > @@ -448,9 +448,9 @@ COMMIT; > and execute the first one that succeeds. > If MERGE attempts an INSERT > and a unique index is present and a duplicate row is concurrently > -inserted, then a uniqueness violation is r

Re: Typo in pg_db_role_setting.h

On Mon, 01 Aug 2022 at 22:16, Tom Lane wrote: > John Naylor writes: >> You are correct, but I wonder if it'd be better to just drop the comment >> entirely. I checked a couple other random headers with function >> declarations and they didn't have such a comment, and it's kind of obvious >> what

Re: Add test of pg_prewarm extenion

Thank you for letting me know. I edited my patch with `wait_for_log()`. 2022년 8월 1일 (월) 오후 6:55, Julien Rouhaud 님이 작성: > > On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote: > > > > > Keep in mind also that the logfile accumulates over stops and > > > restarts. As you've coded this test, you do

Re: Add test of pg_prewarm extenion

Julien Rouhaud writes: > On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote: >> I have no idea how to deal with race conditions. >> Does anybody know how to deal with this? > Couldn't you use $node->wait_for_log() instead? Yeah. The standard usage pattern for that also covers the issue of not

Re: Typo in pg_db_role_setting.h

On Mon, 01 Aug 2022 at 20:46, John Naylor wrote: > On Mon, Aug 1, 2022 at 4:18 PM Japin Li wrote: >> >> >> Hi, hackers >> >> I think there is a typo in pg_db_role_setting.h, should we fix it? >> >> diff --git a/src/include/catalog/pg_db_role_setting.h > b/src/include/catalog/pg_db_role_setting.

Re: Triggers should work in isolation, with a final conflict detection step

On Sunday, July 31, 2022, Gianluca Calcagni wrote: > > The real drawback is that such approach is forgoing the natural principle > of *"separation of concerns"*! I have been looking into using trigger > frameworks to solve this problem, but there is no trigger framework that is > able to meet my

Re: Typo in pg_db_role_setting.h

John Naylor writes: > You are correct, but I wonder if it'd be better to just drop the comment > entirely. I checked a couple other random headers with function > declarations and they didn't have such a comment, and it's kind of obvious > what they're for. Some places have these, some don't. It

[feature]COPY FROM enable FORCE_NULL/FORCE_NOT_NULL on all columns

Hi, The previous discussion is: https://www.postgresql.org/message-id/CACJufxEnVqzOFtqhexF2%2BAwOKFrV8zHOY3y%3Dp%2BgPK6eB14pn_w%40mail.gmail.com We  have FORCE_NULL/FORCE_NOT_NULL options when COPY FROM,  but users must set the columns one by one.  CREATE TABLE forcetest (  a INT NOT NULL,  b

Re: Reducing planning time on tables with many indexes

Hi Tom, On Wed, Jul 27, 2022 at 7:15 PM Tom Lane wrote: > I wrote: > > Unfortunately, as things stand today, the planner needs more than the > > right to look at the indexes' schemas, because it makes physical accesses > > to btree indexes to find out their tree height (and I think there are > s

Re: logical replication restrictions

On Tue, Jul 5, 2022, at 9:29 AM, Amit Kapila wrote: > I wonder why we don't apply the delay on commit/commit_prepared > records only similar to physical replication. See recoveryApplyDelay. > One more advantage would be then we don't need to worry about > transactions that we are going to skip due

Re: Typo in pg_db_role_setting.h

On Mon, Aug 1, 2022 at 4:18 PM Japin Li wrote: > > > Hi, hackers > > I think there is a typo in pg_db_role_setting.h, should we fix it? > > diff --git a/src/include/catalog/pg_db_role_setting.h b/src/include/catalog/pg_db_role_setting.h > index 45d478e9e7..f92e867df4 100644 > /* > - * prototypes

  1   2   >