RE: Replica Identity check of partition table on subscriber

2022-06-19 Thread shiy.f...@fujitsu.com
On Mon, Jun 20, 2022 1:33 PM Amit Kapila wrote: > > On Fri, Jun 17, 2022 at 11:22 AM shiy.f...@fujitsu.com > wrote: > > > > On Fri Jun 17, 2022 11:06 AM shiy.f...@fujitsu.com > wrote: > > > > > > Attached the new version of patch set. I also moved the partitioned table > > > check > > > in logi

Re: Add index scan progress to pg_stat_progress_vacuum

2022-06-19 Thread Masahiko Sawada
On Mon, Jun 6, 2022 at 11:42 PM Robert Haas wrote: > > On Thu, May 26, 2022 at 11:43 AM Masahiko Sawada > wrote: > > Another idea I came up with is that we can wait for all index vacuums > > to finish while checking and updating the progress information, and > > then calls WaitForParallelWorkers

Re: Replica Identity check of partition table on subscriber

2022-06-19 Thread Amit Kapila
On Fri, Jun 17, 2022 at 11:22 AM shiy.f...@fujitsu.com wrote: > > On Fri Jun 17, 2022 11:06 AM shiy.f...@fujitsu.com > wrote: > > > > Attached the new version of patch set. I also moved the partitioned table > > check > > in logicalrep_rel_mark_updatable() to check_relation_updatable() as > > di

Re: Non-replayable WAL records through overflows and >MaxAllocSize lengths

2022-06-19 Thread Michael Paquier
On Sat, Jun 11, 2022 at 09:25:48PM +0200, Matthias van de Meent wrote: > Did you initiate a new cluster or otherwise skip the invalid record > you generated when running the instance based on master? It seems to > me you're trying to replay the invalid record (len > MaxAllocSize), > and this patch

RE: Handle infinite recursion in logical replication setup

2022-06-19 Thread shiy.f...@fujitsu.com
On Thu, Jun 16, 2022 6:18 PM vignesh C wrote: > > Thanks for the comments, the attached v21 patch has the changes for the > same. > Thanks for updating the patch. Here are some comments. 0002 patch == 1. + publisher to only send changes that originated locally. Setting +

RE: Support logical replication of DDLs

2022-06-19 Thread houzj.f...@fujitsu.com
On Saturday, June 18, 2022 3:38 AM Zheng Li wrote: > On Wed, Jun 15, 2022 at 12:00 AM Amit Kapila > wrote: > > > > On Wed, Jun 15, 2022 at 5:44 AM Zheng Li wrote: > > > > > > > > > While I agree that the deparser is needed to handle the potential > > > syntax differences between the pub/sub, I t

Re: Perform streaming logical transactions by background workers and parallel apply

2022-06-19 Thread Amit Kapila
On Fri, Jun 17, 2022 at 12:47 PM wangw.f...@fujitsu.com wrote: > > On Wed, Jun 15, 2022 at 8:13 PM Amit Kapila wrote: > > Few questions/comments on 0001 > > === > Thanks for your comments. > > > 1. > > In the commit message, I see: "We also need to allow stream_stop to > >

Re: [PATCH] Completed unaccent dictionary with many missing characters

2022-06-19 Thread Michael Paquier
On Wed, Jun 15, 2022 at 01:01:37PM +0200, Przemysław Sztoch wrote: > Two fixes (bad comment and fixed Latin-ASCII.xml). if codepoint.general_category.startswith('L') and \ - len(codepoint.combining_ids) > 1: + len(codepoint.combining_ids) > 0: So, this one checks for t

Re: [PoC] Improve dead tuple storage for lazy vacuum

2022-06-19 Thread Masahiko Sawada
Hi, On Thu, Jun 16, 2022 at 4:30 PM John Naylor wrote: > > On Thu, Jun 16, 2022 at 11:57 AM Masahiko Sawada > wrote: > > I've attached an updated version patch that changes the configure > > script. I'm still studying how to support AVX2 on msvc build. Also, > > added more regression tests. > >

Re: Add header support to text format and matching feature

2022-06-19 Thread Michael Paquier
On Thu, Jun 16, 2022 at 09:24:56AM +0200, Peter Eisentraut wrote: > I don't feel very strongly about this. It makes sense to stay consistent > with the existing COPY code. Yes, my previous argument is based on consistency with the surroundings. I am not saying that this could not be made better,

Re: libpq: Remove redundant null pointer checks before free()

2022-06-19 Thread Tom Lane
Alvaro Herrera writes: > For PQclear() specifically, one thing that I thought a few days ago > would be useful would to have it return (PGresult *) NULL. Then the > very common pattern of doing "PQclear(res); res = NULL;" could be > simplified to "res = PQclear(res);", which is nicely compact and

Re: libpq: Remove redundant null pointer checks before free()

2022-06-19 Thread Alvaro Herrera
On 2022-Jun-17, Peter Eisentraut wrote: > From 355ef1a68be690d9bb8ee0524226abd648733ce0 Mon Sep 17 00:00:00 2001 > From: Peter Eisentraut > Date: Fri, 17 Jun 2022 12:09:32 +0200 > Subject: [PATCH v2 3/3] Remove redundant null pointer checks before PQclear > and PQconninfofree > > These function