Re: Support logical replication of DDLs

On Fri, May 27, 2022 at 11:03 AM Amit Kapila wrote: > > On Fri, May 27, 2022 at 3:49 AM Zheng Li wrote: > > > > Hi Masahiko, > > > > > Thank you for updating the patches! > > > > > > I've not looked at these patches in-depth yet but with this approach, > > > what do you think we can handle the DD

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

Amit-san, On Fri, May 27, 2022 at 9:22 PM Amit Langote wrote: > On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita wrote: > > Attached is a patch for that. > I think we should also rewrite the description to match the CREATE > TABLE's text, as in the attached updated patch. Actually, I thought the

Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

On Wed, May 25, 2022 at 12:11 PM Masahiko Sawada wrote: > > On Tue, May 24, 2022 at 2:18 PM Amit Kapila wrote: > > > > On Tue, May 24, 2022 at 7:58 AM Masahiko Sawada > > wrote: > > > > > > On Mon, May 23, 2022 at 2:39 PM Amit Kapila > > > wrote: > > > > > > > > On Mon, May 23, 2022 at 10:03

Re: Frontend error logging style

On 23.05.22 11:53, Peter Eisentraut wrote: On 29.03.22 16:24, Peter Eisentraut wrote: I think I would want the program name/location also in front of the detail and hint lines.  I need to think about this a bit more.  This shouldn't hold up this patch; it would be a quick localized change. Af

Re: fix stats_fetch_consistency value in postgresql.conf.sample

On Sat, May 28, 2022 at 01:14:09PM -0700, Andres Freund wrote: > I pushed this bit too. Thanks for taking care of that! -- Michael signature.asc Description: PGP signature

Re: docs: mention "pg_read_all_stats" in "track_activities" description

On Sat, May 28, 2022 at 06:10:31AM -0700, Nathan Bossart wrote: > Sorry, I missed this one earlier. I'm okay with something along those > lines. I'm still trying to think of ways to make the last part a little > clearer, but I don't have any ideas beyond what we've discussed upthread. Okay. I h

Unicode Variation Selector and Combining character

Hi, I tried it on PostgreSQL 13. If you use the Unicode Variation Selector and Combining Character , the base character and the Variation selector will be 2 in length. Since it will be one character on the display, we expect it to be one in length. Please provide a function corresponding to

Re: SLRUs in the main buffer pool, redux

Hi, On 2022-05-28 13:13:20 +1200, Thomas Munro wrote: > There was a little bit of discussion on #pgcon-stream2 which I could > summarise as: can we figure out a way to keep parts of the CLOG pinned > so that backends don't have to do that for each lookup? Then CLOG > checks become simple reads.

SQL/JSON functions vs. ECPG vs. STRING as a reserved word

Commit 1a36bc9db (SQL/JSON query functions) introduced STRING as a type_func_name_keyword. As per the complaint at [1], this broke use of "string" as a table name, column name, function parameter name, etc. The restriction about column names, in particular, seems likely to break boatloads of appli

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em dom., 29 de mai. de 2022 às 15:21, Andres Freund escreveu: > On 2022-05-29 18:00:14 +0200, Tomas Vondra wrote: > > Also, there's the question of correctness, and I'd bet Andres is right > > getting snapshot without holding ProcArrayLock is busted. > > Unless there's some actual analysis of thi

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/29/22 19:26, Ranier Vilela wrote: > ... > I redid the benchmark with a better machine: > Intel i7-10510U > RAM 8GB > SSD 512GB > Linux Ubuntu 64 bits > > All files are attached, including the raw data of the results. > I did the calculations as requested. > But a quick average of the 10 bench

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 2022-05-29 18:00:14 +0200, Tomas Vondra wrote: > Also, there's the question of correctness, and I'd bet Andres is right > getting snapshot without holding ProcArrayLock is busted. Unless there's some actual analysis of this by Rainier, I'm just going to ignore this thread going forward. It's po

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em sáb., 28 de mai. de 2022 às 09:35, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > On 5/28/22 02:36, Ranier Vilela wrote: > > Em sex., 27 de mai. de 2022 às 18:22, Andres Freund > > escreveu: > > > > Hi, > > > > On 2022-05-27 10:35:08 -0300, Ranier

Re: convert libpq uri-regress tests to tap test

On Sat, Feb 26, 2022 at 05:46:26PM -0800, Andres Freund wrote: > On 2022-02-25 17:52:29 -0800, Andres Freund wrote: > > I'd like to commit 0001 and 0002 soon, unless somebody sees a reason not to? > > Pushed. If I'm not wrong, this isn't being run by check-world. commit 4dc465207517c4b69a1f2b657

RE: Perform streaming logical transactions by background workers and parallel apply

On Wednesday, May 25, 2022 11:25 AM wangw.f...@fujitsu.com wrote: > Attach the patches. (Did not change v6-0001 and v6-0002.) Hi, Some review comments on the new patches from v6-0001 to v6-0004. (1) create_subscription.sgml + the transaction is committed. Note that if an error happ