Re: [BUG] Panic due to incorrect missingContrecPtr after promotion

At Fri, 27 May 2022 02:01:27 +, "Imseih (AWS), Sami" wrote in > After further research, we found the following. > > Testing on 13.6 with the attached patch we see > that the missingContrecPtr is being incorrectly > set on the standby and the promote in the tap > test fails. > > Per the com

Prevent writes on large objects in read-only transactions

Hello, Currently, lo_creat(e), lo_import, lo_unlink, lowrite, lo_put, and lo_from_bytea are allowed even in read-only transactions. By using them, pg_largeobject and pg_largeobject_metatable can be modified in read-only transactions and the effect remains after the transaction finished. Is it unac

Re: doc phrase: "inheritance child"

On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat wrote: > > - If true, the stats include inheritance child columns, not just the > + If true, the stats include child tables, not just the > > We are replacing columns with tables; is that intentional? > > Partitioned tables do not

Re: bogus: logical replication rows/cols combinations

On Fri, May 27, 2022 at 11:17:00AM +0530, Amit Kapila wrote: > On Tue, May 24, 2022 at 11:03 AM houzj.f...@fujitsu.com > wrote: > > > > On Friday, May 20, 2022 11:06 AM Amit Kapila > > wrote: > > > > Thanks for pointing it out. Here is the new version patch which add this > > version check. >

Re: bogus: logical replication rows/cols combinations

On Tue, May 24, 2022 at 11:03 AM houzj.f...@fujitsu.com wrote: > > On Friday, May 20, 2022 11:06 AM Amit Kapila wrote: > > Thanks for pointing it out. Here is the new version patch which add this > version check. > I have added/edited a few comments and ran pgindent. The attached looks good to

Re: ICU_LOCALE set database default icu collation but not working as intended.

Hi, here are some other trigger cases. CREATE DATABASE dbicu3 LOCALE_PROVIDER icu LOCALE 'en_US.UTF-8' ICU_LOCALE 'en-u-kr-latn-digit-kf-upper-kn-true' TEMPLATE 'template0'; CREATE DATABASE dbicu4 LOCALE_PROVIDER icu LOCALE 'en_US.UTF-8' ICU_LOCALE 'en-u-kr-latn-digit-kn-true' TEMPLATE 'te

Re: Handle infinite recursion in logical replication setup

Here are some more review comments for v15-0002 I found while working through the documented examples. These are all for doc/src/sgml/logical-replication.sgml. The section numbers (e.g. 31.11.1) are the assigned numbers after HTML rendering. The general comment is that the sections appeared at fir

Re: Invalid memory alloc request size for repeat()

Japin Li writes: > Do those mean we cannot store 1GB to a field [1] and send 1GB of data to the > client? That's what I said upthread. I'm not terribly excited about that. Shoving gigabyte-sized field values around as atomic strings is not going to lead to anything but pain: even if the server

Re: Invalid memory alloc request size for repeat()

On Thu, 26 May 2022 at 09:03, Japin Li wrote: > On Wed, 25 May 2022 at 22:50, Tom Lane wrote: >> Japin Li writes: >>> Today, I try to use repeat() to generate 1GB text, and it occurs invalid >>> memory >>> alloc request size [1]. It is a limit from palloc(), then I try to reduce >>> it, >>>

Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

On Thu, May 26, 2022 at 10:17:08AM +0200, Juan José Santamaría Flecha wrote: > There have been a couple of discussions involving not only Windows > version10, but also the Release id: > > https://commitfest.postgresql.org/38/3347/ This mentions 0x0A00, aka Windows 10, for atomic rename support.

Re: doc phrase: "inheritance child"

Hi, On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat wrote: > @@ -7306,7 +7306,7 @@ SCRAM-SHA-256$ count>:&l > > Normally there is one entry, with stainherit = > false, for each table column that has been analyzed. > - If the table has inheritance children, a second entry

Re: Assert name/short_desc to prevent SHOW ALL segfault

Michael Paquier writes: > FWIW, I would be fine to backpatch the NULL handling for short_desc, > while treating the addition of nonnull as a HEAD-only change. Yeah, sounds about right to me. My guess is that we will need a configure check for nonnull, but perhaps I'm wrong.

Re: Assert name/short_desc to prevent SHOW ALL segfault

On Thu, May 26, 2022 at 02:45:50PM -0700, Nathan Bossart wrote: > On Tue, May 24, 2022 at 11:17:39PM -0700, Andres Freund wrote: >> On 2022-05-24 11:41:49 -0700, Nathan Bossart wrote: >>> I would actually ERROR on this so that we aren't relying on >>> --enable-cassert builds to catch it. >> >> How

Re: PostgreSQL 15 Beta 1 release announcement draft (windows)

On Tue, May 24, 2022 at 12:57:02AM -0400, Jeff Janes wrote: > I have some belated feedback. I was excited to try this on Windows (I don't > have a build system for that) This is unrelated to beta1, but someone (Thomas Munro?) had the idea to allow retrieving the windows binaries built by cirrus c

Re: Handle infinite recursion in logical replication setup

On Wed, Apr 6, 2022 at 9:36 AM Amit Kapila wrote: > > On Tue, Apr 5, 2022 at 7:06 PM Ashutosh Bapat > wrote: > > > > On Tue, Apr 5, 2022 at 6:21 AM Peter Smith wrote: > > > > > > Below are some other name ideas. Maybe they are not improvements, but > > > it might help other people to come up wit

Re: Support logical replication of DDLs

On Fri, May 27, 2022 at 3:49 AM Zheng Li wrote: > > Hi Masahiko, > > > Thank you for updating the patches! > > > > I've not looked at these patches in-depth yet but with this approach, > > what do you think we can handle the DDL syntax differences between > > major versions? DDL syntax or behavior

Re: Add index scan progress to pg_stat_progress_vacuum

>Another idea I came up with is that we can wait for all index vacuums >to finish while checking and updating the progress information, and >then calls WaitForParallelWorkersToFinish after confirming all index >status became COMPLETED. That way, we don’t need to change the >para

Re: [BUG] Panic due to incorrect missingContrecPtr after promotion

At Thu, 26 May 2022 19:57:41 +, "Imseih (AWS), Sami" wrote in > We see another occurrence of this bug with the last patch applied in 13.7. > > After a promotion we observe the following in the logs: ... > We think it's because VerifyOverwriteContrecord was not > called which is why we see

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/27/22 02:11, Ranier Vilela wrote: > > ... > > Here the results with -T 60: Might be a good idea to share your analysis / interpretation of the results, not just the raw data. After all, the change is being proposed by you, so do you think this shows the change is beneficial? > Linux Ubuntu

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Thu, May 26, 2022 at 4:13 PM Tom Lane wrote: > Gurjeet Singh writes: > > On Thu, May 26, 2022 at 12:16 PM Tom Lane wrote: > >> so maybe those comments in libpq-be.h > >> should be moved to their respective functions? In any case, I'm not > >> excited about having three separate comments cove

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 08:26, Ranier Vilela escreveu: > Em qua., 25 de mai. de 2022 às 07:13, Tomas Vondra < > tomas.von...@enterprisedb.com> escreveu: > >> >> >> On 5/25/22 11:07, Ranier Vilela wrote: >> > Em qua., 25 de mai. de 2022 às 00:46, Andres Freund > >

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Thu, May 26, 2022 at 2:40 PM Tom Lane wrote: > > Robert Haas writes: > > I think you're overreacting to a behavior that isn't really very surprising. > > > If we don't initialize SSL the first time, we don't have a working SSL > > stack. If we didn't choose to die at that point, we'd be starti

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 07:51:08PM -0400, Tom Lane wrote: > I wouldn't object to doing that, and even back-patching. It looked > like a pretty sane change, and we've learned before that skimping on > back-branch test infrastructure is a poor tradeoff. Okay, fine by me. Andres, what do you think

Re: [BUG] Panic due to incorrect missingContrecPtr after promotion

On Fri, May 27, 2022 at 08:53:03AM +0900, Michael Paquier wrote: > This needs a very close lookup, I'll try to check all that except if > somebody beats me to it. Please ignore that.. I need more coffee, and likely a break. -- Michael signature.asc Description: PGP signature

Re: [BUG] Panic due to incorrect missingContrecPtr after promotion

On Tue, Feb 22, 2022 at 07:20:55PM +, Imseih (AWS), Sami wrote: > The overwrite_contrecord was introduced in 13.5 with > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ff9f111bce24. > > Attached is a patch and a TAP test to handle this condition. The > patch ensures that an ov

Re: pg_upgrade test writes to source directory

Michael Paquier writes: > On Thu, May 26, 2022 at 06:19:56PM -0400, Tom Lane wrote: >> It looks like that patch is meant to resolve misbehaviors equivalent to >> this one that already exist in several other places. So fixing this >> one along with the other ones seems like an appropriate thing to

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

On Fri, May 27, 2022 at 1:58 AM Robert Haas wrote: > On Thu, May 26, 2022 at 1:50 AM Amit Langote wrote: > > Attached 2 patches -- one for PG 11 onwards and another for PG 10. > > Committed, except I adjusted the v11 version so that the CREATE > FOREIGN TABLE documentation would match the CREATE

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 06:19:56PM -0400, Tom Lane wrote: > It looks like that patch is meant to resolve misbehaviors equivalent to > this one that already exist in several other places. So fixing this > one along with the other ones seems like an appropriate thing to do > when that lands. Well,

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

Gurjeet Singh writes: > On Thu, May 26, 2022 at 12:16 PM Tom Lane wrote: >> so maybe those comments in libpq-be.h >> should be moved to their respective functions? In any case, I'm not >> excited about having three separate comments covering the same point. > By 3 locations, I suppose you're re

Re: pg_upgrade test writes to source directory

Michael Paquier writes: > On Thu, May 26, 2022 at 03:52:18PM -0500, Justin Pryzby wrote: >> It looks like Peter working on top of the meson branch. >> TESTOUTDIR is not yet in master. > Well, we need to do something about that on HEAD, and it also means > that TESTDIR is the best fit for the jo

Re: Support logical replication of DDLs

Hi Masahiko, > Thank you for updating the patches! > > I've not looked at these patches in-depth yet but with this approach, > what do you think we can handle the DDL syntax differences between > major versions? DDL syntax or behavior could be changed by future > changes and I think we need to som

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 03:52:18PM -0500, Justin Pryzby wrote: > It looks like Peter working on top of the meson branch. > TESTOUTDIR is not yet in master. Thanks for the reference. I didn't know this part of the puzzle. > https://commitfest.postgresql.org/38/3395/ > https://github.com/anaraze

Re: selectivity function

Greg Hennessy writes: > On Thu, May 26, 2022 at 3:10 PM Tom Lane wrote: >> Attaching a support function to a SQL-language function seems pretty >> weird to me. > Is there a way to set the selectivity of a SQL-language function? I think it'd work if you prevented inlining, but doing so would def

Re: Remove support for Visual Studio 2013

Michael Paquier writes: > On Thu, May 26, 2022 at 10:43:11AM -0500, Justin Pryzby wrote: >> Maybe consider removing this workaround? The original problem report >> indicated >> that it didn't affect later versions: >> >> src/backend/optimizer/path/costsize.c: /* This apparently-useless variabl

Re: Assert name/short_desc to prevent SHOW ALL segfault

On Tue, May 24, 2022 at 11:17:39PM -0700, Andres Freund wrote: > On 2022-05-24 11:41:49 -0700, Nathan Bossart wrote: >> I would actually ERROR on this so that we aren't relying on >> --enable-cassert builds to catch it. > > How about adding pg_nonnull(...) (ending up as __attribute__((nonnull(...)

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

Robert Haas writes: > I think you're overreacting to a behavior that isn't really very surprising. > If we don't initialize SSL the first time, we don't have a working SSL > stack. If we didn't choose to die at that point, we'd be starting up a > server that could not accept any SSL connections.

Re: selectivity function

On Thu, May 26, 2022 at 3:10 PM Tom Lane wrote: > Greg Hennessy writes: > > I'm trying to include a sensitivity operator in a function. My issue is > > that when I have my function, I get a call to SupportRequestSimplify, but > > not SupportRequestSensitivity. It is not obvious what I am doing t

Status of cluster file encryption

Here is a status report of where I think we are with cluster file encryption. The last patch for temporary file I/O centralization is from April 20: https://www.postgresql.org/message-id/24759.1650466826@antos Once that is done I can modify my patch set to switch from CTR to XTS mode and

Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

On Thu, May 26, 2022 at 4:27 PM Michael Paquier wrote: > Perhaps the async work? (Checks code...) Looks like the experimental Windows native AIO code we have today, namely io_method=windows_iocp, only needs Vista. That's for GetQueueCompletionStatusEx() (before that you had to call GetQueuedCompl

Re: Remove support for Visual Studio 2013

On Thu, May 26, 2022 at 10:43:11AM -0500, Justin Pryzby wrote: Ah, thanks. I forgot to grep for those patterns. Good catches. > Maybe consider removing this workaround? The original problem report > indicated > that it didn't affect later versions: > > src/backend/optimizer/path/costsize.c:

Re: pg_upgrade test writes to source directory

On Fri, May 27, 2022 at 05:43:04AM +0900, Michael Paquier wrote: > On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote: > > I chose TESTOUTDIR because it corresponds to the tmp_check directory, so > > that the output files of the pg_upgrade run are removed when the test > > artifacts a

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote: > I chose TESTOUTDIR because it corresponds to the tmp_check directory, so > that the output files of the pg_upgrade run are removed when the test > artifacts are cleaned up. When using TESTDIR, the pg_upgrade output files > end up

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Thu, May 26, 2022 at 1:00 PM Robert Haas wrote: > > On Thu, May 26, 2022 at 1:05 AM Gurjeet Singh wrote: > > There's an symmetry, almost a diametric opposition, between how SSL I meant "an asymmetry". > > initialization error is treated when it occurs during server startup, > > versus when t

Re: ICU_LOCALE set database default icu collation but not working as intended.

jian he wrote: > CREATE > DATABASE dbicu1 LOCALE_PROVIDER icu LOCALE 'en_US.UTF-8' ICU_LOCALE > 'en-u-kf-upper' TEMPLATE 'template0'; > CREATE DATABASE dbicu2 LOCALE_PROVIDER icu LOCALE 'en_US.UTF-8' ICU_LOCALE > 'en-u-kr-latn-digit' TEMPLATE 'template0'; > [...] > I am not sure this is my

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Thu, May 26, 2022 at 12:16 PM Tom Lane wrote: > Gurjeet Singh writes: > > On Mon, May 23, 2022 at 8:51 PM Tom Lane wrote: > >> The comments for secure_initialize() and be_tls_init() both explain > >> this already. > > > The comments above secure_initialize() do, but there are no comments > >

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

On Thu, May 26, 2022 at 1:05 AM Gurjeet Singh wrote: > There's an symmetry, almost a diametric opposition, between how SSL > initialization error is treated when it occurs during server startup, > versus when the error occurs during a reload/SIGHUP. During startup an > error in SSL initialization

Re: [BUG] Panic due to incorrect missingContrecPtr after promotion

We see another occurrence of this bug with the last patch applied in 13.7. After a promotion we observe the following in the logs: 2022-05-25 00:35:38 UTC::@:[371]:PANIC: xlog flush request 10/B1FA3D88 is not satisfied --- flushed only to 7/A860 2022-05-25 00:35:38 UTC:172.31.26.238(38610):

Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

Gurjeet Singh writes: > On Mon, May 23, 2022 at 8:51 PM Tom Lane wrote: >> The comments for secure_initialize() and be_tls_init() both explain >> this already. > The comments above secure_initialize() do, but there are no comments > above be_tls_init(), and nothing in there attempts to explain t

Re: selectivity function

Greg Hennessy writes: > I'm trying to include a sensitivity operator in a function. My issue is > that when I have my function, I get a call to SupportRequestSimplify, but > not SupportRequestSensitivity. It is not obvious what I am doing that is > incorrect. Attaching a support function to a SQL

selectivity function

I'm trying to include a sensitivity operator in a function. My issue is that when I have my function, I get a call to SupportRequestSimplify, but not SupportRequestSensitivity. It is not obvious what I am doing that is incorrect. My c (stub) function is: PG_FUNCTION_INFO_V1(pgq3c_join_selectivity

Re: postgres and initdb not working inside docker

Roffild writes: > postgres and initdb not working inside docker. > chmod 755 always for a mounted volume inside docker. This patch will never be accepted. You don't need it if you take the standard advice[1] that the Postgres data directory should not itself be a mount point. Instead, make a su

postgres and initdb not working inside docker

postgres and initdb not working inside docker. chmod 755 always for a mounted volume inside docker. = From: Roffild Subject: fix chmod inside docker diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c index 30f0f19dd5..adf3218cf9 100644 --- a/src/

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

On Thu, May 26, 2022 at 1:50 AM Amit Langote wrote: > Attached 2 patches -- one for PG 11 onwards and another for PG 10. Committed, except I adjusted the v11 version so that the CREATE FOREIGN TABLE documentation would match the CREATE TABLE documentation in that branch. -- Robert Haas EDB: htt

Re: Add --{no-,}bypassrls flags to createuser

On Thu, May 26, 2022 at 02:16:37PM +0900, Shinya Kato wrote: > On 2022-05-25 11:07, Kyotaro Horiguchi wrote: >> At Tue, 24 May 2022 10:09:10 -0700, Nathan Bossart >> wrote in >> > We're still missing some "fancier" string patterns in the tests, but >> > we >> > might just be nitpicking at this poi

Re: Add index scan progress to pg_stat_progress_vacuum

On Fri, May 6, 2022 at 4:26 AM Imseih (AWS), Sami wrote: > > Thank you for the feedback! > > >I think we can pass the progress update function to > > WaitForParallelWorkersToFinish(), which seems simpler. And we can call > > Directly passing the callback to WaitForParallelWorkersToFinish > w

Re: Remove support for Visual Studio 2013

Maybe consider removing this workaround? The original problem report indicated that it didn't affect later versions: src/backend/optimizer/path/costsize.c: /* This apparently-useless variable dodges a compiler bug in VS2013: */ I'm not sure if it's worth removing this one, though: src/port/st

ICU_LOCALE set database default icu collation but not working as intended.

Base on this thread: https://www.postgresql.org/message-id/20220305083830.lpz3k3yku5lmm5xs%40jrouhaud ordering reference: https://unicode-org.github.io/cldr-staging/charts/latest/collation/en_US_POSIX.html CREATE DAT

Re: pg_upgrade test writes to source directory

On 25.05.22 09:25, Michael Paquier wrote: It looks like an addition of chdir $ENV{TESTOUTDIR}; could fix it. Please check the patch. I think that you mean TESTDIR, and not TESTOUTDIR? I chose TESTOUTDIR because it corresponds to the tmp_check directory, so that the output files of the

RE: Skipping schema changes in publication

On Monday, May 23, 2022 2:13 PM vignesh C wrote: > Attached v7 patch which fixes the buildfarm warning for an unused warning in > release mode as in [1]. Hi, thank you for the patches. I'll share several review comments. For v7-0001. (1) I'll suggest some minor rewording. + + The RESET c

Compare variables of composite type with slightly different column types

Hi, Researching on join selectivity improvement I stuck into the code in rowtypes.c: /* * Have two matching columns, they must be same type */ if (att1->atttypid != att2->atttypid) ereport(ERROR, ... Why, for example, isn't allowed next trivial query: SELECT * FROM (SELECT ROW(1::intege

Re: Handle infinite recursion in logical replication setup

On Fri, May 20, 2022 at 3:31 PM vignesh C wrote: > > On Wed, May 18, 2022 at 4:22 PM Amit Kapila wrote: > > > > 5. > > * It is quite possible that subscriber has not yet pulled data to > > + * the tables, but in ideal cases the table data will be subscribed. > > + * To keep the code simple it is

Re: [RFC] building postgres with meson

Hi Andres, Thanks for working on this! I'm very enthusiastic about this effort and I was glad to see on PGCon Unconference that the majority of the community seems to be as well. > The halfway decent list includes, I think: > 1) cmake > 2) bazel > 3) meson Was SCons considered as an option? It i

Re: Handle infinite recursion in logical replication setup

This post completes my review of patch v15*. == 1. A general comment affecting both patches I realised the things defined in the subscription WITH are referred to in the PG DOCS as "parameters" (not "options"). See CREATE SUBSCRIPTION [1]. This is already reflected in some of my review comme

Re: Support logical replication of DDLs

On Sat, May 14, 2022 at 6:02 AM Zheng Li wrote: > > > > 4. The handling related to partition tables seems missing because, on > > > the subscriber-side, it always creates a relation entry in > > > pg_subscription_rel which won't work. Check its interaction with > > > publish_via_partition_root. >

Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

On Thu, May 26, 2022 at 6:27 AM Michael Paquier wrote: > > Is there anything posted recently that would require that? Perhaps > the async work? FWIW, I agree to be much more aggressive, but there > is nothing in the tree now that depends on _WIN32_WINNT, except one > change for the locales. T

Re: Add --{no-,}bypassrls flags to createuser

At Thu, 26 May 2022 14:16:37 +0900, Shinya Kato wrote in > On 2022-05-25 12:47, Michael Paquier wrote: > > On Wed, May 25, 2022 at 11:07:52AM +0900, Kyotaro Horiguchi wrote: > >> I reproduced the same failure at my hand and identified the > >> cause. Windows' version of getopt_long seems to disl

Re: fix stats_fetch_consistency value in postgresql.conf.sample

At Thu, 26 May 2022 13:00:45 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 25 May 2022 21:25:53 -0500, Justin Pryzby > wrote in > > And I think these should be updated it postgresql.conf to use the same unit > > as > > in current_setting(). > > > > track_activity_query_size | 1kB

Re: Allow file inclusion in pg_hba and pg_ident files

On Tue, May 24, 2022 at 10:44:05AM +0900, Michael Paquier wrote: > On Mon, May 23, 2022 at 07:43:08PM +0800, Julien Rouhaud wrote: > > That being said, I'd gladly drop that enum and only handle a single error > > message, as the rest of the error context (including the owning file name > > and > >

Re: suboverflowed subtransactions concurrency performance optimize

On Tue, May 24, 2022 at 04:52:50PM -0700, Andres Freund wrote: > As is, this strikes me as dangerous. At the very least this ought to be > structured so it can have assertions verifying that the cache contents are > correct. Well, under USE_ASSERT_CHECKING we could force a recalculation of the loo