Re: [Proposal] vacuumdb --schema only

2022-04-24 Thread Gilles Darold
goo Le 25/04/2022 à 03:27, Nathan Bossart a écrit : > On Fri, Apr 22, 2022 at 10:57:46PM -0700, Nathan Bossart wrote: >> On Fri, Apr 22, 2022 at 11:57:05AM +0200, Gilles Darold wrote: >>> Patch v10 attached. >> Thanks! I've attached a v11 with some minor editorialization. I think I >> was able to

Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508

2022-04-24 Thread Michael Paquier
On Wed, Apr 20, 2022 at 01:03:20PM +0200, Erik Rijkers wrote: > Yes, that seems to fix it: I applied that latter patch, and ran my program > 250x without errors. Then I removed it again an it gave the error within > 15x. That looks simple enough, indeed. Andres, are you planning to address this i

Re: why pg_walfile_name() cannot be executed during recovery?

2022-04-24 Thread Andrey Borodin
> 22 апр. 2022 г., в 19:15, Bharath Rupireddy > написал(а): > > On Sat, Apr 9, 2022 at 10:21 PM Robert Haas wrote: >> >> On Sat, Apr 9, 2022 at 12:25 PM Andrey Borodin wrote: >>> Please excuse me if I'm not attentive enough. I've read this thread. And I >>> could not find what is the prob

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

2022-04-24 Thread Michael Paquier
On Sat, Apr 23, 2022 at 01:43:36PM -0500, David Christensen wrote: > Hi Matthias, great point. Enclosed is a revised version of the patch > that adds the fork identifier to the end if it's a non-main fork. Like Alvaro, I have seen cases where this would have been really handy. So +1 from me, as

Re: json_object returning jsonb reuslt different from returning json, returning text

2022-04-24 Thread alias
seems it's a bug around value 0. SELECT JSON_OBJECTAGG(k: v ABSENT ON NULL WITH UNIQUE KEYS RETURNING jsonb) FROM (VALUES (1, 1), (10, NULL),(4, null), (5, null),(6, null),(2, 2)) foo(k, v); return: {"1": 1, "2": 2} SELECT JSON_OBJECTAGG(k: v ABSENT ON NULL WITH UNIQUE KEYS RETURNING jsonb) FROM

json_object returning jsonb reuslt different from returning json, returning text

2022-04-24 Thread alias
select json_objectagg( k:v absent on null with unique keys returning text ) from ( values(1,1),(0, null),(3, null),(2,2),(4,null) ) foo(k, v); return json_objectagg -- { "1" : 1, "2" : 2 } select json_objectagg(k:v absent on null with unique

Re: Defer selection of asynchronous subplans until the executor initialization stage

2022-04-24 Thread Etsuro Fujita
Hi, On Wed, Apr 20, 2022 at 2:04 AM Zhihong Yu wrote: > It is okay to keep the formation in your patch. I modified mark_async_capable_plan() a bit further; 1) adjusted code in the ProjectionPath case, just for consistency with other cases, and 2) tweaked/improved comments a bit. Attached is a n

Re: [Proposal] vacuumdb --schema only

2022-04-24 Thread Nathan Bossart
On Fri, Apr 22, 2022 at 10:57:46PM -0700, Nathan Bossart wrote: > On Fri, Apr 22, 2022 at 11:57:05AM +0200, Gilles Darold wrote: >> Patch v10 attached. > > Thanks! I've attached a v11 with some minor editorialization. I think I > was able to improve the error handling for invalid combinations of

RE: Data is copied twice when specifying both child and parent table in publication

2022-04-24 Thread wangw.f...@fujitsu.com
On Sun, Apr 24, 2022 at 2:16 PM I wrote: > On Thur, Apr 21, 2022 at 5:41 PM Amit Kapila wrote: > > IIRC, the column list and row filter also have some issues exactly due to > > this > > reason, so, I would like those cases to be also mentioned here and probably > > include the tests for them in t

Re: [PATCH] Add native windows on arm64 support

2022-04-24 Thread Michael Paquier
On Thu, Apr 21, 2022 at 10:21:04AM +0100, Niyas Sait wrote: > The following error occurs: > > LINK : fatal error LNK1246: '/DYNAMICBASE:NO' not compatible with 'ARM64' > target machine; link without '/DYNAMICBASE:NO Okay, that's interesting. In light of things like 7f3e17b, that may be annoying.

Re: pg_receivewal fail to streams when the partial file to write is not fully initialized present in the wal receiver directory

2022-04-24 Thread Michael Paquier
On Fri, Apr 22, 2022 at 07:17:37PM +0530, Bharath Rupireddy wrote: > Right. We find enough disk space and go to write and suddenly the > write operations fail for some reason or the VM crashes because of a > reason other than disk space. I think the foolproof solution is to > figure out the availab

Re: Cryptohash OpenSSL error queue in FIPS enabled builds

2022-04-24 Thread Michael Paquier
On Sat, Apr 23, 2022 at 11:40:19PM +0200, Daniel Gustafsson wrote: > On 22 Apr 2022, at 19:01, Tom Lane wrote: >> Daniel Gustafsson writes: >>> Consuming all (both) errors and creating a concatenated string seems >>> overkill >>> as it would alter the API from a const error string to something t

Re: Estimating HugePages Requirements?

2022-04-24 Thread Michael Paquier
On Fri, Apr 22, 2022 at 09:49:34AM +0200, Magnus Hagander wrote: > I agree that thats a very narrow use case. And I'm not sure the use case of > a running server is even that important here - it's really the offline one > that's important. Or rather, the really compelling one is when there is a > s

Re: [RFC] building postgres with meson -v8

2022-04-24 Thread Andrew Dunstan
On 2022-04-21 Th 17:34, Tom Lane wrote: > Andres Freund writes: >> On 2022-04-21 22:36:01 +0200, Peter Eisentraut wrote: >>> Why is Python 3.5 relevant? >> It's the latest available on some older platforms. It's pretty easy to >> install >> a new meson, a heck of a lot more work to install a ne

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-24 Thread Andrew Dunstan
On 2022-04-24 Su 14:19, Noah Misch wrote: > On Sun, Apr 24, 2022 at 01:09:08PM -0400, Andrew Dunstan wrote: >> On 2022-04-22 Fr 22:59, Noah Misch wrote: >>> The MinGW gcc crt*.o files do shell-glob expansion on the arguments before >>> entering main(). See https://google.com/search?q=mingw+comma

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-24 Thread Noah Misch
On Sun, Apr 24, 2022 at 01:09:08PM -0400, Andrew Dunstan wrote: > On 2022-04-22 Fr 22:59, Noah Misch wrote: > > The MinGW gcc crt*.o files do shell-glob expansion on the arguments before > > entering main(). See https://google.com/search?q=mingw+command+line+glob > > for > > various discussion of

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-24 Thread Andrew Dunstan
On 2022-04-22 Fr 22:59, Noah Misch wrote: > On Sat, Apr 23, 2022 at 09:12:20AM +1200, Thomas Munro wrote: >> On Sat, Apr 23, 2022 at 8:06 AM Robert Haas wrote: >>> I have to say the fact that IPC::Run does shell-glob expansion of its >>> arguments on some machines and not others seems ludicrous