Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

On Sat, 8 May 2021 at 20:29, David Rowley wrote: > > On Sat, 8 May 2021 at 20:17, Zhihong Yu wrote: > > + if (!OidIsValid(saop->negfuncid)) > > + record_plan_function_dependency(root, saop->hashfuncid); > > > > Is there a typo in the second line ? (root, saop->negfuncid) > > Yeah,

Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

On Sat, May 22, 2021 at 10:22 PM Mark Dilger wrote: > My concern isn't that the code is doing the wrong thing, but that the docs > and the error messages are confusing. This is particularly troubling given > that having a single action which combines the dropping of one publication > with the

Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS

On Sun, May 23, 2021 at 10:28 AM Tom Lane wrote: > I wrote: > > ... wrong. Running v13 branch tip under CLOBBER_CACHE_ALWAYS provokes > > a core dump in 013_partition.pl, so 1375422c is not to blame. Now > > I'm wondering how far back there's a live issue. > > Oh, of course, it's directly the fa

Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS

I wrote: > ... wrong. Running v13 branch tip under CLOBBER_CACHE_ALWAYS provokes > a core dump in 013_partition.pl, so 1375422c is not to blame. Now > I'm wondering how far back there's a live issue. Oh, of course, it's directly the fault of the patch that added support for partitioned target ta

Re: PG 14 release notes, first draft

On Sat, May 22, 2021 at 07:29:45PM -0400, Stephen Frost wrote: > Greetings, > > * Bruce Momjian (br...@momjian.us) wrote: > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > > > https://momjian.us/pgsql_docs/release-14.ht

Re: PG 14 release notes, first draft

Greetings, * Bruce Momjian (br...@momjian.us) wrote: > I have committed the first draft of the PG 14 release notes. You can > see the most current build of them here: > > https://momjian.us/pgsql_docs/release-14.html It occurs to me that the wording around the new default roles could pro

Re: Development version of release notes

On Sat, May 22, 2021 at 05:56:32PM -0400, Bruce Momjian wrote: > Anyway, this means that the markup I added post-packaging to PG 14 is > inaccessible, and will not appear until PG 14 beta 2. Here is the > actual markup from my local build: > > https://momjian.us/pgsql_docs/release-14.htm

Re: PG 14 release notes, first draft

On Sat, May 22, 2021 at 03:35:13PM -0700, Peter Geoghegan wrote: > On Thu, May 20, 2021 at 4:54 PM Bruce Momjian wrote: > > I think our text "This new default better reflects current hardware > > capabilities." is detailed enough. People can dig into the item to see > > what it does and how it ad

Re: PG 14 release notes, first draft

On Thu, May 20, 2021 at 4:54 PM Bruce Momjian wrote: > I think our text "This new default better reflects current hardware > capabilities." is detailed enough. People can dig into the item to see > what it does and how it adjusts costs. Fair enough. I noticed something about the same item that

Development version of release notes

It appears the development version of the release notes are not accessible. If you go from: https://www.postgresql.org/developer/testing/ to https://www.postgresql.org/docs/devel/ to https://www.postgresql.org/docs/devel/release.html it is fine, but once you ask for the P

Re: Buildfarm latest links

On 5/22/21 5:42 PM, Magnus Hagander wrote: > > > On Sat, May 22, 2021, 23:40 Andrew Dunstan > wrote: > > > On 5/22/21 4:20 PM, Magnus Hagander wrote: > > Our website links to: > > > > > > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?

Re: Buildfarm latest links

On Sat, May 22, 2021, 23:40 Andrew Dunstan wrote: > > On 5/22/21 4:20 PM, Magnus Hagander wrote: > > Our website links to: > > > > > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus&dt=latest&stg=make-doc > > > > in order to display the latest build log for the docs. > >

Re: Buildfarm latest links

On 5/22/21 4:20 PM, Magnus Hagander wrote: > Our website links to: > > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus&dt=latest&stg=make-doc > > in order to display the latest build log for the docs. > > This appears to have stopped working at some point. I don't know

Buildfarm latest links

Our website links to: https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus&dt=latest&stg=make-doc in order to display the latest build log for the docs. This appears to have stopped working at some point. I don't know when, unfortunately, it was just brought to my attention

Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

> On May 21, 2021, at 10:39 PM, Bharath Rupireddy > wrote: > > On Sat, May 22, 2021 at 1:49 AM Mark Dilger > wrote: >> >> -hackers, >> >> I think commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f created some >> confusion that should be cleaned up before release. I'd like some guidance >>

Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS

I wrote: > Amit Langote writes: >> BTW, I think we'd need to cherry-pick f3b141c4825 (or maybe parts of >> it) into v13 branch for back-patching this. > I already did a fair amount of that yesterday, cf 84f5c2908 et al. > But that does raise the question of how far we need to back-patch this. > I

Re: Race condition in recovery?

On Sat, May 22, 2021 at 12:45 AM Dilip Kumar wrote: > No, in my original scenario also the new standby was not old primary, > I had 3 nodes > node1-> primary, node2 -> standby1, node3-> standby2 > node2 promoted as a new primary and node3's local WAL was removed (so > that it has to stream checkpo

Re: Installation of regress.so?

Andrew Dunstan writes: > Second, we are treating the regression databases as a suitable base for > testing pg_upgrade. But they aren't designed for that, they are designed > for completely different purposes, and we're really just using them out > of laziness because they are something we happen t

Re: Installation of regress.so?

On 5/21/21 5:43 PM, Andres Freund wrote: > Hi, > > On 2021-05-20 09:16:50 -0400, Andrew Dunstan wrote: >> We certainly shouldn't want that.  But we do need it for the target >> unless we wipe out everything in the source that refers to it. > Is there a reason not to go for the wipe? I don't think

Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS

Amit Langote writes: > BTW, I think we'd need to cherry-pick f3b141c4825 (or maybe parts of > it) into v13 branch for back-patching this. I already did a fair amount of that yesterday, cf 84f5c2908 et al. But that does raise the question of how far we need to back-patch this. I gather that the wh

Proposition for columns expanding: table_name.**

Hello I some time ago asks about "Proposition for autoname columns" https://www.postgresql.org/message-id/13139.20201102170529%40yandex.ru Now I have another idea. How about table_name.**? which will be expanded to: table_name.id, table_name.name, table_name.qty etc. In my original query

Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options

On Sat, May 22, 2021 at 6:32 AM Peter Smith wrote: > I am unsure if this will lead to better code or not; Anyway, it is > something to consider - maybe you can experiment with it to see. Thanks. I think using bitmaps would help us have clean code. This is also more extensible. See pseudo code at

Re: Commitfest app vs. pgsql-docs

On Thu, May 20, 2021 at 09:39:13AM +0900, Michael Paquier wrote: > On Wed, May 19, 2021 at 03:35:00PM -0400, Tom Lane wrote: > > Magnus Hagander writes: > >> Changing that to look globally can certainly be done. It takes a bit > >> of work I think, as there are no API endpoints today that will do

Re: seawasp failing, maybe in glibc allocator

We know that seawasp was okay as of configure: using compiler=clang version 13.0.0 (https://github.com/llvm/llvm-project.git f22d3813850f9e87c5204df6844a93b8c5db7730) and not okay as of configure: using compiler=clang version 13.0.0 (https://github.com/llvm/llvm-project.git 0e8f5e4a686483