Re: proposal - log_full_scan

2021-04-17 Thread Pavel Stehule
so 17. 4. 2021 v 20:51 odesílatel Pavel Stehule napsal: > > > so 17. 4. 2021 v 20:36 odesílatel Justin Pryzby > napsal: > >> On Sat, Apr 17, 2021 at 05:22:59PM +0200, Pavel Stehule wrote: >> > so 17. 4. 2021 v 17:09 odesílatel Justin Pryzby >> napsal: >> > >> > > On Sat, Apr 17, 2021 at 04:36:5

Re: Replication slot stats misgivings

2021-04-17 Thread vignesh C
On Sun, Apr 18, 2021 at 8:43 AM Amit Kapila wrote: > > On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote: > > > > On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote: > > > > > > I wrote: > > > > The buildfarm suggests that this isn't entirely stable: > > > > https://buildfarm.postgresql.org/cgi-bin/sh

Re: Replication slot stats misgivings

2021-04-17 Thread Amit Kapila
On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote: > > On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote: > > > > I wrote: > > > The buildfarm suggests that this isn't entirely stable: > > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49 > > > https://buildf

Re: Replication slot stats misgivings

2021-04-17 Thread vignesh C
On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote: > > I wrote: > > The buildfarm suggests that this isn't entirely stable: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49 > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bichir&dt=2021-04-17%2

Re: terminate called after throwing an instance of 'std::bad_alloc'

2021-04-17 Thread Justin Pryzby
On Fri, Apr 16, 2021 at 10:18:37PM -0500, Justin Pryzby wrote: > On Fri, Apr 16, 2021 at 09:48:54PM -0500, Justin Pryzby wrote: > > On Fri, Apr 16, 2021 at 07:17:55PM -0700, Andres Freund wrote: > > > Hi, > > > > > > On 2020-12-18 17:56:07 -0600, Justin Pryzby wrote: > > > > I'd be happy to run wi

Re: Replication slot stats misgivings

2021-04-17 Thread Tom Lane
I wrote: > The buildfarm suggests that this isn't entirely stable: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49 > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bichir&dt=2021-04-17%2016%3A30%3A15 Oh, I missed that hyrax is showing the ident

Re: Replication slot stats misgivings

2021-04-17 Thread Tom Lane
Amit Kapila writes: > I have pushed the first patch. The buildfarm suggests that this isn't entirely stable: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bichir&dt=2021-04-17%2016%3A30%3A15 Eac

Re: feature request ctid cast / sql exception

2021-04-17 Thread David G. Johnston
On Saturday, April 17, 2021, Tom Lane wrote: > "David G. Johnston" writes: > > On Sat, Apr 17, 2021 at 10:58 AM Vladimír Houba ml. > > wrote: > >> Another nice feature would be a function that can be called from a sql > >> statement and would throw an exception when executed. > > > An assertion

Re: feature request ctid cast / sql exception

2021-04-17 Thread David G. Johnston
On Sat, Apr 17, 2021 at 12:58 PM Vladimír Houba ml. wrote: > I use ctid as a row identifier within a transaction in a Java application. > This doesn't present a very compelling argument since an actual user declared primary key is what is expected to be used as a row identifier. And as those are

Re: feature request ctid cast / sql exception

2021-04-17 Thread Tom Lane
"David G. Johnston" writes: > On Sat, Apr 17, 2021 at 10:58 AM Vladimír Houba ml. > wrote: >> Another nice feature would be a function that can be called from a sql >> statement and would throw an exception when executed. > An assertion-related extension in core would be welcomed. This has been

Re: pg_amcheck option to install extension

2021-04-17 Thread Mark Dilger
> On Apr 16, 2021, at 11:06 AM, Andrew Dunstan wrote: > > > Hi, > > Peter Geoghegan suggested that I have the cross version upgrade checker > run pg_amcheck on the upgraded module. This seemed to me like a good > idea, so I tried it, only to find that it refuses to run unless the > amcheck ex

Re: "could not find pathkey item to sort" for TPC-DS queries 94-96

2021-04-17 Thread Tom Lane
[ sorry for not getting to this thread till now ] Tomas Vondra writes: > 3) Shouldn't find_em_expr_usable_for_sorting_rel now mostly mimic what > prepare_sort_from_pathkeys does? That is, try to match the entries > directly first, before the new pull_vars() business? Yeah. I concur that the pro

Re: feature request ctid cast / sql exception

2021-04-17 Thread David G. Johnston
On Sat, Apr 17, 2021 at 10:58 AM Vladimír Houba ml. wrote: > I propose to implement a builtin and efficient bidirectional cast between > ctid and bigint types. > > Why? > Another nice feature would be a function that can be called from a sql > statement and would throw an exception when execut

Re: proposal - log_full_scan

2021-04-17 Thread Pavel Stehule
so 17. 4. 2021 v 20:36 odesílatel Justin Pryzby napsal: > On Sat, Apr 17, 2021 at 05:22:59PM +0200, Pavel Stehule wrote: > > so 17. 4. 2021 v 17:09 odesílatel Justin Pryzby > napsal: > > > > > On Sat, Apr 17, 2021 at 04:36:52PM +0200, Pavel Stehule wrote: > > > > today I worked on postgres's ser

Re: proposal - log_full_scan

2021-04-17 Thread Justin Pryzby
On Sat, Apr 17, 2021 at 05:22:59PM +0200, Pavel Stehule wrote: > so 17. 4. 2021 v 17:09 odesílatel Justin Pryzby napsal: > > > On Sat, Apr 17, 2021 at 04:36:52PM +0200, Pavel Stehule wrote: > > > today I worked on postgres's server used for critical service. Because the > > > application is very

More info on pg_stat_activity Wait Event Name when is DataFileRead

2021-04-17 Thread PegoraroF10
I have a Publication/Subscription. Then 10 days ago my replication just stopped, no one interesting message log on both sides. Then select from pg_stat_replication was empty and some time later, an hour or two, pg_stat_replication came back showing a record like it should. Well, it´s replicating ?

feature request ctid cast / sql exception

2021-04-17 Thread Vladimír Houba ml .
Hello, this is a feature request for a rather simple functionality. I propose to implement a builtin and efficient bidirectional cast between ctid and bigint types. Another nice feature would be a function that can be called from a sql statement and would throw an exception when executed. I kno

Re: proposal - log_full_scan

2021-04-17 Thread Pavel Stehule
so 17. 4. 2021 v 18:54 odesílatel Julien Rouhaud napsal: > On Sat, Apr 17, 2021 at 05:22:59PM +0200, Pavel Stehule wrote: > > > > The fullscan of this table needs about 30ms and has 200K rows. So > > decreasing log_min_duration to this value is very risky. > > > > [...] > > > > I use pg_stat_all

Re: proposal - log_full_scan

2021-04-17 Thread Julien Rouhaud
On Sat, Apr 17, 2021 at 05:22:59PM +0200, Pavel Stehule wrote: > > The fullscan of this table needs about 30ms and has 200K rows. So > decreasing log_min_duration to this value is very risky. > > [...] > > I use pg_stat_all_tables.seq_scan and I see seq scans there. But I need to > know the rel

Re: multi-install PostgresNode fails with older postgres versions

2021-04-17 Thread Andrew Dunstan
On 4/17/21 12:31 PM, Andrew Dunstan wrote: > On 4/12/21 10:57 AM, Jehan-Guillaume de Rorthais wrote: >> On Mon, 12 Apr 2021 09:52:24 -0400 >> Andrew Dunstan wrote: >> >>> On 4/12/21 8:59 AM, Jehan-Guillaume de Rorthais wrote: Hi, On Wed, 7 Apr 2021 20:07:41 +0200 Jehan-Guillau

Re: multi-install PostgresNode fails with older postgres versions

2021-04-17 Thread Andrew Dunstan
On 4/12/21 10:57 AM, Jehan-Guillaume de Rorthais wrote: > On Mon, 12 Apr 2021 09:52:24 -0400 > Andrew Dunstan wrote: > >> On 4/12/21 8:59 AM, Jehan-Guillaume de Rorthais wrote: >>> Hi, >>> >>> On Wed, 7 Apr 2021 20:07:41 +0200 >>> Jehan-Guillaume de Rorthais wrote: >>> [...] >> Let me know

Re: proposal - log_full_scan

2021-04-17 Thread Pavel Stehule
so 17. 4. 2021 v 17:09 odesílatel Justin Pryzby napsal: > On Sat, Apr 17, 2021 at 04:36:52PM +0200, Pavel Stehule wrote: > > today I worked on postgres's server used for critical service. Because > the > > application is very specific, we had to do final tuning on production > > server. I fix lot

Re: proposal - log_full_scan

2021-04-17 Thread Justin Pryzby
On Sat, Apr 17, 2021 at 04:36:52PM +0200, Pavel Stehule wrote: > today I worked on postgres's server used for critical service. Because the > application is very specific, we had to do final tuning on production > server. I fix lot of queries, but I am not able to detect fast queries that > does fu

proposal - log_full_scan

2021-04-17 Thread Pavel Stehule
Hi today I worked on postgres's server used for critical service. Because the application is very specific, we had to do final tuning on production server. I fix lot of queries, but I am not able to detect fast queries that does full scan of middle size tables - to 1M rows. Surely I wouldn't log a

Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows

2021-04-17 Thread Andrew Dunstan
On 4/17/21 9:04 AM, Michael Paquier wrote: > On Thu, Apr 15, 2021 at 09:12:52PM -0400, Andrew Dunstan wrote: >> It's worked on fairywren, I will double check on drongo and if all is >> well will commit. > Thanks Andrew. For the archive's sake, this has been committed as of > 3c5b068. > > While r

Re: Table refer leak in logical replication

2021-04-17 Thread Amit Kapila
On Fri, Apr 16, 2021 at 11:55 AM Michael Paquier wrote: > > On Tue, Apr 06, 2021 at 02:25:05PM +0900, Amit Langote wrote: > > Attached is v5 that I am finishing with. Much more could be done but > I don't want to do something too invasive at this stage of the game. > There are a couple of extra r

Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows

2021-04-17 Thread Michael Paquier
On Thu, Apr 15, 2021 at 09:12:52PM -0400, Andrew Dunstan wrote: > It's worked on fairywren, I will double check on drongo and if all is > well will commit. Thanks Andrew. For the archive's sake, this has been committed as of 3c5b068. While reading the commit, I have noticed that you used SEEK_SE

Re: Error when defining a set returning function

2021-04-17 Thread Esteban Zimanyi
> If you build with pgxs it should supply the appropriate compiler flags. > Alternatively, get the right settings from pg_config. In general rolling > your own is a bad idea. > I didn't know about pgxs. Many thanks Andrew for pointing this out.

Re: Bogus collation version recording in recordMultipleDependencies

2021-04-17 Thread Julien Rouhaud
On Fri, Apr 16, 2021 at 10:24:21PM -0400, Tom Lane wrote: > Thomas Munro writes: > > On Sat, Apr 17, 2021 at 10:47 AM Tom Lane wrote: > >> Although there are only a few buildfarm members complaining, I don't > >> really want to leave them red all weekend. I could either commit the > >> patch I j

Re: Bogus collation version recording in recordMultipleDependencies

2021-04-17 Thread Julien Rouhaud
On Fri, Apr 16, 2021 at 01:07:52PM -0400, Tom Lane wrote: > I wrote: > > ... or maybe not just yet. Andres' buildfarm critters seem to have > > a different opinion than my machine about what the output of > > collate.icu.utf8 ought to be. I wonder what the prevailing LANG > > setting is for them,

Re: Truncate in synchronous logical replication failed

2021-04-17 Thread Japin Li
On Sat, 17 Apr 2021 at 12:03, osumi.takami...@fujitsu.com wrote: > On Saturday, April 17, 2021 12:53 AM Japin Li >> On Fri, 16 Apr 2021 at 17:19, osumi.takami...@fujitsu.com >> wrote: >> > On Friday, April 16, 2021 5:50 PM Amit Kapila >> wrote: >> >> On Fri, Apr 16, 2021 at 12:56 PM osumi.ta

Re: Forget close an open relation in ReorderBufferProcessTXN()

2021-04-17 Thread Amit Kapila
On Sat, Apr 17, 2021 at 12:05 PM Japin Li wrote: > > On Sat, 17 Apr 2021 at 14:09, Amit Kapila wrote: > > On Thu, Apr 15, 2021 at 4:53 PM Amit Kapila wrote: > >> > >> On Thu, Apr 15, 2021 at 4:00 PM Japin Li wrote: > >> > > >> > The RelationIdGetRelation() comment says: > >> > > >> > > Caller s