On Mon, Mar 15, 2021 at 11:34 AM Justin Pryzby wrote:
>
> On Mon, Mar 15, 2021 at 11:25:26AM +0530, Amit Kapila wrote:
> > On Fri, Mar 12, 2021 at 3:01 PM houzj.f...@fujitsu.com wrote:
> > >
> > > Attaching new version patch with this change.
> >
> > Thanks, the patch looks good to me. I have made
On Mon, Mar 15, 2021 at 10:39 AM Thomas Munro wrote:
>
> On Mon, Jan 4, 2021 at 9:05 PM Luc Vlaming wrote:
>
> While reading some back history, I saw that commit e9baa5e9 introduced
> parallelism for CREATE M V, but REFRESH was ripped out of the original
> patch by Robert, who said:
>
> > The pro
On Wed, Feb 24, 2021 at 02:35:51PM +, gkokola...@pm.me wrote:
> Now with attachment. Apologies for the chatter.
The patch has no documentation for the two new functions, so it is a
bit hard to understand what is the value brought here, and what is the
goal wanted just by reading the patch, exc
On Tue, Mar 9, 2021 at 7:27 AM Peter Eisentraut
wrote:
>
>
> I see. The problem is that we don't have serialization and
> deserialization support for most utility statements. I think I'll need
> to add that eventually. For now, I have added code to prevent utility
> statements. I think it's st
On Mon, Mar 15, 2021 at 11:25:26AM +0530, Amit Kapila wrote:
> On Fri, Mar 12, 2021 at 3:01 PM houzj.f...@fujitsu.com wrote:
> >
> > Attaching new version patch with this change.
>
> Thanks, the patch looks good to me. I have made some minor cosmetic
> changes in the attached. I am planning to pus
At Sun, 14 Mar 2021 17:59:59 +0900, Michael Paquier wrote
in
> On Thu, Mar 04, 2021 at 05:10:36PM +0900, Kyotaro Horiguchi wrote:
> > read_local_xlog_page is *designed* to maintain ThisTimeLineID.
> > Currently it doesn't seem utilized but I think it's sufficiently
> > reasonable that the functi
On Fri, Mar 12, 2021 at 3:01 PM houzj.f...@fujitsu.com
wrote:
>
> Attaching new version patch with this change.
>
Thanks, the patch looks good to me. I have made some minor cosmetic
changes in the attached. I am planning to push this by tomorrow unless
you or others have any more comments or sugg
On 2021-03-07 19:16, Bharath Rupireddy wrote:
On Fri, Feb 5, 2021 at 5:15 PM Bharath Rupireddy
wrote:
pg_terminate_backend and pg_cancel_backend with postmaster PID produce
"PID is not a PostgresSQL server process" warning [1], which
basically implies that the postmaster is not a PostgreS
On Mon, Mar 15, 2021 at 6:14 PM Bharath Rupireddy
wrote:
> On Mon, Mar 15, 2021 at 9:54 AM Thomas Munro wrote:
> > While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I
> > noticed that select_parallel.sql and write_parallel.sql believe that
> > (1) the tests are supposed to work wi
On Mon, Mar 15, 2021 at 9:54 AM Thomas Munro wrote:
> While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I
> noticed that select_parallel.sql and write_parallel.sql believe that
> (1) the tests are supposed to work with serializable as a default
> isolation level, and (2) parallelis
On Mon, Jan 4, 2021 at 9:05 PM Luc Vlaming wrote:
> The new status of this patch is: Ready for Committer
I think the comments above this might as well be removed, because they
aren't very convincing:
+-- Allow parallel planning of the underlying query for refresh materialized
+-- view. We can be
On 2021/03/15 12:27, Bharath Rupireddy wrote:
On Sun, Mar 7, 2021 at 2:39 PM Bharath Rupireddy
wrote:
Attaching v7 patch for further review.
Attaching v8 patch after rebasing on to the latest master.
Thanks for rebasing the patch!
- WAIT_EVENT_XACT_GROUP_UPDATE
+ WAIT_EVENT_
On Tue, Mar 09, 2021 at 02:33:47PM -0500, Joe Conway wrote:
> My vote would be reject using fastpath for procedures in all relevant
> branches.
> If someday someone cares enough to make it work, it is a new feature for a new
> major release.
FWIW, my vote would go for issuing an error if attempti
On Sun, Feb 21, 2021 at 08:14:45AM +0900, Michael Paquier wrote:
> Okay, that sounds fine to me. Thanks for confirming.
Guillaume, it has been a couple of weeks since your last update. Are
you planning to send a new version of the patch?
--
Michael
signature.asc
Description: PGP signature
On Wed, Mar 10, 2021 at 09:35:10AM +0100, Matthias van de Meent wrote:
> There are examples in which pg_stat_progress_* -views report
> inaccurate data. I think it is fairly reasonable to at least validate
> some part of the progress reporting, as it is one of the few methods
> for administrators t
po 15. 3. 2021 v 4:54 odesílatel Julien Rouhaud napsal:
> On Sun, Mar 14, 2021 at 08:41:15PM +0100, Pavel Stehule wrote:
> >
> > My English is good enough for taking beer everywhere in the world :) . Ti
> > is not good, but a lot of people who don't understand to English
> understand
> > my simpl
po 15. 3. 2021 v 3:48 odesílatel Thomas Munro
napsal:
> On Thu, Mar 11, 2021 at 2:06 AM David Steele wrote:
> > On 12/1/20 3:38 AM, Jürgen Purtz wrote:
> > > OK. Patch attached.
>
> +Queries which access multiple tables (including repeats) at once are
> called
>
> I'd write "Queries that" he
Hi,
While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I
noticed that select_parallel.sql and write_parallel.sql believe that
(1) the tests are supposed to work with serializable as a default
isolation level, and (2) parallelism would be inhibited by that, so
they'd better use somet
On Sun, Mar 14, 2021 at 08:41:15PM +0100, Pavel Stehule wrote:
>
> My English is good enough for taking beer everywhere in the world :) . Ti
> is not good, but a lot of people who don't understand to English understand
> my simplified fork of English language.
I have the same problem. We can tal
Please find attached v7, with the following changes:
- all typo reported by Michael and Mark are fixed
- REINDEX (OUTDATED) INDEX will now ignore the index if it doesn't have any
outdated dependency. Partitioned index are correctly handled.
- REINDEX (OUTDATED, VERBOSE) will now inform caller o
On Sat, Mar 13, 2021 at 7:00 AM Japin Li wrote:
>
> On Mon, 08 Mar 2021 at 12:28, Bharath Rupireddy
> wrote:
> > On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu wrote:
> >> Hi,
> >>
> >> +* EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
> >> +* WITH NO DATA is weird.
>
On Sun, Mar 7, 2021 at 2:39 PM Bharath Rupireddy
wrote:
> Attaching v7 patch for further review.
Attaching v8 patch after rebasing on to the latest master.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
v8-0001-pg_terminate_backend-with-wait-and-timeout.patch
Descri
On Mon, Sep 21, 2020 at 1:11 PM Andres Freund wrote:
> > I'm not sure I really understand how that's happening, because surely
> > HOT chains and non-HOT chains are pruned by the same code, but it
> > doesn't sound good.
>
> Not necessarily, unfortunately:
>
> case HEAPTUPLE_DEAD:
> So if
On Fri, Mar 12, 2021 at 2:09 PM Peter Smith wrote:
>
> Please find attached the latest patch set v58*
>
In this patch-series, I see a problem with synchronous replication
when GUC 'synchronous_standby_names' is configured to use subscriber.
This will allow Prepares and Commits to wait for the sub
On Thu, Mar 11, 2021 at 2:06 AM David Steele wrote:
> On 12/1/20 3:38 AM, Jürgen Purtz wrote:
> > OK. Patch attached.
+Queries which access multiple tables (including repeats) at once are called
I'd write "Queries that" here (that's is a transatlantic difference in
usage; I try to proofread
On Sun, Mar 14, 2021 at 6:54 PM Avinash Kumar
wrote:
> Following may be helpful to understand what I meant.
>
> I have renamed the table and index names before adding it here.
It should be possible to run amcheck on your database, which will
detect corrupt posting list tuples on Postgres 13. It's
On Thu, Mar 11, 2021 at 8:31 AM Robert Haas wrote:
> But even if not, I'm not sure this
> helps much with the situation you're concerned about, which involves
> non-HOT tuples.
Attached is a POC-quality revision of Masahiko's
skip_index_vacuum.patch [1]. There is an improved design for skipping
i
On Wed, Mar 10, 2021 at 1:31 AM Michael Paquier wrote:
> On Tue, Mar 09, 2021 at 02:28:43AM +0100, Tomas Vondra wrote:
> > Let's move this patch forward. Based on the responses, I agree the
> > default behavior should be to remove the temp files, and I think we
> > should have the GUC (on the off
Hi,
On Sun, Mar 14, 2021 at 10:17 PM Thomas Munro
wrote:
> [Dropping pgsql-general@ from the CC, because cross-posting triggers
> moderation; sorry I didn't notice that on my first reply]
>
> On Mon, Mar 15, 2021 at 2:05 PM Avinash Kumar
> wrote:
> > On Sun, Mar 14, 2021 at 10:01 PM Avinash Kum
On 2021/03/11 21:29, Masahiro Ikeda wrote:
On 2021-03-11 11:52, Fujii Masao wrote:
On 2021/03/11 9:38, Masahiro Ikeda wrote:
On 2021-03-10 17:08, Fujii Masao wrote:
IIUC the stats collector basically exits after checkpointer and
walwriter exit.
But there seems no guarantee that the stats coll
On 2021-03-12 12:39, Fujii Masao wrote:
On 2021/03/11 21:29, Masahiro Ikeda wrote:
In addition, I rebased the patch for WAL receiver.
(v17-0003-Makes-the-wal-receiver-report-WAL-statistics.patch)
Thanks! Will review this later.
Thanks a lot!
I read through the 0003 patch. Here are some com
On Fri, Nov 6, 2020 at 10:56 AM Thomas Munro wrote:
> On Wed, Nov 4, 2020 at 9:11 PM Michael Paquier wrote:
> > On Wed, Nov 04, 2020 at 08:44:15AM +0100, Juan José Santamaría Flecha wrote:
> > > We could create a static table with the conversion based on what was
> > > discussed for commit a1691
[Dropping pgsql-general@ from the CC, because cross-posting triggers
moderation; sorry I didn't notice that on my first reply]
On Mon, Mar 15, 2021 at 2:05 PM Avinash Kumar
wrote:
> On Sun, Mar 14, 2021 at 10:01 PM Avinash Kumar
> wrote:
>> Also the datatype is bigint
Ok. Collation changes ar
@cfbot: Resending without duplicate patches
>From 581884bb12f666a1eb6a7f4bd769b1edeba4c563 Mon Sep 17 00:00:00 2001
From: Andrey Borodin
Date: Sat, 27 Feb 2021 09:03:50 +0500
Subject: [PATCH 01/10] Allow alternate compression methods for wal_compression
TODO: bump XLOG_PAGE_MAGIC
---
doc/src/sgm
Hi Mark,
On Sun, Mar 14, 2021 at 05:01:20PM -0700, Mark Dilger wrote:
>
> > On Mar 14, 2021, at 12:10 AM, Julien Rouhaud wrote:
>
> I'm coming to this patch quite late, perhaps too late to change design
> decision in time for version 14.
Thanks for lookint at it!
> + if (outdated && PQse
On Mon, Mar 15, 2021 at 08:56:00AM +0900, Michael Paquier wrote:
> On Sun, Mar 14, 2021 at 10:57:37PM +0800, Julien Rouhaud wrote:
> >
> > Is there really a use case for reindexing a specific index and at the same
> > time
> > asking for possibly ignoring it? I think we should just forbid REINDE
On Sat, Mar 13, 2021 at 08:48:33PM +0500, Andrey Borodin wrote:
> > 13 марта 2021 г., в 06:28, Justin Pryzby написал(а):
> > Updated patch with a minor fix to configure.ac to avoid warnings on OSX.
> > And 2ndary patches from another thread to allow passing recovery tests.
> > Renamed to WAL_COMPR
Hi ,
In one of the environments, using pg_upgrade with hard links, PostgreSQL 12
has been upgraded to PostgreSQL 13.1. The OS was Ubuntu 16.04.7 LTS (Xenial
Xerus). pg_repack was used to rebuild all the tables across the database
right after the upgrade to PG 13.
A new server with Ubuntu 20.04.1
On Sun, Mar 14, 2021 at 5:03 PM Zhihong Yu wrote:
> For 0001-Add-bsearch-and-unique-templates-to-sort_template.h.patch :
>
> + * Remove duplicates from an array. Return the new size.
> + */
> +ST_SCOPE size_t
> +ST_UNIQUE(ST_ELEMENT_TYPE *array,
>
> The array is supposed to be sorted, right ?
> T
> On Mar 14, 2021, at 12:10 AM, Julien Rouhaud wrote:
>
> v6 attached, rebase only due to conflict with recent commit.
Hi Julien,
I'm coming to this patch quite late, perhaps too late to change design decision
in time for version 14.
+ if (outdated && PQserverVersion(conn) < 14)
On Sun, Mar 14, 2021 at 10:57:37PM +0800, Julien Rouhaud wrote:
> On Sun, Mar 14, 2021 at 08:54:11PM +0900, Michael Paquier wrote:
>> In ReindexRelationConcurrently(), there is no filtering done for the
>> index themselves. The operation is only done on the list of indexes
>> fetched from the pare
On Mon, Mar 15, 2021 at 11:52 AM Thomas Munro wrote:
> Time being of the essence, here is the patch I posted last year, this
> time with a GUC and some docs. You can set sync_after_crash to
> "fsync" (default) or "syncfs" if you have it.
Cfbot told me to add HAVE_SYNCFS to Solution.pm, and I fix
On Wed, Sep 9, 2020 at 7:33 AM Peter Geoghegan wrote:
> On Tue, Sep 8, 2020 at 1:23 AM Masahiko Sawada
> wrote:
> > > > I wonder if you would also see a speed-up with a bsearch() replacement
> > > > that is inlineable, so it can inline the comparator (instead of
> > > > calling it through a funct
On Thu, Mar 11, 2021 at 2:32 PM Thomas Munro wrote:
> On Thu, Mar 11, 2021 at 2:25 PM Tom Lane wrote:
> > Trolling the net, I found a newer-looking version of the man page,
> > and behold it says
> >
> >In mainline kernel versions prior to 5.8, syncfs() will fail only
> >when pass
A Case For Inlining Immediate Referential Integrity Checks
--
The following is an overview of how Postgres currently implemented
referential integrity, the some problems with that architecture, attempted
solutions for those problems, and a su
Hi
so 13. 3. 2021 v 12:48 odesílatel Julien Rouhaud
napsal:
> On Sat, Mar 13, 2021 at 12:10:29PM +0100, Pavel Stehule wrote:
> >
> > so 13. 3. 2021 v 9:53 odesílatel Julien Rouhaud
> napsal:
> > >
> > > I don't think that it makes sense to have multiple occurences of this
> > > command,
> > > a
On Sat, Mar 13, 2021 at 7:23 PM Peter Geoghegan wrote:
> In other words, I am not worried about debt, exactly. Debt is normal
> in moderation. Healthy, even. I am worried about bankruptcy, perhaps
> following a rare and extreme event. It's okay to be imprecise, but all
> of the problems must be su
On Thu, Feb 11, 2021 at 6:25 PM Masahiko Sawada
wrote:
> On Fri, Feb 5, 2021 at 2:45 PM Masahiko Sawada
> wrote:
> >
> > On Tue, Feb 2, 2021 at 5:18 PM Fujii Masao
> wrote:
> > >
> > >
> > >
> > > On 2021/01/27 14:08, Masahiko Sawada wrote:
> > > > On Wed, Jan 27, 2021 at 10:29 AM Fujii Masao
>
Hello Alvaro,
+ /*-
+* Apply 4 rounds of bijective transformations using key updated
+* at each stage:
+*
+* (1) whiten: partial xors on overlapping power-of-2 subsets
+* for instance with v in 0 .. 14 (i.e. with size == 15):
+*
Hello hackers,
22.11.2020 18:59, Alexander Lakhin wrote:
> 19.11.2020 01:28, Tom Lane wrote:
>
>> Hmm, that is an interesting question isn't it. Here's a search going
>> back a full year. There are a few in v12 --- interestingly, all on
>> the statistics file, none from pg_ctl --- and none in v1
On Sun, Mar 14, 2021 at 08:54:11PM +0900, Michael Paquier wrote:
> On Sun, Mar 14, 2021 at 04:10:07PM +0800, Julien Rouhaud wrote:
>
> + booloutdated_filter = false;
> Wouldn't it be better to rename that "outdated" instead for
> consistency with the other options?
I agree.
> In Reinde
On 2021-Mar-14, Fabien COELHO wrote:
> + /*-
> + * Apply 4 rounds of bijective transformations using key updated
> + * at each stage:
> + *
> + * (1) whiten: partial xors on overlapping power-of-2 subsets
> + * for instance with v in 0 .. 14 (i.e. with size ==
> Ok. ISTM that the option should be triggered as soon as it is
> available, but you do as you wish.
Can you elaborate why you think that using COPY FREEZE before 14 is
beneficial? Or do you want to standardize to use COPY FREEZE?
> I'm unsure how this could happen ever. The benefit of not caring
On Wed, Feb 24, 2021 at 11:51:36AM +0900, Michael Paquier wrote:
> For the file name, using something like pseudo_handler.c or similar
> would be fine, I guess. However, if we go down the path of one AM per
> relkind for the slot callback, then why not just calling the AMs
> foreign_table_am, view
On Sun, Mar 14, 2021 at 04:10:07PM +0800, Julien Rouhaud wrote:
> v6 attached, rebase only due to conflict with recent commit.
I have read through the patch.
+ booloutdated_filter = false;
Wouldn't it be better to rename that "outdated" instead for
consistency with the other options?
I
See attached v22.
v23:
- replaces remaining occurences of "pr_perm" in the documentation
- removes duplicated includes
--
Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
index 299d93b241..9f49a6a78d 100644
--- a/doc/src/sgml/ref/pgbench.sgml
+++ b/doc/src/s
Hello Peter,
This reply was two months ago, and nothing has happened, so I have
marked the patch as RwF.
Given the ongoing work on returning multiple result sets from stored
procedures[0], I went to dust off this patch.
Based on the feedback, I put back the titular SHOW_ALL_RESULTS option,
On Thu, Mar 04, 2021 at 05:10:36PM +0900, Kyotaro Horiguchi wrote:
> read_local_xlog_page is *designed* to maintain ThisTimeLineID.
> Currently it doesn't seem utilized but I think it's sufficiently
> reasonable that the function maintains ThisTimeLineID.
I don't quite follow this line of thoughts
Hello,
After giving it some thought, ISTM that there could also be a
performance improvement with copy freeze from older version, so I'd
suggest to add it after 9.3 where the option was added, i.e. 90300.
You misunderstand about COPY FREEZE. Pre-13 COPY FREEZE does not
contribute a performan
On Wed, Mar 03, 2021 at 01:56:59PM +0800, Julien Rouhaud wrote:
>
> Please find attached v5 which address all previous comments:
>
> - consistently use "outdated"
> - use REINDEX (OUTDATED) grammar (with a new unreserved OUTDATED keyword)
> - new --outdated option to reindexdb
> - expose a new "p
Recent conflict, thanks to cfbot. v18 attached.
>From fa94eba58ee0ca098cfde0d17de72dc230ee471c Mon Sep 17 00:00:00 2001
From: Julien Rouhaud
Date: Wed, 14 Oct 2020 02:11:37 +0800
Subject: [PATCH v18 1/3] Move pg_stat_statements query jumbling to core.
A new compute_queryid GUC is also added, to
61 matches
Mail list logo
