On Thu, Feb 25, 2021 at 12:42 PM Kyotaro Horiguchi
wrote:
>
> Thanks for your patience and sorry for having annoyed you.
Thank you very much for your review and inputs.
> The latest version applies (almost) cleanly to the current master and
> works fine.
> I don't have further comment on this.
>
At Thu, 25 Feb 2021 09:49:15 +0530, Dilip Kumar wrote
in
> On Thu, Feb 25, 2021 at 6:52 AM Kyotaro Horiguchi
> wrote:
>
> > Recently we have mildly changed to the direction to utilize the
> > compiler warning about enum coverage in switch struct. (Maybe we need
> > another compiler option that
Thank you for sharing
Best regards
Shenhao Wang
-Original Message-
From: Michael Paquier
Sent: Thursday, February 25, 2021 2:22 PM
To: Wang, Shenhao/王 申豪
Cc: Tom Lane ; Juan José Santamaría Flecha
; Emil Iggland ; PostgreSQL
Hackers
Subject: Re: BUG #15858: could not stat file - ove
On Thu, Feb 25, 2021 at 06:07:06AM +, wangsh.f...@fujitsu.com wrote:
> I noticed that this modification only commit into master branch,
> there is still have a problem on 12.6 or 13.2 on Windows.
>
> Do you have a plan to backpatch this commit into REL_12_STABLE or
> REL_13_STABLE ?
The cha
"wangsh.f...@fujitsu.com" writes:
> Do you have a plan to backpatch this commit into REL_12_STABLE or
> REL_13_STABLE ?
https://www.postgresql.org/message-id/ycszix2a2ilsv...@paquier.xyz
regards, tom lane
Hi,
I noticed that this modification only commit into master branch,
there is still have a problem on 12.6 or 13.2 on Windows.
Do you have a plan to backpatch this commit into REL_12_STABLE or REL_13_STABLE
?
The commit:
https://github.com/postgres/postgres/commit/bed90759fcbcd72d4d06969eebab8
On Wed, Feb 24, 2021 at 8:13 PM Justin Pryzby wrote:
> I think 8e12f4a25 wasn't quite aggressive enough in its changes, and I had
> another patch laying around. I rebased and came up with this.
See my remarks/questions about vacuum_cleanup_index_scale_factor
addressed to Masahiko from a little e
On Wed, Feb 24, 2021 at 5:55 PM Amit Kapila wrote:
>
> On Wed, Feb 24, 2021 at 12:47 PM Masahiko Sawada
> wrote:
> >
> > On Fri, Feb 12, 2021 at 2:49 PM Amit Kapila wrote:
> > >
> > >
> > > Thanks, I have pushed the fix and the latest run of 'thorntail' has
> > > passed.
> >
> > I got the foll
On Mon, Feb 22, 2021 at 2:54 PM Peter Geoghegan wrote:
> Good point. I think that the structure should make the page deletion
> triggering condition have only secondary importance -- it is only
> described at all to be complete and exhaustive. The
> vacuum_cleanup_index_scale_factor-related thresh
On Thu, Feb 25, 2021 at 6:52 AM Kyotaro Horiguchi
wrote:
> Recently we have mildly changed to the direction to utilize the
> compiler warning about enum coverage in switch struct. (Maybe we need
> another compiler option that enables that check for switch'es with the
> default case, though.) In t
On Mon, Feb 22, 2021 at 02:54:54PM -0800, Peter Geoghegan wrote:
> On Mon, Feb 22, 2021 at 4:21 AM Masahiko Sawada wrote:
> > The 0001 patch looks good to me. In the documentation, I think we need
> > to update the following paragraph in the description of
> > vacuum_cleanup_index_scale_factor:
>
> > It is quite possible what you are saying is correct but I feel that is
> > not this patch's fault. So, won't it better to discuss this in a
> > separate thread?
> >
> > Good use case but again, I think this can be done as a separate patch.
>
> Agreed.
> I think even the current patch offers gr
On Sat, Feb 13, 2021 at 12:18 PM Masahiko Sawada wrote:
>
> On Thu, Jan 28, 2021 at 1:41 AM Tomas Vondra
> wrote:
> >
> > On 1/25/21 3:56 AM, Masahiko Sawada wrote:
> > >>
> > >> ...
> > >>
> > >> On 1/21/21 3:17 AM, Masahiko Sawada wrote:
> > >>> ...
> > >>>
> > >>> While looking at the two meth
At Wed, 24 Feb 2021 15:25:57 +0530, Dilip Kumar wrote
in
> On Wed, Feb 24, 2021 at 2:26 PM Kyotaro Horiguchi
> wrote:
> > I should have took the meaning of "confirm" wrongly. I took that as
> > "somehow determine if the recovery is to be paused". If that reading
> > is completely wrong, I don
On Wed, Feb 24, 2021 at 09:14:19AM +0100, Michael J. Baars wrote:
> I've written this function to insert several rows at once, and noticed a
> certain postgresql overhead as you can see from the log file. A lot more data
> than the
> user data is actually sent over the net. This has a certain not
Sorry for sending again.
> * Only an SQL literal or a host variable is acceptable.
> I understand we should support other notations, but now hacking.
I tried to add support notation. Now unquoted string can be used.
In the flex file, IPv6 string is parsed with the square bracket, it means
the f
I wrote:
> On my machine, the combination of these two ideas reduces the
> runtime of the example above from ~150 seconds to ~53 seconds,
> or nearly 3x better. I see something like a 2% improvement on
> Joel's test corpus, which might just be noise. So this isn't
> any sort of universal panacea,
> That makes sense, although the exact number seems precisely tailored to your
> use case. 2% gives 164 bytes of slack and doesn't seem too large. Updated
> patch attached.
Yeah, I tried picking it as conservative as I could, but 2% is obviously great
too. :-) I can't think of any large drawba
Hi,
On 2021-02-24 21:41:16 +0100, Dmitry Dolgov wrote:
> I'm curious about control knobs for this feature, it's somewhat related
> to the stats questions also discussed in this thread. I guess most
> important of those are max_aio_in_flight, io_max_concurrency etc, and
> they're going to be a hard
Hi,
On 2021-02-24 14:59:19 -0500, Greg Stark wrote:
> I guess what I would be looking for in stats would be a way to tell
> what the bandwidth, latency, and queue depth is. Ideally one day
> broken down by relation/index and pg_stat_statement record.
I think doing it at that granularity will like
On Wed, Feb 24, 2021 at 4:52 PM Floris Van Nee
wrote:
> I also understand the temptation to define it based on the relation's
fill factor, as you did in the patch. However, upon some further thought I
wonder if that's useful? A relation with a higher fill factor will have a
lower 'saveFreeSpace'
Hi,
On 2021-02-24 21:15:14 +0500, Alexey Lesovsky wrote:
> pg_stat_aios.
> In general, this stat is a set of text values, and at the same time it looks
> GAUGE-like (similar to pg_stat_activity or pg_locks), and is only relevant
> for the moment when the user is looking at it. I think it would be
> In this case, the vast majority has between 8050-8099 bytes free according to
> the FSM. That means that, for this particular case, for a fillfactor of 10,
> we’d need to subtract ~120 bytes or so in order to properly recycle the pages.
Also, I think this "fudge" factor would need to be define
Hey, all,
I went ahead and made a patch for introducing a new GUC variable,
max_replication_origins, to replace the awkward re-use of
max_replication_slots.
I'm mostly indifferent whether a new GUC variable is necessary, or
simply just updating the existing documentation (the first patch I
sent)
> On Tue, Feb 23, 2021 at 02:03:44AM -0800, Andres Freund wrote:
>
> over the last ~year I spent a lot of time trying to figure out how we could
> add AIO (asynchronous IO) and DIO (direct IO) support to postgres. While
> there's still a *lot* of open questions, I think I now have a decent handle o
Hi John,
> One idea is to take your -50 idea and make it more general and safe, by
> scaling the fudge factor based on fillfactor, such that if fillfactor is less
> than 100, the requested freespace is a bit smaller than the max. It's still a
> bit of a hack, though. I've attached a draft of
I guess what I would be looking for in stats would be a way to tell
what the bandwidth, latency, and queue depth is. Ideally one day
broken down by relation/index and pg_stat_statement record.
I think seeing the actual in flight async requests in a connection is
probably not going to be very usefu
On Wed, Feb 24, 2021 at 10:44 AM Floris Van Nee
wrote:
>
> The problem here is two-folded: for any non-HOT update of a tuple that’s
larger than the size of the fillfactor, the fsm will not be used, but
instead a new page will be chosen.
I confirmed this not only non-HOT updates, but regular inser
Sorry, I don't have checkout the hash codebase for the patch.
Compiled OK now.
Best regards
On Tue, Feb 23, 2021 at 12:38 PM Mark Dilger
wrote:
> This is changed in v40 as you propose to exit on FATAL and PANIC level errors
> and on error to send a query. On lesser errors (which includes all
> corruption reports about btrees and some heap corruption related errors), the
> slot's conn
On Thu, Feb 25, 2021 at 1:22 AM Julien Rouhaud wrote:
> #define reindexHasFilter(x)((x & REINDEXOPT_COLL_NOT_CURRENT) != 0)
It's better to use "(x) & ..." in macros to avoid weird operator
precedence problems in future code.
It seems like there are several different names for similar thi
Hello,
The PostGIS project needed this from time to time. Would be great if
reindex by opclass can be made possible.
We changed the semantics of btree at least twice (in 2.4 and 3.0), fixed
some ND mixed-dimension indexes semantics in 3.0, fixed hash index on 32
bit arch in 3.0.
On Thu, Dec 3, 2
I wrote:
> I've also decided after reflection that the patch should indeed
> create a named "word" character class. That's allowed per POSIX,
> and it simplifies some aspects of the documentation, since we can
> rely on referencing the class instead of repeating ourselves.
> The attached 0001 v2 d
Alvaro Herrera writes:
> On 2021-Feb-23, Tom Lane wrote:
>> * Create infrastructure to allow treating \w as a character class
>> in its own right. (I did not expose [[:word:]] as a class name,
>> though it would be a little more symmetric to do so; should we?)
> Apparently [:word:] is a GNU exte
"Joel Jacobson" writes:
> On Tue, Feb 23, 2021, at 18:15, Tom Lane wrote:
>> Perl and Javascript believe that \W and \D should match newlines
>> regardless of their 's' flag, so there's a case for changing
>> \W and \D to match newline regardless of our 'n' flag. 0002
>> attached is the quite tri
Hi,
Trying to apply the last patch (global_temporary_table_v42-pg14.patch) to the
code cloned from github, ending with this error:
usr/bin/ld: catalog/storage_gtt.o: in function `up_gtt_relstats':
storage_gtt.c:(.text+0x1276): undefined reference to `ReadNewTransactionId'
collect2: error: ld ret
Hi,
On Thu, Feb 25, 2021 at 12:11 AM mariakatosvich
wrote:
>
> From what I heard on this topic, the goal is to reduce
> the amount of time necessary to reindex a system so as REINDEX only
> works on indexes whose dependent collation versions are not known or
> works on indexes in need of a collat
On 2021-Feb-23, Tom Lane wrote:
> * Create infrastructure to allow treating \w as a character class
> in its own right. (I did not expose [[:word:]] as a class name,
> though it would be a little more symmetric to do so; should we?)
Apparently [:word:] is a GNU extension (or at least a "bash-spe
Hi,
Thank you for the amazing and great work.
On 23.02.2021 15:03, Andres Freund wrote:
## Stats
There are two new views: pg_stat_aios showing AIOs that are currently
in-progress, pg_stat_aio_backends showing per-backend statistics about AIO.
As a DBA I would like to propose a few amendments
>From what I heard on this topic, the goal is to reduce
the amount of time necessary to reindex a system so as REINDEX only
works on indexes whose dependent collation versions are not known or
works on indexes in need of a collation refresh (like a reindexdb
--all --collation -j $jobs).
--
Sent
On Wed, Feb 24, 2021, at 16:23, I wrote:
>I will hopefully be able to provide a similar analysis of \D soon,
>but wanted to send this in the meantime.
CREATE TABLE "\D" AS SELECT * FROM regex_tests WHERE processed AND error_pg IS
NULL AND pattern LIKE '%\\D%';
SELECT 67558
CREATE TABLE "\D diff"
On 2/19/21 10:13 AM, Jan Wieck wrote:
Give the function, that postmaster is calling to accept a connection
when a server_fd is ready, a return code that it can use to tell
postmaster "forget about it, don't fork or do anything else with it".
This function is normally calling StreamConnection() b
Hi,
On Tue, Feb 23, 2021, at 18:15, Tom Lane wrote:
>0001 preserves the current behavior of these constructs with
>respect to newlines, namely that:
>
>\s matches newline, with or without 'n' flag
>\S doesn't match newline, with or without 'n' flag
>\w doesn't match newline, with or without 'n' fl
On Wed, Feb 24, 2021 at 3:25 PM Dilip Kumar wrote:
>
> > > > The reason for the checkpoint is to move to "paused" state in a
> > > > reasonable time. I think we need to mention that reason rather than
> > > > what is done here.
> > >
> > > I will do that.
I have fixed this.
> > > >
> > > > +
Hi hackers,
Recently we found a table that was slowly, but consistently increasing in size.
The table has a low fill-factor set and was updated very frequently. As
expected, almost all updates are HOT updates, but for some of the non-HOT
updates it always wanted to use a new page, rather than r
‐‐‐ Original Message ‐‐‐
On Wednesday, February 24, 2021 3:34 PM, wrote:
>
>
> ‐‐‐ Original Message ‐‐‐
> On Friday, February 19, 2021 4:57 PM, gkokola...@pm.me wrote:
>
> > ‐‐‐ Original Message ‐‐‐
> > On Monday, February 1, 2021 1:18 PM, Masahiko Sawada sawada.m...@
‐‐‐ Original Message ‐‐‐
On Friday, February 19, 2021 4:57 PM, wrote:
>
>
> ‐‐‐ Original Message ‐‐‐
> On Monday, February 1, 2021 1:18 PM, Masahiko Sawada sawada.m...@gmail.com
> wrote:
>
> > On Thu, Nov 12, 2020 at 2:54 AM Soumyadeep Chakraborty
> > soumyadeep2...@gmail.c
On Thu, Feb 25, 2021 at 12:19 AM Amit Kapila wrote:
>
> On Wed, Feb 24, 2021 at 6:21 PM Greg Nancarrow wrote:
> >
> > On Wed, Feb 24, 2021 at 10:38 PM Amit Kapila
> > wrote:
> > > >
> > > > Thanks, I'll try it.
> > > > I did, however, notice a few concerns with your suggested alternative
> > >
Hi,
On Wed, Feb 24, 2021 at 8:21 PM talk to ben wrote:
>
> The documentation describes how a return code > 125 on the restore_command
> would prevent the server from starting [1] :
>
> "
> It is important that the command return nonzero exit status on failure. The
> command will be called reque
On Wed, Feb 24, 2021 at 6:21 PM Greg Nancarrow wrote:
>
> On Wed, Feb 24, 2021 at 10:38 PM Amit Kapila wrote:
> > >
> > > Thanks, I'll try it.
> > > I did, however, notice a few concerns with your suggested alternative fix:
> > > - It is not restricted to INSERT (as current fix is).
> > >
> >
> >
On Wed, Feb 24, 2021 at 6:12 PM Drouvot, Bertrand wrote:
> On 2/24/21 9:12 AM, Amit Langote wrote:
> > I've attached a patch with my suggested fixes and also test cases.
> > Please take a look.
>
> I had a look and it looks good to me. Also the new regression tests are
> doing it right and are seg
On Wed, Feb 24, 2021 at 10:38 PM Amit Kapila wrote:
> >
> > Thanks, I'll try it.
> > I did, however, notice a few concerns with your suggested alternative fix:
> > - It is not restricted to INSERT (as current fix is).
> >
>
> So what? The Select also has a similar problem.
>
Yes, but you're poten
On Wed, Feb 24, 2021 at 12:47 PM Masahiko Sawada wrote:
>
> On Fri, Feb 12, 2021 at 2:49 PM Amit Kapila wrote:
> >
> >
> > Thanks, I have pushed the fix and the latest run of 'thorntail' has passed.
>
> I got the following WARNING message from a logical replication apply worker:
>
> WARNING: rel
Hi,
Thanks for the review!
On Mon, Feb 8, 2021 at 12:14 AM Zhihong Yu wrote:
>
> Hi,
> For index_has_deprecated_collation(),
>
> + object.objectSubId = 0;
>
> The objectSubId field is not accessed by
> do_check_index_has_deprecated_collation(). Does it need to be assigned ?
Indeed it's not s
Hi,
The documentation describes how a return code > 125 on the restore_command
would prevent the server from starting [1] :
"
It is important that the command return nonzero exit status on failure. The
command *will* be called requesting files that are not present in the
archive; it must return n
On Wed, Feb 24, 2021 at 4:30 PM Greg Nancarrow wrote:
>
> On Wed, Feb 24, 2021 at 8:39 PM Amit Kapila wrote:
> >
> > On Fri, Feb 19, 2021 at 6:56 AM Greg Nancarrow wrote:
> > >
> > > Posting a new version of the patches, with the following updates:
> > >
> >
> > I am not happy with the below cod
On Wed, Feb 24, 2021 at 4:48 PM Ajin Cherian wrote:
> I plan to split this into two patches next. But do review and let me
> know if you have any comments.
Attaching an updated patch-set with the changes for
snapshot_was_exported_at_lsn separated out from the changes for the
APIs pg_create_logic
On Wed, Feb 24, 2021 at 8:39 PM Amit Kapila wrote:
>
> On Fri, Feb 19, 2021 at 6:56 AM Greg Nancarrow wrote:
> >
> > Posting a new version of the patches, with the following updates:
> >
>
> I am not happy with the below code changes, I think we need a better
> way to deal with this.
>
> @@ -313,
Hi Kirk san,
Thank you for your review. I update patch to v21.
> -Original Message-
> From: Jamison, Kirk/ジャミソン カーク
> Sent: Wednesday, February 24, 2021 1:04 PM
> (1) Doc: PQtraceSetFlags
> + flags contains flag bits describing the operating
> mode
> + of tracing. If flags c
On Wed, Feb 24, 2021 at 2:26 PM Kyotaro Horiguchi
wrote:
>
> At Wed, 24 Feb 2021 13:15:27 +0530, Dilip Kumar wrote
> in
> > On Wed, Feb 24, 2021 at 12:39 PM Kyotaro Horiguchi
> > wrote:
> > >
> > > At Tue, 23 Feb 2021 12:03:32 +0530, Dilip Kumar
> > > wrote in
> > > > On Fri, Feb 12, 2021 at
On Fri, Feb 19, 2021 at 6:56 AM Greg Nancarrow wrote:
>
> Posting a new version of the patches, with the following updates:
>
I am not happy with the below code changes, I think we need a better
way to deal with this.
@@ -313,19 +314,35 @@ standard_planner(Query *parse, const char
*query_string,
On Wed, Feb 24, 2021 at 2:14 PM Greg Nancarrow wrote:
>
> On Wed, Feb 24, 2021 at 3:12 PM Amit Kapila wrote:
> >
> > On Wed, Feb 24, 2021 at 8:41 AM Greg Nancarrow wrote:
> > >
> > > On Tue, Feb 23, 2021 at 10:53 PM Amit Kapila
> > > wrote:
> > > >
> > > > > But the non-parallel plan was chose
At Wed, 24 Feb 2021 17:56:41 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Wed, 24 Feb 2021 13:15:27 +0530, Dilip Kumar wrote
> in
> > > After the renaming of the function, the following structure looks
> > > simpler and more natural.
> > >
> > > while (ConfirmRecoveryPaused())
> > > {
> > >
At Wed, 24 Feb 2021 13:15:27 +0530, Dilip Kumar wrote
in
> On Wed, Feb 24, 2021 at 12:39 PM Kyotaro Horiguchi
> wrote:
> >
> > At Tue, 23 Feb 2021 12:03:32 +0530, Dilip Kumar
> > wrote in
> > > On Fri, Feb 12, 2021 at 3:26 AM Robert Haas wrote:
> > How about something like this?
> >
> > Requ
On Wed, Feb 24, 2021 at 3:12 PM Amit Kapila wrote:
>
> On Wed, Feb 24, 2021 at 8:41 AM Greg Nancarrow wrote:
> >
> > On Tue, Feb 23, 2021 at 10:53 PM Amit Kapila
> > wrote:
> > >
> > > > But the non-parallel plan was chosen (instead of a parallel plan)
> > > > because of parallel-safety checks
Hi,
I've written this function to insert several rows at once, and noticed a
certain postgresql overhead as you can see from the log file. A lot more data
than the
user data is actually sent over the net. This has a certain noticeable impact
on the user transmission speed.
I noticed that a lib
Hi Bertrand,
On Wed, Feb 24, 2021 at 5:56 AM Drouvot, Bertrand wrote:
> Hi hackers,
>
> Here is a scenario that segfault during delete (with version >= 12):
>
> create table parent (
> col1 text primary key
> );
>
> create table child (
> col1 text primary key,
> FOREIGN KEY (col1) REFERENCES par
67 matches
Mail list logo
