Re: On login trigger: take three

2020-12-09 Thread Pavel Stehule
st 9. 12. 2020 v 14:28 odesílatel Konstantin Knizhnik < k.knizh...@postgrespro.ru> napsal: > > > On 09.12.2020 15:34, Pavel Stehule wrote: > > Hi > > st 9. 12. 2020 v 13:17 odesílatel Greg Nancarrow > napsal: > >> On Tue, Dec 8, 2020 at 3:26 PM Pavel Stehule >> wrote: >> > >> > >> > There are tw

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Greg Nancarrow
On Thu, Dec 10, 2020 at 1:23 PM tsunakawa.ta...@fujitsu.com wrote: > > From: Greg Nancarrow > > Firstly, in order to perform parallel-safety checks in the case of > > partitions, the > > patch currently recursively locks/unlocks > > (AccessShareLock) each partition during such checks (as each pa

Re: Asynchronous Append on postgres_fdw nodes.

2020-12-09 Thread Andrey V. Lepikhov
On 11/17/20 2:56 PM, Etsuro Fujita wrote: On Mon, Oct 5, 2020 at 3:35 PM Etsuro Fujita wrote: Comments welcome! The attached is still WIP and maybe I'm missing something, though. I reviewed your patch and used it in my TPC-H benchmarks. It is still WIP. Will you improve this patch? I also wa

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Dilip Kumar
On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow wrote: > > On Wed, Dec 9, 2020 at 1:35 AM vignesh C wrote: > > > > Most of the code present in > > v9-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch is > > applicable for parallel copy patch also. The patch in this thread > > handles the

Re: Is Recovery actually paused?

2020-12-09 Thread Dilip Kumar
On Mon, Nov 30, 2020 at 2:40 PM Dilip Kumar wrote: > > On Mon, Nov 30, 2020 at 12:17 PM Yugo NAGATA wrote: > > Thanks for looking into this. > > > On Thu, 22 Oct 2020 20:36:48 +0530 > > Dilip Kumar wrote: > > > > > On Thu, Oct 22, 2020 at 7:50 PM Dilip Kumar wrote: > > > > > > > > On Thu, Oct 2

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Greg Nancarrow
On Thu, Dec 10, 2020 at 3:50 PM vignesh C wrote: > Few comments: > + Node *index_expr; > + > + if (index_expr_item == NULL) > /* shouldn't happen */ > + elog(ERROR, "too

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread vignesh C
On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow wrote: > > On Wed, Dec 9, 2020 at 1:35 AM vignesh C wrote: > > > > Most of the code present in > > v9-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch is > > applicable for parallel copy patch also. The patch in this thread > > handles the

Re: [HACKERS] [PATCH] Generic type subscripting

2020-12-09 Thread Pavel Stehule
st 9. 12. 2020 v 22:59 odesílatel Tom Lane napsal: > Here's a couple of little finger exercises to move this along a bit. > > 0001 adds the ability to attach a subscript handler to an existing > data type with ALTER TYPE. This is clearly going to be necessary > if we want extension types to be a

Re: [Patch] Optimize dropping of relation buffers using dlist

2020-12-09 Thread Amit Kapila
On Thu, Dec 10, 2020 at 7:11 AM Kyotaro Horiguchi wrote: > > At Wed, 9 Dec 2020 16:27:30 +0530, Amit Kapila > wrote in > > On Wed, Dec 9, 2020 at 6:32 AM Kyotaro Horiguchi > > > Mmm. At least btree doesn't need to call smgrnblocks except at > > > expansion, so we cannot get to the optimized path

Re: Parallel Inserts in CREATE TABLE AS

2020-12-09 Thread Bharath Rupireddy
On Thu, Dec 10, 2020 at 7:48 AM Zhihong Yu wrote: > + if (!OidIsValid(col->collOid) && > + type_is_collatable(col->typeName->typeOid)) > + ereport(ERROR, > ... > + attrList = lappend(attrList, col); > > Should attrList be freed when ereport is called

Re: Refactor MD5 implementations and switch to EVP for OpenSSL

2020-12-09 Thread Michael Paquier
On Wed, Dec 09, 2020 at 01:52:32PM +0100, Daniel Gustafsson wrote: > The tiniest level of nitpicking would be that md5.h doesn't have the > /* PG_MD5_H */ comment on the #endif line (and it's even tinier since it's > not even the fault of this patch - I just happened to notice when looking > at th

Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS

2020-12-09 Thread Craig Ringer
On Thu, 3 Dec 2020 at 15:53, Craig Ringer wrote: > > On Tue, 27 Oct 2020 at 16:34, Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: > >> On 2020-09-25 09:40, Craig Ringer wrote: >> > While working on extensions I've often wanted to enable cache >> clobbering >> > for a targeted piece

RE: [Patch] Optimize dropping of relation buffers using dlist

2020-12-09 Thread tsunakawa.ta...@fujitsu.com
From: Kyotaro Horiguchi > Oh, sorry. I wrongly looked to non-recovery path. smgrnblocks is > called during buffer loading while recovery. So, smgrnblock is called > for indexes if any update happens on the heap relation. I misunderstood that you said there's no problem with the TOAST index becaus

Re: Deleting older versions in unique indexes to avoid page splits

2020-12-09 Thread Zhihong Yu
Hi, In v11-0001-Pass-down-logically-unchanged-index-hint.patch : + if (hasexpression) + return false; + + return true; The above can be written as 'return !hasexpression;' For +index_unchanged_by_update_var_walker: + * Returns true when Var that appears within allUpdatedCols located.

RE: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread tsunakawa.ta...@fujitsu.com
From: Greg Nancarrow > Firstly, in order to perform parallel-safety checks in the case of > partitions, the > patch currently recursively locks/unlocks > (AccessShareLock) each partition during such checks (as each partition may > itself be a partitioned table). Is there a better way of performin

Re: Parallel Inserts in CREATE TABLE AS

2020-12-09 Thread Zhihong Yu
Hi, + if (!OidIsValid(col->collOid) && + type_is_collatable(col->typeName->typeOid)) + ereport(ERROR, ... + attrList = lappend(attrList, col); Should attrList be freed when ereport is called ? + query->CTASParallelInsInfo &= CTAS_PARALLEL_INS

Re: Setof RangeType returns

2020-12-09 Thread Patrick Handja
Hello, After some days, I finally found what I was looking for. Actually this worked: > Oid rngtypid = get_fn_expr_rettype(fcinfo->flinfo); > typcache = range_get_typcache(fcinfo, rngtypid); Thanks for the help. *Andjasubu Bungama, Patrick * Le mar. 1 déc. 2020 à 17:39, Tom Lane a écri

Re: Get memory contexts of an arbitrary backend process

2020-12-09 Thread torikoshia
On 2020-12-04 19:16, torikoshia wrote: On 2020-12-03 10:36, Tom Lane wrote: Fujii Masao writes: I'm starting to study how this feature behaves. At first, when I executed the following query, the function never returned. ISTM that since the autovacuum launcher cannot respond to the request of

Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

2020-12-09 Thread Bharath Rupireddy
On Wed, Dec 9, 2020 at 4:49 PM Fujii Masao wrote: > I started reviewing 0001 patch. > Thanks! > IMO the 0001 patch should be self-contained so that we can commit it at > first. That is, I think that it's better to move the documents and tests for > the functions 0001 patch adds from 0004 to 00

Re: Parallel Inserts in CREATE TABLE AS

2020-12-09 Thread Bharath Rupireddy
On Wed, Dec 9, 2020 at 10:16 AM Dilip Kumar wrote: > > On Tue, Dec 8, 2020 at 6:24 PM Hou, Zhijie wrote: > > > > > > I'm not quite sure how to address this. Can we not allow the planner > > > > to consider that the select is for CTAS and check only after the > > > > planning is done for the Gathe

Re: [Patch] Optimize dropping of relation buffers using dlist

2020-12-09 Thread Kyotaro Horiguchi
At Wed, 9 Dec 2020 16:27:30 +0530, Amit Kapila wrote in > On Wed, Dec 9, 2020 at 6:32 AM Kyotaro Horiguchi > wrote: > > > > At Tue, 8 Dec 2020 16:28:41 +0530, Amit Kapila > > wrote in > > > On Tue, Dec 8, 2020 at 12:13 PM tsunakawa.ta...@fujitsu.com > > > wrote: > > > > > > > > From: Jamison

Re: Proposed patch for key managment

2020-12-09 Thread Bruce Momjian
On Fri, Dec 4, 2020 at 10:32:45PM -0500, Bruce Momjian wrote: > I can break out the -R/file descriptor passing part as a separate patch, > and have the ssl_passphrase_command use that, but that's the only part I > know can be useful on its own. > > Since the patch is large, I found a way to push

RE: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

2020-12-09 Thread tsunakawa.ta...@fujitsu.com
From: Bharath Rupireddy > I'm not sure how many more of such commands exist which require changes. > > How about doing it this way? > > 1) Have a separate common thread listing the commands and specifying > clearly the agreed behaviour for such commands. > 2) Whenever the separate patches are su

RE: Wrong statistics for size of XLOG_SWITCH during pg_waldump.

2020-12-09 Thread Shinya11.Kato
Thanks for the reply. > Mr.Horiguchi. I reviewed the patch and found some problems. >+ if(startSegNo != endSegNo) >+ else if(record->ReadRecPtr / XLOG_BLCKSZ != >+ if(rmid == RM_XLOG_ID && info == XLOG_SWITCH) >+ if(ri == RM_XLOG_ID) >+ if(info == XLOG_SWITCH) You need to put a space after the "i

RE: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

2020-12-09 Thread tsunakawa.ta...@fujitsu.com
From: Alvaro Herrera > Well, that definition seems unfriendly to me. I prefer the stance that > if you change the value for the parent, then future partitions inherit > that value. That would be right when the storage property is an optional specification such as fillfactor. For example, when

Re: [Patch] ALTER SYSTEM READ ONLY

2020-12-09 Thread Andres Freund
Hi, On 2020-12-09 16:13:06 -0500, Robert Haas wrote: > That's not good. On a typical busy system, a system is going to be in > the middle of a checkpoint most of the time, and the checkpoint will > take a long time to finish - maybe minutes. Or hours, even. Due to the cost of FPWs it can make a l

Re: [Patch] ALTER SYSTEM READ ONLY

2020-12-09 Thread Andres Freund
On 2020-11-20 11:23:44 -0500, Robert Haas wrote: > Andres, do you like the new loop better? I do!

Re: Proposed patch for key managment

2020-12-09 Thread Stephen Frost
Greetings, * Daniel Gustafsson (dan...@yesql.se) wrote: > > On 2 Dec 2020, at 22:38, Bruce Momjian wrote: > > Attached is a patch for key management, which will eventually be part of > > cluster file encryption (CFE), called TDE (Transparent Data Encryption) > > by Oracle. > > The attackvector p

Re: [HACKERS] [PATCH] Generic type subscripting

2020-12-09 Thread Tom Lane
Here's a couple of little finger exercises to move this along a bit. 0001 adds the ability to attach a subscript handler to an existing data type with ALTER TYPE. This is clearly going to be necessary if we want extension types to be able to use this facility. The only thing that I think might b

Re: Proposed patch for key managment

2020-12-09 Thread Daniel Gustafsson
> On 2 Dec 2020, at 22:38, Bruce Momjian wrote: > > Attached is a patch for key management, which will eventually be part of > cluster file encryption (CFE), called TDE (Transparent Data Encryption) > by Oracle. The attackvector protected against seems to be operating systems users (*without* an

Re: [Patch] ALTER SYSTEM READ ONLY

2020-12-09 Thread Robert Haas
On Sat, Sep 12, 2020 at 1:23 AM Amul Sul wrote: > > So, if we're in the middle of a paced checkpoint with a large > > checkpoint_timeout - a sensible real world configuration - we'll not > > process ASRO until that checkpoint is over? That seems very much not > > practical. What am I missing? > >

Re: Hybrid Hash/Nested Loop joins and caching results from subplans

2020-12-09 Thread David Rowley
On Tue, 8 Dec 2020 at 20:15, David Rowley wrote: > I've attached another patchset that addresses some comments left by > Zhihong Yu over on [1]. The version number got bumped to v12 instead > of v11 as I still have a copy of the other version of the patch which > I made some changes to and intern

Re: SELECT INTO deprecation

2020-12-09 Thread Peter Eisentraut
On 2020-12-03 20:26, Peter Eisentraut wrote: On 2020-12-03 16:34, Tom Lane wrote: As I recall, a whole lot of the pain we have with INTO has to do with the semantics we've chosen for INTO in a set-operation nest. We think you can write something like SELECT ... INTO foo FROM ... UNION SELE

Re: libpq compression

2020-12-09 Thread Robert Haas
On Tue, Dec 8, 2020 at 9:42 AM Daniil Zakhlystov wrote: > I proposed a slightly different handshake (three-phase): > > 1. At first, the client sends _pq_.compression parameter in startup packet > 2. Server replies with CompressionAck and following it with > SetCompressionMethod message. > These t

create table like: ACCESS METHOD

2020-12-09 Thread Justin Pryzby
I thought this was a good idea, but didn't hear back when I raised it before. Failing to preserve access method is arguably a bug, reminiscent of CREATE STATISTICS and 5564c1181. But maybe it's not important to backpatch a fix in this case, since access methods are still evolving. https://www.po

Re: [HACKERS] [PATCH] Generic type subscripting

2020-12-09 Thread Tom Lane
Dmitry Dolgov <9erthali...@gmail.com> writes: >> On Wed, Dec 09, 2020 at 12:49:48PM -0500, Tom Lane wrote: >> I'd be happier if the "container" terminology were reserved for >> that sort of physical containment, which means that I think a lot >> of the commentary around SubscriptingRef is misleadin

Re: pg_stat_statements and "IN" conditions

2020-12-09 Thread Dmitry Dolgov
> On Wed, Dec 09, 2020 at 03:37:40AM +, Chengxi Sun wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:not te

Re: [HACKERS] [PATCH] Generic type subscripting

2020-12-09 Thread Dmitry Dolgov
> On Wed, Dec 09, 2020 at 12:49:48PM -0500, Tom Lane wrote: > > I've pushed the core patch now. Thanks a lot! > The jsonb parts now have to be > rebased onto this design, which I'm assuming Dmitry will tackle Yes, I'm already on it, just couldn't keep up with the changes in this thread. > BTW,

Re: [HACKERS] [PATCH] Generic type subscripting

2020-12-09 Thread Tom Lane
I've pushed the core patch now. The jsonb parts now have to be rebased onto this design, which I'm assuming Dmitry will tackle (I do not intend to). It's not quite clear to me whether we have a meeting of the minds on what the jsonb functionality should be, anyway. Alexander seemed to be thinkin

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2020-12-09 Thread Justin Pryzby
On Fri, Dec 04, 2020 at 12:23:23PM -0500, Tom Lane wrote: > Justin Pryzby writes: > [ v24-0001-Document-historic-behavior-of-links-to-directori.patch ] > > The cfbot is unhappy with one of the test cases you added: > Maybe it could be salvaged by reversing the sense of the WHERE condition > so t

Insert Documentation - Returning Clause and Order

2020-12-09 Thread David G. Johnston
Hey, Would it be accurate to add the following sentence to the INSERT documentation under "Outputs"? "...inserted or updated by the command." For a multiple-values insertion, the order of output rows will match the order that rows are presented in the values or query clause. https://www.postgre

Re: get_constraint_index() and conindid

2020-12-09 Thread Peter Eisentraut
On 2020-12-09 07:37, Michael Paquier wrote: Only thing I could think of is that it maybe could use a (small) comment in the message on that/why get_constraint_index is moved to utils/lsyscache from catalog/dependency, as that took me some time to understand. commit message could reasonably say

Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

2020-12-09 Thread Alvaro Herrera
On 2020-Dec-09, Bharath Rupireddy wrote: > I'm not sure how many more of such commands exist which require changes. The other thread has a list. I think it is complete, but if you want to double-check, that would be helpful. > How about doing it this way? > > 1) Have a separate common thread l

Re: pg_rewind race condition just after promotion

2020-12-09 Thread Heikki Linnakangas
On 08/12/2020 06:45, Kyotaro Horiguchi wrote: At Mon, 7 Dec 2020 20:13:25 +0200, Heikki Linnakangas wrote in I think we should fix this properly. I'm not sure if it can lead to a broken cluster, but at least it can cause pg_rewind to fail unnecessarily and in a user-unfriendly way. But this is

Re: On login trigger: take three

2020-12-09 Thread Konstantin Knizhnik
On 09.12.2020 15:34, Pavel Stehule wrote: Hi st 9. 12. 2020 v 13:17 odesílatel Greg Nancarrow > napsal: On Tue, Dec 8, 2020 at 3:26 PM Pavel Stehule mailto:pavel.steh...@gmail.com>> wrote: > > > There are two maybe generic questions? >

Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

2020-12-09 Thread Bharath Rupireddy
On Wed, Dec 9, 2020 at 6:22 PM Alvaro Herrera wrote: > > On 2020-Dec-09, tsunakawa.ta...@fujitsu.com wrote: > > > From: Alvaro Herrera > > > But what happens when you create another partition after you change the > > > "loggedness" of the partitioned table? > > > > The new partition will have a p

Re: Refactor MD5 implementations and switch to EVP for OpenSSL

2020-12-09 Thread Daniel Gustafsson
> On 9 Dec 2020, at 06:47, Michael Paquier wrote: > In short, this seems rather committable to me. Agreed, this version of the patch looks good to me. I've looked over the attributions for the code movement and it seems to match now, and all tests pass etc. +1 on going ahead with this version.

Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently

2020-12-09 Thread Alvaro Herrera
On 2020-Dec-09, tsunakawa.ta...@fujitsu.com wrote: > From: Alvaro Herrera > > But what happens when you create another partition after you change the > > "loggedness" of the partitioned table? > > The new partition will have a property specified when the user creates > it. That is, while the st

Re: On login trigger: take three

2020-12-09 Thread Pavel Stehule
Hi st 9. 12. 2020 v 13:17 odesílatel Greg Nancarrow napsal: > On Tue, Dec 8, 2020 at 3:26 PM Pavel Stehule > wrote: > > > > > > There are two maybe generic questions? > > > > 1. Maybe we can introduce more generic GUC for all event triggers like > disable_event_triggers? This GUC can be checked

Re: On login trigger: take three

2020-12-09 Thread Pavel Stehule
st 9. 12. 2020 v 13:17 odesílatel Greg Nancarrow napsal: > On Tue, Dec 8, 2020 at 3:26 PM Pavel Stehule > wrote: > > > > > > There are two maybe generic questions? > > > > 1. Maybe we can introduce more generic GUC for all event triggers like > disable_event_triggers? This GUC can be checked onl

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Dilip Kumar
On Wed, 9 Dec 2020 at 5:41 PM, Amit Kapila wrote: > On Wed, Dec 9, 2020 at 4:18 PM Dilip Kumar wrote: > > > > On Wed, Dec 9, 2020 at 4:03 PM Amit Kapila > wrote: > > > > > > On Wed, Dec 9, 2020 at 2:38 PM Dilip Kumar > wrote: > > > > > > > > On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow > wr

Re: On login trigger: take three

2020-12-09 Thread Greg Nancarrow
On Tue, Dec 8, 2020 at 3:26 PM Pavel Stehule wrote: > > > There are two maybe generic questions? > > 1. Maybe we can introduce more generic GUC for all event triggers like > disable_event_triggers? This GUC can be checked only by the database owner or > super user. It can be an alternative ALTER

Re: Feature improvement for pg_stat_statements

2020-12-09 Thread Fujii Masao
On 2020/12/09 20:42, Li Japin wrote: Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki mailto:sein...@oss.nttdata.com>> wrote: 2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Amit Kapila
On Wed, Dec 9, 2020 at 4:18 PM Dilip Kumar wrote: > > On Wed, Dec 9, 2020 at 4:03 PM Amit Kapila wrote: > > > > On Wed, Dec 9, 2020 at 2:38 PM Dilip Kumar wrote: > > > > > > On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow > > > wrote: > > > > > > > > On Wed, Dec 9, 2020 at 1:35 AM vignesh C wr

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Amit Kapila
On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow wrote: > > On Wed, Dec 9, 2020 at 1:35 AM vignesh C wrote: > > > > Most of the code present in > > v9-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch is > > applicable for parallel copy patch also. The patch in this thread > > handles the

Re: Feature improvement for pg_stat_statements

2020-12-09 Thread Li Japin
Hi, On Dec 9, 2020, at 6:37 PM, Seino Yuki mailto:sein...@oss.nttdata.com>> wrote: 2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/2

Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

2020-12-09 Thread Fujii Masao
On 2020/12/04 20:15, Bharath Rupireddy wrote: On Fri, Dec 4, 2020 at 1:46 PM Bharath Rupireddy wrote: On Fri, Dec 4, 2020 at 11:49 AM Fujii Masao wrote: Attaching the v2 patch set. Please review it further. Regarding the 0001 patch, we should add the function that returns the informat

Re: MultiXact\SLRU buffers configuration

2020-12-09 Thread Gilles Darold
Le 09/12/2020 à 11:51, Gilles Darold a écrit : Also PG regression tests are failing too on several part. Forget this, I have not run the regression tests in the right repository: ... ===  All 189 tests passed. === I'm looking why the application is fa

Re: [Patch] Optimize dropping of relation buffers using dlist

2020-12-09 Thread Amit Kapila
On Wed, Dec 9, 2020 at 6:32 AM Kyotaro Horiguchi wrote: > > At Tue, 8 Dec 2020 16:28:41 +0530, Amit Kapila > wrote in > > On Tue, Dec 8, 2020 at 12:13 PM tsunakawa.ta...@fujitsu.com > > wrote: > > > > > > From: Jamison, Kirk/ジャミソン カーク > > > > Because one of the rel's cached value was false, it

Re: MultiXact\SLRU buffers configuration

2020-12-09 Thread Gilles Darold
Hi Andrey, Thanks for the backport. I have issue with the first patch "Use shared lock in GetMultiXactIdMembers for offsets and members" (v1106-0001-Use-shared-lock-in-GetMultiXactIdMembers-for-o.patch) the applications are not working anymore when I'm applying it. Also PG regression tests ar

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Dilip Kumar
On Wed, Dec 9, 2020 at 4:03 PM Amit Kapila wrote: > > On Wed, Dec 9, 2020 at 2:38 PM Dilip Kumar wrote: > > > > On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow wrote: > > > > > > On Wed, Dec 9, 2020 at 1:35 AM vignesh C wrote: > > > > > > > > Most of the code present in > > > > v9-0001-Enable-pa

Re: Parallel copy

2020-12-09 Thread vignesh C
On Mon, Dec 7, 2020 at 3:00 PM Hou, Zhijie wrote: > > > Attached v11 patch has the fix for this, it also includes the changes to > > rebase on top of head. > > Thanks for the explanation. > > I think there is still chances we can know the size. > > +* line_size will be set. Read th

Re: Feature improvement for pg_stat_statements

2020-12-09 Thread Seino Yuki
2020-12-01 01:04 に Fujii Masao さんは書きました: On 2020/11/30 23:05, Seino Yuki wrote: 2020-11-30 15:02 に Fujii Masao さんは書きました: On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Amit Kapila
On Wed, Dec 9, 2020 at 2:38 PM Dilip Kumar wrote: > > On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow wrote: > > > > On Wed, Dec 9, 2020 at 1:35 AM vignesh C wrote: > > > > > > Most of the code present in > > > v9-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch is > > > applicable for

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-12-09 Thread Amit Kapila
On Wed, Dec 9, 2020 at 2:56 PM Noah Misch wrote: > > Further testing showed it was a file location problem, not a deletion problem. > The worker tried to open > base/pgsql_tmp/pgsql_tmp9896408.1.sharedfileset/16393-510.changes.0, but these > were the files actually existing: > > [nm@power-aix 0:2

Re: Yet another fast GiST build

2020-12-09 Thread Andrey Borodin
> 7 дек. 2020 г., в 23:56, Peter Geoghegan написал(а): > > On Mon, Dec 7, 2020 at 2:05 AM Andrey Borodin wrote: >> Here's version with tests and docs. I still have no idea how to print some >> useful information about tuples keys. > > I suggest calling BuildIndexValueDescription() from your

Re: Change default of checkpoint_completion_target

2020-12-09 Thread Laurenz Albe
On Tue, 2020-12-08 at 17:29 +, Bossart, Nathan wrote: > +1 to setting checkpoint_completion_target to 0.9 by default. +1 for changing the default or getting rid of it, as Tom suggested. While we are at it, could we change the default of "log_lock_waits" to "on"? Yours, Laurenz Albe

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-12-09 Thread Noah Misch
On Wed, Dec 02, 2020 at 01:50:25PM +0530, Amit Kapila wrote: > On Wed, Dec 2, 2020 at 1:20 PM Dilip Kumar wrote: > > > On Mon, Nov 30, 2020 at 6:49 PM Amit Kapila > > > wrote: > > > > On Mon, Nov 30, 2020 at 3:14 AM Noah Misch wrote: > > > > > On Mon, Sep 07, 2020 at 12:00:41PM +0530, Amit Kapi

Re: Parallel INSERT (INTO ... SELECT ...)

2020-12-09 Thread Dilip Kumar
On Wed, Dec 9, 2020 at 10:11 AM Greg Nancarrow wrote: > > On Wed, Dec 9, 2020 at 1:35 AM vignesh C wrote: > > > > Most of the code present in > > v9-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch is > > applicable for parallel copy patch also. The patch in this thread > > handles the

Re: [Proposal] Global temporary tables

2020-12-09 Thread Pavel Stehule
st 9. 12. 2020 v 7:34 odesílatel 曾文旌 napsal: > > > 2020年12月8日 13:28,Pavel Stehule 写道: > > Hi > > čt 26. 11. 2020 v 12:46 odesílatel 曾文旌 > napsal: > >> This is the latest patch for feature GTT(v38). >> Everybody, if you have any questions, please let me know. >> > > please, co you send a rebased

Re: Disallow cancellation of waiting for synchronous replication

2020-12-09 Thread Andrey Borodin
> 9 июня 2020 г., в 23:32, Jeff Davis написал(а): > > After using a patch for a while it became obvious that PANICing during termination is not a good idea. Even when we wait for synchronous replication. It generates undesired coredumps. I think in presence of SIGTERM it's reasonable to say

A failure of standby to follow timeline switch

2020-12-09 Thread Kyotaro Horiguchi
Hello. We found a behavioral change (which seems to be a bug) in recovery at PG13. The following steps might seem somewhat strange but the replication code deliberately cope with the case. This is a sequense seen while operating a HA cluseter using Pacemaker. - Run initdb to create a primary. -

Re: pg_stat_statements and "IN" conditions

2020-12-09 Thread Chengxi Sun
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Hi, I did some test and it works well