Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs

2020-11-29 Thread Pavel Stehule
po 30. 11. 2020 v 4:24 odesílatel David G. Johnston < david.g.johns...@gmail.com> napsal: > On Thu, Nov 26, 2020 at 12:49 AM Pavel Stehule > wrote: > >> >> >> čt 26. 11. 2020 v 6:41 odesílatel David G. Johnston < >> david.g.johns...@gmail.com> napsal: >> >>> Hackers, >>> >>> Bug # 16519 [1] is an

Re: Improving spin-lock implementation on ARM.

2020-11-29 Thread Alexander Korotkov
On Mon, Nov 30, 2020 at 9:20 AM Krunal Bauskar wrote: > Some of us may be surprised by the fact that enabling lse is causing > regression (1816 -> 892 or 714 -> 610) with HEAD itself. > While lse is meant to improve the performance. This, unfortunately, is not > always the case at-least based on

Re: Add Information during standby recovery conflicts

2020-11-29 Thread Masahiko Sawada
On Mon, Nov 30, 2020 at 3:46 PM Drouvot, Bertrand wrote: > > Hi, > > On 11/30/20 4:41 AM, Masahiko Sawada wrote: > > On Sun, Nov 29, 2020 at 3:47 PM Drouvot, Bertrand > > wrote: > >> Hi Alvaro, > >> > >> On 11/28/20 6:36 PM, Alvaro Herrera wrote: > >>> Hi Bertrand, > >>> > >>> On 2020-Nov-28, Dr

Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour

2020-11-29 Thread Michael Paquier
On Sun, Nov 29, 2020 at 01:27:48PM -0600, Justin Pryzby wrote: > activity of scans already in progress. This can result in > unpredictable changes in the row ordering returned by queries that > have no ORDER BY clause. Setting this parameter > to > -off ensures

Re: Is Recovery actually paused?

2020-11-29 Thread Yugo NAGATA
On Thu, 22 Oct 2020 20:36:48 +0530 Dilip Kumar wrote: > On Thu, Oct 22, 2020 at 7:50 PM Dilip Kumar wrote: > > > > On Thu, Oct 22, 2020 at 6:59 AM Kyotaro Horiguchi > > wrote: > > > > > > At Wed, 21 Oct 2020 11:14:24 -0400, Robert Haas > > > wrote in > > > > On Wed, Oct 21, 2020 at 7:16 AM Di

Re: Disable WAL logging to speed up data loading

2020-11-29 Thread Masahiko Sawada
() On Mon, Nov 30, 2020 at 2:39 PM Kyotaro Horiguchi wrote: > > At Fri, 27 Nov 2020 13:34:49 +, "osumi.takami...@fujitsu.com" > wrote in > > Thank you, Horiguchi-San > > > > > I haven't seen a criteria of whether a record is emitted or not for > > > wal_leve=none. > > > > > > We're emitting

Re: Is it useful to record whether plans are generic or custom?

2020-11-29 Thread Tatsuro Yamada
Hi Torikoshi-san, In this patch, exposing new columns is mandatory, but I think it's better to make it optional by adding a GUC something like 'pgss.track_general_custom_plans. I also feel it makes the number of columns too many. Just adding the total time may be sufficient. I think this fe

Re: Improving spin-lock implementation on ARM.

2020-11-29 Thread Krunal Bauskar
On Mon, 30 Nov 2020 at 11:38, Tom Lane wrote: > Krunal Bauskar writes: > > On Mon, 30 Nov 2020 at 10:14, Tom Lane wrote: > >> The results I posted at [1] seem to contradict this for Apple's new > >> machines. > > > For the results you saw on Mac-Mini was LSE enabled by default. > > Hmm, I don't

Re: Improving spin-lock implementation on ARM.

2020-11-29 Thread Tom Lane
Krunal Bauskar writes: > On Mon, 30 Nov 2020 at 10:14, Tom Lane wrote: >> The results I posted at [1] seem to contradict this for Apple's new >> machines. > For the results you saw on Mac-Mini was LSE enabled by default. Hmm, I don't know how to get Apple's clang to admit what its default setti

Re: Feature improvement for pg_stat_statements

2020-11-29 Thread Fujii Masao
On 2020/11/30 12:08, Seino Yuki wrote: 2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches discussed in the following thread. ht

Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted

2020-11-29 Thread Thomas Munro
On Wed, Nov 25, 2020 at 8:00 AM Pavel Borisov wrote: > The new status of this patch is: Ready for Committer Thanks! One small thing bothered me about the last version of the patch. It tried to unlink when ENOENT had already been enountered by open(2), so COMMIT of a DROP looks like: openat(AT_

Re: proposal: function pg_setting_value_split() to parse shared_preload_libraries etc.

2020-11-29 Thread Craig Ringer
On Mon, 30 Nov 2020 at 03:24, Anastasia Lubennikova wrote: > > On 23.10.2020 05:06, Ian Lawrence Barwick wrote: > > Having just submitted this, I realised I'm focussing on the GUCs which call > > "SplitDirectoriesString()" (as my specific uses case is for > > "shared_preload_libraries") > > but th

Re: Removing unneeded self joins

2020-11-29 Thread Andrey V. Lepikhov
On 11/29/20 10:10 PM, Heikki Linnakangas wrote: On 28/11/2020 19:21, Andrey Lepikhov wrote: On 27.11.2020 21:49, Heikki Linnakangas wrote: CREATE TABLE a(x int, y int); CREATE UNIQUE INDEX ON a(x); SELECT a1.* FROM a a1, a a2 WHERE a1.x = a2.x;  -- self-join CREATE UNIQUE INDEX ON a(y); SELECT a

Re: Disable WAL logging to speed up data loading

2020-11-29 Thread Kyotaro Horiguchi
At Fri, 27 Nov 2020 13:34:49 +, "osumi.takami...@fujitsu.com" wrote in > Thank you, Horiguchi-San > > > I haven't seen a criteria of whether a record is emitted or not for > > wal_leve=none. > > > > We're emitting only redo logs. So I think theoretically we don't need > > anything > > ot

Re: Printing backtrace of postgres processes

2020-11-29 Thread Craig Ringer
> Surely this is *utterly* unsafe. You can't do that sort of stuff in > a signal handler. Not safely, anyway. The signal handler could be called in the middle of a malloc(), a pfree(), or all sorts of other exciting circumstances. It'd have to be extremely careful to use only local resources on t

Re: Multi Inserts in CREATE TABLE AS - revived patch

2020-11-29 Thread Bharath Rupireddy
Hi, Currently, required logic for multi inserts (such as buffer slots allocation, flushing, tuple size calculation to decide when to flush, cleanup and so on) is being handled outside of the existing tableam APIs. And there are a good number of cases where multi inserts can be used, such as for ex

Re: Parallel Inserts in CREATE TABLE AS

2020-11-29 Thread Bharath Rupireddy
On Fri, Nov 27, 2020 at 1:07 PM Luc Vlaming wrote: > > Disclaimer: I have by no means throughly reviewed all the involved parts > and am probably missing quite a bit of context so if I understood parts > wrong or they have been discussed before then I'm sorry. Most notably > the whole situation ab

Re: [PATCH] fix compilation with gnu89

2020-11-29 Thread Tom Lane
Andres Freund writes: > On 2020-11-29 20:33:41 -0800, Rosen Penev wrote: >> GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions. > We require C99 support since postgres 12, and configure should end up > choosing flags to make the compiler support that if possible. Hmm, yeah, tha

Re: Improving spin-lock implementation on ARM.

2020-11-29 Thread Krunal Bauskar
On Mon, 30 Nov 2020 at 10:14, Tom Lane wrote: > Krunal Bauskar writes: > > So given all the permutations and combinations, I think we could approach > > the problem as follows: > > > * Enable use of CAS as it is known to have optimal performance (vs TAS) > > The results I posted at [1] seem to c

Re: Printing backtrace of postgres processes

2020-11-29 Thread vignesh C
On Sun, Nov 22, 2020 at 11:55 AM Tom Lane wrote: > > vignesh C writes: > > The idea here is to implement & expose pg_print_callstack function, > > internally what this function does is, the connected backend will send > > SIGUSR1 signal by setting PMSIGNAL_BACKTRACE_EMIT to the postmaster > > pro

Re: [PATCH] fix compilation with gnu89

2020-11-29 Thread Tom Lane
Rosen Penev writes: > GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions. Project policy now is to require C99 support, so the correct solution for using an older compiler is to do something like ./configure CC="gcc -std=gnu99" ... We're not going to accept patches to remove d

Re: [PATCH] fix compilation with gnu89

2020-11-29 Thread Andres Freund
Hi, On 2020-11-29 20:33:41 -0800, Rosen Penev wrote: > GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions. We require C99 support since postgres 12, and configure should end up choosing flags to make the compiler support that if possible. As far as I can tell the code you chang

Re: Improving spin-lock implementation on ARM.

2020-11-29 Thread Tom Lane
Krunal Bauskar writes: > So given all the permutations and combinations, I think we could approach > the problem as follows: > * Enable use of CAS as it is known to have optimal performance (vs TAS) The results I posted at [1] seem to contradict this for Apple's new machines. In general, I'm pr

[PATCH] fix compilation with gnu89

2020-11-29 Thread Rosen Penev
GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions. --- src/common/logging.c | 3 ++- src/common/unicode_norm.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/common/logging.c b/src/common/logging.c index f3fc0b8..2ac502a 100644 --- a/src/common/

Notes on physical replica failover with logical publisher or subscriber

2020-11-29 Thread Craig Ringer
Hi all I recently wrote some notes on interaction between physical replication failover/promotion and logical replication publisher and/or standby. As you probably all know, right now we don't support physical failover for logical replication publishers at all, either for in-core logical replicat

Re: Improving spin-lock implementation on ARM.

2020-11-29 Thread Krunal Bauskar
On Sun, 29 Nov 2020 at 22:23, Alexander Korotkov wrote: > On Sat, Nov 28, 2020 at 1:31 PM Alexander Korotkov > wrote: > > I guess that might depend on the implementation of CAS and TAS. I bet > > usage of CAS in spinlock gives advantage when ldxr/stxr are used, but > > not when swpal/casa are u

Re: Fix typo in cost.h

2020-11-29 Thread Fujii Masao
On 2020/11/30 12:15, Tang, Haiying wrote: Hi Found a possible typo in cost.h -/* If you change these, update backend/utils/misc/postgresql.sample.conf */ +/* If you change these, update backend/utils/misc/postgresql.conf.sample */ Pushed. Thanks! Regards, -- Fujii Masao Advanced Computi

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-11-29 Thread Amit Kapila
On Mon, Nov 30, 2020 at 3:14 AM Noah Misch wrote: > > On Mon, Sep 07, 2020 at 12:00:41PM +0530, Amit Kapila wrote: > > Thanks, I have pushed the last patch. Let's wait for a day or so to > > see the buildfarm reports > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sungazer&dt=2020-09-0

Re: Add Information during standby recovery conflicts

2020-11-29 Thread Masahiko Sawada
On Sun, Nov 29, 2020 at 3:47 PM Drouvot, Bertrand wrote: > > Hi Alvaro, > > On 11/28/20 6:36 PM, Alvaro Herrera wrote: > > Hi Bertrand, > > > > On 2020-Nov-28, Drouvot, Bertrand wrote: > > > >> + if (nprocs > 0) > >> + { > >> + ereport(LOG, > >> +

Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs

2020-11-29 Thread David G. Johnston
On Thu, Nov 26, 2020 at 12:49 AM Pavel Stehule wrote: > > > čt 26. 11. 2020 v 6:41 odesílatel David G. Johnston < > david.g.johns...@gmail.com> napsal: > >> Hackers, >> >> Bug # 16519 [1] is another report of confusion regarding trying to use >> parameters in improper locations - specifically the

RFC: extension_search_path to supplement dynamic_library_path

2020-11-29 Thread Craig Ringer
Hi all We have a dynamic_library_path setting to allow postgres to search additional locations for loadable libraries (since 8.1, commit 761a0bb69b). This permits libraries to be located in alternate locations for loading by shared_preload_libraries, LOAD commands, implicit loading via function ca

Re: A few new options for CHECKPOINT

2020-11-29 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > On 11/28/20, 9:50 AM, "Stephen Frost" wrote: > >> Granted, I used a rather aggressive checkpoint_timeout, but I think > >> this demonstrates that waiting for a non-immediate checkpoint to > >> complete can lower the amount of WAL needed

Fix typo in cost.h

2020-11-29 Thread Tang, Haiying
Hi Found a possible typo in cost.h -/* If you change these, update backend/utils/misc/postgresql.sample.conf */ +/* If you change these, update backend/utils/misc/postgresql.conf.sample */ Best regards, Tang 0001-fix-typo.patch Description: 0001-fix-typo.patch

Re: Feature improvement for pg_stat_statements

2020-11-29 Thread Seino Yuki
2020-11-27 22:39 に Fujii Masao さんは書きました: On 2020/11/27 21:39, Seino Yuki wrote: 2020-11-27 21:37 に Seino Yuki さんは書きました: 2020-11-16 12:28 に Seino Yuki さんは書きました: Due to similar fixed, we have also merged the patches discussed in the following thread. https://commitfest.postgresql.org/30/2736/ T

Re: Implementing Incremental View Maintenance

2020-11-29 Thread Yugo NAGATA
On Wed, 25 Nov 2020 18:00:16 +0300 Konstantin Knizhnik wrote: > > > On 25.11.2020 16:06, Yugo NAGATA wrote: > > On Wed, 25 Nov 2020 15:16:05 +0300 > > Konstantin Knizhnik wrote: > > > >> > >> On 24.11.2020 13:11, Yugo NAGATA wrote: > I wonder if it is possible to somehow use predicate loc

Re: Asynchronous Append on postgres_fdw nodes.

2020-11-29 Thread Craig Ringer
"On Thu, Nov 26, 2020 at 9:28 AM movead...@highgo.ca wrote: > > > I test the patch and occur several issues as blow: > > Issue one: > Get a Assert error at 'Assert(bms_is_member(i, node->as_needrequest));' in > ExecAppendAsyncRequest() function when I use more than two foreign table > on different

Re: POC: postgres_fdw insert batching

2020-11-29 Thread Craig Ringer
On Fri, 27 Nov 2020, 14:06 tsunakawa.ta...@fujitsu.com, wrote: > > Also, I'm afraid it requires major surgery or reform of executor. I don't want it to delay the release of reasonably good (10x) improvement with the synchronous interface.) Totally sensible. If it isn't feasible without signific

Re: Add docs stub for recovery.conf

2020-11-29 Thread Stephen Frost
Greetings, * Craig Ringer (craig.rin...@enterprisedb.com) wrote: > On Sat, Nov 14, 2020 at 1:42 AM Bruce Momjian wrote: > > Clearly we have need for documenting these renamings somewhere. We were > > going to go with a simple URL redirect and a "tip" for > > default/pre-installed roles, but I lik

Re: list of extended statistics on psql

2020-11-29 Thread Tatsuro Yamada
Hi Tomas and hackers, I don't prefer a long name but I'll replace the name with it to be clearer. For example, s/N_size/Ndistinct_size/. Please find attached patcheds:   - 0001: Replace column names   - 0002: Recreate regression test based on 0001 I rebased the patch set on the master (7e5

Re: [sqlsmith] Planner error on lateral joins

2020-11-29 Thread Tom Lane
I wrote: > Andreas Seltenreich writes: >> testing with sqlsmith on master at 3df51ca8b3 produced one instance of >> the following error: >> ERROR: failed to build any 6-way joins > Thanks for the test case! The attached modification to use only > longstanding test tables fails back to 9.5, but

Re: Printing LSN made easy

2020-11-29 Thread Craig Ringer
On Mon, Nov 30, 2020 at 1:10 AM Tom Lane wrote: > Michael Paquier writes: > > On Fri, Nov 27, 2020 at 04:10:27PM +0530, Ashutosh Bapat wrote: > >> Off list Craig Ringer suggested introducing a new format specifier > >> similar to %m for LSN but I did not get time to take a look at the > >> relev

Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module

2020-11-29 Thread Fujii Masao
On 2020/11/27 16:47, Bharath Rupireddy wrote: On Fri, Nov 27, 2020 at 12:26 PM Fujii Masao wrote: > > When I read the patch again, I found that, with the patch, the shutdown > > of worker_spi causes to report the following FATAL message. > > > > FATAL: terminating connection

Re: Add docs stub for recovery.conf

2020-11-29 Thread Craig Ringer
On Sat, Nov 14, 2020 at 1:42 AM Bruce Momjian wrote: > > Clearly we have need for documenting these renamings somewhere. We were > going to go with a simple URL redirect and a "tip" for > default/pre-installed roles, but I like the idea of doing something more > wholistic that covers all of our r

Re: autovac issue with large number of tables

2020-11-29 Thread Masahiko Sawada
On Sun, Nov 29, 2020 at 10:34 PM Kasahara Tatsuhito wrote: > > Hi, Thanks for you comments. > > On Fri, Nov 27, 2020 at 9:51 PM Fujii Masao > wrote: > > > > > > > > On 2020/11/27 18:38, Kasahara Tatsuhito wrote: > > > Hi, > > > > > > On Fri, Nov 27, 2020 at 1:43 AM Fujii Masao > > > wrote: > >

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-11-29 Thread Michael Paquier
On Wed, Nov 25, 2020 at 04:12:15PM +0900, Michael Paquier wrote: > Yeah, we had better fix and I guess backpatch something here. That's > annoying. I have considered that over the weekend, and let's be conservative. pg_database has gained a toast table since 12, and before that we would just have

Re: should INSERT SELECT use a BulkInsertState?

2020-11-29 Thread Justin Pryzby
On Mon, Nov 23, 2020 at 08:00:20PM -0600, Justin Pryzby wrote: > On Mon, Nov 02, 2020 at 12:45:51PM -0600, Justin Pryzby wrote: > > On Mon, Nov 02, 2020 at 07:53:45AM +0100, Luc Vlaming wrote: > > > On 30.10.20 05:51, Justin Pryzby wrote: > > > > On Thu, Oct 22, 2020 at 01:29:53PM +0100, Simon Rigg

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-11-29 Thread Noah Misch
On Mon, Sep 07, 2020 at 12:00:41PM +0530, Amit Kapila wrote: > Thanks, I have pushed the last patch. Let's wait for a day or so to > see the buildfarm reports https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sungazer&dt=2020-09-08%2006%3A24%3A14 failed the new 015_stream.pl test with the su

Re: Fix generate_useful_gather_paths for parallel unsafe pathkeys

2020-11-29 Thread Tomas Vondra
On 11/29/20 3:26 PM, James Coleman wrote: > On Mon, Nov 23, 2020 at 8:35 AM James Coleman wrote: >> >> On Sun, Nov 22, 2020 at 4:59 PM Tomas Vondra >> wrote: >>> ... >>> Thanks for the patches, I'll take a closer look next week. The 0002 >>> patch is clearly something we need to backpatch, not su

Re: Why does create_gather_merge_plan need make_sort?

2020-11-29 Thread Tomas Vondra
On 11/29/20 3:44 PM, James Coleman wrote: > On Mon, Nov 23, 2020 at 8:19 AM James Coleman wrote: >> >> .. >> >> So I'm +1 on turning it into an ERROR log instead, since it seems to >> me that encountering this case would almost certainly represent a bug >> in path generation. > > Here's a patc

Re: Additional improvements to extended statistics

2020-11-29 Thread Tomas Vondra
On 11/29/20 3:57 PM, Dean Rasheed wrote: >> On Wed, 18 Nov 2020 at 22:37, Tomas Vondra >> wrote: >>> >>> Seems fine to me, although the "_opt_ext_stats" is rather cryptic. >>> AFAICS we use "_internal" for similar functions. >>> > > I have been thinking about this some more. The one part of thi

Re: [sqlsmith] Planner error on lateral joins

2020-11-29 Thread Tom Lane
Andreas Seltenreich writes: > testing with sqlsmith on master at 3df51ca8b3 produced one instance of > the following error: > ERROR: failed to build any 6-way joins Thanks for the test case! The attached modification to use only longstanding test tables fails back to 9.5, but succeeds in 9.

Re: [sqlsmith] parallel worker errors "subplan ... was not initialized"

2020-11-29 Thread Tom Lane
Andreas Seltenreich writes: > yesterday's sqlsmith run on master at 3df51ca8b3 also yielded 4855 > queries failing with ERRORs like the following: > | ERROR: subplan "InitPlan 3 (returns $3)" was not initialized > | CONTEXT: parallel worker This is somewhat of a known issue [1], but thanks for

Re: CREATE INDEX CONCURRENTLY on partitioned index

2020-11-29 Thread Justin Pryzby
On Sat, Oct 31, 2020 at 01:31:17AM -0500, Justin Pryzby wrote: > Forking this thread, since the existing CFs have been closed. > https://www.postgresql.org/message-id/flat/20200914143102.GX18552%40telsasoft.com#58b1056488451f8594b0f0ba40996afd > > The strategy is to create catalog entries for all

[sqlsmith] parallel worker errors "subplan ... was not initialized"

2020-11-29 Thread Andreas Seltenreich
Hi, yesterday's sqlsmith run on master at 3df51ca8b3 also yielded 4855 queries failing with ERRORs like the following: , | ERROR: subplan "InitPlan 3 (returns $3)" was not initialized | CONTEXT: parallel worker ` They all run fine with parallel scans off. Below is a recipe that reprod

Re: range_agg

2020-11-29 Thread Alexander Korotkov
On Sun, Nov 29, 2020 at 8:11 PM Paul A Jungwirth wrote: > On Fri, Nov 27, 2020 at 12:35 AM Alexander Korotkov > wrote: > > I'd like to review this patch. Could you please rebase it once again? > > Thanks. > > Thanks! Here is a rebased version. It also includes one more cleanup > commit from Al

Re: Improving psql slash usage help message

2020-11-29 Thread Anastasia Lubennikova
On 02.11.2020 18:02, Anastasia Lubennikova wrote: Status update for a commitfest entry. This thread was inactive for a while. Is anyone going to continue working on it? My two cents on the topic: I don’t see it as a big problem in the first place. In the source code, \dE refers to foreign table

Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour

2020-11-29 Thread Justin Pryzby
On Mon, Oct 26, 2020 at 09:18:00AM +0200, Heikki Linnakangas wrote: > On 25/10/2020 23:56, Justin Pryzby wrote: > > On Fri, Oct 23, 2020 at 11:09:26PM +0300, Heikki Linnakangas wrote: > > > Findings in detail follow. > > > > Are you working on a patch for these ? > > I pushed the patch I included

Re: proposal: function pg_setting_value_split() to parse shared_preload_libraries etc.

2020-11-29 Thread Anastasia Lubennikova
On 23.10.2020 05:06, Ian Lawrence Barwick wrote: Having just submitted this, I realised I'm focussing on the GUCs which call "SplitDirectoriesString()" (as my specific uses case is for "shared_preload_libraries") but the patch does not consider the other GUC_LIST_INPUT settings, which call "Split

Re: archive status ".ready" files may be created too early

2020-11-29 Thread Anastasia Lubennikova
On 14.10.2020 03:06, Kyotaro Horiguchi wrote: The patch includes a fix for primary->standby case. But I'm not sure we can do that in the cascaded case. A standby is not aware of the structure of a WAL blob and has no idea of up-to-where to send the received blobs. However, if we can rely on the b

Re: pgbench - test whether a variable exists

2020-11-29 Thread Anastasia Lubennikova
On 20.10.2020 15:22, Ibrar Ahmed wrote: The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: tested, failed Documentation:not tested I am not very convinced to have

[sqlsmith] Planner error on lateral joins

2020-11-29 Thread Andreas Seltenreich
Hi, testing with sqlsmith on master at 3df51ca8b3 produced one instance of the following error: ERROR: failed to build any 6-way joins I can reproduce it on a fresh regression database with the query below. These were last logged in 2015. Back then, it resulted in this commit: http:/

Re: proposal: unescape_text function

2020-11-29 Thread Pavel Stehule
pá 27. 11. 2020 v 15:37 odesílatel Peter Eisentraut < peter.eisentr...@enterprisedb.com> napsal: > On 2020-10-07 11:00, Pavel Stehule wrote: > > Since the idea originated from unescaping unicode string > > literals i.e. > > select unescape('Odpov\u011Bdn\u00E1 osoba

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2020-11-29 Thread Justin Pryzby
On Mon, Nov 23, 2020 at 04:14:18PM -0500, Tom Lane wrote: > Justin Pryzby writes: > >> This patch has been waiting for input from a committer on the approach I've > >> taken with the patches since March 10, so I'm planning to set to "Ready" - > >> at > >> least ready for senior review. > > I too

Re: configure and DocBook XML

2020-11-29 Thread Tom Lane
Michael Paquier writes: > On Fri, Nov 27, 2020 at 10:29:24AM -0500, Tom Lane wrote: >> To me, it makes sense to have an option to do that, but I do find it >> surprising that it's the default. > But there is no need for an option, right? It is already possible to > override the location where xm

Re: Removing unneeded self joins

2020-11-29 Thread Heikki Linnakangas
On 28/11/2020 19:21, Andrey Lepikhov wrote: On 27.11.2020 21:49, Heikki Linnakangas wrote: On 31/10/2020 11:26, Andrey V. Lepikhov wrote: +    /* + * Process restrictlist to seperate out the self join quals from + * the other quals. e.g x = x goes to selfjoinqual

Re: Printing LSN made easy

2020-11-29 Thread Tom Lane
Michael Paquier writes: > On Fri, Nov 27, 2020 at 04:10:27PM +0530, Ashutosh Bapat wrote: >> Off list Craig Ringer suggested introducing a new format specifier >> similar to %m for LSN but I did not get time to take a look at the >> relevant code. AFAIU it's available only to elog/ereport, so may

Re: Improving spin-lock implementation on ARM.

2020-11-29 Thread Alexander Korotkov
On Thu, Nov 26, 2020 at 7:35 AM Krunal Bauskar wrote: > * x86 uses optimized xchg operation. > ARM too started supporting it (using Large System Extension) with > ARM-v8.1 but since it not supported with ARM-v8, GCC default tends > to roll more generic load-store assembly code. > > * gcc-9.4

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

2020-11-29 Thread Simon Riggs
On Fri, 20 Nov 2020 at 15:29, Alvaro Herrera wrote: > > Note on heap_prepare_freeze_tuple()'s fifth parameter, it's not valid to > pass OldestXmin; you need a multixact limit there, not an Xid limit. I > think the return value of GetOldestMultiXactId is a good choice. AFAICS > this means that yo

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

2020-11-29 Thread Simon Riggs
On Fri, 20 Nov 2020 at 11:47, Simon Riggs wrote: > > On Fri, 20 Nov 2020 at 10:15, Simon Riggs wrote: > > > > On Fri, 20 Nov 2020 at 01:40, Masahiko Sawada wrote: > > > > > > On Thu, Nov 19, 2020 at 8:02 PM Simon Riggs wrote: > > > > > > > > On Wed, 18 Nov 2020 at 17:59, Robert Haas wrote: > >

Re: Additional improvements to extended statistics

2020-11-29 Thread Dean Rasheed
> On Wed, 18 Nov 2020 at 22:37, Tomas Vondra > wrote: > > > > Seems fine to me, although the "_opt_ext_stats" is rather cryptic. > > AFAICS we use "_internal" for similar functions. > > I have been thinking about this some more. The one part of this that I still wasn't happy with was the way that

Re: Why does create_gather_merge_plan need make_sort?

2020-11-29 Thread James Coleman
On Mon, Nov 23, 2020 at 8:19 AM James Coleman wrote: > > On Sun, Nov 22, 2020 at 5:07 PM Tomas Vondra > wrote: > > > > On 11/22/20 10:31 PM, Tom Lane wrote: > > > Tomas Vondra writes: > > >> On 11/20/20 11:24 PM, James Coleman wrote: > > >>> While looking at another issue I noticed that create_g

Re: Fix generate_useful_gather_paths for parallel unsafe pathkeys

2020-11-29 Thread James Coleman
On Mon, Nov 23, 2020 at 8:35 AM James Coleman wrote: > > On Sun, Nov 22, 2020 at 4:59 PM Tomas Vondra > wrote: > > ... > > Thanks for the patches, I'll take a closer look next week. The 0002 > > patch is clearly something we need to backpatch, not sure about 0001 as > > it essentially enables new

Re: proposal: possibility to read dumped table's name from file

2020-11-29 Thread Pavel Stehule
Hi ne 29. 11. 2020 v 0:49 odesílatel Justin Pryzby napsal: > On Sat, Nov 28, 2020 at 09:14:35PM +0100, Pavel Stehule wrote: > > Any short or long option can be read from this file in simple format - > one > > option per line. Arguments inside double quotes can be multi lined. Row > > comments st

Re: autovac issue with large number of tables

2020-11-29 Thread Kasahara Tatsuhito
Hi, Thanks for you comments. On Fri, Nov 27, 2020 at 9:51 PM Fujii Masao wrote: > > > > On 2020/11/27 18:38, Kasahara Tatsuhito wrote: > > Hi, > > > > On Fri, Nov 27, 2020 at 1:43 AM Fujii Masao > > wrote: > >> > >> > >> > >> On 2020/11/26 10:41, Kasahara Tatsuhito wrote: > >>> On Wed, Nov 25,