Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)

2020-08-23 Thread hubert depesz lubaczewski
On Fri, Aug 21, 2020 at 07:54:13AM +0200, Pierre Giraud wrote: > It looks good to me too. Thanks a lot! > Let's not forget to notify Hubert (depesz) once integrated. Thanks a lot, and sorry for not responding earlier - vacation. Best regards, depesz

Re: ReplicationSlotsComputeRequiredXmin seems pretty questionable

2020-08-23 Thread Amit Kapila
On Sat, Aug 22, 2020 at 8:33 PM Tom Lane wrote: > > Amit Kapila writes: > > On Thu, Aug 20, 2020 at 10:28 PM Tom Lane wrote: > >> 2. On the other hand, the code is *releasing* the > >> ReplicationSlotControlLock before it calls > >> ProcArraySetReplicationSlotXmin, and that seems like a flat out

Re: Re: [HACKERS] Custom compression methods

2020-08-23 Thread Dilip Kumar
On Thu, Aug 13, 2020 at 5:18 PM Dilip Kumar wrote: > There was some question which Robert has asked in this mail, please find my answer inline. Also, I have a few questions regarding further splitting up this patch. > On Fri, Jun 19, 2020 at 10:33 PM Robert Haas wrote: > > > > > > - One thing

Re: list of extended statistics on psql

2020-08-23 Thread Julien Rouhaud
On Mon, Aug 24, 2020 at 6:13 AM Pavel Stehule wrote: > > po 24. 8. 2020 v 5:23 odesílatel Tatsuro Yamada > napsal: >> >> Hi! >> >> I created a POC patch that allows showing a list of extended statistics by >> "\dz" command on psql. I believe this feature helps DBA and users who >> would like to

Re: Creating a function for exposing memory usage of backend process

2020-08-23 Thread Fujii Masao
On 2020/08/24 13:13, Fujii Masao wrote: On 2020/08/24 13:01, torikoshia wrote: On 2020-08-22 21:18, Michael Paquier wrote: Thanks for reviewing! On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote: OK. Added a regression test on sysviews.sql. (0001-Added-a-regression-test-for-pg_

Re: display offset along with block number in vacuum errors

2020-08-23 Thread Amit Kapila
On Fri, Aug 21, 2020 at 12:31 PM Masahiko Sawada wrote: > > On Thu, 20 Aug 2020 at 21:12, Amit Kapila wrote: > > > > > > Attached are both the patches. The first one is to improve existing > > error context information, so I think we should back-patch to 13. The > > second one is to add additiona

Re: Creating a function for exposing memory usage of backend process

2020-08-23 Thread Fujii Masao
On 2020/08/24 13:01, torikoshia wrote: On 2020-08-22 21:18, Michael Paquier wrote: Thanks for reviewing! On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote: OK. Added a regression test on sysviews.sql. (0001-Added-a-regression-test-for-pg_backend_memory_contex.patch) Fujii-san gav

Re: list of extended statistics on psql

2020-08-23 Thread Pavel Stehule
po 24. 8. 2020 v 5:23 odesílatel Tatsuro Yamada < tatsuro.yamada...@nttcom.co.jp> napsal: > Hi! > > I created a POC patch that allows showing a list of extended statistics by > "\dz" command on psql. I believe this feature helps DBA and users who > would like to know all extended statistics easily

Re: Creating a function for exposing memory usage of backend process

2020-08-23 Thread torikoshia
On 2020-08-22 21:18, Michael Paquier wrote: Thanks for reviewing! On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote: OK. Added a regression test on sysviews.sql. (0001-Added-a-regression-test-for-pg_backend_memory_contex.patch) Fujii-san gave us an example, but I added more simple on

list of extended statistics on psql

2020-08-23 Thread Tatsuro Yamada
Hi! I created a POC patch that allows showing a list of extended statistics by "\dz" command on psql. I believe this feature helps DBA and users who would like to know all extended statistics easily. :-D I have not a strong opinion to assign "\dz". I prefer "\dx" or "\de*" than "\dz" but they we

Continuing instability in insert-conflict-specconflict test

2020-08-23 Thread Tom Lane
We've seen repeated failures in the tests added by commit 43e084197: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2020-08-23%2005%3A46%3A17 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tern&dt=2020-08-04%2001%3A05%3A30 https://buildfarm.postgresql.org/cgi-bin/show_lo

Re: proposal - function string_to_table

2020-08-23 Thread Peter Smith
I have re-checked the string_to_table_20200821.patch. Below is one remaining problem. COMMENT (help text) +Splits the string at occurrences +of delimiter and forms the remaining data +into a table with one text type column. +If delimiter is NULL, +ea

Re: Row estimates for empty tables

2020-08-23 Thread Tom Lane
Pavel Stehule writes: > I am sending a patch that is years used in GoodData. I'm quite unexcited about that. I'd be the first to agree that the ten-pages estimate is a hack, but it's not an improvement to ask users to think of a better value ... especially not as a one-size-fits- all-relations G

Re: Yet another fast GiST build (typo)

2020-08-23 Thread Andrey M. Borodin
> 14 авг. 2020 г., в 14:21, Pavel Borisov написал(а): > > I see this feature quite useful in concept and decided to test it. Thanks for reviewing and benchmarking, Pavel! I agree with your suggestions. PFA patch with relevant changes. Thanks a lot. Best regards, Andrey Borodin. v11-0001-

Re: [PATCH] Covering SPGiST index

2020-08-23 Thread Andrey M. Borodin
Hi! > 17 авг. 2020 г., в 21:04, Pavel Borisov написал(а): > > Postgres Professional: http://postgrespro.com > I'm looking into the patch. I have few notes: 1. I see that in src/backend/access/spgist/README you describe SP-GiST tuple as sequence of {Value, ItemPtr to heap, Included attributes