Re: text coverage for EXTRACT()

2020-06-13 Thread Peter Eisentraut
On 2020-06-09 16:11, Tom Lane wrote: Vik Fearing writes: On 6/9/20 1:36 PM, Peter Eisentraut wrote: During the discussion in [0] I noticed that the extract()/date_part() variants for time, timetz, and interval had virtually no test coverage. So I put some more tests together, which should be u

Re: some grammar refactoring

2020-06-13 Thread Peter Eisentraut
On 2020-05-19 08:43, Peter Eisentraut wrote: Here is a series of patches to do some refactoring in the grammar around the commands COMMENT, DROP, SECURITY LABEL, and ALTER EXTENSION ... ADD/DROP. These patches have been committed. -- Peter Eisentraut http://www.2ndQuadrant.com/ Po

Re: Read access for pg_monitor to pg_replication_origin_status view

2020-06-13 Thread Michael Paquier
On Wed, Jun 10, 2020 at 12:35:49PM +0900, Michael Paquier wrote: > On Tue, Jun 09, 2020 at 05:07:39PM +0900, Masahiko Sawada wrote: >> I agreed with the change you proposed. > > OK, thanks. Then let's wait a couple of days to see if anybody has > any objections with the removal of the hardcoded s

Re: Add tap test for --extra-float-digits option

2020-06-13 Thread Michael Paquier
On Sat, Jun 13, 2020 at 06:34:46PM +0900, Dong Wook Lee wrote: > First of all, thank you for merging my patch. > And I'm sorry, I should have been more careful about it. Next time I > will follow format. And there is something I will tell you We are all here to learn. It is good to begin with sma

Re: Transactions involving multiple postgres foreign servers, take 2

2020-06-13 Thread Masahiko Sawada
On Sat, 13 Jun 2020 at 14:02, Amit Kapila wrote: > > On Fri, Jun 12, 2020 at 6:24 PM Masahiko Sawada > wrote: > > > > On Fri, 12 Jun 2020 at 19:24, Amit Kapila wrote: > > > > > > > > Which are these other online transactions? I had assumed that foreign > > > > > transaction resolver process is

Re: exp() versus the POSIX standard

2020-06-13 Thread Tom Lane
Emre Hasegeli writes: >> No, no kind of GUC switch is needed. Just drop underflow/overflow checks. >> You'll get 0 or Infinity in expected places, and infinities are okay since >> 2007. > This is out of scope of this thread. Yeah, that. At the moment I'm just interested in making the float an

Re: Warn when parallel restoring a custom dump without data offsets

2020-06-13 Thread Justin Pryzby
On Mon, May 25, 2020 at 01:54:29PM -0500, David Gilman wrote: > > Is it possible to dump to stdout (or pipe to cat or dd) to avoid a new > > option ? > > The underlying IPC::Run code seems to support piping in a cross-platform > way. I am not a Perl master though and after spending an evening try

Re: new heapcheck contrib module (typos)

2020-06-13 Thread Erik Rijkers
On 2020-06-12 23:06, Mark Dilger wrote: [v7-0001-Adding-verify_heapam-and-pg_amcheck.patch] [v7-0002-Adding-checks-o...ations-of-hint-bit.patch] I came across these typos in the sgml: --exclude-scheam should be --exclude-schema table should be --table I found this connection problem

Re: Infinities in type numeric

2020-06-13 Thread Tom Lane
Here's a v2 patch: * Rebased over today's nearby commits * Documentation changes added * Sort abbrev support improved per Andrew's suggestions * Infinities now considered to fail any typmod precision limit, per discussion with Robert. regards, tom lane diff --git a/c

Re: hashagg slowdown due to spill changes

2020-06-13 Thread Tomas Vondra
On Sat, Jun 13, 2020 at 11:48:09AM -0700, Jeff Davis wrote: On Fri, 2020-06-12 at 17:12 -0700, Andres Freund wrote: Do you think we should tackle this for 13? To me 4cad2534da seems like a somewhat independent improvement to spillable hashaggs. We've gone back and forth on this issue a few tim

Re: jacana vs -Wimplicit-fallthrough

2020-06-13 Thread Andrew Dunstan
On 6/13/20 12:25 PM, Tom Lane wrote: > I happened to notice today that, while the rest of the buildfarm is free > of implicit-fallthrough warnings, jacana is emitting a whole boatload of > them. It looks like it must have a different idea of which spellings of > the "fall through" comment are al

Re: hashagg slowdown due to spill changes

2020-06-13 Thread Jeff Davis
On Fri, 2020-06-12 at 17:12 -0700, Andres Freund wrote: > Do you think we should tackle this for 13? To me 4cad2534da seems > like a > somewhat independent improvement to spillable hashaggs. We've gone back and forth on this issue a few times, so let's try to get some agreement before we revert 4c

Re: what can go in root.crt ?

2020-06-13 Thread Bruce Momjian
On Fri, Jun 12, 2020 at 04:17:56PM -0400, Chapman Flack wrote: > On 06/12/20 15:13, Bruce Momjian wrote: > > Without that ability, every client would need be changed as soon as the > > server certificate was changed. Allowing intermediate certificates to > > function as root certificates would fix

Re: Uninitialized-variable warnings in nbtinsert.c

2020-06-13 Thread Tom Lane
Peter Geoghegan writes: > On Sat, Jun 13, 2020 at 9:17 AM Tom Lane wrote: >> I scraped the buildfarm's compiler warnings today, as I do from >> time to time, and I noticed that half a dozen animals that normally >> don't report any uninitialized-variable warnings are complaining >> about "curitup

Re: Uninitialized-variable warnings in nbtinsert.c

2020-06-13 Thread Peter Geoghegan
On Sat, Jun 13, 2020 at 9:17 AM Tom Lane wrote: > I scraped the buildfarm's compiler warnings today, as I do from > time to time, and I noticed that half a dozen animals that normally > don't report any uninitialized-variable warnings are complaining > about "curitup" in _bt_doinsert. (Clearly yo

jacana vs -Wimplicit-fallthrough

2020-06-13 Thread Tom Lane
I happened to notice today that, while the rest of the buildfarm is free of implicit-fallthrough warnings, jacana is emitting a whole boatload of them. It looks like it must have a different idea of which spellings of the "fall through" comment are allowed. Could you check its documentation to se

Uninitialized-variable warnings in nbtinsert.c

2020-06-13 Thread Tom Lane
I scraped the buildfarm's compiler warnings today, as I do from time to time, and I noticed that half a dozen animals that normally don't report any uninitialized-variable warnings are complaining about "curitup" in _bt_doinsert. We traditionally ignore such warnings from compilers that have demon

Re: Definitional issue: stddev_pop (and related) for 1 input

2020-06-13 Thread Tom Lane
Dean Rasheed writes: > The patch looks reasonable, except I wonder if all compilers are smart > enough to realise that totCount is always initialised. I think they should be, since that if-block ends with a return; the only way to get to the use of totCount is for both parts of the first if-condi

Re: pg_upgrade fails if vacuum_defer_cleanup_age > 0

2020-06-13 Thread Bruce Momjian
On Wed, Jun 10, 2020 at 04:07:05PM +0200, Laurenz Albe wrote: > A customer's upgrade failed, and it took me a while to > figure out that the problem was that they had set > "vacuum_defer_cleanup_age=1" on the new cluster. > > The consequence was that the "vacuumdb --freeze" that > takes place

Re: Resetting spilled txn statistics in pg_stat_replication

2020-06-13 Thread Fujii Masao
On 2020/06/13 14:23, Amit Kapila wrote: On Fri, Jun 12, 2020 at 6:11 PM Magnus Hagander wrote: On Fri, Jun 12, 2020 at 10:23 AM Amit Kapila wrote: The problem with "lifetime of a process" is that it's not predictable. A replication process might "bounce" for any reason, and it is nor

Re: Definitional issue: stddev_pop (and related) for 1 input

2020-06-13 Thread Dean Rasheed
On Fri, 12 Jun 2020 at 20:53, Tom Lane wrote: > > I wrote: > > Before v12, stddev_pop() had the following behavior with just a > > single input value: > > ... > > As of v12, though, all three cases produce 0. I am not sure what > > to think about that with respect to an infinity input, but I'm >

Re: Add tap test for --extra-float-digits option

2020-06-13 Thread Dong Wook Lee
> That's more of an habit to look around, find similar patterns and the > check if these are covered. > > I have applied your patch, and you may want to be careful about a > couple of things: > - Please avoid top-posting on the mailing lists: > https://en.wikipedia.org/wiki/Posting_style#Top-postin