On Fri, May 08, 2020 at 09:21:25PM -0700, Peter Geoghegan wrote:
> Fine with me.
Thanks, Peter. Done.
--
Michael
signature.asc
Description: PGP signature
On Sat, May 9, 2020 at 3:19 PM Tomas Vondra
wrote:
> I'm generally OK with most of this - I'd probably keep the single-line
> format, but I don't feel very strongly about that and if others think
> using two lines is better ...
>
> Barring objections I'll get this polished and pushed soon-ish (say
On Sat, May 09, 2020 at 07:11:56PM -0400, Tom Lane wrote:
> I'd be OK with pushing it now, but I dunno about other people.
Sounds like a good idea to me to apply this part now.
> If we do want to push this sort of thing now, the nearby changes
> to enable fallthrough warnings should go in too.
I
Andres Freund writes:
> On 2020-05-09 14:15:01 -0400, Tom Lane wrote:
>> Andres Freund writes:
>>> Since gcc has a warning detecting such definition, I think we ought to
>>> automatically add it when available?
>> +1
> Any opinion about waiting for branching or not?
I'd be OK with pushing it n
On Sat, May 09, 2020 at 10:50:12PM +0200, Tomas Vondra wrote:
On Sat, May 09, 2020 at 03:18:36PM -0500, Justin Pryzby wrote:
Checking if it's possible to address this Opened Item before 13b1.
https://wiki.postgresql.org/wiki/PostgreSQL_13_Open_Items
consistency of explain output: two spaces, eq
Em sáb., 9 de mai. de 2020 às 17:48, Tomas Vondra <
tomas.von...@2ndquadrant.com> escreveu:
> On Sat, May 09, 2020 at 02:51:50PM -0300, Ranier Vilela wrote:
> >Em sáb., 9 de mai. de 2020 às 14:44, Tomas Vondra <
> >tomas.von...@2ndquadrant.com> escreveu:
> >
> >> On Sat, May 09, 2020 at 06:48:59AM
On Sat, May 09, 2020 at 03:18:36PM -0500, Justin Pryzby wrote:
Checking if it's possible to address this Opened Item before 13b1.
https://wiki.postgresql.org/wiki/PostgreSQL_13_Open_Items
consistency of explain output: two spaces, equals vs colons, semicolons
(incremental sort)
Yes. Now that
On Sat, May 09, 2020 at 02:51:50PM -0300, Ranier Vilela wrote:
Em sáb., 9 de mai. de 2020 às 14:44, Tomas Vondra <
tomas.von...@2ndquadrant.com> escreveu:
On Sat, May 09, 2020 at 06:48:59AM -0300, Ranier Vilela wrote:
>Em sáb., 9 de mai. de 2020 às 01:45, Tom Lane
escreveu:
>
>> James Coleman
Checking if it's possible to address this Opened Item before 13b1.
https://wiki.postgresql.org/wiki/PostgreSQL_13_Open_Items
consistency of explain output: two spaces, equals vs colons, semicolons
(incremental sort)
On Sun, Apr 19, 2020 at 09:46:55AM -0400, James Coleman wrote:
> On Sat, Apr 18
Hi,
On 2020-05-09 14:15:01 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Since gcc has a warning detecting such definition, I think we ought to
> > automatically add it when available?
>
> +1
Any opinion about waiting for branching or not?
- Andres
On Fri, 8 May 2020 at 03:03, Kyotaro Horiguchi
wrote:
>
> A user can start physical replication without needing CONNECT on any
> database if it has REPLICATION attribute. That means any user that
> is allowed logical replication on a specific database (or even no
> databases) can replicate the w
Stephen Frost writes:
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
>> ISTM those statements are contradictory. The two privileges could
>> only be called orthogonal if it's possible to make use of one without
>> having the other. As things stand, REPLICATION without LOGIN is an
>> entirely useless s
Andres Freund writes:
> Since gcc has a warning detecting such definition, I think we ought to
> automatically add it when available?
+1
regards, tom lane
Fabien COELHO writes:
> Possibly. I'm a little at odds with Type not being above types, but far on
> the left, so that you cannot really "see" that it is about the format,
Yeah, agreed. We can adjust the space in the header independently of
what's in the table entries, so it'd be possible to p
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Michael Paquier writes:
> > Not to make the life of everybody more complicated here, but I don't
> > agree. LOGIN and REPLICATION are in my opinion completely orthogonal
> > and it sounds more natural IMO that a REPLICATION user should be able
Em sáb., 9 de mai. de 2020 às 14:44, Tomas Vondra <
tomas.von...@2ndquadrant.com> escreveu:
> On Sat, May 09, 2020 at 06:48:59AM -0300, Ranier Vilela wrote:
> >Em sáb., 9 de mai. de 2020 às 01:45, Tom Lane
> escreveu:
> >
> >> James Coleman writes:
> >> > There are always full sort groups before
Hi,
ISTM that it's our coding style that we use
something
my_paramless_func(void)
{
...
}
definitions rather than omitting the (void), which makes the function
look like an old-style function declaration. I somewhat regularly notice
such omissions during review, and fix them.
Since gcc has a wa
On Fri, May 08, 2020 at 07:36:38PM -0400, James Coleman wrote:
On Fri, May 8, 2020 at 7:14 PM Tomas Vondra
wrote:
On Fri, Apr 24, 2020 at 04:35:02PM -0400, James Coleman wrote:
>On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote:
>>
>> On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote:
>
On Sat, May 09, 2020 at 06:48:59AM -0300, Ranier Vilela wrote:
Em sáb., 9 de mai. de 2020 às 01:45, Tom Lane escreveu:
James Coleman writes:
> There are always full sort groups before any prefix groups can happen,
> so we know (even though the tooling doesn't) that the 2nd test can
> never co
Hello Tom,
Here's a more fully fleshed out draft for this, with stylesheet
markup to get extra space around the column type names.
I find this added spacing awkward, espacially as attribute names are
always one word anyway. I prefer the non spaced approach.
It's certainly arguable that tha
Michael Paquier writes:
> Not to make the life of everybody more complicated here, but I don't
> agree. LOGIN and REPLICATION are in my opinion completely orthogonal
> and it sounds more natural IMO that a REPLICATION user should be able
> to log into the server only if it has LOGIN defined.
IST
On 2020/05/08 12:10, Kyotaro Horiguchi wrote:
At Fri, 8 May 2020 11:31:42 +0900, Fujii Masao
wrote in
You mean that pg_lsn_pli() and pg_lsn_mii() should emit an error like
"the number of bytes to add/subtract cannnot be NaN" when NaN is
specified?
The function is called while executing an e
On Fri, May 8, 2020 at 12:07 PM Amit Langote wrote:
> On Fri, May 8, 2020 at 2:06 AM Bruce Momjian wrote:
> > On Fri, May 8, 2020 at 12:32:16AM +0900, Amit Langote wrote:
> > > c8434d64c implements a new feature whereby, to use partitionwise join,
> > > partition bounds of the tables being joine
Em sáb., 9 de mai. de 2020 às 01:45, Tom Lane escreveu:
> James Coleman writes:
> > There are always full sort groups before any prefix groups can happen,
> > so we know (even though the tooling doesn't) that the 2nd test can
> > never contradict the first.
>
> So maybe an assertion enforcing th
On Fri, May 08, 2020 at 03:03:26PM +0900, Kyotaro Horiguchi wrote:
> At Fri, 8 May 2020 01:02:11 -0400, Alvaro Herrera
> wrote in
>> On 2020-May-07, Tom Lane wrote:
>>> FWIW, I would argue that LOGIN permits logging in on a regular SQL
>>> connection, while REPLICATION should permit logging in o
On Sat, May 9, 2020 at 2:49 AM Alvaro Herrera
wrote:
> On 2018-Sep-13, Tom Lane wrote:
>
> > What I was vaguely imagining is that win32_port.h could #include
> > whichever Windows header defines these functions and structs, and
> > then do
> >
> > #define stat __stat64
> >
> > static inline ... _
On Fri, May 08, 2020 at 03:02:26PM +0500, godjan • wrote:
> Can you recommend what to use to determine which quorum standby
> should be promoted in such case?
> We planned to use pg_last_wal_receive_lsn() to determine which has
> fresh data but if it returns the beginning of the segment on both
>
On Fri, May 08, 2020 at 07:45:16PM -0400, Alvaro Herrera wrote:
> Yeah, there's a lot of frontend code that uses free() instead of
> pg_free(). There are too many of these that worrying about a single one
> would not improve things much. I guess we could convert them all, but I
> don't see much p
28 matches
Mail list logo
