Fix compilation failure against LLVM 11

2020-04-25 Thread Jesse Zhang
Hi hackers, My local build of master started failing last night with this error: llvmjit_inline.cpp:59:10: fatal error: 'llvm/IR/CallSite.h' file not found #include ^~~~ I searched my inbox and the archive, strange that nobody else is seeing this. Turns out that LLVM h

001_rep_changes.pl timeout on jacana/bowerbird

2020-04-25 Thread Noah Misch
Starting 2019-11-17, jacana and bowerbird (different compiler, same machine?) have failed four times like this: # poll_query_until timed out executing this query: # SELECT pg_current_wal_lsn() <= replay_lsn AND state = 'streaming' FROM pg_catalog.pg_stat_replication WHERE application_name = 'tap_

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-25 Thread Tomas Vondra
On Sat, Apr 25, 2020 at 06:47:41PM -0400, James Coleman wrote: On Sat, Apr 25, 2020 at 5:41 PM David Rowley wrote: On Sun, 26 Apr 2020 at 00:40, Tomas Vondra wrote: > This reminds me our attempts to add bloom filters to hash joins, which I > think ran into mostly the same challenge of decidin

Re: Using Valgrind to detect faulty buffer accesses (no pin or buffer content lock held)

2020-04-25 Thread Peter Geoghegan
On Fri, Apr 24, 2020 at 6:37 PM Peter Geoghegan wrote: > The final two patches fix the two newly discovered bugs -- I don't > have a fix for the first bug yet, since that one is more complicated > (and probably more serious). I pushed both of the two fixes that I posted yesterday -- fixes for the

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-25 Thread James Coleman
On Sat, Apr 25, 2020 at 5:41 PM David Rowley wrote: > > On Sun, 26 Apr 2020 at 00:40, Tomas Vondra > wrote: > > This reminds me our attempts to add bloom filters to hash joins, which I > > think ran into mostly the same challenge of deciding when the bloom > > filter can be useful and is worth t

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-25 Thread David Rowley
On Sun, 26 Apr 2020 at 00:40, Tomas Vondra wrote: > This reminds me our attempts to add bloom filters to hash joins, which I > think ran into mostly the same challenge of deciding when the bloom > filter can be useful and is worth the extra work. Speaking of that, it would be interesting to see h

Re: Improving psql slash usage help message

2020-04-25 Thread David G. Johnston
On Sat, Apr 25, 2020 at 12:29 PM Hamid Akhtar wrote: > > "\dE" displays the list with a "List of relations" heading whereas "\det" > displays "List of foreign tables". So, to differentiate the two, I suggest > to change the help message for "\dE" to: > > \dE[S+] [PATTERN] list foreign rela

Improving psql slash usage help message

2020-04-25 Thread Hamid Akhtar
psql slash usage show two options for listing foreign tables. \dE[S+] [PATTERN] list foreign tables \det[+] [PATTERN] list foreign tables This seems a little odd especially when the output of both of these commands is different. postgres=# \dE+ List of relations Schema

Re: WIP: WAL prefetch (another approach)

2020-04-25 Thread Dmitry Dolgov
> On Tue, Apr 21, 2020 at 05:26:52PM +1200, Thomas Munro wrote: > > One report I heard recently said that if you get rid of I/O stalls, > pread() becomes cheap enough that the much higher frequency lseek() > calls I've complained about elsewhere[1] become the main thing > recovery is doing, at lea

Re: Anybody want to check for Windows timezone updates?

2020-04-25 Thread Tom Lane
=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= writes: >> Could you verify that there are no complaints now with HEAD? >> I might've fat-fingered something. > Nothing gets reported with current HEAD. OK, thanks for checking! regards, tom lane

Re: Autovacuum on partitioned table (autoanalyze)

2020-04-25 Thread Justin Pryzby
On Wed, Mar 18, 2020 at 11:30:39AM -0500, Justin Pryzby wrote: > In the past, I think there's was talk that maybe someone would invent a clever > way to dynamically combine all the partitions' statistics, so analyzing the > parent wasn't needed. [...] I happened across the thread I was referring t

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

2020-04-25 Thread Tomas Vondra
On Fri, Apr 24, 2020 at 09:22:34PM -0400, James Coleman wrote: On Fri, Apr 24, 2020 at 5:55 PM Tomas Vondra wrote: On Fri, Apr 24, 2020 at 09:38:54AM -0400, James Coleman wrote: >On Thu, Apr 23, 2020 at 10:55 AM Tomas Vondra > wrote: >> >> On Thu, Apr 23, 2020 at 09:02:26AM -0400, James Colema

Re: Parallel Append can break run-time partition pruning

2020-04-25 Thread David Rowley
On Thu, 23 Apr 2020 at 22:37, David Rowley wrote: > For now. I'd still like to get a bit more confidence that the only > noticeable change in the outcome here is that we're now pulling up > sub-Appends in all cases. I've read the code a number of times and > just can't quite see any room for anyth

Re: Anybody want to check for Windows timezone updates?

2020-04-25 Thread Juan José Santamaría Flecha
On Fri, Apr 24, 2020 at 11:55 PM Tom Lane wrote: > > Thanks! That was a bit tedious --- I suppose it's not quite worth > automating further, but I did make some effort to remove the cross-version > formatting hazards in that table. > That might explain why it gets updated not so often. Forcing