Re: Greatest Common Divisor

2020-01-25 Thread Vik Fearing
On 25/01/2020 15:18, Dean Rasheed wrote: > > Committed with some adjustments, mostly cosmetic but a couple more > substantive: Thanks! > The code to guard against a floating point exception with inputs of > (INT_MIN, -1) wasn't quite right because it actually just moved the > problem so that it

Re: vacuum verbose detail logs are unclear; log at *start* of each stage

2020-01-25 Thread Justin Pryzby
On Wed, Jan 22, 2020 at 02:34:57PM +0900, Michael Paquier wrote: > From patch 0003: > /* > +* Indent multi-line DETAIL if being sent to client (verbose) > +* We don't know if it's sent to the client (client_min_messages); > +* Also, that affects output to the logfile

Re: t/010_pg_basebackup.pl checksum verify fails with RELSEG_SIZE 1

2020-01-25 Thread Tom Lane
Thomas Munro writes: > Sometimes I set RELSEG_SIZE to 1, as a way to get the various in-tree > tests to give the relation segment code a good workout. That's > outside the range that configure --with-segsize would allow and > therefore not really a supported size (it's set in GB), but it's very >

t/010_pg_basebackup.pl checksum verify fails with RELSEG_SIZE 1

2020-01-25 Thread Thomas Munro
Hi, Sometimes I set RELSEG_SIZE to 1, as a way to get the various in-tree tests to give the relation segment code a good workout. That's outside the range that configure --with-segsize would allow and therefore not really a supported size (it's set in GB), but it's very useful for giving the rela

Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)

2020-01-25 Thread Andres Freund
Hi, On 2020-01-25 15:43:41 +0100, Magnus Hagander wrote: > On Fri, Jan 24, 2020 at 8:52 PM Andres Freund wrote: > > Additionally pg_stat_bgwriter.buffers_backend also counts writes done by > > autovacuum et al. > > I think it'd make sense to at least split buffers_backend into > > buffers_backen

Re: Duplicate Workers entries in some EXPLAIN plans

2020-01-25 Thread Tom Lane
Andres Freund writes: > I wonder if we could introduce a debug GUC that makes parallel worker > acquisition just retry in a loop, for a time determined by the GUC. That > obviously would be a bad idea to do in a production setup, but it could > be good enough for regression tests? There are some

Re: Duplicate Workers entries in some EXPLAIN plans

2020-01-25 Thread Andres Freund
Hi, On 2020-01-25 14:23:50 -0500, Tom Lane wrote: > A side effect of this change is that per-worker JIT info is now > printed one plan level further down: before it was printed on > the Gather node, but now it's attached to the Gather's child, > because that's where we print other per-worker data.

Re: Duplicate Workers entries in some EXPLAIN plans

2020-01-25 Thread Tom Lane
I wrote: > It's still really unclear to me how we could exercise any of > this behavior meaningfully in a regression test. I thought > for a little bit about using the TAP infrastructure instead > of a traditional-style test, but it seems like that doesn't > buy anything except for a bias towards

Re: Duplicate Workers entries in some EXPLAIN plans

2020-01-25 Thread Tom Lane
Maciek Sakrejda writes: > For what it's worth, this version makes sense to me. Thanks for looking. Here's a version that deals with the JIT instrumentation. As Andres noted far upthread, that was also really bogusly done before. Not only could you get multiple "JIT" subnodes on a Gather node,

Re: Strange coding in _mdfd_openseg()

2020-01-25 Thread Noah Misch
On Thu, Apr 04, 2019 at 12:15:52PM +0900, Kyotaro HORIGUCHI wrote: > At Wed, 3 Apr 2019 13:47:46 -0700, Andres Freund wrote > in <20190403204746.2yumq7c2mirmo...@alap3.anarazel.de> > > On 2019-04-04 09:24:49 +1300, Thomas Munro wrote: > > > On Wed, Apr 3, 2019 at 5:34 PM Kyotaro HORIGUCHI > > >

Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support

2020-01-25 Thread Nino Floris
Attached is the new patch rebased onto master. Best regards, Nino Floris On Thu, Jan 16, 2020 at 11:00 PM Tomas Vondra wrote: > > On Fri, Nov 29, 2019 at 11:29:03AM +0900, Michael Paquier wrote: > >On Mon, Nov 11, 2019 at 03:44:54PM +0100, Nino Floris wrote: > >> Alright, as usual life got in th

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2020-01-25 Thread Sehrope Sarkuni
Hi, I took a look at this patch. With some additions I think the feature itself is useful but the patch needs more work. It also doesn't have any of its own automated tests yet so the testing below was done manually. The attached file, kms_v2.patch, is a rebased version of the kms_v1.patch that f

Re: [Proposal] Global temporary tables

2020-01-25 Thread 曾文旌(义从)
Thank you for review patch. > 2020年1月24日 下午4:20,Konstantin Knizhnik 写道: > > > > On 23.01.2020 19:28, 曾文旌(义从) wrote: >> >> I'm trying to improve this part of the implementation in >> global_temporary_table_v7-pg13.patch >> Please check my patch and give me feedback. >> >> >> Thanks >> >> W

Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)

2020-01-25 Thread Magnus Hagander
On Fri, Jan 24, 2020 at 8:52 PM Andres Freund wrote: > > Hi, > > Currently pg_stat_bgwriter.buffers_backend is pretty useless to gauge > whether backends are doing writes they shouldn't do. That's because it > counts things that are either unavoidably or unlikely doable by other > parts of the sys

Re: Greatest Common Divisor

2020-01-25 Thread Dean Rasheed
On Mon, 20 Jan 2020 at 08:04, Vik Fearing wrote: > > On 20/01/2020 08:44, Dean Rasheed wrote: > >> > > I see this has been marked RFC. I'll take it, > Committed with some adjustments, mostly cosmetic but a couple more substantive: The code to guard against a floating point exception with inputs

Re: [WIP] UNNEST(REFCURSOR): allowing SELECT to consume data from a REFCURSOR

2020-01-25 Thread Dent John
> On 19 Jan 2020, at 22:30, Dent John wrote: > > I have not yet made steps towards documentation, nor yet rebased, so the > Makefile chunk will probably still fail. Attached patch addresses these points, so should now apply cleanly agains dev. I also changed the OID assigned to ROWS_IN and its

Re: Parallel grouping sets

2020-01-25 Thread Amit Kapila
On Sat, Jan 25, 2020 at 4:22 AM Jesse Zhang wrote: > > On Thu, Jan 23, 2020 at 2:47 AM Amit Kapila wrote: > > > > On Sun, Jan 19, 2020 at 2:23 PM Richard Guo wrote: > > > > > > I realized that there are two patches in this thread that are > > > implemented according to different methods, which c

Re: Allow to_date() and to_timestamp() to accept localized names

2020-01-25 Thread Peter Eisentraut
On 2020-01-24 19:01, Peter Eisentraut wrote: postgres=# select to_char(now(),'TMmonth'); to_char ιανουαρίου (1 row) which is the genitive of ιανουάριος. You use the genitive form for a date (24th of January) but the nominative otherwise. But the reverse mapping can only tak