Fix a comment in CreateLockFile

2019-12-07 Thread Hadi Moshayedi
It seems that explanation for the contents of the pid file has moved to pidfile.h, but the comments in CreateLockFile() still point to miscadmin.h. The attached patch updates those pointers. diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c index 83c9514856..de554e

Re: proposal: minscale, rtrim, btrim functions for numeric

2019-12-07 Thread Pavel Stehule
Hi ne 8. 12. 2019 v 2:23 odesílatel Karl O. Pinc napsal: > Hello Pavel, > > On Mon, 11 Nov 2019 15:47:37 +0100 > Pavel Stehule wrote: > > > Here is a patch. It's based on Dean's suggestions. > > > > I implemented two functions - first minscale, second trim_scale. The > > overhead of second is m

Re: Windows buildfarm members vs. new async-notify isolation test

2019-12-07 Thread Amit Kapila
On Sat, Dec 7, 2019 at 10:50 PM Tom Lane wrote: > > Amit Kapila writes: > > On Sat, Dec 7, 2019 at 5:01 AM Tom Lane wrote: > >> A possible theory as to what's happening is that the kernel scheduler > >> is discriminating against listener2's signal management thread(s) > >> and not running them u

Re: Windows buildfarm members vs. new async-notify isolation test

2019-12-07 Thread Amit Kapila
On Sun, Dec 8, 2019 at 1:26 AM Tom Lane wrote: > > So, just idly looking at the code in src/backend/port/win32/signal.c > and src/port/kill.c, I have to wonder why we have this baroque-looking > design of using *two* signal management threads. And, if I'm > reading it right, we create an entire n

Re: proposal: minscale, rtrim, btrim functions for numeric

2019-12-07 Thread Karl O. Pinc
Hello Pavel, On Mon, 11 Nov 2019 15:47:37 +0100 Pavel Stehule wrote: > Here is a patch. It's based on Dean's suggestions. > > I implemented two functions - first minscale, second trim_scale. The > overhead of second is minimal - so I think it can be good to have it. > I started design with the

Re: [proposal] recovery_target "latest"

2019-12-07 Thread Grigory Smolkin
On 11/21/19 1:46 PM, Peter Eisentraut wrote: On 2019-11-08 05:00, Grigory Smolkin wrote: Attached new patch revision, now end of available WAL is defined as the fact of missing required WAL. In case of standby, the end of WAL is defined as 2 consecutive switches of WAL source, that didn`t provid

RE: [Proposal] Level4 Warnings show many shadow vars

2019-12-07 Thread Ranier Vilela
This is the first part of the variable shadow fixes. Basically it consists of renaming the variables in collision with the global ones, with the minimum change in the semantics. make check pass all the tests. regards, Ranier Vileladiff --git a/src/backend/access/transam/xlog.c b/src/backend/acce

RE: psql small improvement patch

2019-12-07 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Thank you very much for your comments. I seem to have thought easily. I will reconsider. Regards. -Original Message- From: Mark Dilger [mailto:hornschnor...@gmail.com] Sent: Sunday, December 8, 2019 12:20 AM To: Shinoda, Noriyoshi (PN Japan A&PS Delivery) ; pgsql-hackers@lists.postgresq

Re: ssl passphrase callback

2019-12-07 Thread Tom Lane
Andrew Dunstan writes: > Well that pretty much brings us back to the patch as submitted :-) Yeah, pretty nearly. Taking a quick look over the v3 patch, my only quibble is that it doesn't provide any convenient way for the external module to make decisions about how to interact with ssl_passphras

Re: log bind parameter values on error

2019-12-07 Thread Tom Lane
Alvaro Herrera writes: > I added some tests to the pgbench suite in the attached. I also finally > put it the business to limit the length of parameters reported. > I'd probably drop testlibpq5.c, since it seems a bit pointless now ... I took a look through the v17 patches. 0001: The two heade

Re: ssl passphrase callback

2019-12-07 Thread Andrew Dunstan
On 12/7/19 12:16 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Bruce was worried about what would happen if we defined both >> ssl_passphrase_command and ssl_passphrase_callback. The submitted patch >> let's the callback have precedence, but it might be cleaner to error out >> with such a conf

Re: Windows buildfarm members vs. new async-notify isolation test

2019-12-07 Thread Tom Lane
I wrote: > Amit Kapila writes: >> On Sat, Dec 7, 2019 at 5:01 AM Tom Lane wrote: >>> A possible theory as to what's happening is that the kernel scheduler >>> is discriminating against listener2's signal management thread(s) >>> and not running them until everything else goes idle for a moment.

Re: psql small improvement patch

2019-12-07 Thread Tom Lane
"Shinoda, Noriyoshi (PN Japan A&PS Delivery)" writes: > I propose a small improvement to the psql command. > Currently, psql's help/quit/exit command needs to start from the first > position of the prompt. > The attached patch allows the command to be executed ignoring leading white > spaces.

Re: Windows buildfarm members vs. new async-notify isolation test

2019-12-07 Thread Tom Lane
Amit Kapila writes: > On Sat, Dec 7, 2019 at 5:01 AM Tom Lane wrote: >> A possible theory as to what's happening is that the kernel scheduler >> is discriminating against listener2's signal management thread(s) >> and not running them until everything else goes idle for a moment. > If we have to

Re: ssl passphrase callback

2019-12-07 Thread Tom Lane
Andrew Dunstan writes: > Bruce was worried about what would happen if we defined both > ssl_passphrase_command and ssl_passphrase_callback. The submitted patch > let's the callback have precedence, but it might be cleaner to error out > with such a config. OTOH, that wouldn't be so nice on a reloa

Re: verbose cost estimate

2019-12-07 Thread Tom Lane
Justin Pryzby writes: > Jeff said: >> |What would I find very useful is a verbosity option to get the cost >> |estimates expressed as a multiplier of each *_cost parameter, rather than >> |just as a scalar. > It seems to me that's "just" a matter of redefining Cost and fixing > everything that b

Re: psql small improvement patch

2019-12-07 Thread Mark Dilger
On 12/7/19 5:23 AM, Shinoda, Noriyoshi (PN Japan A&PS Delivery) wrote: Hi, Hackers. I propose a small improvement to the psql command. Currently, psql's help/quit/exit command needs to start from the first position of the prompt. For example, if you write a command after a space, the continu

Re: libpq sslpassword parameter and callback function

2019-12-07 Thread Andrew Dunstan
On 12/6/19 2:57 AM, Noah Misch wrote: > On Fri, Nov 29, 2019 at 09:27:02AM -0500, Andrew Dunstan wrote: >> On 11/28/19 10:25 PM, Greg Nancarrow wrote: >>> 3) Documentation for the "PQsslpassword" function should be added to the >>> libpq "33.2 Connection Status Functions" section. >> I plan to c

psql small improvement patch

2019-12-07 Thread Shinoda, Noriyoshi (PN Japan A&PS Delivery)
Hi, Hackers. I propose a small improvement to the psql command. Currently, psql's help/quit/exit command needs to start from the first position of the prompt. For example, if you write a command after a space, the continuation prompt (PROMPT2) is displayed. --- postgres=> \set PROMPT2 'continue=

verbose cost estimate

2019-12-07 Thread Justin Pryzby
Jeff said: https://www.postgresql.org/message-id/CAMkU%3D1zBJNVo2DGYBgLJqpu8fyjCE_ys%2Bmsr6pOEoiwA7y5jrA%40mail.gmail.com |What would I find very useful is a verbosity option to get the cost |estimates expressed as a multiplier of each *_cost parameter, rather than |just as a scalar. I guess the g