On Fri, Nov 1, 2019 at 7:42 PM Zhenghua Lyu wrote:
> It is tricky to set disable_cost a huge number. Can we come up with
> better solution?
What happens if you use DBL_MAX?
Hi,
Postgres has a global variable `disable_cost`. It is set the value
1.0e10.
This value will be added to the cost of path if related GUC is set off.
For example,
if enable_nestloop is set off, when planner trys to add nestloop join
path, it continues
to add such path but with a
Hi vignesh!
On 2019/09/17 20:51, vignesh C wrote:
On Thu, Sep 5, 2019 at 2:31 AM Alvaro Herrera wrote:
There were some minor problems in v5 -- bogus Docbook as well as
outdated rules.out, small "git diff --check" complaint about whitespace.
This v6 (on today's master) fixes those, no other c
On Oct 31, 2019, at 10:11, Michael Paquier wrote:
>
> On Wed, Oct 30, 2019 at 05:43:04PM +0900, Kyotaro Horiguchi wrote:
>> At Wed, 30 Oct 2019 17:21:17 +0900, Fujii Masao
>> wrote in
>>> This change causes every ending backends to always take the exclusive lock
>>> even when it's not in SyncR
Em qui, 31 de out de 2019 às 23:45, Andres Freund escreveu:
>
> 1) I don't think you can do the < 0 check on an elementwise basis. Your
>code would e.g. make a hash out of abs('1 day -1 second'), by
>inverting the second, but not the day (whereas nothing should be
>done).
>
>It'd p
On Thu, Oct 31, 2019 at 10:54 PM Tom Lane wrote:
>
> Fujii Masao writes:
> > On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
> >> Fujii Masao writes:
> >>> Currently CREATE OR REPLACE VIEW command fails if the column names
> >>> are changed.
>
> >> That is, I believe, intentional. It's an effe
Em seg, 28 de out de 2019 às 01:41, Kyotaro Horiguchi
escreveu:
>
> At Sat, 26 Oct 2019 16:50:48 +0800, Quan Zongliang
> wrote in
> > In fact, the replication property of the table has not been modified,
> > and it is still 'i'(REPLICA_IDENTITY_INDEX). But the previously
> > specified index prop
On Fri, Nov 1, 2019 at 6:34 AM Ibrar Ahmed wrote:
>
>
>
> On Thu, Oct 31, 2019 at 6:56 PM Tom Lane wrote:
>>
>> Fujii Masao writes:
>> > ... I found that the command tag of
>> > ALTER MATERIALIZED VIEW RENAME COLUMN is "ALTER TABLE", not "ALTER VIEW".
>>
>> > =# ALTER MATERIALIZED VIEW hoge
Hi,
On 2019-10-31 23:20:07 -0300, Euler Taveira wrote:
> diff --git a/src/backend/utils/adt/timestamp.c
> b/src/backend/utils/adt/timestamp.c
> index 1dc4c820de..a6b8b8c221 100644
> --- a/src/backend/utils/adt/timestamp.c
> +++ b/src/backend/utils/adt/timestamp.c
> @@ -2435,6 +2435,23 @@ interval
Hi,
Sometimes you want to answer if a difference between two timestamps is
lesser than x minutes but you are not sure which timestamp is greater
than the other one (to obtain a positive result -- it is not always
possible). However, if you cannot obtain the absolute value of
subtraction, you have
On 2019/10/28 12:39, Kyotaro Horiguchi wrote:
Hello.
# The patch no longer applies on the current master. Needs a rebasing.
At Sat, 26 Oct 2019 16:50:48 +0800, Quan Zongliang
wrote in
In fact, the replication property of the table has not been modified,
and it is still 'i'(REPLICA_IDENTITY_I
On Thu, Oct 31, 2019 at 1:45 PM Michael Paquier wrote:
> On Tue, Oct 29, 2019 at 01:16:58PM +0900, Michael Paquier wrote:
> > Yes, something looks wrong with that. I have not looked at it in
> > details yet though. I'll see about that tomorrow.
>
> So.. When building the attribute map for a clo
Hello.
On Thu, Oct 31, 2019 at 11:25 PM Masahiko Sawada wrote:
>
> On Fri, Sep 6, 2019 at 3:34 PM Smith, Peter
> wrote:
> >
> > -Original Message-
> > From: Masahiko Sawada Sent: Thursday, 15 August
> > 2019 7:10 PM
> >
> > > BTW I've created PoC patch for cluster encryption feature.
This patch achieves $SUBJECT and also provides some testing of the
sslpassword setting.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/contrib/postgres_fdw/expected/postgres_fdw
Hi!
Our customer faced with issue, when index is invisible after creation.
The reproducible case is following.
$ psql db2
# begin;
# select txid_current();
$ psql db1
# select i as id, 0 as v into t from generate_series(1, 10) i;
# create unique index idx on t (id);
# update t set
Hi,
On 2019-10-31 23:59:19 +0100, Tomas Vondra wrote:
> On Tue, Oct 29, 2019 at 02:00:00PM +1300, Thomas Munro wrote:
> > On Tue, Oct 29, 2019 at 12:15 PM Andres Freund wrote:
> > > I've groused about this a few times, but to me it seems wrong that
> > > HashJoin and Hash are separate nodes. They
On 10/31/19 6:34 PM, Andrew Dunstan wrote:
> This time with attachment.
>
>
> On 10/31/19 6:33 PM, Andrew Dunstan wrote:
>> This patch provides for an sslpassword parameter for libpq, and a hook
>> that a client can fill in for a callback function to set the password.
>>
>>
>> This provides simil
Hello hackers,
Please feel free to edit this new page, which I'd like to use to keep
track of observations, ideas and threads relating to hash joins.
https://wiki.postgresql.org/wiki/Hash_Join
On Tue, Oct 29, 2019 at 02:00:00PM +1300, Thomas Munro wrote:
On Tue, Oct 29, 2019 at 12:15 PM Andres Freund wrote:
I've groused about this a few times, but to me it seems wrong that
HashJoin and Hash are separate nodes. They're so tightly bound together
that keeping them separate just doesn't
This time with attachment.
On 10/31/19 6:33 PM, Andrew Dunstan wrote:
> This patch provides for an sslpassword parameter for libpq, and a hook
> that a client can fill in for a callback function to set the password.
>
>
> This provides similar facilities to those already available in the JDBC
>
This patch provides for an sslpassword parameter for libpq, and a hook
that a client can fill in for a callback function to set the password.
This provides similar facilities to those already available in the JDBC
driver.
There is also a function to fetch the sslpassword from the connection
p
On Thu, Oct 31, 2019 at 6:56 PM Tom Lane wrote:
> Fujii Masao writes:
> > ... I found that the command tag of
> > ALTER MATERIALIZED VIEW RENAME COLUMN is "ALTER TABLE", not "ALTER VIEW".
>
> > =# ALTER MATERIALIZED VIEW hoge RENAME COLUMN j TO x;
> > ALTER TABLE
>
> > Is this intentiona
On Thu, Oct 31, 2019 at 03:19:23PM +0530, Natarajan R wrote:
Hi,
I want to know how postgres stores catalog relations in cache in-depth. Is
there any documentation for that?
Not sure what exactly you mean by "cache" - whether shared buffers (as a
shared general database cache) or syscache/catc
This patch allows the superuser to grant passwordless connection rights
in postgres_fdw user mappings.
The patch is authored by my colleague Craig Ringer, with slight bitrot
fixed by me.
One use case for this is with passphrase-protected client certificates,
a patch for which will follow short
On Thu, 31 Oct 2019 at 17:56, Tom Lane wrote:
>
> David Rowley writes:
> > In Ottawa this year, Andres and I briefly talked about the possibility
> > of making a series of changes to how equalfuncs.c works. The idea was
> > to make it easy by using some pre-processor magic to allow us to
> > crea
On Thu, Oct 31, 2019 at 11:43 PM Fabien COELHO wrote:
>
> Hello Devs,
>
> This patch moves duplicated query cancellation code code from psql &
> scripts to fe-utils, so that it is shared and may be used by other
> commands.
>
> This is because Masao-san suggested to add a query cancellation featu
On Thu, Oct 31, 2019 at 12:24:33PM -0700, Andres Freund wrote:
Hi,
On 2019-10-31 20:15:12 +0100, Tomas Vondra wrote:
On Thu, Oct 31, 2019 at 11:48:21AM -0700, Andres Freund wrote:
> We currently align byval types such as int4/8, float4/8, timestamp *,
> date etc, even though we mostly don't nee
On Thu, Oct 31, 2019 at 12:51:17PM -0300, Igor Calabria wrote:
Hi everyone,
I was taking a look at pg_stat_statements module and noticed that it does
not collect any percentile metrics. I believe that It would be really handy
to have those available and I'd love to contribute with this feature.
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Patch looks to me and works on my machine
73025140885c889410b9bf
Hi,
On 2019-10-31 20:15:12 +0100, Tomas Vondra wrote:
> On Thu, Oct 31, 2019 at 11:48:21AM -0700, Andres Freund wrote:
> > We currently align byval types such as int4/8, float4/8, timestamp *,
> > date etc, even though we mostly don't need to. When tuples are deformed,
> > all byval types are copi
On Thu, Oct 31, 2019 at 03:02:40PM -0400, Isaac Morland wrote:
On Thu, 31 Oct 2019 at 14:50, Stephen Frost wrote:
Greetings,
* Peter Geoghegan (p...@bowt.ie) wrote:
[]
Absolutely- our lack of such is a common point of issue when folks are
considering using or migrating to PostgreSQL.
On Thu, Oct 31, 2019 at 11:48:21AM -0700, Andres Freund wrote:
Hi,
We currently align byval types such as int4/8, float4/8, timestamp *,
date etc, even though we mostly don't need to. When tuples are deformed,
all byval types are copied out from the tuple data into the
corresponding Datum array,
Hello Masao-san,
If large scale factor is specified, the query for generating
pgbench_accounts data can take a very long time. While that query is
running, operators may be likely to do Ctrl-C to cancel the data
generation. In this case, IMO pgbench should cancel the query, i.e.,
call PQcan
On Thu, 31 Oct 2019 at 14:50, Stephen Frost wrote:
> Greetings,
>
> * Peter Geoghegan (p...@bowt.ie) wrote:
>
[]
>
> Absolutely- our lack of such is a common point of issue when folks are
> considering using or migrating to PostgreSQL.
>
Not sure how similar my situation really is, but I fi
Greetings,
* Peter Geoghegan (p...@bowt.ie) wrote:
> On Wed, Oct 30, 2019 at 9:23 AM Tom Lane wrote:
> > Well, the *effects* of the feature seem desirable, but that doesn't
> > mean that we want an implementation that actually has a shared index.
> > As soon as you do that, you've thrown away mos
Hi,
We currently align byval types such as int4/8, float4/8, timestamp *,
date etc, even though we mostly don't need to. When tuples are deformed,
all byval types are copied out from the tuple data into the
corresponding Datum array, therefore the original alignment in the tuple
data doesn't matte
Hello Devs,
This patch moves duplicated query cancellation code code from psql &
scripts to fe-utils, so that it is shared and may be used by other
commands.
This is because Masao-san suggested to add a query cancellation feature to
pgbench for long queries (server-side data generation bein
This small patch authored by my colleague Craig Ringer enhances
Testlib's command_fails_like by allowing the passing of extra keyword
type arguments. The keyword initially recognized is 'extra_ipcrun_opts'.
The value for this keyword needs to be an array, and is passed through
to the call to IPC::
On 10/29/19 11:32 PM, Andres Freund wrote:
Hi,
On 2019-10-29 16:31:11 -0400, Tom Lane wrote:
Andres Freund writes:
one of the most frequent conflicts I see is that two patches add files
to OBJS (or one of its other spellings), and there are conflicts because
another file has been added.
..
Hi
long time we are think how to allow add some custom commands in psql. I had
a following idea
1. psql can has special buffer for custom queries. This buffer can be
filled by special command \gdefq. This command will have two parameters -
name and number of arguments.
some like
select * from p
čt 31. 10. 2019 v 16:51 odesílatel Igor Calabria
napsal:
> Hi everyone,
>
> I was taking a look at pg_stat_statements module and noticed that it does
> not collect any percentile metrics. I believe that It would be really handy
> to have those available and I'd love to contribute with this featur
Hi,
On 2019-10-28 12:33:00 +0800, Craig Ringer wrote:
> I was recently surprised to notice that log_line_prefix doesn't support a
> cluster_name placeholder. I suggest adding one. If I don't hear objections
> I'll send a patch.
>
> Before anyone asks "but why?!":
>
> * A constant (short) string
Hi,
On October 31, 2019 8:51:11 AM PDT, Andrzej Barszcz wrote:
>x <> 0 is evaluated first, 1/x only when x <> 0, not ?
>
>czw., 31 paź 2019 o 16:45 Tom Lane napisał(a):
>
>> Andres Freund writes:
>> > Potentially related note: for nodes like seqscan, combining the
>qual and
>> projection proce
Hi everyone,
I was taking a look at pg_stat_statements module and noticed that it does
not collect any percentile metrics. I believe that It would be really handy
to have those available and I'd love to contribute with this feature.
The basic idea is to accumulate the the query execution times us
x <> 0 is evaluated first, 1/x only when x <> 0, not ?
czw., 31 paź 2019 o 16:45 Tom Lane napisał(a):
> Andres Freund writes:
> > Potentially related note: for nodes like seqscan, combining the qual and
> projection processing into one expression seems to be a noticable win (at
> least when tak
Hi,
On October 31, 2019 8:45:26 AM PDT, Tom Lane wrote:
>Andres Freund writes:
>> Potentially related note: for nodes like seqscan, combining the qual
>and projection processing into one expression seems to be a noticable
>win (at least when taking care do emit two different sets of deform
>exp
Andres Freund writes:
> Potentially related note: for nodes like seqscan, combining the qual and
> projection processing into one expression seems to be a noticable win (at
> least when taking care do emit two different sets of deform expression steps).
There's just one problem: that violates S
This is the first of a number of patches to enhance SSL functionality,
particularly w.r.t. passphrases.
This patch provides a hook for a function that can supply an SSL
passphrase. The hook can be filled in by a shared preloadable module. In
order for that to be effective, the startup order is m
On Thu, Sep 26, 2019 at 1:53 AM Alvaro Herrera
wrote:
> Apparently this patch now has a duplicate OID. Please do use random
> OIDs >8000 as suggested by the unused_oids script.
>
> --
> Álvaro Herrerahttps://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA,
Hi,
On October 31, 2019 8:06:50 AM PDT, Tom Lane wrote:
>Andres Freund writes:
>> On October 31, 2019 7:45:26 AM PDT, Tom Lane
>wrote:
>>> We've typically supposed that the cost of searching for duplicate
>>> subexpressions would outweigh the benefits of sometimes finding
>them.
>
>> Based on
Andres Freund writes:
> On October 31, 2019 7:45:26 AM PDT, Tom Lane wrote:
>> We've typically supposed that the cost of searching for duplicate
>> subexpressions would outweigh the benefits of sometimes finding them.
> Based on profiles I've seen I'm not sure that's the right choice. Both for
On 10/31/19 3:45 PM, Tom Lane wrote:
Andres Freund writes:
On October 31, 2019 7:06:13 AM PDT, Andrzej Barszcz wrote:
Any pros and cons ?
Depends on the actual way of implementing this proposal. Think we need more
details than what you idea here.
We've typically supposed that the cost
Hi
On October 31, 2019 7:53:20 AM PDT, Andres Freund wrote:
>On October 31, 2019 7:45:26 AM PDT, Tom Lane wrote:
>>We've typically supposed that the cost of searching for duplicate
>>subexpressions would outweigh the benefits of sometimes finding them.
>
>Based on profiles I've seen I'm not sure
On Thu, Oct 31, 2019 at 9:45 AM Michael Paquier wrote:
> On Tue, Oct 29, 2019 at 01:16:58PM +0900, Michael Paquier wrote:
> > Yes, something looks wrong with that. I have not looked at it in
> > details yet though. I'll see about that tomorrow.
>
> So.. When building the attribute map for a cl
Hello Masao-san,
+ snprintf(sql, sizeof(sql),
+ "insert into pgbench_branches(bid,bbalance) "
+ "select bid, 0 "
+ "from generate_series(1, %d) as bid", scale);
"scale" should be "nbranches * scale".
Yep, even if nbranches is 1, it should be there.
+ snprintf(sql, sizeof(sql),
+ "insert in
Hi,
On October 31, 2019 7:45:26 AM PDT, Tom Lane wrote:
>Andres Freund writes:
>> On October 31, 2019 7:06:13 AM PDT, Andrzej Barszcz
> wrote:
>>> I almost finished patch optimizing non volatile function calls.
>>>
>>> select f(t.n) from t where f(t.n) > 10 and f(t.n) < 100; needs 3
>calls
>>
Andres Freund writes:
> On October 31, 2019 7:06:13 AM PDT, Andrzej Barszcz wrote:
>> I almost finished patch optimizing non volatile function calls.
>>
>> select f(t.n) from t where f(t.n) > 10 and f(t.n) < 100; needs 3 calls
>> of
>> f() for each tuple,
>> after applying patch only 1.
>>
>>
On Fri, Sep 6, 2019 at 3:34 PM Smith, Peter wrote:
>
> -Original Message-
> From: Masahiko Sawada Sent: Thursday, 15 August 2019
> 7:10 PM
>
> > BTW I've created PoC patch for cluster encryption feature. Attached patch
> > set has done some items of TODO list and some of them can be use
Hi,
On October 31, 2019 7:06:13 AM PDT, Andrzej Barszcz wrote:
>Hi
>
>I almost finished patch optimizing non volatile function calls.
>
>select f(t.n) from t where f(t.n) > 10 and f(t.n) < 100; needs 3 calls
>of
>f() for each tuple,
>after applying patch only 1.
>
>Any pros and cons ?
Depends
Hi
I almost finished patch optimizing non volatile function calls.
select f(t.n) from t where f(t.n) > 10 and f(t.n) < 100; needs 3 calls of
f() for each tuple,
after applying patch only 1.
Any pros and cons ?
Fujii Masao writes:
> ... I found that the command tag of
> ALTER MATERIALIZED VIEW RENAME COLUMN is "ALTER TABLE", not "ALTER VIEW".
> =# ALTER MATERIALIZED VIEW hoge RENAME COLUMN j TO x;
> ALTER TABLE
> Is this intentional? Or bug?
Seems like an oversight.
re
Fujii Masao writes:
> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
>> Fujii Masao writes:
>>> Currently CREATE OR REPLACE VIEW command fails if the column names
>>> are changed.
>> That is, I believe, intentional. It's an effective aid to catching
>> mistakes in view redefinitions, such as
Peter Eisentraut writes:
> float4 is now always pass-by-value; the pass-by-reference code path is
> completely removed.
I think this is OK.
> float8 and related types are now hardcoded to pass-by-value or
> pass-by-reference depending on whether the build is 64- or 32-bit, as
> was previously
Hello Thomas,
On Tue, May 28, 2019 at 9:00 PM Thomas Munro wrote:
>
> Since there's a chance of an "unconference" session on locale versions
> tomorrow at PGCon, here's a fresh rebase of the patchset to add
> per-database-object collation version tracking. It doesn't handle
> default collations
On 31/10/2019 14:52, Jesper Pedersen wrote:
Hi,
The attached patch adds an -a / --appname command line switch to
pg_basebackup, pg_receivewal and pg_recvlogical.
This is useful when f.ex. pg_receivewal needs to connect as a
synchronous client (synchronous_standby_names),
pg_receivewal -h my
Hi,
The attached patch adds an -a / --appname command line switch to
pg_basebackup, pg_receivewal and pg_recvlogical.
This is useful when f.ex. pg_receivewal needs to connect as a
synchronous client (synchronous_standby_names),
pg_receivewal -h myhost -p 5432 -S replica1 -a replica1 --sync
On Thu, Oct 31, 2019 at 5:28 PM Ibrar Ahmed wrote:
>
>
> On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote:
>
>>
>>
>> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao
>> wrote:
>>
>>> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed
>>> wrote:
>>> >
>>> >
>>> >
>>> > On Thu, Oct 31, 2019 at 12:32 PM Fu
Dear hackers,
As declared last month, I propose again the new ECPG grammar, DECLARE STATEMENT.
This had been committed once, but it removed from PG12 because of
some problems.
In this mail, I want to report some problems that previous implementation has,
produce a new solution, and attach a WIP p
On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote:
>
>
> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote:
>
>> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed
>> wrote:
>> >
>> >
>> >
>> > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao
>> wrote:
>> >>
>> >> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane
On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote:
> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao
> wrote:
> >>
> >> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
> >> >
> >> > Fujii Masao writes:
> >> > > Currently CREATE O
On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed wrote:
>
>
>
> On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao wrote:
>>
>> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
>> >
>> > Fujii Masao writes:
>> > > Currently CREATE OR REPLACE VIEW command fails if the column names
>> > > are changed.
>> >
>
On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao wrote:
> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
> >
> > Fujii Masao writes:
> > > Currently CREATE OR REPLACE VIEW command fails if the column names
> > > are changed.
> >
> > That is, I believe, intentional. It's an effective aid to catchi
Hi,
The command tag of ALTER MATERIALIZED VIEW is basically
"ALTER MATERIALIZED VIEW". For example,
=# ALTER MATERIALIZED VIEW test ALTER COLUMN j SET STATISTICS 100;
ALTER MATERIALIZED VIEW
=# ALTER MATERIALIZED VIEW test OWNER TO CURRENT_USER;
ALTER MATERIALIZED VIEW
=# ALTE
Hello
> So, I'd like to propose to move the stuff to the second switch().
> (See the attached incomplete patch.) This is rather similar to
> Sergei's previous proposal, but the structure of the state
> machine is kept.
Very similar to my v4 proposal (also move RequestXLogStreaming call), but
clo
Hi,
I want to know how postgres stores catalog relations in cache in-depth. Is
there any documentation for that?
On Tue, Oct 29, 2019 at 7:29 PM Etsuro Fujita wrote:
> On Fri, Oct 25, 2019 at 6:59 PM amul sul wrote:
> > On Wed, Oct 16, 2019 at 6:20 PM Etsuro Fujita
> > wrote:
> >> So I'd like to propose to introduce separate functions like
> >> process_outer_partition() and process_inner_partition() in th
Hello Tom,
psql=> select 1...
psql->
I cannot move back with readline to edit further, I'm stuck there, which
is strange.
I don't follow. readline doesn't allow you to edit already-entered lines
today, that is, after typing "select 1" you see
regression=# select 1
regression-#
a
On Mon, Oct 28, 2019 at 10:56:33PM -0500, Justin Pryzby wrote:
> I suppose it should something other than partition(ed), since partitions can
> be
> partitioned, too...
>
> Attaching a partition acquires a SHARE UPDATE
> EXCLUSIVE
> lock on the parent table, in addition to
> AC
On Thu, Oct 31, 2019 at 05:18:46PM +0900, Amit Langote wrote:
> On Thu, Oct 31, 2019 at 4:49 PM Michael Paquier wrote:
>> Let's remove it then.
>
> Removed in the attached.
Thanks. I exactly did the same thing on my local branch.
--
Michael
signature.asc
Description: PGP signature
AFAICT, these build options were only useful to maintain compatibility
for version-0 functions, but those are no longer supported, so these
options can be removed. There is a fair amount of code all over the
place to support these options, so the cleanup is quite significant.
The current beha
Tomas Vondra wrote:
> On Wed, Oct 30, 2019 at 02:44:18PM +0100, Antonin Houska wrote:
> >Please consider this scenario (race conditions):
> >
> >1. FlushBuffer() has written the buffer but hasn't yet managed to clear the
> >BM_DIRTY flag (however BM_JUST_DIRTIED could be cleared by now).
> >
> >2
Hi all,
I wondered can we have a shortcut somewhat similar to following POC
in recomputeNamespacePath () when the recomputed path is the same as the
previous baseSearchPath/activeSearchPath :
== POC patch ==
diff --git a/src/backend/catalog/namespace.c
b/src/backend/catalog/namespace.c
index e251
On Thu, Oct 31, 2019 at 11:12 AM Michael Paquier wrote:
>
> On Wed, Oct 30, 2019 at 05:43:04PM +0900, Kyotaro Horiguchi wrote:
> > At Wed, 30 Oct 2019 17:21:17 +0900, Fujii Masao
> > wrote in
> >> This change causes every ending backends to always take the exclusive lock
> >> even when it's not
On Thu, Oct 31, 2019 at 4:49 PM Michael Paquier wrote:
> On Thu, Oct 31, 2019 at 04:38:55PM +0900, Amit Langote wrote:
> > On Wed, Oct 30, 2019 at 12:11 PM Michael Paquier
> > wrote:
> > This sentence sounds wrong, because the result structure doesn't
> > contain values in text-array format. In
Hello,
On Tue, Oct 29, 2019 at 12:13 AM Alvaro Herrera
wrote:
> On 2019-Oct-28, Michael Paquier wrote:
> > On Sun, Oct 27, 2019 at 07:12:07PM -0500, Justin Pryzby wrote:
> > > commit #898e5e32 (Allow ATTACH PARTITION with only
> > > ShareUpdateExclusiveLock)
> > > updates ddl.sgml but not alter_
On Thu, Oct 31, 2019 at 04:38:55PM +0900, Amit Langote wrote:
> On Wed, Oct 30, 2019 at 12:11 PM Michael Paquier wrote:
> This sentence sounds wrong, because the result structure doesn't
> contain values in text-array format. Individual values in the struct
> would be in their native format (C bo
On Mon, Oct 28, 2019 at 1:33 PM Craig Ringer wrote:
>
> Hi folks
>
> I was recently surprised to notice that log_line_prefix doesn't support a
> cluster_name placeholder. I suggest adding one. If I don't hear objections
> I'll send a patch.
If we do this, cluster_name should be included in csvl
Hi Michael,
On Wed, Oct 30, 2019 at 12:11 PM Michael Paquier wrote:
> Looks fine. I have done some refinements as per the attached.
Thanks. This stood out to me:
+ * The result is a structure containing all the parsed option values in
+ * text-array format.
This sentence sounds wrong, becaus
On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote:
>
> Fujii Masao writes:
> > Currently CREATE OR REPLACE VIEW command fails if the column names
> > are changed.
>
> That is, I believe, intentional. It's an effective aid to catching
> mistakes in view redefinitions, such as misaligning the new set
On 2019-09-17 15:08, Daniel Verite wrote:
When trying databases defined with ICU locales, I see that backends
that serve such databases seem to have their LC_CTYPE inherited from
the environment (as opposed to a per-database fixed value).
fr-utf8=# select to_tsvector('été');
ERROR: invalid mu
90 matches
Mail list logo
