On Fri, Oct 4, 2019 at 12:10 PM Smith, Peter
wrote:
> From: Tom Lane Sent: Friday, 4 October 2019 2:08 PM
>
> >> #define INIT_ALL_ELEMS_ZERO {0}
> >> #define INIT_ALL_ELEMS_FALSE {false}
>
> >I would say that's 100% wrong. The entire point here is that it's
> memset-equivalent, and therefore w
From: Tom Lane Sent: Friday, 4 October 2019 2:08 PM
>> #define INIT_ALL_ELEMS_ZERO {0}
>> #define INIT_ALL_ELEMS_FALSE {false}
>I would say that's 100% wrong. The entire point here is that it's
>memset-equivalent, and therefore writes zeroes, regardless of what the
>datatype is.
I agree i
On Thu, Oct 3, 2019 at 4:40 PM Stephen Frost wrote:
>
> * Robert Haas (robertmh...@gmail.com) wrote:
> > On Mon, Sep 30, 2019 at 5:26 PM Bruce Momjian wrote:
> > > For full-cluster Transparent Data Encryption (TDE), the current plan is
> > > to encrypt all heap and index files, WAL, and all pgsq
On Fri, Oct 4, 2019 at 3:42 AM Stephen Frost wrote:
>
> > It doesn't seem like it would require
> > much work at all to construct an argument that a hacker might enjoy
> > having unfettered access to pg_clog even if no other part of the
> > database can be read.
>
> The question isn't about what
On Fri, Oct 4, 2019 at 10:28 AM Masahiko Sawada
wrote:
> On Thu, Oct 3, 2019 at 9:06 PM Dilip Kumar wrote:
> >
> > On Wed, Oct 2, 2019 at 7:29 PM Masahiko Sawada
> wrote:
> >
> > + else
> > + {
> > + if (for_cleanup)
> > + {
> > + if (lps->nworkers_requested > 0)
> > + appendStringInfo(&buf,
>
Natarajan R writes:
> Me: Thanks Tomas, But this is for that particular database only, I want
> to get the *list of database Id's* on which my extension is installed
> during *PG_INIT* itself...
You can't. In the first place, that information simply isn't obtainable,
because a session running w
On Wed, Oct 2, 2019 at 7:29 PM Masahiko Sawada
wrote:
> On Sat, Sep 21, 2019 at 9:31 PM Amit Kapila
> wrote:
> > *
> > In function compute_parallel_workers, don't we want to cap the number
> > of workers based on maintenance_work_mem as we do in
> > plan_create_index_workers?
> >
> > The basic p
On Thu, Oct 3, 2019 at 9:06 PM Dilip Kumar wrote:
>
> On Wed, Oct 2, 2019 at 7:29 PM Masahiko Sawada wrote:
> >
> I have started reviewing this patch and I have some cosmetic comments.
> I will continue the review tomorrow.
>
Thank you for reviewing the patch!
> +This change adds PARALLEL optio
On Thu, 3 Oct 2019 at 20:54, Tomas Vondra
wrote:
> On Thu, Oct 03, 2019 at 07:51:04PM +0530, Natarajan R wrote:
> >Thanks for your response Euler.
> >
> >1)
> >"id" i meant by database id
> >
> >I make my question simple, " during pg_init i want to get databaseid's in
> >which my extension is ins
So ... why exactly did this patch define MemoryContextData.mem_allocated
as int64? That seems to me to be doubly wrong: it is not the right width
on 32-bit machines, and it is not the right signedness anywhere. I think
that field ought to be of type Size (a/k/a size_t, but memnodes.h always
calls
Hi
so 10. 8. 2019 v 9:10 odesílatel Pavel Stehule
napsal:
> Hi
>
> just rebase
>
fresh rebase
Regards
Pavel
> Regards
>
> Pavel
>
schema-variables-20191004.patch.gz
Description: application/gzip
"Smith, Peter" writes:
> From: Amit Kapila Sent: Friday, 4 October 2019 1:32
> PM
>> Also, if we want to pursue, do we want to use INIT_ALL_ZEROES for bool
>> arrays as well?
> FYI - In case it went unnoticed - my last patch addresses this by defining 2
> macros:
> #define INIT_ALL_ELEMS_Z
From: Amit Kapila Sent: Friday, 4 October 2019 1:32 PM
> Also, if we want to pursue, do we want to use INIT_ALL_ZEROES for bool
>arrays as well?
FYI - In case it went unnoticed - my last patch addresses this by defining 2
macros:
#define INIT_ALL_ELEMS_ZERO {0}
#define INIT_ALL_ELEMS_FAL
On Wed, Oct 2, 2019 at 9:16 PM Tom Lane wrote:
> Joe Nelson writes:
> > Isaac Morland wrote:
> >> I hope you'll forgive a noob question. Why does the "After"
> >> initialization for the boolean array have {0} rather than {false}?
>
> > I think using a value other than {0} potentially gives the i
Kyotaro Horiguchi wrote:
> > pg_standby: -k keepfiles could not parse 'hoge' as integer
>
> I didn't checked closely, but -k of pg_standby's message looks
> somewhat strange. Needs a separator?
Good point, how about this:
pg_standby: -k keepfiles:
> Building a sentense just concatenatin
Hi Greg,
On Tue, Oct 1, 2019 at 4:03 AM Greg Stark wrote:
>
> Actually -- I'm sorry to followup to myself (twice) -- but that's
> wrong. That Todo item predates the modern partitioning code. It came
> from when the partitioned statistics were added for inheritance trees.
> The resulting comment a
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Thu, Oct 3, 2019 at 1:29 PM Stephen Frost wrote:
> > I don't think I was arguing specifically about VM/FSM in particular but
> > rather about things which, for us, are cluster level. Admittedly, some
> > other database systems put more
On Thu, Oct 3, 2019 at 1:29 PM Stephen Frost wrote:
> I don't think I was arguing specifically about VM/FSM in particular but
> rather about things which, for us, are cluster level. Admittedly, some
> other database systems put more things into tablespaces or databases
> than we do (it'd sure be
On 2019-Oct-03, Tom Lane wrote:
> I wrote:
> > [ v2-0001-cope-with-large-encoding-conversions.patch ]
> > [ v2-0002-actually-recover-space-in-repalloc.patch ]
>
> I've pushed these patches (after some more review and cosmetic
> adjustments) and marked the CF entry closed. Andres is welcome
> to
I wrote:
> [ v2-0001-cope-with-large-encoding-conversions.patch ]
> [ v2-0002-actually-recover-space-in-repalloc.patch ]
I've pushed these patches (after some more review and cosmetic
adjustments) and marked the CF entry closed. Andres is welcome
to see if he can improve the situation further.
On Tue, Oct 1, 2019 at 5:55 AM Alexander Korotkov
wrote:
> On Mon, Sep 30, 2019 at 10:54 PM Peter Geoghegan wrote:
> >
> > On Sun, Sep 29, 2019 at 8:12 AM Alexander Korotkov
> > wrote:
> > > I just managed to reproduce this using two sessions on master branch.
> > >
> > > session 1
> > > ses
On Thu, Oct 03, 2019 at 10:26:15AM -0400, Robert Haas wrote:
> On Tue, Oct 1, 2019 at 12:19 PM Bruce Momjian wrote:
> > Just to give more detail. Initially, there was a desire to store
> > keys in only one place, either in the file system or in database
> > tables. However, it became clear that
Andres Freund writes:
> * It's certainly curious that the failures so far only have happended as
> part of pg_upgradeCheck, rather than the plain regression tests.
Isn't it though. We spent a long time wondering why we saw parallel
plan instability mostly in pg_upgradeCheck, too [1]. We event
Justin Pryzby writes:
> This is a "concept" patch to show the version, which is frequently requested
> on
> -performance list and other support requests. If someone sends
> explain(settings), they don't need to also (remember to) send the version..
I'm not really on board with the proposal at a
explain(SETTINGS) was implemented to show relevant settings for which an odd
value could affect a query but could be forgotten during troubleshooting.
This is a "concept" patch to show the version, which is frequently requested on
-performance list and other support requests. If someone sends
exp
Hi,
On 2019-10-03 14:33:26 -0400, Mike Palmiotto wrote:
> > > +#ifdef EXEC_BACKEND
> > > + aux_fork->av[ac++] = pstrdup("--forkboot");
> > > + aux_fork->av[ac++] = NULL; /* filled in by
> > > postmaster_forkexec */
> > > +#endif
> >
> > What's the point of pstrdup()in
On Sun, Sep 29, 2019 at 3:38 AM Alvaro Herrera wrote:
>
> The UTF8 bits looks reasonable to me. I guess the other part of that
> question is whether we support any other multibyte encoding that
> supports combining characters. Maybe for cases other than UTF8 we can
> test for 0-width chars (usin
On Thu, Oct 3, 2019 at 1:31 PM Andres Freund wrote:
>
> Hi,
>
> On 2019-09-30 15:13:18 -0400, Mike Palmiotto wrote:
> > Attached is the reworked and rebased patch set. I put the hook on top
> > and a separate commit for each process type. Note that avworker and
> > avlauncher were intentionally le
On Wed, Oct 2, 2019 at 10:21 PM Pavel Stehule wrote:
>
> Thank you for careful review. I hope so all issues are out.
>
>
Thanks Pavel for fixing the comments.
Few comments:
The else part cannot be hit in DropDatabase function as gram.y expects FORCE.
+
+ if (strcmp(opt->defname, "force") == 0)
+ f
Hi,
On 2019-09-30 15:13:18 -0400, Mike Palmiotto wrote:
> Attached is the reworked and rebased patch set. I put the hook on top
> and a separate commit for each process type. Note that avworker and
> avlauncher were intentionally left together. Let me know if you think
> those should be split out
Greetings,
* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote:
> On Thu, Oct 03, 2019 at 11:58:55AM -0400, Stephen Frost wrote:
> >* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> >>On 2019-10-03 16:40, Stephen Frost wrote:
> As others have said, that sounds wrong to me. I thi
Hello,
I stumbled on a windows-only bug in pg_basebackup which I've reported as
#16032
(https://www.postgresql.org/message-id/16032-4ba56823a2b2805f%40postgresql.org).
I'm pretty sure I've fixed it in the attached patch.
Many Thanks,
RobFrom 148d525c0d30af35abba1b8c5bbe07e4e72ecfec Mon Sep 1
Greetings,
* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote:
> On Thu, Oct 03, 2019 at 11:51:41AM -0400, Stephen Frost wrote:
> >* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote:
> >>On Thu, Oct 03, 2019 at 10:40:40AM -0400, Stephen Frost wrote:
> >>>People who are looking for 'encrypt all t
On Thu, Oct 03, 2019 at 11:58:55AM -0400, Stephen Frost wrote:
Greetings,
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
On 2019-10-03 16:40, Stephen Frost wrote:
>> As others have said, that sounds wrong to me. I think you need to
>> encrypt everything.
> That isn't what other d
On Thu, Oct 03, 2019 at 11:51:41AM -0400, Stephen Frost wrote:
Greetings,
* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote:
On Thu, Oct 03, 2019 at 10:40:40AM -0400, Stephen Frost wrote:
>People who are looking for 'encrypt all the things' should and will be
>looking at filesytem-level encry
Hi,
On 2019-10-03 12:12:40 -0400, Tom Lane wrote:
> I wrote:
> > In the meantime, I still think we should commit what I proposed in the
> > other thread (<974.1569356...@sss.pgh.pa.us>), or something close to it.
> > Andres' proposal would perhaps be an improvement on that, but I don't
> > think i
Hi,
On 2019-10-03 08:23:49 -0700, Andres Freund wrote:
> On 2019-10-03 08:18:42 -0700, Andres Freund wrote:
> > This is around where an error is thrown:
> > -- badly formatted interval
> > INSERT INTO INTERVAL_TBL (f1) VALUES ('badly formatted interval');
> > -ERROR: invalid input syntax for ty
I wrote:
> In the meantime, I still think we should commit what I proposed in the
> other thread (<974.1569356...@sss.pgh.pa.us>), or something close to it.
> Andres' proposal would perhaps be an improvement on that, but I don't
> think it'll be ready anytime soon; and for sure we wouldn't risk
> b
Greetings,
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> On 2019-10-03 16:40, Stephen Frost wrote:
> >> As others have said, that sounds wrong to me. I think you need to
> >> encrypt everything.
> > That isn't what other database systems do though and isn't what people
> > actual
On 2019-10-03 16:40, Stephen Frost wrote:
>> As others have said, that sounds wrong to me. I think you need to
>> encrypt everything.
> That isn't what other database systems do though and isn't what people
> actually asking for this feature are expecting to have or deal with.
It is what some oth
Greetings,
* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote:
> On Thu, Oct 03, 2019 at 10:40:40AM -0400, Stephen Frost wrote:
> >People who are looking for 'encrypt all the things' should and will be
> >looking at filesytem-level encryption options. That's not what this
> >feature is about.
>
On Thu, Oct 3, 2019 at 11:09 AM Andres Freund wrote:
>
>
> I think what would need to be designed is something more like
> RegisterXactCallback():
>
> /*
> * start- and end-of-transaction callbacks for dynamically loaded modules
> */
> typedef enum
> {
> XACT_EVENT_COMMIT,
>
On Thu, Oct 03, 2019 at 07:51:04PM +0530, Natarajan R wrote:
Thanks for your response Euler.
1)
"id" i meant by database id
I make my question simple, " during pg_init i want to get databaseid's in
which my extension is installed... "
1. by using pg_database and pg_extension catalogs
2. if ther
Hi,
On 2019-10-03 08:18:42 -0700, Andres Freund wrote:
> On 2019-10-03 10:21:13 -0400, Andrew Dunstan wrote:
> > My new msys2 animal fairywren has had 3 recent failures when checking
> > pg_upgrade. The failures have been while running the regression tests,
> > specifically the interval test, and
On Thu, Oct 03, 2019 at 10:40:40AM -0400, Stephen Frost wrote:
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
On Mon, Sep 30, 2019 at 5:26 PM Bruce Momjian wrote:
> For full-cluster Transparent Data Encryption (TDE), the current plan is
> to encrypt all heap and index files, WAL, and
Hi,
On 2019-10-03 10:21:13 -0400, Andrew Dunstan wrote:
> My new msys2 animal fairywren has had 3 recent failures when checking
> pg_upgrade. The failures have been while running the regression tests,
> specifically the interval test, and they all look like this:
>
>
> 2019-10-03 05:36:00.373 UT
Hi,
On 2019-10-03 11:19:58 -0300, Fabrízio de Royes Mello wrote:
> On Thu, Oct 3, 2019 at 1:35 AM Andres Freund wrote:
> >
> > [...]
> >
> > In this state I think this patch should be flat out rejected.
> >
>
> Ok.
>
> > I'm seriously baffled at how this stuff is being pursued aggressively,
> >
On Thu, Oct 03, 2019 at 10:43:21AM -0400, Stephen Frost wrote:
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
On Tue, Oct 1, 2019 at 12:19 PM Bruce Momjian wrote:
> Just to give more detail. Initially, there was a desire to store keys
> in only one place, either in the file system or
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Tue, Oct 1, 2019 at 12:19 PM Bruce Momjian wrote:
> > Just to give more detail. Initially, there was a desire to store keys
> > in only one place, either in the file system or in database tables.
> > However, it became clear that the n
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Mon, Sep 30, 2019 at 5:26 PM Bruce Momjian wrote:
> > For full-cluster Transparent Data Encryption (TDE), the current plan is
> > to encrypt all heap and index files, WAL, and all pgsql_tmp (work_mem
> > overflow). The plan is:
> >
> >
On Mon, Sep 30, 2019 at 5:26 PM Bruce Momjian wrote:
> For full-cluster Transparent Data Encryption (TDE), the current plan is
> to encrypt all heap and index files, WAL, and all pgsql_tmp (work_mem
> overflow). The plan is:
>
>
> https://wiki.postgresql.org/wiki/Transparent_Data_Encrypt
On Tue, Oct 1, 2019 at 12:19 PM Bruce Momjian wrote:
> Just to give more detail. Initially, there was a desire to store keys
> in only one place, either in the file system or in database tables.
> However, it became clear that the needs of booting the server and crash
> recovery required file sys
Thanks for your response Euler.
1)
"id" i meant by database id
I make my question simple, " during pg_init i want to get databaseid's in
which my extension is installed... "
1. by using pg_database and pg_extension catalogs
2. if there any other way, kindly suggest me.
2)
I have one sql file wh
My new msys2 animal fairywren has had 3 recent failures when checking
pg_upgrade. The failures have been while running the regression tests,
specifically the interval test, and they all look like this:
2019-10-03 05:36:00.373 UTC [24272:43] LOG: server process (PID 23756) was
terminated by ex
On Thu, Oct 3, 2019 at 1:35 AM Andres Freund wrote:
>
> [...]
>
> In this state I think this patch should be flat out rejected.
>
Ok.
> I'm seriously baffled at how this stuff is being pursued aggressively,
> quite apparently without any serious design considerations. I mean this
> stuff had to
On Wed, Oct 2, 2019 at 4:46 PM Andres Freund wrote:
> > The existing expectation is that we make our build tools in Perl.
> > I'm sure Andres doesn't want to write a C parser in Perl, but
> > poking around suggests that there are multiple options already
> > available in CPAN. I'd much rather tel
Hi,
It is been observed that when we define the generated columns in WHEN
condition for BEFORE EACH ROW trigger then server throw an error from
CreateTrigger().
e.g:
create table bar(a int PRIMARY KEY, b int GENERATED ALWAYS AS (a * 2)
STORED);
CREATE OR REPLACE FUNCTION test() RETURNS trigger A
Em qui, 3 de out de 2019 às 02:24, Natarajan R escreveu:
>
> I am creating sample extension in postgres, For that "During PG_INIT, i want
> to get the list of database Id's in which my extension is installed". Is
> there a way to get this?
>
I'm not sure what you mean by "ld". However, if you wa
Michael Paquier writes:
> On Tue, Oct 01, 2019 at 12:10:50AM +, Hsu, John wrote:
>> get_relkind_objtype(...) was introduced as part of 8b9e9644dc, and it
>> doesn't include
>> RELKIND_TOASTVALUE. As a result when a user who has usage rights on schema
>> pg_toast
>> and attempts to reindex a
On Tue, Oct 1, 2019 at 1:41 PM Alexander Korotkov
wrote:
> So, basically standard requires us to suppress any error happening in
> filter expression.
Sounds like the standard is dumb, then. :-)
> But as I wrote before suppression of errors in
> datetime comparison may lead to surprising results.
On Fri, Sep 27, 2019 at 12:00 PM Asif Rehman wrote:
>> > - SEND_FILES_CONTENTS (file1, file2,...) - returns the files in given list.
>> > pg_basebackup will then send back a list of filenames in this command.
>> > This commands will be send by each worker and that worker will be getting
>> > the
Hi Thomas,
I've noticed that your patch adds:
+#if defined(SHM_LGPAGE)
+ /* AIX */
+ shmget_extra_flags = SHM_LGPAGE | SHM_PIN;
+#endif
However, my original patch contained:
| SHM_LGPAGE | SHM_PIN | S_IRUSR | S_IWUSR);
It looks like these 2 ad
Hi,
> In any case, the proposed patch almost certainly introduces new
> problems, in that you dropped the fcloses's into code that
> executes repeatedly.
I guess it's better to place fclose() right after successful syslogger start.
In that case we close descriptors just one time. But it's enough
On Thu, Oct 3, 2019 at 7:53 AM Peter Eisentraut
wrote:
> On 2018-09-05 23:18, Thomas Munro wrote:
> > On Wed, Sep 5, 2018 at 12:10 PM Christoph Berg wrote:
> >>> So, it's not ideal but perhaps worth considering on the grounds that
> >>> it's better than nothing?
> >>
> >> Ack.
> >
> > Ok, here's
On 2019-Oct-03, Amit Langote wrote:
> There may not really be any problem with the commit itself, but I
> suspect that the new types of dependencies (or the way
> findDependentObject() analyzes them) don't play well with inheritance
> recursion of ATExecDropColumn(). Currently, child columns (and
On Wed, Oct 2, 2019 at 7:29 PM Masahiko Sawada wrote:
>
I have started reviewing this patch and I have some cosmetic comments.
I will continue the review tomorrow.
+This change adds PARALLEL option to VACUUM command that enable us to
+perform index vacuuming and index cleanup with background
+wor
Hi Asif,
I was looking at the patch and tried comipling it. However, got few errors
and warnings.
Fixed those in the attached patch.
On Fri, Sep 27, 2019 at 9:30 PM Asif Rehman wrote:
> Hi Robert,
>
> Thanks for the feedback. Please see the comments below:
>
> On Tue, Sep 24, 2019 at 10:53 PM
On Wed, 18 Sep 2019 at 12:24, Amit Khandekar wrote:
> Probably, for now at least, what everyone seems to agree is to take my
> earlier attached patch forward.
>
> I am going to see if I can add a TAP test for the patch, and will add
> the patch into the commitfest soon.
Attached is an updated pat
On Wed, Sep 4, 2019 at 2:36 PM Amit Langote wrote:
>
> Hi,
>
> Maybe I'm forgetting some dependency management discussion that I was
> part of recently, but is the following behavior unintentional?
>
> create table p (a int, b int, c int) partition by list (a);
> create table p1 partition of p for
On 03.10.2019 6:07, Michael Paquier wrote:
On Wed, Oct 02, 2019 at 08:28:09PM +0300, Alexey Kondratov wrote:
I've directly followed your guess and tried to elaborate pg_rewind test
cases and... It seems I've caught a few bugs:
1) --dry-run actually wasn't completely 'dry'. It did update target
On Thu, Oct 3, 2019 at 4:03 AM Tomas Vondra
wrote:
> On Wed, Oct 02, 2019 at 04:27:30AM +0530, Amit Kapila wrote:
> >On Tue, Oct 1, 2019 at 7:21 PM Tomas Vondra >
> >wrote:
> >
> >> On Tue, Oct 01, 2019 at 06:55:52PM +0530, Amit Kapila wrote:
> >> >
> >> >On further testing, I found that the pat
On Thu, Oct 3, 2019 at 1:53 PM Fabien COELHO wrote:
>
>
> Hello,
>
> > As partitions is an integer type variable, the maximum value it can
> > hold is "2147483647". But if I specify partitions as "3147483647",
> > atoi function returns a value lesser than zero and pgbench terminates
> > with an er
On Thu, Oct 3, 2019 at 1:57 PM Michael Paquier wrote:
>
> On Thu, Oct 03, 2019 at 01:49:34PM +0900, Fujii Masao wrote:
> > But this can cause subsequent recovery to always fail with invalid-pages
> > error
> > and the server not to start up. This is bad. So, to allviate the situation,
> > I'm thi
Hello,
As partitions is an integer type variable, the maximum value it can
hold is "2147483647". But if I specify partitions as "3147483647",
atoi function returns a value lesser than zero and pgbench terminates
with an error. However, if the value for number of partitions
specified is somethi
Hi Fabien, Amit,
I could see that when an invalid number of partitions is specified,
sometimes pgbench fails with an error "invalid number of partitions:
..." whereas many a times it doesn't, instead it creates number of
partitions that hasn't been specified by the user.
As partitions is an integ
75 matches
Mail list logo
