Fix typos and inconsistencies for HEAD (take 5)

2019-07-06 Thread Alexander Lakhin
Hello hackers, Please consider fixing the next cluster of typos and inconsistencies in the tree: 5.1. datetkntbl -> datetktbl 5.2. datminxmid -> datminmxid 5.3. DatumGetP -> DatumGetPointer 5.4. ECPG_COMPILE, DECPG_COMPILE -> remove (orphaned since 328d235) 5.5. defer_cleanup_age -> vacuum_defer_c

Re: Tid scan improvements

2019-07-06 Thread Edmund Horner
On Thu, 4 Jul 2019 at 15:43, David Rowley wrote: > On Mon, 1 Jul 2019 at 23:29, Thomas Munro wrote: > > The new CF is here. I'm going through poking threads for submissions > > that don't apply, but it sounds like this needs more than a rebase? > > Perhaps this belongs in the next CF? > > 0001 a

Re: Introduce timeout capability for ConditionVariableSleep

2019-07-06 Thread Thomas Munro
On Fri, Jul 5, 2019 at 1:40 PM Thomas Munro wrote: > I think this is looking pretty good and I'm planning to commit it > soon. The convention for CHECK_FOR_INTERRUPTS() in latch wait loops > seems to be to put it after the ResetLatch(), so I've moved it in the > attached version (though I don't t

Re: Declared but no defined functions

2019-07-06 Thread Michael Paquier
On Sun, Jul 07, 2019 at 07:31:12AM +0800, Masahiko Sawada wrote: > Attached patch removes these functions. Thanks, applied. -- Michael signature.asc Description: PGP signature

Re: Declared but no defined functions

2019-07-06 Thread Masahiko Sawada
On Sat, Jul 6, 2019 at 7:32 AM Tom Lane wrote: > > Masahiko Sawada writes: > > I think the following functions are mistakenly left in the header > > file. So attached patch removes them. > > > dsa_startup() > > TransactionIdAbort() > > renameatt_type() > > Agreed, these are referenced nowhere. I

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2019-07-06 Thread Peter Geoghegan
On Thu, Jul 4, 2019 at 5:06 AM Anastasia Lubennikova wrote: > The new version of the patch is attached. > This version is even simpler than the previous one, > thanks to the recent btree design changes and all the feedback I received. > I consider it ready for review and testing. I took a closer

Re: Switching PL/Python to Python 3 by default in PostgreSQL 12

2019-07-06 Thread Steven Pousty
Why would it be a 13 or later issue? I am specifically talking about changing the default. On Sat, Jul 6, 2019, 6:28 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2019-07-06 21:02, Steven Pousty wrote: > > /" The default will probably be changed to Python 3 in a distant futu

Re: Switching PL/Python to Python 3 by default in PostgreSQL 12

2019-07-06 Thread Peter Eisentraut
On 2019-07-06 21:02, Steven Pousty wrote: > /" The default will probably be changed to Python 3 in a distant future > release of PostgreSQL, depending on the progress of the migration to > Python 3 in the Python community."/ > > I know we are late in the Postgresql 12 cycle but I think switching th

Re: Multivariate MCV list vs. statistics target

2019-07-06 Thread Tomas Vondra
Hi, apparently v1 of the ALTER STATISTICS patch was a bit confused about length of the VacAttrStats array passed to statext_compute_stattarget, causing segfaults. Attached v2 patch fixes that, and it also makes sure we print warnings about ignored statistics only once. regards -- Tomas Vondra

Re: CREATE STATISTICS documentation bug

2019-07-06 Thread Peter Eisentraut
On 2019-06-14 23:04, Alvaro Herrera wrote: > On 2019-Jun-14, Tom Lane wrote: > >> Alvaro Herrera writes: > >>> Proposal: each program declares at startup whether it wants the program >>> name prefix or not. >> >> Well, to clarify: I think it's reasonable to include "psql: " if the >> message is

Re: doc: improve PG 12 to_timestamp()/to_date() wording

2019-07-06 Thread Justin Pryzby
On Tue, Apr 30, 2019 at 07:14:04PM -0500, Justin Pryzby wrote: > On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote: > > I'd like to add couple of comments from my side. > > > > - returns an error because the second template string space is > > > consumed > > > - by th

Re: range_agg

2019-07-06 Thread Jeff Davis
On Fri, 2019-07-05 at 10:57 -0700, Paul A Jungwirth wrote: > I take it that a multirange contains of *disjoint* ranges, so instead > of {[1,2), [2,3), [6,7)} you'd have {[1,3), [6,7)}. Jeff does that > match your expectation? Yes. > I just realized that since weighted_range_agg and covering_range

Re: range_agg

2019-07-06 Thread Jeff Davis
On Fri, 2019-07-05 at 09:58 -0700, Paul A Jungwirth wrote: > user-defined range types. So how about I start on it and see how it > goes? I expect I can follow the existing code for range types pretty > closely, so maybe it won't be too hard. That would be great to at least take a look. If it start

Switching PL/Python to Python 3 by default in PostgreSQL 12

2019-07-06 Thread Steven Pousty
Greetings: I am not sure if this has been brought up before but Python 2 is EOL on Jan 1 2020. After that time there will not be any security fixes or patches. https://python3statement.org/ According to our most recent official documentation: https://www.postgresql.org/docs/11/plpython-python23.h

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-07-06 Thread Bruce Momjian
On Fri, Jul 5, 2019 at 10:24:39PM +0200, Tomas Vondra wrote: > I agree this is a pretty crucial challenge, and those requirements seem > in direct conflict. Users use encryption to protect privacy of the data, > but we need access to some of the data to implement some of the > important tasks of a

Re: Optimize partial TOAST decompression

2019-07-06 Thread Tomas Vondra
On Sat, Jul 06, 2019 at 02:27:56AM +0800, Binguo Bao wrote: Hi, Tomas! Thanks for your testing and the suggestion. That's quite bizarre behavior - it does work with a prefix, but not with suffix. And the exact ERROR changes after the prefix query. I think bug is caused by "#2 0x004c

Re: POC: Cleaning up orphaned files using undo logs

2019-07-06 Thread Dilip Kumar
On Thu, Jul 4, 2019 at 5:24 PM Amit Kapila wrote: > PFA, the latest version of the undo interface and undo processing patches. Summary of the changes in the patch set 1. Undo Interface - Rebased over latest undo storage code - Implemented undo page compression (don't store the common fields in a

Re: using explicit_bzero

2019-07-06 Thread Peter Eisentraut
On 2019-07-05 23:02, Thomas Munro wrote: > On Sat, Jul 6, 2019 at 1:07 AM Peter Eisentraut > wrote: >> On 2019-07-05 14:06, Thomas Munro wrote: >>> +#ifndef HAVE_EXPLICIT_BZERO >>> +#define explicit_bzero(b, len) memset(b, 0, len) >>> +#endif >>> >>> I noticed some other libraries use memset throu

Re: Comment typo in tableam.h

2019-07-06 Thread Amit Kapila
On Tue, Jul 2, 2019 at 1:00 AM Ashwin Agrawal wrote: > Please find attached v2 of patch 1 without objectionable comment change. v1 > of patch 2 attaching here just for convenience, no modifications made to it. > 0001* * See table_index_fetch_tuple's comment about what the difference between -