Meskes-san
> This looks good to me. It passes all my tests, too.
>
> There were two minor issues, the regression test did not run and gcc
> complained about the indentation in ECPGprepare(). Both I easily fixed.
Thank you so much !
> > (2)
> > I found some bugs (two types). I didn't fix them an
On Thu, 30 May 2019 at 20:13, Andres Freund wrote:
>
> Hi,
>
> On 2019-05-30 19:46:26 +0530, Amit Khandekar wrote:
> > @@ -1042,7 +1042,8 @@ ReplicationSlotReserveWal(void)
> > if (!RecoveryInProgress() && SlotIsLogical(slot))
> > {
> >
> > }
> > else
> > {
> > - restart_lsn = GetR
On Thu, May 30, 2019 at 6:39 PM Magnus Hagander wrote:
> For those of you that have not read the minutes from the developer meeting
> ahead of pgcon (can be found at
> https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like to
> announce here as well that David Rowley has join
On 2019/05/30 18:51, Amit Kapila wrote:
> On Wed, May 29, 2019 at 6:12 AM Amit Langote wrote:
>> On 2019/05/28 20:26, Amit Kapila wrote:
>>> Can we ensure some way that only FDW's rely on it not any other part
>>> of the code?
>>
>> Hmm, I can't think of any way of doing than other than manual insp
On 2019/05/31 0:39, Magnus Hagander wrote:
> Hi!
>
> For those of you that have not read the minutes from the developer meeting
> ahead of pgcon (can be found at
> https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like
> to announce here as well that David Rowley has joined the
2019/05/30 16:33、Amit Langote のメール:
>> On 2019/05/29 15:50, Kohei KaiGai wrote:
>> 2019年5月29日(水) 13:26 Amit Langote :
It means we can skip to load the sub-fields unreferenced, if
query-planner can handle
referenced and unreferenced sub-fields correctly.
On the other hands, it l
On Wed, May 29, 2019 at 12:09:08PM -0400, Alvaro Herrera wrote:
> Are there objections to doing that now on the master branch?
Adding the flush call just on HEAD is fine for me. Not sure that
there is an actual reason to back-patch that.
--
Michael
signature.asc
Description: PGP signature
On 2019-May-30, Andres Freund wrote:
> On 2019-05-30 15:02:44 -0700, Andres Freund wrote:
>
> > Seems we could round the edges a good bit further than what's done in
> > the attached (argument checking, for example, but also using the C++
> > compiler from configure). But I think this would alread
Hi,
On 2019-05-30 15:02:44 -0700, Andres Freund wrote:
> right now cpluspluscheck doesn't work with vpath builds. That's pretty
> annoying, because it does require cloning the git tree into a separate
> directory + doing configure there just to run cpluspluscheck.
>
> Attached is a small patch al
Hi,
right now cpluspluscheck doesn't work with vpath builds. That's pretty
annoying, because it does require cloning the git tree into a separate
directory + doing configure there just to run cpluspluscheck.
Attached is a small patch allowing cpluspluscheck to run from different
directories. I ne
Hi,
On 2019-05-22 10:25:14 +0200, Daniel Gustafsson wrote:
> It passes make check and some light profiling around regress suites indicates
> that it does improve a bit by reducing the somewhat costly calls.
Just for the record, here is the profile I did:
perf record --call-graph lbr make -s chec
Hi,
On 2019-05-30 14:01:00 -0400, Tom Lane wrote:
> Using Apple's clang as c++ compiler:
>
> In file included from /tmp/cpluspluscheck.KejiIw/test.cpp:3:
> ./src/include/access/tableam.h:144:16: error: typedef redefinition with
> different types ('void (*)(Relation, HeapTuple, Datum *, bool *, b
On Thu, May 30, 2019 at 11:39:23AM -0400, Magnus Hagander wrote:
> Congratulations to David, may the buildfarm be gentle to him, and his first
> revert far away!
Congrats!
--
Michael
signature.asc
Description: PGP signature
On Mon, May 27, 2019 at 04:22:37PM +0200, Fabien COELHO wrote:
> Works for me. Doc build is ok as well.
Thanks, committed.
--
Michael
signature.asc
Description: PGP signature
On Thu, May 30, 2019 at 01:52:20PM -0400, Alvaro Herrera wrote:
> If there are other obvious improvements to be had, please let me know.
> (We have PG_TEST_EXTRA="ssl ldap" currently, do we have any more extra
> tests now?)
You can add kerberos to this list, to give:
PG_TEST_EXTRA='ssl ldap kerber
Alvaro Herrera writes:
> Apparently, for ecpg you have to do "make checktcp" in order for some of
> the tests to run, and "make check-world" doesn't do that. Not sure
> what's a good fix for this; do we want to add "make -C
> src/interfaces/ecpg/test checktcp" to what "make check-world" does,
> o
I wrote:
> I propose that we change src/tools/pginclude/cpluspluscheck so that
> it searches basically everywhere:
> -for f in `find src/include src/interfaces/libpq/libpq-fe.h
> src/interfaces/libpq/libpq-events.h -name '*.h' -print | \
> +for f in `find src contrib -name '*.h' -print | \
Afte
On 2019-May-30, Tom Lane wrote:
> Alvaro Herrera writes:
> > I just enabled --enabled-llvm on the coverage reporting machine, which
> > made src/backend/jit/jit.c go from 60/71 % (line/function wise) to 78/85 %
> > ...
> > and src/backend/jit/llvm from not appearing at all in the report to
> > 7
Apparently, for ecpg you have to do "make checktcp" in order for some of
the tests to run, and "make check-world" doesn't do that. Not sure
what's a good fix for this; do we want to add "make -C
src/interfaces/ecpg/test checktcp" to what "make check-world" does,
or do we rather what to add checktc
On 5/30/19 11:43 AM, Andres Freund wrote:
> Hi,
>
> On 2019-05-30 11:39:23 -0400, Magnus Hagander wrote:
>> For those of you that have not read the minutes from the developer meeting
>> ahead of pgcon (can be found at
>> https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like
>>
On 05/30/2019 10:39 am, Magnus Hagander wrote:
> Hi!
>
> For those of you that have not read the minutes from the developer meeting
> ahead of pgcon (can be found at
> https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like to
> announce here as well that David Rowley has jo
On Thu, May 30, 2019 at 9:09 PM Magnus Hagander wrote:
>
> Hi!
>
> For those of you that have not read the minutes from the developer meeting
> ahead of pgcon (can be found at
> https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like to
> announce here as well that David Rowle
Alvaro Herrera writes:
> I just enabled --enabled-llvm on the coverage reporting machine, which
> made src/backend/jit/jit.c go from 60/71 % (line/function wise) to 78/85 % ...
> and src/backend/jit/llvm from not appearing at all in the report to
> 78/94 %. That's a good improvement.
> If there
Using Apple's clang as c++ compiler:
In file included from /tmp/cpluspluscheck.KejiIw/test.cpp:3:
./src/include/access/tableam.h:144:16: error: typedef redefinition with
different types ('void (*)(Relation, HeapTuple, Datum *, bool *, bool, void *)'
(aka 'void (*)(RelationData *, HeapTupleData *
I just enabled --enabled-llvm on the coverage reporting machine, which
made src/backend/jit/jit.c go from 60/71 % (line/function wise) to 78/85 % ...
and src/backend/jit/llvm from not appearing at all in the report to
78/94 %. That's a good improvement.
If there are other obvious improvements to
Hi,
I, Devansh Gupta, have just completed my sophomore year in B.Tech. in
Computer Science and Engineering from International Institute of
Information Technology Hyderabad, India and am planning to contribute to
the documentation of the *postgreSQL *project.
I have already used numPy for many pro
Alvaro Herrera writes:
> On 2019-May-30, Tom Lane wrote:
>> Hm, I don't understand how this works at all:
>>
>> +PERFORM pg_sleep(CASE WHEN count(*) = 0 THEN 0 ELSE 0.1
>> END)
>> +FROM schema1.counted WHERE type = 'delta';
>> +GET DIAG
On Thu, May 30, 2019 at 11:39:23AM -0400, Magnus Hagander wrote:
> Hi!
>
> For those of you that have not read the minutes from the developer meeting
> ahead of pgcon (can be found at
> https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like
> to announce here as well that David
Hi,
On 2019-05-30 11:39:23 -0400, Magnus Hagander wrote:
> For those of you that have not read the minutes from the developer meeting
> ahead of pgcon (can be found at
> https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like
> to announce here as well that David Rowley has joine
On 2019-May-30, Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2019-May-29, Tom Lane wrote:
> >> I'm not opposed to adding a new test case at this point in the cycle,
> >> but as written this one seems more or less guaranteed to fail under
> >> load.
>
> > True. Here's a version that should be
Alvaro Herrera writes:
> On 2019-May-29, Tom Lane wrote:
>> I'm not opposed to adding a new test case at this point in the cycle,
>> but as written this one seems more or less guaranteed to fail under
>> load.
> True. Here's a version that should be more resilient.
Hm, I don't understand how th
On 5/30/19 11:39 AM, Magnus Hagander wrote:
For those of you that have not read the minutes from the developer
meeting ahead of pgcon (can be found at
https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd
like to announce here as well that David Rowley has joined the ranks of
On 2019-May-30, Tomas Vondra wrote:
> Pushed and backpatched, changing most places to elog().
Thanks :-)
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-May-29, Tom Lane wrote:
> Alvaro Herrera writes:
> > Tom pointed out that coverage for worker_spi is 0%. For a module that
> > only exists to provide coverage, that's pretty stupid. This patch
> > increases coverage to 90.9% line-wise and 100% function-wise, which
> > seems like a suffi
[ redirecting to -hackers ]
=?koi8-r?B?9MHSwdPP1yDnxc/Sx8nKIPfJ1MHM2MXXyd4=?= writes:
> I'm working on development of some PL/pgSQL plugin.
> The smaller part of my code is written on C.
> It's a standard extension code for integration with fmgr (_PG_init ...)
> But bigger part of the code is wri
On Thu, May 30, 2019 at 6:39 PM Magnus Hagander wrote:
For those of you that have not read the minutes from the developer meeting
ahead of pgcon (can be found at
https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like
to announce here as well that David Rowley has joined the rank
Hi!
For those of you that have not read the minutes from the developer meeting
ahead of pgcon (can be found at
https://wiki.postgresql.org/wiki/PgCon_2019_Developer_Meeting), we'd like
to announce here as well that David Rowley has joined the ranks of
PostgreSQL committers.
Congratulations to Dav
On Wed, May 15, 2019 at 06:35:47PM +0200, Tomas Vondra wrote:
On Wed, May 15, 2019 at 12:17:29PM -0400, Alvaro Herrera wrote:
On 2019-May-05, Tomas Vondra wrote:
OK, so here is a patch, using elog() for all places except for the
input function, where we simply report we don't accept those valu
it's really cool and very good progress,
I'm interesting if SIDM/JIT will be supported
best wishes
TY
On 2019/5/23 08:07, Ashwin Agrawal wrote:
> We (Heikki, me and Melanie) are continuing to build Zedstore. Wish to
> share the recent additions and modifications. Attaching a patch
> with th
Hi,
On 2019-05-30 16:31:39 +0530, Ashutosh Sharma wrote:
> Here are some more details on the crash reported in my previous e-mail for
> better clarity:
I'll look into this once pgcon is over... Thanks for finding!
Greetings,
Andres Freund
Hi,
On 2019-05-30 19:46:26 +0530, Amit Khandekar wrote:
> @@ -1042,7 +1042,8 @@ ReplicationSlotReserveWal(void)
> if (!RecoveryInProgress() && SlotIsLogical(slot))
> {
>
> }
> else
> {
> - restart_lsn = GetRedoRecPtr();
> + restart_lsn = SlotIsLogical(slot) ?
> +
> On Wed, May 29, 2019 at 6:17 PM Pavel Stehule wrote:
>
> st 29. 5. 2019 v 17:49 odesílatel Dmitry Dolgov <9erthali...@gmail.com>
> napsal:
>>
>> Rebase after pg_indent. Besides, off the list there was a suggestion that
>> this
>> could be useful to accept more than one data type as a key for s
On Mon, 27 May 2019 at 19:26, Andres Freund wrote:
>
> On 2019-05-27 17:04:44 +0530, Amit Khandekar wrote:
> > On Fri, 24 May 2019 at 21:00, Amit Khandekar wrote:
> > >
> > > On Fri, 24 May 2019 at 19:26, Amit Khandekar
> > > wrote:
> > > > Working on the patch now
> > >
> > > Attached is
Hi All,
Here are some more details on the crash reported in my previous e-mail for
better clarity:
The crash only happens when a *primary key* or *btree index* is created on
the test table. For example consider the following two scenarios.
*TC1: With PK*
create table t1(a int *primary key*, b te
On Wed, May 29, 2019 at 6:12 AM Amit Langote
wrote:
>
> On 2019/05/28 20:26, Amit Kapila wrote:
> > On Tue, May 28, 2019 at 12:29 PM Amit Langote wrote:
> >> Seeing that the crash occurs due to postgres_fdw relying on
> >> es_result_relation_info being set when initializing a "direct
> >> modifica
On Tue, May 28, 2019 at 10:30 AM Alexander Lakhin wrote:
>
> 28.05.2019 2:05, Amit Kapila wrote:
> > On Mon, May 27, 2019 at 3:59 AM Tom Lane wrote:
> >> Amit Kapila writes:
> >>> On Sun, May 26, 2019 at 2:20 AM Alexander Lakhin
> >>> wrote:
> 5. ExecContextForcesOids - not changed, but m
On 2019/05/29 15:50, Kohei KaiGai wrote:
> 2019年5月29日(水) 13:26 Amit Langote :
>>> It means we can skip to load the sub-fields unreferenced, if
>>> query-planner can handle
>>> referenced and unreferenced sub-fields correctly.
>>> On the other hands, it looks to me RelOptInfo or other optimizer
>>>
On 29.05.2019 22:20, Michael Paquier wrote:
On Mon, May 27, 2019 at 05:52:13PM +0300, Konstantin Knizhnik wrote:
Postgres is opening file with FILE_SHARE_DELETE flag which makes it
possible to unlink opened file.
But unlike Unixes, the file is not actually deleted. You can see it using
"dir"
48 matches
Mail list logo
