Re: AllocSetContextCreate changes breake extensions

2018-12-01 Thread Andrew Gierth
> "Tom" == Tom Lane writes: [snip] The commit for this said: With this change, there is no reason for anybody to call AllocSetContextCreateExtended directly, so in HEAD I renamed it to except there IS such a reason: if you need (as I do in pl/lua) to wrap the call in a catch block

Re: Markdown format output for psql, design notes

2018-12-01 Thread Pavel Stehule
so 1. 12. 2018 v 22:11 odesílatel Daniel Verite napsal: > Lætitia Avrot wrote: > > > But as Vik said earlier, maybe it's not worth it to provide a markdown > > output as pandoc can generate the markdown from the HTML output. > > And if you need the markdown output to generate HTML why don

Re: proposal: less strict input of regprocedure type

2018-12-01 Thread Pavel Stehule
ne 2. 12. 2018 v 4:52 odesílatel Pavel Stehule napsal: > > > so 1. 12. 2018 v 20:49 odesílatel Tom Lane napsal: > >> Pavel Stehule writes: >> > input value of regrocedure type should be complete function signature. >> > postgres=# select 'uni'::regprocedure; >> > ERROR: expected a left parenth

Re: proposal: less strict input of regprocedure type

2018-12-01 Thread Pavel Stehule
so 1. 12. 2018 v 20:49 odesílatel Tom Lane napsal: > Pavel Stehule writes: > > input value of regrocedure type should be complete function signature. > > postgres=# select 'uni'::regprocedure; > > ERROR: expected a left parenthesis > > LINE 1: select 'uni'::regprocedure; > >^ >

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-12-01 Thread Peter Geoghegan
On Sat, Dec 1, 2018 at 4:10 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > Just for the information, cfbot says there are problems on windows: > > src/backend/catalog/pg_depend.c(33): error C2065: 'INT32_MAX' : > undeclared identifier Thanks. Looks like I should have used PG_INT32_MAX. -- Pet

Re: [PATCH] Log CSV by default

2018-12-01 Thread Vik Fearing
On 30/11/2018 21:15, Andres Freund wrote: > Secondarily, csvlog doesn't contain all the interesting information. It doesn't? What is it missing? -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

2018-12-01 Thread Andres Freund
Hi, On 2018-12-01 17:28:54 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-12-01 12:06:36 -0500, Tom Lane wrote: > >> Or should we go so far as to have configure add -msse2 automatically? > > > Probably not - there's several OSs / distributions that do not yet > > require an SSE2 capa

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

2018-12-01 Thread Tom Lane
Andres Freund writes: > On 2018-12-01 12:06:36 -0500, Tom Lane wrote: >> I wonder whether we shouldn't remove the clang aspect of the test >> you added, ie just make it read "if on x86, you must have either >> -fexcess-precision=standard or -msse2". > That sounds reasonable. >> Or should we go s

on or true

2018-12-01 Thread Tatsuo Ishii
In the documentation of ssl_passphrase_command_supports_reload: configuration reload if a key file needs a passphrase. If this parameter is false (the default), then : : running. Setting this parameter to true might be appropriate if the passphrase is obtained fro

{PROPOSAL] add session information column to pg_stat_statements

2018-12-01 Thread Sergei Agalakov
I have renamed the thread [PROPOSAL] extend the object names to the qualified names in pg_stat_statements started on https://www.postgresql.org/message-id/9baf5c06-d6ab-c688-010c-843348e3d98c%40gmail.com and ended on https://www.postgresql.org/message-id/c93bb5ce-22bd-eb6b-a057-d0666585258f%40gma

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

2018-12-01 Thread Andres Freund
Hi,m On 2018-12-01 12:06:36 -0500, Tom Lane wrote: > I wonder whether we shouldn't remove the clang aspect of the test > you added, ie just make it read "if on x86, you must have either > -fexcess-precision=standard or -msse2". That sounds reasonable. > Or should we go so far as to have configu

Re: Frontends including fd.h

2018-12-01 Thread Sergei Kornilov
Hello I am +1 to have separate header with path names. Another examples are: - pg_ctl with many hardcoded files such as "promote" (PROMOTE_SIGNAL_FILE), "logrotate" (LOGROTATE_SIGNAL_FILE), postgresql.conf, PG_VERSION, backup_label, postmaster.pid - pg_basebackup with currently hardcoded "stand

Re: Markdown format output for psql, design notes

2018-12-01 Thread Daniel Verite
Lætitia Avrot wrote: > But as Vik said earlier, maybe it's not worth it to provide a markdown > output as pandoc can generate the markdown from the HTML output. > And if you need the markdown output to generate HTML why don't you use the > HTML output ? The round-trip through pandoc does

Re: Support custom socket directory in pg_upgrade

2018-12-01 Thread Tom Lane
Peter Eisentraut writes: > On 30/11/2018 17:58, Tom Lane wrote: >> Given that we have a patch for this approach, and no patch has been >> offered for the /tmp approach, I'm kind of inclined to exercise >> committer's discretion and proceed with this patch. Will anybody >> be seriously annoyed if

Re: [HACKERS] Can ICU be used for a database's default sort order?

2018-12-01 Thread Daniel Verite
Dmitry Dolgov wrote: > As a side note, I'm a bit confused, who is the original author of > the proposed patch? If it's Marina, why she isn't involved in the > discussion or even mentioned in the patch itself? The original patch [1] starts with these commit metadata: From e1cb130f550952

Re: proposal: less strict input of regprocedure type

2018-12-01 Thread Tom Lane
Pavel Stehule writes: > input value of regrocedure type should be complete function signature. > postgres=# select 'uni'::regprocedure; > ERROR: expected a left parenthesis > LINE 1: select 'uni'::regprocedure; >^ Yup. > I think so it is not necessary, when function name is uniq

proposal: less strict input of regprocedure type

2018-12-01 Thread Pavel Stehule
Hi input value of regrocedure type should be complete function signature. postgres=# select 'uni'::regprocedure; ERROR: expected a left parenthesis LINE 1: select 'uni'::regprocedure; ^ I think so it is not necessary, when function name is unique. plpgsql_check uses regprocedure

Re: Commitfest 2018-11

2018-12-01 Thread Lætitia Avrot
> > > > Yeah, I've been annoyed by that too (not that I've not been guilty of > it myself). We should probably tell people not to add themselves as > reviewers unless they're actively planning to review soon, because it > discourages other people from reviewing the same item. Maybe also, > when a

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

2018-12-01 Thread Tom Lane
I wrote: > Looking at the buildfarm, our only extant member that is on x86, and > is not using clang, and doesn't have -fexcess-precision=standard, is > dromedary which is using Apple's old toolchain. So the fact that it > isn't showing the problem isn't very good evidence about how widespread > t

Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2018-12-01 Thread Jesse Zhang
Hey Chengyu, How did you set up your GDB to get "p" to pretty-print a Postgres list? Cheers, Jesse On Fri, Nov 30, 2018 at 1:00 PM Chengchao Yu wrote: > Greetings, > > > > Recently, we hit a few occurrences of deadlock when IO failure (including > disk full, random remote disk IO failures) happ

Re: Commitfest 2018-11

2018-12-01 Thread Jaime Casanova
On Sat, 1 Dec 2018 at 12:38, Tom Lane wrote: > > Maybe also, > when a patch gets moved to the next CF, we should drop all reviewers > (ie make them sign up afresh if they're still interested). > i like that idea, fwiw -- Jaime Casanova www.2ndQuadrant.com PostgreSQL Develop

Re: Commitfest 2018-11

2018-12-01 Thread Tom Lane
Dmitry Dolgov <9erthali...@gmail.com> writes: > Commitfest 2018-11 is closed. Thanks everyone who participated by posting > patches, reviewing them, occasionally committing them, commenting on ideas or > just raising one eyebrow in surprise while reading the hackers mailing list. Thanks for all th

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

2018-12-01 Thread Tom Lane
Andres Freund writes: > On 2018-09-04 17:51:30 -0700, Andres Freund wrote: >> My current proposal is thus to do add a check that does >> #if defined(__clang__) && defined(__i386__) && !defined(__SSE2_MATH__) >> something-that-fails >> #endif >> in an autoconf test, and have configure complain if t

Re: pg_stat_ssl additions

2018-12-01 Thread Peter Eisentraut
Updated patch with the renamed columns. On 29/11/2018 14:49, Peter Eisentraut wrote: > On 29/11/2018 01:27, Lou Picciano wrote: >> Further, I’m not sure exposing details about Cert Issuer, etc. to >> non-privileged users is much of an issue. For the most part, in most use >> cases, ‘users’ should

Re: Inadequate executor locking of indexes

2018-12-01 Thread Amit Kapila
On Fri, Nov 23, 2018 at 9:55 PM Tom Lane wrote: > > Thinking more about this, the problem I noted previously about two of > these solutions not working if the index scan node is not physically > underneath the ModifyTable node actually applies to all three :-(. > It's a slightly different issue fo

Re: jsonpath

2018-12-01 Thread Dmitry Dolgov
> On Wed, Nov 28, 2018 at 9:26 PM Alexander Korotkov > wrote: > > On Sat, Nov 24, 2018 at 11:03 PM Tomas Vondra > wrote: > > I've done another round of reviews on v20, assuming the patch is almost > > ready to commit, but unfortunately I ran into a bunch of issues that > > need to be resolved. N

Re: Protect syscache from bloating with negative cache entries

2018-12-01 Thread Dmitry Dolgov
> On Tue, Nov 27, 2018 at 11:40 AM Kyotaro HORIGUCHI > wrote: > > The attached is the rebased version that has multidimentional > ageclass. Thank you, Just for the information, cfbot complains about this patch because: pgstatfuncs.c: In function ‘pgstat_get_syscache_stats’: pgstatfuncs.c:1973:

Re: Refactoring the checkpointer's fsync request queue

2018-12-01 Thread Dmitry Dolgov
> On Mon, Nov 26, 2018 at 11:47 PM Thomas Munro > wrote: > > On Fri, Nov 23, 2018 at 5:45 PM Thomas Munro > wrote: > > I do have a new plan though... > > Ugh. The plan in my previous email doesn't work, I was confused about > the timing of the buffer header update. Back to the drawing board.

Re: Make foo=null a warning by default.

2018-12-01 Thread Dmitry Dolgov
> On Mon, Nov 26, 2018 at 9:19 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Tue, Aug 7, 2018 at 11:19 PM Bruce Momjian wrote: > > > > On Mon, Jul 16, 2018 at 11:37:28AM -0400, Tom Lane wrote: > > > Heikki Linnakangas writes: > > > > On 16/07/18 18:10, Tom Lane wrote: > > > >> TBH I'm

Re: SQL/JSON: functions

2018-12-01 Thread Dmitry Dolgov
> On Mon, Nov 26, 2018 at 5:11 PM Nikita Glukhov > wrote: > > On 26.11.2018 15:57, Dmitry Dolgov wrote: > > >> On Tue, Jul 3, 2018 at 2:57 PM Pavel Stehule > >> wrote: > >> > >> 2018-07-03 14:30 GMT+02:00 Nikita Glukhov : > >>> Attached 16th version of the patches: > >>> * changed type of new

Re: inconsistency and inefficiency in setup_conversion()

2018-12-01 Thread Dmitry Dolgov
> On Mon, Nov 26, 2018 at 9:31 AM John Naylor wrote: > > v7 is a rebase over recent catalog changes. Thanks for working on this, I see that the author keeps patch updated, but I'm a bit worried because of lack of full review since probably May. I'm moving it to the next CF, let's see if there wo

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-12-01 Thread Dmitry Dolgov
> On Sun, Nov 25, 2018 at 12:14 AM Peter Geoghegan wrote: > > Attached is v8 of the patch series, which has some relatively minor changes: Thank you for working on this patch, Just for the information, cfbot says there are problems on windows: src/backend/catalog/pg_depend.c(33): error C2065: '

Re: Online verification of checksums

2018-12-01 Thread Dmitry Dolgov
> On Wed, Nov 21, 2018 at 1:38 PM Michael Banck > wrote: > > Hi, > > On Tue, Oct 30, 2018 at 06:22:52PM +0100, Fabien COELHO wrote: > > >I am not convinced we need to differentiate further between online and > > >offline operation, can you explain in more detail which other > > >differences are o

Re: cursors with prepared statements

2018-12-01 Thread Dmitry Dolgov
> On Thu, Nov 22, 2018 at 11:11 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Wed, Jul 18, 2018 at 10:27 AM Heikki Linnakangas wrote: > > > > On 16/07/18 15:56, Peter Eisentraut wrote: > > > On 11.07.18 19:07, Heikki Linnakangas wrote: > > >> It's confusing, and risks conflicting with f

Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot

2018-12-01 Thread Simon Riggs
On Fri, 30 Nov 2018 at 23:08, Michael Paquier wrote: > On Fri, Nov 30, 2018 at 02:55:47PM +, Simon Riggs wrote: > > 1df21ddb looks OK to me and was simple enough to backpatch safely. > > Thanks for the feedback! > > > Seems excessive to say that the WAL record is corrupt, it just contains > >

Re: WIP: Avoid creation of the free space map for small tables

2018-12-01 Thread Amit Kapila
On Sat, Dec 1, 2018 at 12:42 PM John Naylor wrote: > > On 11/29/18, Amit Kapila wrote: > > On Thu, Nov 29, 2018 at 3:07 PM John Naylor wrote: > >> Done. I tried adding it to several schedules, but for some reason > >> vacuuming an empty table failed to truncate the heap to 0 blocks. > >> Putting