Re: Conflicting option checking in pg_restore

2018-10-27 Thread Fabien COELHO
HallÄ Daniel, Checking for conflicting options in pg_restore was mostly done in main() with one check deferred until RestoreArchive(). Reading the git history makes it seem like it simply happened, without the disjoint checking being intentional. Am I reading it right that we can consolidate a

Re: [RFC] Removing "magic" oids

2018-10-27 Thread Amit Kapila
On Sun, Oct 28, 2018 at 12:26 AM Andres Freund wrote: > > Hi, > > On 2018-10-28 00:21:23 +0530, Amit Kapila wrote: > > On Sun, Sep 30, 2018 at 9:18 AM Andres Freund wrote: > > > I think we should drop WITH OIDs support. pg_dump should convert WITH > > > OIDs tables into tables that have an expli

Re: Comment fix and question about dshash.c

2018-10-27 Thread Thomas Munro
On Sun, Oct 28, 2018 at 1:22 AM Tomas Vondra wrote: > On 10/27/2018 01:51 PM, Antonin Houska wrote: > > Antonin Houska wrote: > >> Thomas Munro wrote: > >>> On Sat, Oct 27, 2018 at 12:30 AM Antonin Houska wrote: > >>> Are you saying there is a bug in this logic (which is nbuckets * 0.75 > >>> e

Re: PostgreSQL Limits and lack of documentation about them.

2018-10-27 Thread Narayanan V
+1 for inclusion in docs. On Fri, Oct 26, 2018 at 4:00 AM David Rowley wrote: > For a long time, we documented our table size, max columns, max column > width limits, etc. in https://www.postgresql.org/about/ , but that > information seems to have now been removed. The last version I can > find

Re: vacuum fails with "could not open statistics file" "Device or resource busy"

2018-10-27 Thread Tomas Vondra
Hi, On 10/20/2018 04:15 AM, Andres Freund wrote: > Hi, > > buildfarm member lorikeet had an interesting buildfarm failure in the > logical decoding test. The failure looks unrelated to logical decoding, > but might be more widely relevant: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl

Re: Remove obsolete pg_attrdef.adsrc column

2018-10-27 Thread Daniel Gustafsson
> On 27 Oct 2018, at 12:57, Peter Eisentraut > wrote: > > On 23/10/2018 19:48, Daniel Gustafsson wrote: >>> On 23 Oct 2018, at 15:17, Peter Eisentraut >>> wrote: >>> >>> I propose the attached patch to remove the long-unused catalog column >>> pg_attrdef.adsrc. >> >> +1, I ran into a bug in

Conflicting option checking in pg_restore

2018-10-27 Thread Daniel Gustafsson
Checking for conflicting options in pg_restore was mostly done in main() with one check deferred until RestoreArchive(). Reading the git history makes it seem like it simply happened, without the disjoint checking being intentional. Am I reading it right that we can consolidate all the option chec

Re: Postgres restore issue

2018-10-27 Thread Narayanan V
Hi Anand, I was unsuccessful in trying to reproduce this with a database and pg_dump from 8.3.7 and a pg_restore of 8.4.22. -- I do get the following error during the restore on an empty database,

Re: Ltree: set of allowed charcters is limited to [A-Za-z0-9_]. Could the dash "-" be included?

2018-10-27 Thread Alban Hertroys
> On 27 Oct 2018, at 18:14, David G. Johnston > wrote: > >> On Saturday, October 27, 2018, joernbs wrote: >> Dear friends, >> >> I would like to use ltree for search paths in a warehouse application, >> something like "Material-Entry-01.Main-Aisle.Shelf-Aisle-R07/R08.R07-12-03" >> Unfortuna

Re: [RFC] Removing "magic" oids

2018-10-27 Thread Andres Freund
Hi, On 2018-10-28 00:21:23 +0530, Amit Kapila wrote: > On Sun, Sep 30, 2018 at 9:18 AM Andres Freund wrote: > > I think we should drop WITH OIDs support. pg_dump should convert WITH > > OIDs tables into tables that have an explicit oid column (with an > > appropriate default function), pg_upgrad

Re: [RFC] Removing "magic" oids

2018-10-27 Thread Amit Kapila
On Sun, Sep 30, 2018 at 9:18 AM Andres Freund wrote: > > Hi, > > In my opinion the current WITH OIDs system has numerous weaknesses: > > 1) The fact that oids are so magic means that if we get pluggable >storage, the design of the potential pluggable systems is constrained >and similar mag

Re: [RFC] Removing "magic" oids

2018-10-27 Thread Amit Kapila
On Wed, Oct 17, 2018 at 9:22 PM Stephen Frost wrote: > > Greetings, > > * Robert Haas (robertmh...@gmail.com) wrote: > > On Sun, Oct 14, 2018 at 6:43 PM Andres Freund wrote: > > > I'm not sure we want that however - yes, the short time pain will be > > > lower, but do we really want to inflict th

Re: Ltree: set of allowed charcters is limited to [A-Za-z0-9_]. Could the dash "-" be included?

2018-10-27 Thread David G. Johnston
On Saturday, October 27, 2018, joernbs wrote: > Dear friends, > > I would like to use ltree for search paths in a warehouse application, > something like "Material-Entry-01.Main-Aisle. > Shelf-Aisle-R07/R08.R07-12-03" > Unfortunately I can not use common separators like dash (-) or slash(/) > > D

Re: Resetting PGPROC atomics in ProcessInit()

2018-10-27 Thread Amit Kapila
On Sat, Oct 27, 2018 at 8:52 PM Andres Freund wrote: > On October 27, 2018 3:36:45 PM GMT+01:00, Amit Kapila > wrote: > >On Sat, Oct 27, 2018 at 4:11 PM Andres Freund > >wrote: > >> > >> Hi, > >> > >> I just noticed, while working on a patch adding things to PGPROC, > >that > >> the group clear

Ltree: set of allowed charcters is limited to [A-Za-z0-9_]. Could the dash "-" be included?

2018-10-27 Thread joernbs
Dear friends, I would like to use ltree for search paths in a warehouse application, something like "Material-Entry-01.Main-Aisle.Shelf-Aisle-R07/R08.R07-12-03" Unfortunately I can not use common separators like dash (-) or slash(/) Documentation states only thes characters [A-Za-z0-9_] are allow

Re: DSM robustness failure (was Re: Peripatus/failures)

2018-10-27 Thread Amit Kapila
On Thu, Oct 18, 2018 at 2:33 PM Thomas Munro wrote: > > On Thu, Oct 18, 2018 at 5:00 PM Amit Kapila wrote: > > The below code seems to be problemetic: > > dsm_cleanup_using_control_segment() > > { > > .. > > if (!dsm_control_segment_sane(old_control, mapped_size)) > > { > > dsm_impl_op(DSM_OP_DET

Re: Resetting PGPROC atomics in ProcessInit()

2018-10-27 Thread Andres Freund
On October 27, 2018 3:36:45 PM GMT+01:00, Amit Kapila wrote: >On Sat, Oct 27, 2018 at 4:11 PM Andres Freund >wrote: >> >> Hi, >> >> I just noticed, while working on a patch adding things to PGPROC, >that >> the group clearning patches for the proc array and clog reset atomics >in >> InitProce

Re: Ordered Partitioned Table Scans

2018-10-27 Thread Julien Rouhaud
Hi, On Fri, Oct 26, 2018 at 1:01 PM Julien Rouhaud wrote: > On Fri, Oct 26, 2018 at 6:40 AM David Rowley > wrote: > > > > On 26 October 2018 at 16:52, Amit Langote > > wrote: > > > I recall Ronan Dunklau and Julien Rouhaud had proposed a patch for this > > > last year, but the partitioning-rel

Re: Resetting PGPROC atomics in ProcessInit()

2018-10-27 Thread Amit Kapila
On Sat, Oct 27, 2018 at 4:11 PM Andres Freund wrote: > > Hi, > > I just noticed, while working on a patch adding things to PGPROC, that > the group clearning patches for the proc array and clog reset atomics in > InitProcess(). > > I'm not a big fan of that, because it means that it's not safe to

Re: Comment fix and question about dshash.c

2018-10-27 Thread Tomas Vondra
On 10/27/2018 01:51 PM, Antonin Houska wrote: Antonin Houska wrote: Thomas Munro wrote: On Sat, Oct 27, 2018 at 12:30 AM Antonin Houska wrote: Are you saying there is a bug in this logic (which is nbuckets * 0.75 expressed as integer maths), or saying that 0.75 is not a good maximum load

Re: Comment fix and question about dshash.c

2018-10-27 Thread Antonin Houska
Antonin Houska wrote: > Thomas Munro wrote: > > > On Sat, Oct 27, 2018 at 12:30 AM Antonin Houska wrote: > > > > Are you saying there is a bug in this logic (which is nbuckets * 0.75 > > expressed as integer maths), or saying that 0.75 is not a good maximum > > load factor? I looked around a

Re: Comment fix and question about dshash.c

2018-10-27 Thread Antonin Houska
Thomas Munro wrote: > On Sat, Oct 27, 2018 at 12:30 AM Antonin Houska wrote: > > Thanks, will fix. > > > 2. Can anyone please explain this macro? > > > > /* Max entries before we need to grow. Half + quarter = 75% load factor. */ > > #define MAX_COUNT_PER_PARTITION(hash_table)

Re: [PROPOSAL]a new data type 'bytea' for ECPG

2018-10-27 Thread Michael Meskes
Hi Ryo-san, > # Please call me Ryo. Matsumura is too long. Thanks. > In Pro*C, the data should be represented as hex format C string. Just to clarify, there is no special datatype for binary data? > bytea as a type of table definition may correspond to BLOB in the > standard. Would we prefer

Re: Remove obsolete pg_attrdef.adsrc column

2018-10-27 Thread Peter Eisentraut
On 23/10/2018 19:48, Daniel Gustafsson wrote: >> On 23 Oct 2018, at 15:17, Peter Eisentraut >> wrote: >> >> I propose the attached patch to remove the long-unused catalog column >> pg_attrdef.adsrc. > > +1, I ran into a bug in an app as recently as today where adsrc was used > instead of pg_get_

Resetting PGPROC atomics in ProcessInit()

2018-10-27 Thread Andres Freund
Hi, I just noticed, while working on a patch adding things to PGPROC, that the group clearning patches for the proc array and clog reset atomics in InitProcess(). I'm not a big fan of that, because it means that it's not safe to look at the atomics of backends that aren't currently in use. Is th

Re: Postgres restore issue

2018-10-27 Thread Heikki Linnakangas
On 25 October 2018 20:27:07 WEST, "Vaidyanathaswamy, Anandsaikrishnan" wrote: >We have postgres running in 8.4.22, We have back up from 8.3.7 >When I try to restore, All the tables are not restored, almost 60% of >the tables not exist, Failed with the following errors. > >Any help on this much ap