On 14 August 2018 at 09:23, Robert Haas wrote:
> On Sat, Aug 11, 2018 at 9:16 AM, David Rowley
> wrote:
>> I started debugging this to see where things go wrong. I discovered
>> that add_paths_to_append_rel() is called yet again from
>> apply_scanjoin_target_to_paths() and this is where it's all
On 17 August 2018 at 06:52, Robert Haas wrote:
> I don't know whether there's actually a defect here any more. I was
> trying to dispel some perceived confusion on the part of David and Tom
> about what this code was trying to accomplish, but the fact that the
> code caused some confusion does no
On Mon, Aug 13, 2018 at 12:21:42AM +0200, Michael Paquier wrote:
> The patch attached includes tests which I have used to also check that
> correct error messages are produced for VACUUM, VACUUM ANALYZE and
> ANALYZE.
I have reworked the patch on this side, clarifying the use of the new
common API
Hello hackers,
The attached patch adds a new option work_mem to postgres_fdw contrib module.
Previously, it was impossible to change the setting of work_mem for remote
session with connection by postgres_fdw.
By adding this option to the CREATE SERVER statement, you can also change the
work_
On 29 June 2018 at 11:53, Amit Langote wrote:
> What I'm thinking of doing is something that's inspired by one of the
> things that David Rowley proposes in his patch for PG 12 to remove
> inefficiencies in the tuple routing code [1].
>
> Instead of a single TupleTableSlot attached at partition_tu
On Thu, Aug 09, 2018 at 10:37:28AM -0400, Cynthia Shang wrote:
> This patch looks good. I realized I should have changed the status
> back while we were discussing all this. It is now (and still is) ready
> for committer.
I have some comments.
-ERROR: COPY HEADER available only in CSV mode
+ERRO
17.08.2018 08:55, Michael Paquier пишет:
On Fri, Aug 17, 2018 at 08:47:15AM +0500, Andrey Lepikhov wrote:
Previously, in all cases of using WAL this was not a problem. However if you
plan to perform some decoding operations before returning the WAL record to
the caller (this is my case), this
On Fri, Aug 17, 2018 at 08:47:15AM +0500, Andrey Lepikhov wrote:
> Previously, in all cases of using WAL this was not a problem. However if you
> plan to perform some decoding operations before returning the WAL record to
> the caller (this is my case), this can lead to bugs that are difficult to
>
Hi, hackers!
I propose the patch for fix one small code defect.
The XLogReadRecord() function reads the pages of a WAL segment that
contain a WAL-record. Then it creates a readRecordBuf buffer in private
memory of a backend and copy record from the pages to the readRecordBuf
buffer. Pointer 'r
On 2018/08/17 11:47, Michael Paquier wrote:
On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
I have been looking at this patch. And while consistency is nice, I
think that if we are cleaning up th
On 2018/08/17 12:31, Michael Paquier wrote:
On Fri, Aug 17, 2018 at 12:19:42PM +0900, Tatsuro Yamada wrote:
But if you think it needs back-patch, please let me know, I can create it.
This would not be back-patched.
I see.
Thanks,
Tatsuro Yamada
Hi Robert,
On 2018/08/17 4:32, Robert Haas wrote:
On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada
wrote:
As you can see, queries with and without a semicolon are mixed, it is hard
to understand the end of each query. This is not beautiful and
user-friendly,
do not you think so?
I agree with
On Fri, Aug 17, 2018 at 12:19:42PM +0900, Tatsuro Yamada wrote:
> But if you think it needs back-patch, please let me know, I can create it.
This would not be back-patched.
--
Michael
signature.asc
Description: PGP signature
Hi Laurenz and Michael,
On 2018/08/16 20:57, Michael Paquier wrote:
On Thu, Aug 16, 2018 at 12:40:42PM +0200, Laurenz Albe wrote:
I don't think it is super important, but +1 for consistency.
Thanks! :)
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
I have
On Thu, 16 Aug 2018 19:37:42 -0400
Tom Lane wrote:
> Yugo Nagata writes:
> > I found that has_table_privilege returns an error when a table is specified
> > by schema-qualified name and the user doen't have privilege for its schema.
>
> > postgres=> select has_table_privilege('myschema.tbl','s
On 08/16/18 21:31, Bruce Momjian wrote:
> I understand you don't like that a search_path changed by a function is
> passed down to functions it calls, but what would you like the system to
> use as a search path for called functions? The search path of the
> session?
This is beginning to sound l
On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
> I agree on both points. Any objections if I apply what's proposed here
> on HEAD?
I have been looking at this patch. And while consistency is nice, I
think that if we are cleaning up this stuff we could do a bit more to
be more c
On Thu, Aug 16, 2018 at 09:36:29AM -0400, Dian Fay wrote:
> Fair enough! Here's a new version.
Thanks, pushed. Instead of putting the new sentence in the "Notes"
section, I have added it in the "Description" section, which is more
consistent with other commands, like DROP MATERIALIZED VIEW, etc.
On Thu, Aug 16, 2018 at 03:07:18PM -0400, Robert Haas wrote:
> We definitely don't want to use RangeVarGetRelidExtended more than
> necessary. It is important that we use that function only when
> necessary - that is, to look up names supplied by users - and it is
> also important that we look up
On Thu, Aug 16, 2018 at 03:46:06PM -0400, Robert Haas wrote:
> On Wed, Aug 15, 2018 at 3:17 PM, Bruce Momjian wrote:
> > On Wed, Aug 15, 2018 at 11:05:06AM -0400, Robert Haas wrote:
> >> On Tue, Aug 14, 2018 at 4:42 PM, Bruce Momjian wrote:
> >> > So you are saying PG functions should lock down t
On Thu, Aug 16, 2018 at 11:36 PM, Masayuki Takahashi
wrote:
> I am trying to change cstore_fdw to scan in parallel. FDW interface provide
> 'EstimateDSMForeignScan' for required shared memory size to scan in parallel.
>
> How to estimate the shared memory size required for parallel scan?
It's a s
Yugo Nagata writes:
> I found that has_table_privilege returns an error when a table is specified
> by schema-qualified name and the user doen't have privilege for its schema.
> postgres=> select has_table_privilege('myschema.tbl','select');
> ERROR: permission denied for schema myschema
> I
Hello,
Please find below a submission of a patch to the PostgreSQL documentation.
You can also find the patch in this git commit:
https://gitlab.com/paulrbr/postgresql/commit/024d3870450df6dcdc69bddbe2de46084b73e3a2.diff
commit 024d3870450df6dcdc69bddbe2de46084b73e3a2
Author: Paul B
On Thu, 16 Aug 2018 at 13:54, Shay Rojansky wrote:
> Peter,
>
> I think this is all coming from Microsoft. The JDBC driver API was
>> modeled after the ODBC API, and the ODBC specification also contains the
>> {call} escape. Microsoft SQL Server is also the only SQL implementation
>> to handle
On Fri, Aug 17, 2018 at 7:48 AM, Peter Geoghegan wrote:
> On Wed, Aug 15, 2018 at 11:22 PM, Thomas Munro
> wrote:
>> * groups and certain aggregates (MIN() and MAX() of suffix index
>> columns within each group)
>> * index scans where the scan key doesn't include the leading columns
>> (but you e
On 14/08/18 22:39, Tom Lane wrote:
> Peter Eisentraut writes:
>> What should we do with the use of the keyword PROCEDURE in the CREATE
>> OPERATOR and CREATE TRIGGER syntaxes?
>
> We're kinda stuck with that. We could add FUNCTION as a preferred
> synonym, perhaps, but I doubt that'd really be w
On Wed, Jul 18, 2018 at 05:18:18PM +0900, Michael Paquier wrote:
> On Mon, Jul 09, 2018 at 02:03:09PM +0900, Michael Paquier wrote:
>> I think that we really need to harden things, by making
>> ReadTwoPhaseFile() fail hard is it finds something unexpected, which is
>> in this case anything except t
Hi,
I found that has_table_privilege returns an error when a table is specified
by schema-qualified name and the user doen't have privilege for its schema.
postgres=> select has_table_privilege('myschema.tbl','select');
ERROR: permission denied for schema myschema
I think that this function s
> On Aug 16, 2018, at 1:05 AM, Jonathan S. Katz
> wrote:
>
>>
>> On Aug 15, 2018, at 9:15 PM, Michael Paquier wrote:
>>
>> On Wed, Aug 15, 2018 at 09:06:34PM -0400, Jonathan S. Katz wrote:
>>> I played around with this feature a bit and did see this was the case.
>>> Also while playing aroun
On August 16, 2018 8:28:45 PM GMT+02:00, Jesper Pedersen
wrote:
>One thing to consider is the pluggable storage patch, which is a lot
>more important than this patch. I don't want this patch to get in the
>way of that work, so it may have to wait a bit in order to see any new
>potential requ
On Thu, Aug 16, 2018 at 3:53 AM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> Hi, David!
>
> You can notice that:
>
> 1) We identified downside of changes in to_timestamp() function and
> documented them [1].
> 2) We found 4 more differences between between patches behavior and
> Oracl
On 08/16/2018 12:05 PM, Andres Freund wrote:
Hi,
On 2018-08-16 11:41:30 -0400, Tom Lane wrote:
Andres Freund writes:
But enabling C99 support triggered a somewhat weird failure on
protosciurus (also solaris, but gcc)
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=protosciurus&dt=2
On Thu, Aug 16, 2018 at 12:27 AM, Tom Lane wrote:
> Mark Dilger writes:
>> Go ahead and define some new lexical scope mechanism. I'm probably
>> going to move into the 21st century with you and use it. (I mostly
>> use "my", not "local", when I write perl code.) But let's treat that as
>> a ne
On Wed, Aug 15, 2018 at 11:22 PM, Thomas Munro
wrote:
> Yeah, there are a few tricks you can do with "index skip scans"
> (Oracle name, or as IBM calls them, "index jump scans"... I was
> slightly tempted to suggest we call ours "index hop scans"...).
Hopscotch scans?
> * groups and certain aggr
On Wed, Aug 15, 2018 at 3:17 PM, Bruce Momjian wrote:
> On Wed, Aug 15, 2018 at 11:05:06AM -0400, Robert Haas wrote:
>> On Tue, Aug 14, 2018 at 4:42 PM, Bruce Momjian wrote:
>> > So you are saying PG functions should lock down their search path at
>> > function definition time, and use that for a
On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada
wrote:
> As you can see, queries with and without a semicolon are mixed, it is hard
> to understand the end of each query. This is not beautiful and
> user-friendly,
> do not you think so?
I agree with you.
--
Robert Haas
EnterpriseDB: http://www.
On Tue, Aug 14, 2018 at 11:59 AM, Michael Paquier wrote:
> On HEAD, we check the ownership of the relation vacuumed or analyzed
> after taking a lock on it in respectively vacuum_rel() and
> analyze_rel(), where we already know the OID of the relation and there
> may be no RangeVar which we could
Greetings,
* Jesper Pedersen (jesper.peder...@redhat.com) wrote:
> On 08/16/2018 02:36 PM, Stephen Frost wrote:
> >Not sure where this came from, but I don't think it's particularly good
> >to be suggesting that one feature is more important than another or that
> >we need to have one wait for ano
On Tue, Aug 14, 2018 at 10:04 PM, 王翔宇 wrote:
> Yes, I had read this document, BUT it's call from PL/PGSQL. I want call it
> from c function.
You could look up the OID using e.g. LookupFuncWithArgs and then call
it using one of the OidFunctionCall macros, but it might be a bit
awkward. Perhaps it
On Thu, Aug 16, 2018 at 12:36 PM, Alvaro Herrera
wrote:
> I have to admit I have a hard time understanding this stuff. I don't
> know what a "scan/join target" is (or scan/join relation for that
> matter) ... and this "tlist relation" thing is an entirely new concept
> to me.
Well, I invented th
Hi Stephen,
On 08/16/2018 02:36 PM, Stephen Frost wrote:
Yeah, I'm hoping that a Committer can provide some feedback on the direction
that this patch needs to take.
Thomas is one these days. :)
I know :) However, there are some open questions from Thomas' original
submission that still ne
Greetings,
* Jesper Pedersen (jesper.peder...@redhat.com) wrote:
> On 08/16/2018 02:22 AM, Thomas Munro wrote:
> >The idea of starting with DISTINCT was just that it's
> >comparatively easy. We should certainly try to look ahead and bear
> >those features in mind when figuring out the interfaces
On Thu, Aug 16, 2018 at 4:57 PM Liudmila Mantrova
wrote:
> On 08/14/2018 06:38 PM, Alexander Korotkov wrote:
> > On Thu, Aug 2, 2018 at 9:06 PM Alexander Korotkov
> > wrote:
> > BTW, I've also revised documentation and regression tests. Patch is
> > attached.
> >
> Please consider some further
Hi Thomas,
On 08/16/2018 02:22 AM, Thomas Munro wrote:
The idea of starting with DISTINCT was just that it's
comparatively easy. We should certainly try to look ahead and bear
those features in mind when figuring out the interfaces though. Would
the indexam skip(scan, direction, prefix_size) o
Hi Bhushan,
On 08/16/2018 01:44 AM, Bhushan Uparkar wrote:
I was reviewing index-skip patch example and have a comment on it.
Thanks for your interest, and feedback on this patch !
Example query “select distinct b from t1” is equivalent to “select b from t1 group
by b”. When I tried the 2nd
On 08/09/2018 11:42 AM, Kyotaro HORIGUCHI wrote:
> At Wed, 8 Aug 2018 14:39:54 +0200, Tomas Vondra
> wrote in
> <6ecb4f61-1fb1-08a1-31d6-e58e9c352...@2ndquadrant.com>
>>
>>
>> On 08/03/2018 02:39 PM, Tomas Vondra wrote:
>>> On 08/03/2018 06:40 AM, Kyotaro HORIGUCHI wrote:
...
I'm
Peter,
I think this is all coming from Microsoft. The JDBC driver API was
> modeled after the ODBC API, and the ODBC specification also contains the
> {call} escape. Microsoft SQL Server is also the only SQL implementation
> to handle this stored function/procedure stuff totally differently: The
On Tue, Aug 14, 2018 at 11:18 AM, Robert Haas wrote:
> On Mon, Aug 13, 2018 at 10:52 AM, Jeremy Finzel wrote:
> > On Thu, Aug 9, 2018 at 4:34 PM, Jeremy Finzel wrote:
> >> I am using worker_spi as a model to run a SQL statement inside a
> >> background worker. From my browsing of the Postgres
Peter Eisentraut writes:
> The problem arises with the combination of CALL with output parameters
> and doing a COMMIT inside the procedure.
> When a CALL has output parameters, the portal uses the strategy
> PORTAL_UTIL_SELECT instead of PORTAL_MULTI_QUERY. Using
> PORTAL_UTIL_SELECT causes the
Hi,
On 2018-08-16 20:08:20 +0300, Vladimir Sitnikov wrote:
> Shay>On the other hand, releasing *without* this also has its consequence,
> namely setting in stone that the database-independent language API cannot
> be used for invoking the new stored procedures
> Shay>So I hope you at least conside
On 15-08-2018 11:50, Fabien COELHO wrote:
Hello Marina,
Hello!
v10-0004-Pgbench-errors-and-serialization-deadlock-retrie.patch
- the main patch for handling client errors and repetition of
transactions with serialization/deadlock failures (see the detailed
description in the file).
Patch
Alvaro Herrera writes:
> Hmm, this got me thinking whether the current resource owner setup for a
> procedure is appropriate. Maybe the problem is that resowners are still
> thought of in terms of transactions plus portals, so that if
> transactions are done then everything is over; maybe we need
Shay>On the other hand, releasing *without* this also has its consequence,
namely setting in stone that the database-independent language API cannot
be used for invoking the new stored procedures
Shay>So I hope you at least consider going through the thought process
about allowing this.
+1
I wond
Peter>I am familiar with the Java {call} escape. But I think it's pretty
Peter>useless. You're not going to get any compatibility with anything from
Peter>it, since every SQL implementation does something different with it
Would you please be more specific?
{ call ... } converts the SQL to the
On 16/08/2018 00:50, Shay Rojansky wrote:
> >> Also another request by Vladimir and myself to consider allowing
> >> functions to be invoked with CALL, in order to provide a single way to
> >> call both procedures and functions - this is important as language
> >> database APIs typi
On 2018-Aug-16, Peter Eisentraut wrote:
> There are, technically, three ways to fix this: silence the warning,
> unregister the snapshot explicitly, or don't register the snapshot to
> begin with.
>
> Silencing the warning, other than by just deleting it, might require
> passing in some more cont
On 2018-Jul-23, Jaime Casanova wrote:
> I was trying sqlsmith on REL_11_STABLE (commit
> 1b957e59b92dc44c14708762f882d7910463a9ac) with a database i have at
> hand, and got an assertion failure.
> It seems to happen during planning on prunning time but only when
> tables get bigger than certain s
On 2018-Aug-13, Robert Haas wrote:
> In my original design, apply_scanjoin_target_to_paths() -- or whatever
> I called it in the original patch versions -- built an entirely new
> RelOptInfo, so that we ended up with one RelOptInfo representing the
> unvarnished result of scan/join planning, and a
Hi,
On 2018-08-16 11:41:30 -0400, Tom Lane wrote:
> Andres Freund writes:
> > But enabling C99 support triggered a somewhat weird failure on
> > protosciurus (also solaris, but gcc)
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=protosciurus&dt=2018-08-16%2013%3A37%3A46
>
> > It det
On 2018-Aug-11, David Rowley wrote:
> On 11 August 2018 at 14:09, David Rowley wrote:
> > So my best idea on a
> > fix is simply to remove the code that raises the error.
>
> Here's a patch to do that. I've also included a further simplified
> test to ensure this case performs run-time pruning c
Andres Freund writes:
> But enabling C99 support triggered a somewhat weird failure on
> protosciurus (also solaris, but gcc)
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=protosciurus&dt=2018-08-16%2013%3A37%3A46
> It detects C99 support successfully via -std=gnu99 but then fails
> s
On 14/08/2018 15:35, Peter Eisentraut wrote:
> The commit that started this is
>
> commit 59a85323d9d5927a852939fa93f09d142c72c91a
> Author: Peter Eisentraut
> Date: Mon Jul 9 13:58:08 2018
>
> Add UtilityReturnsTuples() support for CALL
>
> This ensures that prepared statements for C
On Thu, Aug 16, 2018 at 12:47 AM, Tom Lane wrote:
> Thomas Munro writes:
>> That makes it sound like a mere optimisation, but since commit
>> 8e18d04d4da user-created objects are not allowed to have OIDs below
>> that threshold. So I propose the attached tweak.
>
> +1
Looks good to me, too.
--
Hi,
On 2018-08-16 17:28:06 +0200, Fabien COELHO wrote:
> > The new status of this patch is: Ready for Committer
>
> Ok, thanks. Let's see what committers think about it.
>
> Andres, are you still interested in overflow detection and handling?
Yes. I'll try to look at it at some point not too f
Hello Ibrar,
The new status of this patch is: Ready for Committer
Ok, thanks. Let's see what committers think about it.
Andres, are you still interested in overflow detection and handling?
--
Fabien.
On 08/11/2018 04:18 PM, Tomas Vondra wrote:
> On 08/11/2018 04:15 PM, Tom Lane wrote:
>> Tomas Vondra writes:
> On 08/09/2018 07:47 PM, Alvaro Herrera wrote:
>> Actually, it seems to me that ApplyLogicalMappingFile is just leaking
>> the file descriptor for no good reason.
>>
>>> I thi
> On Aug 15, 2018, at 9:27 PM, Tom Lane wrote:
>
> Mark Dilger writes:
>> Go ahead and define some new lexical scope mechanism. I'm probably
>> going to move into the 21st century with you and use it. (I mostly
>> use "my", not "local", when I write perl code.) But let's treat that as
>> a
> "Andres" == Andres Freund writes:
Andres> I think you'd have to instead spill the query results into a
Andres> tuplestore (like we do for FOR HOLD queries at end of xact),
Andres> and then do the computations based on that.
The approach I've suggested to some people who wanted to look i
Hi,
On 2018-08-16 17:27:45 +0300, Surafel Temesgen wrote:
> FETCH FIRST with PERCENT option is SQL standard that state limit count to
> be specified in a percentage in addition to specify it in exact count and
> listed as one of Major features simply not implemented yet in recent wiki
> page [1].
FETCH FIRST with PERCENT option is SQL standard that state limit count to
be specified in a percentage in addition to specify it in exact count and
listed as one of Major features simply not implemented yet in recent wiki
page [1].
I implemented it by executing the query plan twice. One without li
Hi,
On 2018-08-16 04:18:59 -0700, Andres Freund wrote:
> Besides gaur, I'm also awaiting casteroides' results. The latter
> definitely does support C99, but I'm not sure autconf pushes hard
> enough. I think every other relevant animal has reported back.
Casteroides wasn't a problem, -D_STDC_C99
On 2018-08-16 10:07:04 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2018-08-16 09:22:14 -0400, Tom Lane wrote:
> >> The lazy man's way to get rid of it would be to put something like
> >> "int bogus = 0;" in the empty dynloader.c files. Better would be
> >> to not have the empty .c files
Andres Freund writes:
> On 2018-08-16 09:22:14 -0400, Tom Lane wrote:
>> The lazy man's way to get rid of it would be to put something like
>> "int bogus = 0;" in the empty dynloader.c files. Better would be
>> to not have the empty .c files at all, but I'm not sure how much
>> we'd have to conto
On 2018-08-16 09:22:14 -0400, Tom Lane wrote:
> Andres Freund writes:
> > This now generates a super nitpicky warning on at at least some linux +
> > clang configurations. I use -Weverything plus a lot of -Wno-*, and this
> > change added:
> > dynloader.c:7:4: warning: ISO C requires a translation
On 08/14/2018 06:38 PM, Alexander Korotkov wrote:
On Thu, Aug 2, 2018 at 9:06 PM Alexander Korotkov
wrote:
On Thu, Aug 2, 2018 at 6:17 PM Alexander Korotkov
wrote:
After some experiments I found that when you mix spaces and separators
between two fields, then Oracle takes into account only l
Fair enough! Here's a new version.
On 8/16/18 12:07 AM, Tom Lane wrote:
Dian Fay writes:
I feel resorting to the infinitive asks more involvement of the reader,
while leading with the responsible role(s) helps shortcut the process of
determining whether what follows is relevant. Efficiency is
Andres Freund writes:
> This now generates a super nitpicky warning on at at least some linux +
> clang configurations. I use -Weverything plus a lot of -Wno-*, and this
> change added:
> dynloader.c:7:4: warning: ISO C requires a translation unit to contain at
> least one declaration [-Wempty-tr
Hi,
On 2018-08-16 14:28:25 +0200, Peter Eisentraut wrote:
> On 16/08/2018 01:06, Andres Freund wrote:
> > So it looks like msvc 2013 might be the relevant requirement.
>
> According to my research (completely untested in practice), you need
> 2010 for mixed code and declarations and 2013 for name
On 16/08/2018 14:30, Andres Freund wrote:
> Hi,
>
> On 2018-08-16 14:26:07 +0200, Peter Eisentraut wrote:
>> On 16/08/2018 13:18, Andres Freund wrote:
>>> checking for ccache gcc option to accept ISO C99... unsupported
>>>
>>> I suspect that's because of the '-ansi' flag in CFLAGS, not because
Hi,
On 2018-08-16 14:26:07 +0200, Peter Eisentraut wrote:
> On 16/08/2018 13:18, Andres Freund wrote:
> > checking for ccache gcc option to accept ISO C99... unsupported
> >
> > I suspect that's because of the '-ansi' flag in CFLAGS, not because
> > the compiler is incapable of actually sup
On 16/08/2018 01:06, Andres Freund wrote:
> So it looks like msvc 2013 might be the relevant requirement.
According to my research (completely untested in practice), you need
2010 for mixed code and declarations and 2013 for named initialization
of structs.
I wonder what raising the msvc requirem
On 16/08/2018 13:18, Andres Freund wrote:
> checking for ccache gcc option to accept ISO C99... unsupported
>
> I suspect that's because of the '-ansi' flag in CFLAGS, not because
> the compiler is incapable of actually supporting C99.
-ansi is equivalent to -std=c90. If we make the switch
On 08/08/2018 09:47 PM, Tomas Vondra wrote:
>
> IMHO the cleanest way is to add a method like
> ReorderBufferGetChange, which does the allocation internally. That
> way the memory context choice is up to reorderbuffer, not decode.c.
> That's at least consistent with what the rest of decode.c does.
On Thu, Aug 16, 2018 at 12:40:42PM +0200, Laurenz Albe wrote:
> I don't think it is super important, but +1 for consistency.
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
--
Michael
signature.asc
Description: PGP signature
Patch is good to go from my side.
The new status of this patch is: Ready for Committer
På torsdag 16. august 2018 kl. 13:38:54, skrev Andres Freund mailto:and...@anarazel.de>>:
Hi,
On 2018-08-16 13:31:14 +0200, Andreas Joseph Krogh wrote:
> The lack of LargeObject-support makes it unusable for installations using
it.
>
> Any plans to support LOs in logical decoding so we can
Hi,
On 2018-08-16 13:31:14 +0200, Andreas Joseph Krogh wrote:
> The lack of LargeObject-support makes it unusable for installations using it.
>
> Any plans to support LOs in logical decoding so we can replicate databases
> using them?
I personally am not planning to work on it, but would proba
Hi,
I am trying to change cstore_fdw to scan in parallel. FDW interface provide
'EstimateDSMForeignScan' for required shared memory size to scan in parallel.
How to estimate the shared memory size required for parallel scan?
thanks.
--
Masayuki Takahashi
The lack of LargeObject-support makes it unusable for installations using it.
Any plans to support LOs in logical decoding so we can replicate databases
using them?
--
Andreas Joseph Krogh
On 2018-08-16 01:41:34 -0700, Andres Freund wrote:
> I've pushed a minimal version adding the C99 test.
So, we get:
* lotsa animals, unsurprisingly, showing C99 work without any flags.
checking for ccache gcc option to accept ISO C99... none needed
* rhinoceros, nudibranch, grouse, ...:
Hi!
On Tue, Aug 14, 2018 at 12:05 PM Masahiko Sawada wrote:
>
> On Wed, Feb 28, 2018 at 11:24 PM, Ivan Kartyshov
> wrote:
> > The main goal of my changes is to let long read-only transactions run on
> > replica if hot_standby_feedback is turned on.
>
> FWIW the idea proposed on the thread[1], wh
Hi, David!
You can notice that:
1) We identified downside of changes in to_timestamp() function and
documented them [1].
2) We found 4 more differences between between patches behavior and
Oracle behavior [2][3]. One of them was assumed to be ridiculous and
wasn't implemented. So, I think this
Tatsuro Yamada wrote:
> Almost all client applications and extensions will show "Options" and
> "Connection options" sections when running with help option (--help).
> However, "oid2name" was different, there is only the Options section.
>
> For consistency, attached patch divides the Options sect
Hi,
Almost all client applications and extensions will show "Options" and
"Connection options" sections when running with help option (--help).
However, "oid2name" was different, there is only the Options section.
For example,
$ vacuumlo --help
vacuumlo removes unreferenced large objects fro
Hi,
On 2018-08-15 18:31:10 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I think we could get a start by adding that test to configure, without
> > relying on it for now (i.e. keeping mylodon with -Wc99-extensions
> > -Werror=c99-extensions alive). That'd tell us about which machines,
> > be
On 2018-08-09 10:03:43 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2018-08-09 14:29:08 +0200, Peter Eisentraut wrote:
> >> The non-dlopen dynloader code for several operating systems is in some
> >> cases decades obsolete, and I have had some doubts that it would even
> >> compile anymor
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, passed
Hi,
I'm with Melanie Plageman running the SVPUG Patch Review Mee
This is the continuation of the discussion at:
https://www.postgresql.org/message-id/7500.1531920772%40sss.pgh.pa.us
Actually, for more background on what I've written below, reading this
email in the same discussion would help:
https://www.postgresql.org/message-id/4114.1531674...@sss.pgh.pa.us
On Thu, Aug 16, 2018 at 04:36:11AM +, Shinoda, Noriyoshi (PN Japan GCS
Delivery) wrote:
> I attached a modified version.
Thanks, Shinoda-san. Pushed.
--
Michael
signature.asc
Description: PGP signature
Hi
čt 16. 8. 2018 v 5:52 odesílatel Mathias Brossard
napsal:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, failed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation:tested,
100 matches
Mail list logo
