Re: Postgres, fsync, and OSs (specifically linux)

2018-07-28 Thread Thomas Munro
On Thu, Jun 14, 2018 at 5:30 PM, Thomas Munro wrote: > On Wed, May 23, 2018 at 8:02 AM, Andres Freund wrote: >> [patches] > > A more interesting question is: how will you cap the number file > handles you send through that pipe? On that OS you call > DuplicateHandle() to fling handles into anoth

Re: Usability fail with psql's \dp command

2018-07-28 Thread Tom Lane
Fabien COELHO writes: > My 0.02¤: this creates an exception for anyone trying to parse the output. > I would have preferred empty logically meaning no rights, and the default > being spelled out explicitely. Uh, who'd be trying to parse the output of \dp? The reason we provide psql's -E option

Re: [PATCH] Improve geometric types

2018-07-28 Thread Tomas Vondra
On 07/27/2018 10:20 AM, Kyotaro HORIGUCHI wrote: > Thank you for taking this. > > At Thu, 26 Jul 2018 17:12:50 +0200, Tomas Vondra > wrote in > <672f4c42-6742-c1ec-e9a4-1994b815a...@2ndquadrant.com> >> On 07/11/2018 07:13 PM, Emre Hasegeli wrote: >>> New versions are attached after the patc

Re: Usability fail with psql's \dp command

2018-07-28 Thread David Fetter
On Sat, Jul 28, 2018 at 08:11:17PM -0400, Fabien COELHO wrote: > > >>So those are definitely different privilege states, but they look > >>the same. > > > >Please find attached a patch to fix this. Would this be a > >back-patchable bug? > > My 0.02€: this creates an exception for anyone trying t

Re: Making "COPY partitioned_table FROM" faster

2018-07-28 Thread David Rowley
On 29 July 2018 at 05:24, Melanie Plageman wrote: > On Thu, Jul 26, 2018 at 7:26 PM, David Rowley > wrote: >> >> Fixed in the attached v4. That's the only change. > > > I don't see an attachment. Oops. Must've fallen off in transit :) Hopefully, it's more firmly attached this time. > We are pr

Re: Usability fail with psql's \dp command

2018-07-28 Thread Fabien COELHO
So those are definitely different privilege states, but they look the same. Please find attached a patch to fix this. Would this be a back-patchable bug? My 0.02€: this creates an exception for anyone trying to parse the output. I would have preferred empty logically meaning no rights, and

Re: Removing useless \. at the end of copy in pgbench

2018-07-28 Thread Fabien COELHO
Hello Tom, I agree that compatibility with protocol v2 (pg 7.4) is not an issue. As Tom, I would not have bothered, though, however once it is there why not? As far as the patch goes --- I think that someday in the not too distant feature we ought to rip out libpq's support for v2 protocol, w

Re: Problem while setting the fpw with SIGHUP

2018-07-28 Thread Michael Paquier
On Sat, Jul 28, 2018 at 07:10:24PM +0530, Amit Kapila wrote: > I have just responded to your first patch (0001). Can you once again > summarize what the 0002 exactly accomplishes? I think one of the > goals is to fix the original problem reported in this thread and other > is you have found the c

Re: add verbosity to pg_basebackup for sync

2018-07-28 Thread Michael Paquier
On Sat, Jul 28, 2018 at 08:10:10AM +0900, Michael Paquier wrote: > This is a good idea. Would we want that back-patched? I am sure that > nobody is going to complain for an extra informational log. And pushed to HEAD. -- Michael signature.asc Description: PGP signature

Re: Usability fail with psql's \dp command

2018-07-28 Thread David Fetter
On Sat, Jul 28, 2018 at 02:41:24PM -0400, Tom Lane wrote: > I noticed today that \dp does not distinguish empty acl fields > (meaning nobody has any privileges) from null acl fields > (which mean default privileges, typically not empty). > For instance > > regression=# \c joe joe > You are now con

Re: Usability fail with psql's \dp command

2018-07-28 Thread Dmitry Igrishin
> > > What do people think of printing "Default" if the ACL is null? > > Alternatively, since the state with an empty ACL is certainly > the unusual case, maybe we should mark that specially, perhaps > by printing "None" or "No privileges". Old problem. +1.

Re: pg_upgrade from 9.4 to 10.4

2018-07-28 Thread Bruce Momjian
On Sat, Jun 23, 2018 at 10:29:49PM -0400, Bruce Momjian wrote: > On Fri, Jun 15, 2018 at 03:01:37PM -0700, Vimalraj A wrote: > > I would like to understand why it happens so.  > > 1. What transient state corrupts the db? > > 2. Is it a known issue with pg_upgrade?  > > 3. Is there a way to get the

Re: Usability fail with psql's \dp command

2018-07-28 Thread Christophe Pettus
> On Jul 28, 2018, at 11:41, Tom Lane wrote: > > Alternatively, since the state with an empty ACL is certainly > the unusual case, maybe we should mark that specially, perhaps > by printing "None" or "No privileges". +1 for "No privileges". I was just bitted by that this week. -- -- Christo

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

2018-07-28 Thread David Fetter
On Fri, Jul 13, 2018 at 01:52:00PM +0100, Oliver Ford wrote: > Adds the options RESPECT/IGNORE NULLS (null treatment clause) and FROM > FIRST/LAST to the non-aggregate window functions. Please find attached an updated version for OID drift. Best, David. -- David Fetter http://fetter.org/ Phone:

Usability fail with psql's \dp command

2018-07-28 Thread Tom Lane
I noticed today that \dp does not distinguish empty acl fields (meaning nobody has any privileges) from null acl fields (which mean default privileges, typically not empty). For instance regression=# \c joe joe You are now connected to database "joe" as user "joe". joe=> create table jt (f1 int);

Re: Segfault logical replication PG 10.4

2018-07-28 Thread Alvaro Herrera
Aha, I see, thanks. Here's a complete fix with included testcase. In an unpatched assert-enabled build, this crashes this TRAP: FailedAssertion("!(ActiveSnapshotSet())", File: "/pgsql/source/REL_10_STABLE/src/backend/tcop/postgres.c", Line: 788) Will push on Monday. -- Álvaro Herrera

Re: Making "COPY partitioned_table FROM" faster

2018-07-28 Thread Melanie Plageman
On Thu, Jul 26, 2018 at 7:26 PM, David Rowley wrote: > Fixed in the attached v4. That's the only change. > I don't see an attachment. > So, I thinking I'm missing something. Which of the changes would cause the > > performance improvement from patch v2 to v3? My understanding is: > > You could

RE: [Proposal] Add accumulated statistics for wait event

2018-07-28 Thread Phil Florent
Hi, I agree with that. PostgreSQL 10 is really great, tuning tools based on sampling of pg_stat_activity became accurate without any modification. Best regards Phil De : Michael Paquier Envoyé : jeudi 26 juillet 2018 03:24 À : Phil Florent Cc : Tomas Vondra;

Re: Finding database for pg_upgrade missing library

2018-07-28 Thread Bruce Momjian
On Tue, Jul 24, 2018 at 10:33:48AM +0200, Daniel Gustafsson wrote: > > Looking at the code, we do a qsort(), then detect (since they are all > > now adjacent) and remove the duplicate references to the library. What > > I think should be done is to move the duplicate detection down to the > > plac

Re: [HACKERS] pg_upgrade and missing loadable libraries

2018-07-28 Thread Bruce Momjian
On Sun, Jun 4, 2017 at 01:06:25PM -0400, Bruce Momjian wrote: > I have seen a few reports where people are getting this pg_upgrade > error: > > Your installation references loadable libraries that are missing > from the new installation. You can add these libraries to the > new

Re: Removing useless \. at the end of copy in pgbench

2018-07-28 Thread Tom Lane
Fabien COELHO writes: > I agree that compatibility with protocol v2 (pg 7.4) is not an issue. > As Tom, I would not have bothered, though, however once it is there why > not? As far as the patch goes --- I think that someday in the not too distant feature we ought to rip out libpq's support for

modify: request for new parameter for disable promote (slave only mode)

2018-07-28 Thread Ioseph Kim
Sorry, I was misstyped. non shared -> shared On Sat, Jul 28, 2018 at 01:05:40AM +0900, Ioseph Kim wrote: > Hi. > > I want to build one master & multi slave environments to use physical > replication. > Slave nodes have low hardware spec, so I changed max_connection server > parameters, and tr

pgbench - add pseudo-random permutation function

2018-07-28 Thread Fabien COELHO
Hello, This patch adds a pseudo-random permutation function to pgbench. It allows to mix non uniform random keys to avoid trivial correlations between neighboring values, hence between pages. The function is a simplistic form of encryption adapted to any size, using a few iterations of scra

Re: Removing useless \. at the end of copy in pgbench

2018-07-28 Thread Fabien COELHO
Hello Tatsuo-san, If we want to support pre 7.4 backend (which only supports the version 2 protocol), we could test the current protocol version and decide whether we should send out "\." or not, but I doubt it's necessary. Comments? Code tested, ok. I agree that compatibility with protoco

Re: Problem while setting the fpw with SIGHUP

2018-07-28 Thread Amit Kapila
On Tue, Apr 24, 2018 at 7:10 AM, Kyotaro HORIGUCHI wrote: > At Tue, 24 Apr 2018 08:52:17 +0900, Michael Paquier > wrote in <20180423235217.gb1...@paquier.xyz> >> On Mon, Apr 23, 2018 at 12:21:04PM -0400, Robert Haas wrote: >> > Fine, but that doesn't answer the question of whether we actually ne

Re: Problem while setting the fpw with SIGHUP

2018-07-28 Thread Amit Kapila
On Fri, Apr 20, 2018 at 6:06 PM, Amit Kapila wrote: > On Fri, Apr 20, 2018 at 11:40 AM, Kyotaro HORIGUCHI > wrote: >> By the way, I think I found a bug of FPW. >> >> The following steps yields INSERT record that doesn't have a FPI >> after a checkpoint. >> >> (Start server with full_page_writes =

Re: Segfault logical replication PG 10.4

2018-07-28 Thread Quan Tran
Sorry, there is an error in the previous message: insert into itscaro.test values (2, '{{test1.test2.test3}'); should be corrected with: insert into itscaro.test values (2, '{test1.test2.test3}'); >

Re: Segfault logical replication PG 10.4

2018-07-28 Thread Minh-Quan Tran
Hello, Here is the steps to reproduce this problem. Thank you. Pastebin : https://pastebin.com/Wc80YegY -- CREATE EXTENSION IF NOT EXISTS postgis; CREATE EXTENSION IF NOT EXISTS ltree; CREATE EXTENSION IF NOT EXISTS intarray; CREATE EXTENSION IF NOT EXISTS hstore; CREATE EXTENSION IF NOT EXIST