Re: Possible bug in logical replication.

2018-05-22 Thread Masahiko Sawada
On Fri, May 18, 2018 at 2:37 PM, Kyotaro HORIGUCHI wrote: > At Thu, 17 May 2018 13:54:07 +0300, Arseny Sher wrote > in <87in7md034.fsf@ars-thinkpad> >> >> Konstantin Knizhnik writes: >> >> > I think that using restart_lsn instead of confirmed_flush is not right >> > approach. >> > If restart_l

Re: [PATCH] Clear up perlcritic 'missing return' warning

2018-05-22 Thread Mike Blackwell
On Tue, May 22, 2018 at 3:32 AM, Michael Paquier wrote: > > And this > maps with any C code. > The important differences here are: *) Declaring a C function as void prevents returning a value. The intent not to return a value is clear to any caller and is enforced by the compiler. There is

Re: SCRAM with channel binding downgrade attack

2018-05-22 Thread Heikki Linnakangas
On 22/05/18 11:22, Michael Paquier wrote: On Sat, May 19, 2018 at 09:35:57PM +0900, Michael Paquier wrote: The previous patch has actually problems with servers using "trust", "password" and any protocol which can send directly AUTH_REQ_OK as those could still enforce a downgrade to not use chan

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-22 Thread Carter Thaxton
Ah yes, thanks. I did in fact have colors enabled. I've attached a new patch generated by `git format-patch`. Hopefully that's correct. On Mon, May 21, 2018 at 4:00 PM, Thomas Munro wrote: > On Tue, May 22, 2018 at 4:05 AM, Stephen Frost wrote: > > * Carter Thaxton (carter.thax...@gmail.com)

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-22 Thread Carter Thaxton
> How would you handle foreign keys? It seems easier to produce a dump > that won't restore. > This proposal will not attempt to be smart about foreign keys or anything like that. I don't believe that would even be expected. > We have the existing options: > > --include-table=table(and its

-D option of pg_resetwal is only works with absolute path

2018-05-22 Thread tushar
Hi, In the  latest PG v11,  found that  -D option of pg_resetwal is only works with absolute path .. not with relative path e.g Not Working - [centos@localhost bin]$ ./pg_resetwal -D data pg_resetwal: could not read permissions of directory "data": No such file or directory Working - [ce

Re: SCRAM with channel binding downgrade attack

2018-05-22 Thread Michael Paquier
On Tue, May 22, 2018 at 08:19:34PM -0400, Bruce Momjian wrote: > Since tls-unique and tls-server-end-point provide the same level of > security, I don't see any value in allowing prefer-tls-server-end-point, > as you stated above. Thanks. We are on the same line for this portion then. -- Michael

Re: [sqlsmith] Unpinning error in parallel worker

2018-05-22 Thread Thomas Munro
On Wed, Apr 25, 2018 at 8:15 AM, Jonathan Rudenberg wrote: > On Tue, Apr 24, 2018, at 16:06, Thomas Munro wrote: >> I'll write a patch to fix that unpleasant symptom. While holding >> DynamicSharedMemoryControlLock we shouldn't raise any errors without >> releasing it first, because the error han

Re: perl checking

2018-05-22 Thread Kyotaro HORIGUCHI
At Tue, 22 May 2018 15:02:46 -0400, Andrew Dunstan wrote in > > - elsif ($in < 0x1) > > + elsif ($in <= 0x) This is one of my thougts and the reason for regarding it sour is the following. > > For consistency, the other arms of the "if" should be adjusted > > similarly. >

Re: Postgres 11 release notes

2018-05-22 Thread Tom Lane
Bruce Momjian writes: > On Fri, May 18, 2018 at 10:28:12AM -0400, Tom Lane wrote: >> While we're all griping about omissions from the release notes ... >> I think you should have documented that we fixed plpgsql to cope >> (or cope better, at least) with intrasession changes in the rowtypes >> of

Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Wed, May 23, 2018 at 02:06:15PM +1200, David Rowley wrote: > On 23 May 2018 at 13:18, Bruce Momjian wrote: > > On Mon, May 21, 2018 at 07:34:18PM +1200, David Rowley wrote: > >> I've been working a bit in this area over the past few weeks and with > >> PG11 I measured a single INSERT into a 10k

Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Wed, May 23, 2018 at 11:55:29AM +1000, Haribabu Kommi wrote: > Yes, security labels also gets dumped only with --create option. OK. > Can you update the author name as (Haribabu Kommi) to make it consistent > with other entries. Done. Applied patch attached. -- Bruce Momjian htt

Re: Postgres 11 release notes

2018-05-22 Thread David Rowley
On 23 May 2018 at 13:18, Bruce Momjian wrote: > On Mon, May 21, 2018 at 07:34:18PM +1200, David Rowley wrote: >> I've been working a bit in this area over the past few weeks and with >> PG11 I measured a single INSERT into a 10k RANGE partitioned table at >> just 84 tps (!), while inserting the sa

Re: Postgres 11 release notes

2018-05-22 Thread Haribabu Kommi
On Wed, May 23, 2018 at 11:34 AM, Bruce Momjian wrote: > On Mon, May 21, 2018 at 06:28:36PM +1000, Haribabu Kommi wrote: > > On Sat, May 12, 2018 at 1:08 AM, Bruce Momjian wrote: > > > > I have committed the first draft of the Postgres 11 release notes. I > > will add more markup soon.

Re: Postgres 11 release notes

2018-05-22 Thread Amit Langote
On 2018/05/23 10:36, Bruce Momjian wrote: > On Wed, May 23, 2018 at 10:28:41AM +0900, Amit Langote wrote: >>> Uh, we already have this in the release notes: >>> >>> Allow faster partition elimination during query processing (Amit >>> Langote, David Rowley, Dilip Kumar) >>> >>>

Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Wed, May 23, 2018 at 01:37:22PM +1200, Thomas Munro wrote: > On Sat, May 19, 2018 at 2:28 AM, Tom Lane wrote: > > While we're all griping about omissions from the release notes ... > > Hi Bruce, > > > Add support for ARMv8 hardware > CRC calculations (Yuqi Gu, Heikki L

Re: Postgres 11 release notes

2018-05-22 Thread Thomas Munro
On Sat, May 19, 2018 at 2:28 AM, Tom Lane wrote: > While we're all griping about omissions from the release notes ... Hi Bruce, Add support for ARMv8 hardware CRC calculations (Yuqi Gu, Heikki Linnakangas) Could I please ask for a third author credit for this one

Re: [Sender Address Forgery]Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Wed, May 23, 2018 at 10:28:41AM +0900, Amit Langote wrote: > > Uh, we already have this in the release notes: > > > > Allow faster partition elimination during query processing (Amit > > Langote, David Rowley, Dilip Kumar) > > > > This speeds access to partitioned table

Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Mon, May 21, 2018 at 06:28:36PM +1000, Haribabu Kommi wrote: > On Sat, May 12, 2018 at 1:08 AM, Bruce Momjian wrote: > > I have committed the first draft of the Postgres 11 release notes.  I > will add more markup soon.  You can view the most current version here: > >         http

Re: [Sender Address Forgery]Re: Postgres 11 release notes

2018-05-22 Thread Amit Langote
On 2018/05/23 10:16, Bruce Momjian wrote: > On Sat, May 19, 2018 at 12:58:04AM +0900, Amit Langote wrote: >> Hi Bruce. >> >> On Tue, May 15, 2018 at 12:46 PM, Amit Langote >> wrote: >>> On 2018/05/15 5:30, Bruce Momjian wrote: I like it, done. >>> >>> Thank you. >> >> I wonder what you think

Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Mon, May 21, 2018 at 07:34:18PM +1200, David Rowley wrote: > On 19 May 2018 at 03:58, Amit Langote wrote: > > I wonder what you think about including this little performance item: > > > > https://www.postgresql.org/message-id/e1eotsq-0005v0...@gemulon.postgresql.org > > > > especially consideri

Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Sat, May 19, 2018 at 12:58:04AM +0900, Amit Langote wrote: > Hi Bruce. > > On Tue, May 15, 2018 at 12:46 PM, Amit Langote > wrote: > > On 2018/05/15 5:30, Bruce Momjian wrote: > >> I like it, done. > > > > Thank you. > > I wonder what you think about including this little performance item: >

Re: PostgreSQL and Homomorphic Encryption

2018-05-22 Thread Craig Ringer
On 23 May 2018 at 07:52, David Fetter wrote: > On Tue, May 22, 2018 at 08:34:18AM +0200, Tal Glozman wrote: > > Hello PostgreSQL Team, > > > > I'm doing a project at my university (HU Berlin) involving > > homomorphic encrypted searches on data bases. Does PostgreSQL > > support homomorphic encry

Re: Postgres 11 release notes

2018-05-22 Thread Bruce Momjian
On Fri, May 18, 2018 at 10:28:12AM -0400, Tom Lane wrote: > While we're all griping about omissions from the release notes ... > I think you should have documented that we fixed plpgsql to cope > (or cope better, at least) with intrasession changes in the rowtypes > of composite-type variables. Se

Re: SCRAM with channel binding downgrade attack

2018-05-22 Thread Bruce Momjian
On Tue, May 22, 2018 at 05:22:19PM +0900, Michael Paquier wrote: > On Sat, May 19, 2018 at 09:35:57PM +0900, Michael Paquier wrote: > > The previous patch has actually problems with servers using "trust", > > "password" and any protocol which can send directly AUTH_REQ_OK as those > > could still e

Re: SCRAM with channel binding downgrade attack

2018-05-22 Thread Bruce Momjian
On Sat, May 19, 2018 at 09:35:57PM +0900, Michael Paquier wrote: > On Fri, May 18, 2018 at 09:30:22AM -0400, Bruce Momjian wrote: > > Good work, but I think the existance of both scram_channel_binding and > > channel_binding_mode in libpq is confusing. I am thinking we should > > have one channel

Re: Time to put context diffs in the grave

2018-05-22 Thread Michael Paquier
On Tue, May 22, 2018 at 06:59:56PM +0900, Kyotaro HORIGUCHI wrote: > filterdiff has a bug that we can lose a part of hunks with it, > and I actually have stepped on it. I saw Álvaro made a complaint > about the bug but it doesn't seem to have been fixed. It is the > most major reason I'm posting pa

Re: PostgreSQL “tuple already updated by self”

2018-05-22 Thread Michael Paquier
On Tue, May 22, 2018 at 09:17:15AM -0400, Robert Haas wrote: > Another interesting question is how the system got into this state in > the first place, of course. Was it a bug, or did you do something > that corrupted the database? Perhaps a side effect which has been fixed in d2599ecf for 9.6.9?

Re: Fix some error handling for read() and errno

2018-05-22 Thread Michael Paquier
On Tue, May 22, 2018 at 04:51:00PM +0900, Kyotaro HORIGUCHI wrote: > I see the same issue in snapbuild.c(4 places). > > | readBytes = read(fd, &ondisk, SnapBuildOnDiskConstantSize); > | pgstat_report_wait_end(); > | if (readBytes != SnapBuildOnDiskConstantSize) > | { > | CloseTransientFile(fd);

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Matthew Stickney
On Tue, May 22, 2018 at 6:14 PM, Tom Lane wrote: > Well, the question that ought to be answered first is whether to do > anything at all, beyond not-crashing. It doesn't seem to me that > refusing to accept a password if we can't disable echo is a net win, > so I'm inclined to think it's okay to

Re: PostgreSQL and Homomorphic Encryption

2018-05-22 Thread David Fetter
On Tue, May 22, 2018 at 08:34:18AM +0200, Tal Glozman wrote: > Hello PostgreSQL Team, > > I'm doing a project at my university (HU Berlin) involving > homomorphic encrypted searches on data bases. Does PostgreSQL > support homomorphic encryption-based searches? Yes, in the sense that PostgreSQL h

Re: Allowing printf("%m") only where it actually works

2018-05-22 Thread Thomas Munro
On Mon, May 21, 2018 at 2:41 PM, Thomas Munro wrote: > I've raised this on the freebsd-hackers > list, let's see... I bet there's other software out there that just > prints out "m" when things go wrong. It's arguably something that > you'd want the complier to understand as a C dialect thing. R

Re: Error on vacuum: xmin before relfrozenxid

2018-05-22 Thread Andres Freund
Hi, On 2018-05-23 00:04:26 +0200, Paolo Crosato wrote: > I managed to recover the log of the first time we run into the issue, the > error was the same but on template1: > > May 8 11:26:46 xxx postgres[32543]: [1154-1] user=,db=,client= ERROR: > found xmin 2600758304 from before relfrozenxid 400

Re: plperl fails with perl 5.28

2018-05-22 Thread Tom Lane
Andrew Dunstan writes: > Well diagnosed. Maybe it's worth pointing out that almost all the > examples of perl_run() in the perlembed manual simply ignore the > returned value. OTOH, if that's what we're supposed to do why isn't the > function declared that way? Yeah, it seems that mainly what

Re: plperl fails with perl 5.28

2018-05-22 Thread Andrew Dunstan
On 05/22/2018 06:02 PM, Tom Lane wrote: Andrew Dunstan writes: On 05/22/2018 07:18 AM, Christoph Berg wrote: plperl fails to install with perl 5.27.11, which is to be released as 5.28.0: I have a tiny bit more info: andrew=# load 'plperl.so'; ERROR: CONTEXT: while running Pe

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Tom Lane
Matthew Stickney writes: > On Tue, May 22, 2018 at 4:09 PM, Tom Lane wrote: >> But perhaps it's worth adding logic to deal with failure of the call? > I think it would be sufficient to check whether the SetConsoleMode > call fails, because that can fail even on a valid handle (e.g. if you > don'

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread Tom Lane
Andres Freund writes: > On 2018-05-23 09:04:35 +1200, David Rowley wrote: >> I thought the output I pasted was clearly showing it not to be the >> same. 42 vs 43. > Well, the row-returned counter is obviously wide enough, otherwise > 42 couldn't be returned. Tom's point, a

Re: Error on vacuum: xmin before relfrozenxid

2018-05-22 Thread Paolo Crosato
Good evening, 2018-05-22 23:19 GMT+02:00 Andres Freund : > Hi, > > On 2018-05-22 21:43:01 +0200, Paolo Crosato wrote: > > > Could you report the result of > > > select ctid, xmin, xmax from pg_authid ; > > > > > > > This is the result: > > > > postgres=# select ctid, xmin, xmax from pg_authid ; >

Re: plperl fails with perl 5.28

2018-05-22 Thread Tom Lane
Andrew Dunstan writes: > On 05/22/2018 07:18 AM, Christoph Berg wrote: >> plperl fails to install with perl 5.27.11, which is to be released as 5.28.0: > I have a tiny bit more info: > andrew=# load 'plperl.so'; > ERROR: > CONTEXT: while running Perl initialization > andrew=# I

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread David Rowley
On 23 May 2018 at 09:31, Andres Freund wrote: >> On 23 May 2018 at 03:55, Tom Lane wrote: >> > Hm, so why is the correct rowcount returned --- are we running >> > a separate counter for that purpose, and if so why? >> >> I thought the output I pasted was clearly showing it not to be the >> same.

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread Andres Freund
On 2018-05-23 09:04:35 +1200, David Rowley wrote: > Thanks for pushing. > > On 23 May 2018 at 03:55, Tom Lane wrote: > > Hm, so why is the correct rowcount returned --- are we running > > a separate counter for that purpose, and if so why? > > I thought the output I pasted was clearly showing it

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread David Rowley
On 23 May 2018 at 09:16, Vik Fearing wrote: > I think Tom was wondering why it isn't showing 5032703. You'll need to explain that one. The number just looks like nonsense to me. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Serv

Re: Error on vacuum: xmin before relfrozenxid

2018-05-22 Thread Andres Freund
Hi, On 2018-05-22 21:43:01 +0200, Paolo Crosato wrote: > > Could you report the result of > > select ctid, xmin, xmax from pg_authid ; > > > > This is the result: > > postgres=# select ctid, xmin, xmax from pg_authid ; > (0,16) | 3031994631 |0 > 16 | 6496 |1 |144 | 303199463

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread Vik Fearing
On 22/05/18 23:04, David Rowley wrote: > Thanks for pushing. > > On 23 May 2018 at 03:55, Tom Lane wrote: >> Hm, so why is the correct rowcount returned --- are we running >> a separate counter for that purpose, and if so why? > > I thought the output I pasted was clearly showing it not to be th

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread David Rowley
Thanks for pushing. On 23 May 2018 at 03:55, Tom Lane wrote: > Hm, so why is the correct rowcount returned --- are we running > a separate counter for that purpose, and if so why? I thought the output I pasted was clearly showing it not to be the same. 42 vs 43. Did I misunderst

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Matthew Stickney
On Tue, May 22, 2018 at 4:09 PM, Tom Lane wrote: > [ please don't top-post ] Sorry, I'm used to using a better mail client than this. > Hm. The failure mode I was thinking about was insufficient resources > to allocate another handle You have a point here; CreateFile does create a new handle (

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Tom Lane
[ please don't top-post ] Matthew Stickney writes: > On Tue, May 22, 2018 at 2:55 PM, Tom Lane wrote: >> Is it possible to operate on "termin" instead of doing a second open >> (which might fail, which we are failing to cope with :-()? > It is possible, at the cost of two extra function calls,

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-22 Thread Andres Freund
On 2018-05-22 21:58:06 +0200, Dmitry Dolgov wrote: > > On 22 May 2018 at 20:59, Andres Freund wrote: > > On 2018-05-22 20:54:46 +0200, Dmitry Dolgov wrote: > > Huh? Checkpointer was in SendFsyncRequest()? Coudl you share the > > backtrace? > > Well, that's what I've got from gdb: > #3 0x000

Re: Commit fest 2017-11

2018-05-22 Thread Robert Haas
On Tue, May 22, 2018 at 2:02 PM, Andres Freund wrote: > On 2018-05-22 19:59:29 +0200, Magnus Hagander wrote: >> So the big question is, is the data we can get out of it worth it? > > I can't see it being worth it personally. I tend to agree. First, it sounds like a lot of work. If we had the op

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-22 Thread Dmitry Dolgov
> On 22 May 2018 at 20:59, Andres Freund wrote: > On 2018-05-22 20:54:46 +0200, Dmitry Dolgov wrote: >> > On 22 May 2018 at 18:47, Andres Freund wrote: >> > On 2018-05-22 08:57:18 -0700, Andres Freund wrote: >> >> Hi, >> >> >> >> >> >> On 2018-05-22 17:37:28 +0200, Dmitry Dolgov wrote: >> >> > Th

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Matthew Stickney
It is possible, at the cost of two extra function calls, which could theoretically fail (and require a little extra munging to work on Windows CE -- is that a target platform for postgres?). Similar to using CreateFile, I think the cases in which those calls could fail are so extraordinary that ps

Re: pgAdmin4 Docker behind load balancer

2018-05-22 Thread Daniel Gustafsson
> On 22 May 2018, at 18:07, Lenain wrote: > > Hello hackers, > > We are currently using the dpage/pgadmin4 image to run a pgAdmin4 web > interface behind an AWS application load balancer. > The load balancer is configured to check the health of containers by querying > the /login URI and check

Re: perl checking

2018-05-22 Thread Andrew Dunstan
On 05/22/2018 10:09 AM, Tom Lane wrote: Andrew Dunstan writes: On 05/22/2018 04:11 AM, Kyotaro HORIGUCHI wrote: At Fri, 18 May 2018 14:02:39 -0400, Andrew Dunstan wrote in <5a6d6de8-cff8-1ffb-946c-ccf381800...@2ndquadrant.com> One patch silences a warning from convutils.pl about the unpor

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-22 Thread Andres Freund
On 2018-05-22 20:54:46 +0200, Dmitry Dolgov wrote: > > On 22 May 2018 at 18:47, Andres Freund wrote: > > On 2018-05-22 08:57:18 -0700, Andres Freund wrote: > >> Hi, > >> > >> > >> On 2018-05-22 17:37:28 +0200, Dmitry Dolgov wrote: > >> > Thanks for the patch. Out of curiosity I tried to play with

Re: [PATCH] (Windows) psql echoes password when reading from pipe

2018-05-22 Thread Tom Lane
Matthew Stickney writes: > On windows, if you pipe data to psql, the password prompt correctly > reads from and writes to the console, but the password text is echoed to > the console. This is because echoing is disabled on the handle for > stdin, but as part of a pipeline stdin doesn't refer t

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-22 Thread Dmitry Dolgov
> On 22 May 2018 at 18:47, Andres Freund wrote: > On 2018-05-22 08:57:18 -0700, Andres Freund wrote: >> Hi, >> >> >> On 2018-05-22 17:37:28 +0200, Dmitry Dolgov wrote: >> > Thanks for the patch. Out of curiosity I tried to play with it a bit. >> >> Thanks. >> >> >> > `pgbench -i -s 100` actually h

Re: future of contrib/xml2 and xslt processing

2018-05-22 Thread Andres Freund
Hi, On 2018-05-22 14:38:32 -0400, Peter Eisentraut wrote: > 1. Just remove it, leaving users to find other solutions. (PL/P* can > probably fill the gap.) I don't have access to the code anymore, but a good number of past customers and employers of mine relied on xslt. I think we'd get some pus

Re: future of contrib/xml2 and xslt processing

2018-05-22 Thread Tom Lane
Peter Eisentraut writes: > contrib/xml2 has been claimed to be deprecated since PostgreSQL 8.3. I > took a look through the functions it offers and perhaps with xmltable > now being available, they could all be replaced using built-in > functions, perhaps with some small tweaking. > But we don't

future of contrib/xml2 and xslt processing

2018-05-22 Thread Peter Eisentraut
contrib/xml2 has been claimed to be deprecated since PostgreSQL 8.3. I took a look through the functions it offers and perhaps with xmltable now being available, they could all be replaced using built-in functions, perhaps with some small tweaking. But we don't have any replacement lined up for t

Re: A Japanese-unfriendy error message contruction

2018-05-22 Thread Tom Lane
Kyotaro HORIGUCHI writes: > The "policy %s" and " %s" are transposed in Japaese > syntax. Specifically " %s NO %s" is the > natural translation of "policy %s on %s". But currently > we cannot get the natural error message in Japanese. > For the reason, I'd like to propose to refactor > getObje

Re: Commit fest 2017-11

2018-05-22 Thread Jesper Pedersen
Hi, On 05/22/2018 01:57 PM, Robert Haas wrote: On Thu, Mar 29, 2018 at 4:19 AM, Magnus Hagander wrote: I wonder if we should consider adding a field to the CF app *specifically* to track things like this. What I'm thinking is a field that's set (or at least verified) by the person who flags a

Re: Commit fest 2017-11

2018-05-22 Thread Andres Freund
Hi, On 2018-05-22 19:59:29 +0200, Magnus Hagander wrote: > So the big question is, is the data we can get out of it worth it? I can't see it being worth it personally. Greetings, Andres Freund

Re: Commit fest 2017-11

2018-05-22 Thread Magnus Hagander
On Tue, May 22, 2018 at 7:57 PM, Robert Haas wrote: > On Thu, Mar 29, 2018 at 4:19 AM, Magnus Hagander > wrote: > > I wonder if we should consider adding a field to the CF app > *specifically* > > to track things like this. What I'm thinking is a field that's set (or at > > least verified) by th

Re: Commit fest 2017-11

2018-05-22 Thread Robert Haas
On Thu, Mar 29, 2018 at 4:19 AM, Magnus Hagander wrote: > I wonder if we should consider adding a field to the CF app *specifically* > to track things like this. What I'm thinking is a field that's set (or at > least verified) by the person who flags a patch as committed with choices > like Trivia

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-22 Thread Andres Freund
On 2018-05-22 08:57:18 -0700, Andres Freund wrote: > Hi, > > > On 2018-05-22 17:37:28 +0200, Dmitry Dolgov wrote: > > Thanks for the patch. Out of curiosity I tried to play with it a bit. > > Thanks. > > > > `pgbench -i -s 100` actually hang on my machine, because the > > copy process ended up

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread Tom Lane
Andres Freund writes: > On 2018-05-22 11:55:26 -0400, Tom Lane wrote: >> Hm, so why is the correct rowcount returned --- are we running >> a separate counter for that purpose, and if so why? > Yes, it's a local counter in CopyFrom/CopyTo. It's probably not > entirely trivial to unify the two. Th

Re: plperl fails with perl 5.28

2018-05-22 Thread Andrew Dunstan
On 05/22/2018 07:18 AM, Christoph Berg wrote: plperl fails to install with perl 5.27.11, which is to be released as 5.28.0: 2018-05-17 20:01:44.556 UTC [22629] pg_regress ERROR: 2018-05-17 20:01:44.556 UTC [22629] pg_regress CONTEXT: while running Perl initialization 2018-05-17 20:01:44.556

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread Andres Freund
On 2018-05-22 11:55:26 -0400, Tom Lane wrote: > David Rowley writes: > > while it might not look too scary by itself, it gets a bit more so > > when you learn that the cur_lineno is only 32 bits wide. This will > > result in skipping a tuple every time the 32-bit variable wraps back > > around to

pgAdmin4 Docker behind load balancer

2018-05-22 Thread Lenain
Hello hackers, We are currently using the dpage/pgadmin4 image to run a pgAdmin4 web interface behind an AWS application load balancer. The load balancer is configured to check the health of containers by querying the /login URI and checking if it answers with a 200 HTTP code. However the app alw

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-22 Thread Andres Freund
Hi, On 2018-05-22 17:37:28 +0200, Dmitry Dolgov wrote: > Thanks for the patch. Out of curiosity I tried to play with it a bit. Thanks. > `pgbench -i -s 100` actually hang on my machine, because the > copy process ended up with waiting after `pg_uds_send_with_fd` > had Hm, that had worked at s

Re: ppc64le support in 9.3 branch?

2018-05-22 Thread Tom Lane
Christoph Berg writes: > Re: Tom Lane 2018-03-23 <1219.1521831...@sss.pgh.pa.us> >> The compromise I'm inclined to offer is to see what happens if we >> back-patch 9.4's config.guess and config.sub. If that makes these >> animals go green, and doesn't break any others, we'll call it good. >> Othe

Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread Tom Lane
David Rowley writes: > while it might not look too scary by itself, it gets a bit more so > when you learn that the cur_lineno is only 32 bits wide. This will > result in skipping a tuple every time the 32-bit variable wraps back > around to 0 again. Hm, so why is the correct rowcount returned --

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-22 Thread Dmitry Dolgov
> On 22 May 2018 at 03:08, Andres Freund wrote: > On 2018-05-19 18:12:52 +1200, Thomas Munro wrote: >> On Sat, May 19, 2018 at 4:51 PM, Thomas Munro >> wrote: >> > Next, make check hangs in initdb on both of my pet OSes when md.c >> > raises an error (fseek fails) and we raise and error while rai

Re: PG11 jit failing on ppc64el

2018-05-22 Thread Andres Freund
Hi, On 2018-05-22 16:33:57 +0200, Christoph Berg wrote: > PG 11 beta1 is failing on ppc64el. All Debian/Ubuntu releases except > Jessie are affected. My guess is on problems with llvm/jit, because of > the C++ style error message (and LLVM is disabled on Jessie). It was bug in LLVM that's fixed n

COPY FROM WITH HEADER skips a tuple every 4 billion tuples

2018-05-22 Thread David Rowley
I'd been looking over the COPY FROM code tonight when I saw something pretty scary looking: /* on input just throw the header line away */ if (cstate->cur_lineno == 0 && cstate->header_line) { cstate->cur_lineno++; if (CopyReadLine(cstate)) return false; /* done */ } while it might

PG11 jit failing on ppc64el

2018-05-22 Thread Christoph Berg
PG 11 beta1 is failing on ppc64el. All Debian/Ubuntu releases except Jessie are affected. My guess is on problems with llvm/jit, because of the C++ style error message (and LLVM is disabled on Jessie). Debian sid: 15:59:29 2018-05-22 13:59:24.914 UTC [29081] pg_regress/strings STATEMENT: SELECT

Re: ppc64le support in 9.3 branch?

2018-05-22 Thread Christoph Berg
Re: Tom Lane 2018-03-23 <1219.1521831...@sss.pgh.pa.us> > The compromise I'm inclined to offer is to see what happens if we > back-patch 9.4's config.guess and config.sub. If that makes these > animals go green, and doesn't break any others, we'll call it good. > Otherwise, we revert that change a

Re: Fix for FETCH FIRST syntax problems

2018-05-22 Thread David G. Johnston
On Tue, May 22, 2018 at 5:59 AM, Robert Haas wrote: > If we start routinely > back-patching things that fall into that category, we will certainly > manage to destabilize older releases on a regular basis. > Just because something is bad if done in excess doesn't mean specific moderate partaking

Re: perl checking

2018-05-22 Thread Tom Lane
Andrew Dunstan writes: > On 05/22/2018 04:11 AM, Kyotaro HORIGUCHI wrote: >> At Fri, 18 May 2018 14:02:39 -0400, Andrew Dunstan >> wrote in >> <5a6d6de8-cff8-1ffb-946c-ccf381800...@2ndquadrant.com> >>> One patch silences a warning from convutils.pl about the unportability >>> of the literal 0x1

Re: PostgreSQL “tuple already updated by self”

2018-05-22 Thread Robert Haas
On Tue, May 22, 2018 at 8:01 AM, SG wrote: > Our database seems to be broken, normally it uses about 1-2% of cpu, but if > we run some additional backend services making UPDATE and INSERT queries for > 10M rows table (about 1 query per 3 second) everything is going to hell > (including CPU increas

Re: A Japanese-unfriendy error message contruction

2018-05-22 Thread Euler Taveira
2018-05-22 6:20 GMT-03:00 Kyotaro HORIGUCHI : > For the reason, I'd like to propose to refactor > getObjectDescription:OPCLASS_POLICY as the attached patch. The > same structure is seen for OPCLASS_AMOP. > +1. -- Euler Taveira Timbira - http://www.timbira.com

Re: Fix for FETCH FIRST syntax problems

2018-05-22 Thread Robert Haas
On Sun, May 20, 2018 at 5:16 PM, Tom Lane wrote: > "David G. Johnston" writes: >> The risk here is significantly reduced since the existing user-visible >> behavior is an error which presumably no one is relying upon. Between that >> and being able to conform to the standard syntax for a long-st

Re: perl checking

2018-05-22 Thread Andrew Dunstan
On 05/22/2018 04:11 AM, Kyotaro HORIGUCHI wrote: At Fri, 18 May 2018 14:02:39 -0400, Andrew Dunstan wrote in <5a6d6de8-cff8-1ffb-946c-ccf381800...@2ndquadrant.com> These two small patches allow us to run "perl -cw" cleanly on all our perl code. One patch silences a warning from convutils.p

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-05-22 Thread Michail Nikolaev
Hello. > 1. Charts are measured in percents of pgbench TPS, right? Yes, correct. Actual values are calculated as TPS_of_patched / TPS_of_vanilla. TPS was measured using single postgres process (one core) (I was also did tests with multiple processes, but they shows pretty same results). > 2. For

PostgreSQL “tuple already updated by self”

2018-05-22 Thread SG
Our database seems to be broken, normally it uses about 1-2% of cpu, but if we run some additional backend services making UPDATE and INSERT queries for 10M rows table (about 1 query per 3 second) everything is going to hell (including CPU increase from 2% to 98% usage). We have decided to debug w

plperl fails with perl 5.28

2018-05-22 Thread Christoph Berg
plperl fails to install with perl 5.27.11, which is to be released as 5.28.0: 2018-05-17 20:01:44.556 UTC [22629] pg_regress ERROR: 2018-05-17 20:01:44.556 UTC [22629] pg_regress CONTEXT: while running Perl initialization 2018-05-17 20:01:44.556 UTC [22629] pg_regress STATEMENT: CREATE EXTENSIO

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-05-22 Thread Andrey Borodin
Hi, Michail! > 21 мая 2018 г., в 20:43, Michail Nikolaev > написал(а): > This letter related to “Extended support for index-only-scan” from my > previous message in the thread. This is great that you continue your work in this direction! The concept of scan that you propose looks interesting.

Re: Update backend/lib/README

2018-05-22 Thread Heikki Linnakangas
On 22/05/18 11:44, Ideriha, Takeshi wrote: Hi, When I looked into the dshash.c, I noticed that dshash.c, bipartite_match.c and knapsack.c are not mentioned at README. The other files at src/backend/lib are mentioned. I'm not sure this is an intentional one or just leftovers. Does anyone have

Re: Time to put context diffs in the grave

2018-05-22 Thread Kyotaro HORIGUCHI
At Mon, 21 May 2018 21:51:11 -0400, Andrew Dunstan wrote in <247f4d65-31f3-d426-2b24-fc434fa67...@2ndquadrant.com> > > We haven't insisted on context diffs in years now, and one of my > interlocutors has just turned handsprings trying to follow the advice > at

Re: Transform for pl/perl

2018-05-22 Thread Anthony Bykov
On Wed, 02 May 2018 17:41:38 +0100 ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) wrote: > Peter Eisentraut writes: > > > These two items are now outstanding: > > > > On 4/10/18 07:33, Dagfinn Ilmari Mannsåker wrote: > >> 2) jsonb scalar values are passed to the plperl function wrapped > >> in n

A Japanese-unfriendy error message contruction

2018-05-22 Thread Kyotaro HORIGUCHI
Hello. While I revised the translation, I ran across the following code. >form_policy = (Form_pg_policy) GETSTRUCT(tuple); > >appendStringInfo(&buffer, _("policy %s on "), > NameStr(form_policy->polname)); >getRelationDescription(&buffer, form_policy->polrelid); getRelati

Update backend/lib/README

2018-05-22 Thread Ideriha, Takeshi
Hi, When I looked into the dshash.c, I noticed that dshash.c, bipartite_match.c and knapsack.c are not mentioned at README. The other files at src/backend/lib are mentioned. I'm not sure this is an intentional one or just leftovers. Does anyone have opinions? Patch attached. - add summary of

Re: Time to put context diffs in the grave

2018-05-22 Thread Michael Paquier
On Mon, May 21, 2018 at 09:51:11PM -0400, Andrew Dunstan wrote: > Unless someone objects really violently I'm going to rip all that stuff out > and let sanity prevail. Please! -- Michael signature.asc Description: PGP signature

Re: [PATCH] Clear up perlcritic 'missing return' warning

2018-05-22 Thread Michael Paquier
On Mon, May 21, 2018 at 08:07:03PM -0500, Mike Blackwell wrote: > This particular patch addresses the warning caused by falling off the end > of a subroutine rather than explicitly returning. Do we really want to make that a requirement? Making sure that there is a return clause if a subroutine r

Re: SCRAM with channel binding downgrade attack

2018-05-22 Thread Michael Paquier
On Sat, May 19, 2018 at 09:35:57PM +0900, Michael Paquier wrote: > The previous patch has actually problems with servers using "trust", > "password" and any protocol which can send directly AUTH_REQ_OK as those > could still enforce a downgrade to not use channel binding, so we > actually need to m

Re: perl checking

2018-05-22 Thread Kyotaro HORIGUCHI
At Fri, 18 May 2018 14:02:39 -0400, Andrew Dunstan wrote in <5a6d6de8-cff8-1ffb-946c-ccf381800...@2ndquadrant.com> > > These two small patches allow us to run "perl -cw" cleanly on all our > perl code. > > > One patch silences a warning from convutils.pl about the unportability > of the liter

Re: Fix some error handling for read() and errno

2018-05-22 Thread Kyotaro HORIGUCHI
Hello. At Sun, 20 May 2018 09:05:22 +0900, Michael Paquier wrote in <2018052522.gb1...@paquier.xyz> > Hi all, > > This is basically a new thread after what has been discussed for > pg_controldata with its error handling for read(): > https://www.postgresql.org/message-id/CABUevEx8ZRV5Ut_FvP

Re: PostgreSQL and Homomorphic Encryption

2018-05-22 Thread Craig Ringer
On 22 May 2018 at 14:34, Tal Glozman wrote: > Hello PostgreSQL Team, > > I'm doing a project at my university (HU Berlin) involving homomorphic > encrypted searches on data bases. Does PostgreSQL support homomorphic > encryption-based searches? > Not natively, as far as I know anyway. I don't t

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2018-05-22 Thread Masahiko Sawada
On Mon, May 21, 2018 at 10:42 AM, Tsunakawa, Takayuki wrote: > From: Masahiko Sawada [mailto:sawada.m...@gmail.com] >> Regarding to API design, should we use 2PC for a distributed >> transaction if both two or more 2PC-capable foreign servers and >> 2PC-non-capable foreign server are involved with

PostgreSQL and Homomorphic Encryption

2018-05-22 Thread Tal Glozman
Hello PostgreSQL Team, I'm doing a project at my university (HU Berlin) involving homomorphic encrypted searches on data bases. Does PostgreSQL support homomorphic encryption-based searches? I couldn’t find the information about it on the internet. Could you provide me a web link or a PDF on the m

  1   2   >