Re: [GENERAL] Lockless pg_buffercache

2008-02-10 Thread Tom Lane
"Scott Marlowe" <[EMAIL PROTECTED]> writes: > So, what's the real burden like from the pg_buffercache contrib module? I wonder whether pg_buffercache should be changed to work like the statistics views do, ie, you take a snapshot during the first call within a transaction. This would allow correl

Re: [GENERAL] Lockless pg_buffercache

2008-02-10 Thread Scott Marlowe
On Feb 9, 2008 10:34 PM, Markus Bertheau <[EMAIL PROTECTED]> wrote: > Hi, > > I want to use the pg_buffercache contrib module for monitoring our > server. It takes a lock on all buffers and then on each buffer header > in order to get a consistent picture of the buffers. I would be > running the fu

Re: [GENERAL] Lockless pg_buffercache

2008-02-09 Thread Tom Lane
"Markus Bertheau" <[EMAIL PROTECTED]> writes: > Does removing all locking as in the attached patch have any negative > impact other than the non-consistency of the results? Removing the LockBufHdr bit is definitely a pretty foolish idea. regards, tom lane