Re: [GENERAL] zero_damaged_pages doesn't work

2011-02-01 Thread Bruce Momjian
David Boreham wrote: > On 9/27/2010 4:53 PM, Tom Lane wrote: > > The reason it tells you that data will be destroyed is that that could > > very well happen. > > Re-parsing this, I think there was a mis-communication : > > I'm not at all suggesting that the doc should _not_ say that data will

Re: [GENERAL] zero_damaged_pages doesn't work

2010-09-27 Thread David Boreham
On 9/27/2010 4:53 PM, Tom Lane wrote: The reason it tells you that data will be destroyed is that that could very well happen. Re-parsing this, I think there was a mis-communication : I'm not at all suggesting that the doc should _not_ say that data will be corrupted. I'm suggesting that in

Re: [GENERAL] zero_damaged_pages doesn't work

2010-09-27 Thread David Boreham
On 9/27/2010 4:53 PM, Tom Lane wrote: The reason it tells you that data will be destroyed is that that could very well happen. If the system decides to put new data into what will appear to it to be an empty page, then the damaged data on disk will be overwritten, and then there's no hope of re

Re: [GENERAL] zero_damaged_pages doesn't work

2010-09-27 Thread Tom Lane
David Boreham writes: > On 9/27/2010 4:40 PM, Jeff Davis wrote: >> zero_damaged_pages is not meant as a recovery tool. It's meant to allow >> you to pg_dump whatever data is not damaged, so that you can restore >> into a fresh location. > It'd be useful for future generations if this were inclu

Re: [GENERAL] zero_damaged_pages doesn't work

2010-09-27 Thread David Boreham
On 9/27/2010 4:40 PM, Jeff Davis wrote: It does zero the page in the buffer, but I don't think it marks it as dirty. So, it never really makes it to disk as all-zeros. Ah ha ! This is certainly consistent with the observed behavior. zero_damaged_pages is not meant as a recovery tool. It's me

Re: [GENERAL] zero_damaged_pages doesn't work

2010-09-27 Thread Jeff Davis
On Mon, 2010-09-27 at 15:07 -0600, David Boreham wrote: > Is the zero_damaged_pages feature expected to work in 8.3.11 ? > > I have a fair bit of evidence that it doesn't (you get nice messages > in saying that the page is being zeroed, but the on-disk data does not > change). > I also see quite

[GENERAL] zero_damaged_pages doesn't work

2010-09-27 Thread David Boreham
Is the zero_damaged_pages feature expected to work in 8.3.11 ? I have a fair bit of evidence that it doesn't (you get nice messages in saying that the page is being zeroed, but the on-disk data does not change). I also see quite a few folk reporting similar findings in various form and mailing