Re: [GENERAL] pgxs/config/missing is... missing

2015-10-30 Thread Jim Nasby
On 10/30/15 2:55 PM, David E. Wheeler wrote: On Oct 30, 2015, at 11:38 AM, Jim Nasby wrote: Given what pgTap's Makefile is using perl for, perhaps the best bet is to just ignore whatever PGXS has to say about it. So add a check to see if it ends in “missing perl”? Suggested Makefile-foo for

Re: [GENERAL] pgxs/config/missing is... missing

2015-10-30 Thread David E. Wheeler
On Oct 30, 2015, at 11:38 AM, Jim Nasby wrote: > Given what pgTap's Makefile is using perl for, perhaps the best bet is to > just ignore whatever PGXS has to say about it. So add a check to see if it ends in “missing perl”? Suggested Makefile-foo for that? D smime.p7s Description: S/MIME c

Re: [GENERAL] pgxs/config/missing is... missing

2015-10-30 Thread Jim Nasby
On 10/30/15 11:13 AM, Alvaro Herrera wrote: David E. Wheeler wrote: On Oct 29, 2015, at 7:22 PM, Jim Nasby wrote: I'm not sure if this is the right way to go about it, but this patch at least installs the file. Which seems like a decent idea. I’d like a way to know when Perl is missing, t

Re: [GENERAL] pgxs/config/missing is... missing

2015-10-30 Thread Alvaro Herrera
David E. Wheeler wrote: > On Oct 29, 2015, at 7:22 PM, Jim Nasby wrote: > > > I'm not sure if this is the right way to go about it, but this patch at > > least installs the file. > > Which seems like a decent idea. I’d like a way to know when Perl is missing, > though. What does `missing` do?

Re: [GENERAL] pgxs/config/missing is... missing

2015-10-30 Thread David E. Wheeler
On Oct 29, 2015, at 7:22 PM, Jim Nasby wrote: > I'm not sure if this is the right way to go about it, but this patch at least > installs the file. Which seems like a decent idea. I’d like a way to know when Perl is missing, though. What does `missing` do? D smime.p7s Description: S/MIME cryp

Re: [GENERAL] pgxs/config/missing is... missing

2015-10-29 Thread Jim Nasby
On 10/29/15 5:31 PM, David E. Wheeler wrote: >even after explicitly exporting PERL=/usr/local/bin/perl Hrm. I have this code in the pgTAP Makefile: ifndef PERL PERL := $(shell which perl) endif Could that be causing the problem? That doesn't help because PGXS defines PERL: #

Re: [GENERAL] pgxs/config/missing is... missing

2015-10-29 Thread David E. Wheeler
On Oct 28, 2015, at 10:54 AM, Jim Nasby wrote: > I indeed get > > PERL = /bin/sh > /usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing perl Ew. > even after explicitly exporting PERL=/usr/local/bin/perl Hrm. I have this code in the pgTAP Makefile: ifndef PERL PERL := $

[GENERAL] pgxs/config/missing is... missing

2015-10-28 Thread Jim Nasby
I'm trying to install pgTAP on a FreeBSD machine and running into an odd problem: sed -e 's,MODULE_PATHNAME,$libdir/pgtap,g' -e 's,__OS__,freebsd,g' -e 's,__VERSION__,0.95,g' sql/pgtap-core.sql > sql/pgtap-core.tmp /bin/sh /usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing perl