Re: [GENERAL] Contributing code

2006-05-22 Thread Jim C. Nasby
On Fri, May 19, 2006 at 09:37:30AM +0200, Martijn van Oosterhout wrote: > On Thu, May 18, 2006 at 10:54:02PM -0700, Don Y wrote: > > I assumed that the contents of ./contrib have NOT been > > thoroughly tested/reviewed by the Postgres team (though > > that is just an impression I have... i.e. why h

Re: [GENERAL] Contributing code

2006-05-19 Thread Robert Treat
On Friday 19 May 2006 01:54, Don Y wrote: > Tom Lane wrote: > > Tim Allen <[EMAIL PROTECTED]> writes: > >> Don Y wrote: > >>> So, I'll deploy them and get feedback on which features I > >>> may need to add (some of the data types are probably a bit > >>> too exotic for most users). I figure I can

Re: [GENERAL] Contributing code

2006-05-19 Thread Martijn van Oosterhout
On Thu, May 18, 2006 at 10:54:02PM -0700, Don Y wrote: > I assumed that the contents of ./contrib have NOT been > thoroughly tested/reviewed by the Postgres team (though > that is just an impression I have... i.e. why have those > features not been INTEGRATED into the codebase?) contrib has been t

Re: [GENERAL] Contributing code

2006-05-18 Thread Don Y
Tom Lane wrote: Tim Allen <[EMAIL PROTECTED]> writes: Don Y wrote: So, I'll deploy them and get feedback on which features I may need to add (some of the data types are probably a bit too exotic for most users). I figure I can always contribute them just before a release... Just before a rel

Re: [GENERAL] Contributing code

2006-05-17 Thread Tom Lane
Tim Allen <[EMAIL PROTECTED]> writes: > Don Y wrote: >> So, I'll deploy them and get feedback on which features I >> may need to add (some of the data types are probably a bit >> too exotic for most users). I figure I can always contribute >> them just before a release... > Just before a release

Re: [GENERAL] Contributing code

2006-05-17 Thread Tim Allen
Don Y wrote: So, I'll deploy them and get feedback on which features I may need to add (some of the data types are probably a bit too exotic for most users). I figure I can always contribute them just before a release... Just before a release would actually be a bad time to contribute the co

Re: [GENERAL] Contributing code

2006-05-17 Thread Jim C. Nasby
On Wed, May 17, 2006 at 10:46:52AM -0700, Don Y wrote: > Martijn van Oosterhout wrote: > >On Tue, May 16, 2006 at 08:12:05PM -0700, Don Y wrote: > >>Hi, > >> > >>Is it possible to have one of my user defined data types > >>reviewed/critiqued to see if there are things that I am > >>not doing proper

Re: [GENERAL] Contributing code

2006-05-17 Thread Don Y
Martijn van Oosterhout wrote: On Tue, May 16, 2006 at 08:12:05PM -0700, Don Y wrote: Hi, Is it possible to have one of my user defined data types reviewed/critiqued to see if there are things that I am not doing properly? Or, other things that I should be including? Or, should I just contribu

Re: [GENERAL] Contributing code

2006-05-16 Thread Martijn van Oosterhout
On Tue, May 16, 2006 at 08:12:05PM -0700, Don Y wrote: > Hi, > > Is it possible to have one of my user defined data types > reviewed/critiqued to see if there are things that I am > not doing properly? Or, other things that I should be > including? Or, should I just contribute it and hope > for

[GENERAL] Contributing code

2006-05-16 Thread Don Y
Hi, Is it possible to have one of my user defined data types reviewed/critiqued to see if there are things that I am not doing properly? Or, other things that I should be including? Or, should I just contribute it and hope for the best? (if so, how do I do that?) Thanks! --don --