Re: [GENERAL] [PATCH] Partial indicies again

2001-07-10 Thread Martijn van Oosterhout
On Tue, Jul 10, 2001 at 04:47:49PM +0200, Peter Eisentraut wrote: > Martijn van Oosterhout writes: > > > Well, getting closer. Maybe I should start version numbering the patches? > > For one thing, you might want to post them to pgsql-patches instead. And > you should start generating the patch

Re: [GENERAL] [PATCH] Partial indicies again

2001-07-10 Thread Peter Eisentraut
Martijn van Oosterhout writes: > Well, getting closer. Maybe I should start version numbering the patches? For one thing, you might want to post them to pgsql-patches instead. And you should start generating the patches against the 7.2devel sources because I already suspect yours generating con

Re: [GENERAL] [PATCH] Partial indicies again

2001-07-10 Thread Tom Lane
Martijn van Oosterhout <[EMAIL PROTECTED]> writes: > To actually be able to use ExecInsertIndexTuples, you need to create an > EState, a ResultRelInfo and put each tuple in a TupleSlot for a while. Does > it sound like I'm on the right track? That's quite a few changes. Right. I'd recommend copy

Re: [GENERAL] [PATCH] Partial indicies again

2001-07-10 Thread Martijn van Oosterhout
On Mon, Jul 09, 2001 at 08:22:43PM -0400, Tom Lane wrote: > AFAIR, cnfify doesn't modify its inputs. But watch out for the > difference between explicit and implicit ANDing. OK, I'm pretty sure I got it right now. > In practice, I seem to recall that VACUUM is broken for partial indexes > anywa

Re: [GENERAL] [PATCH] Partial indicies again

2001-07-09 Thread Tom Lane
Martijn van Oosterhout <[EMAIL PROTECTED]> writes: >> I suspect you need to run cnfify after and-ing together the predicate >> and index quals. clauselist_selectivity assumes it's working on >> cnf'ified expressions. > OK. Do I need to worry about that function destroying either of the input > l

[GENERAL] [PATCH] Partial indicies again

2001-07-09 Thread Martijn van Oosterhout
Well, getting closer. Maybe I should start version numbering the patches? Things changed in this version: * As Tom Lane pointed out, what to do with EXTEND INDEX. I've decided to remove it since there is no defined syntax for it and you cannot make an index more restrictive with it. Since th