Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-17 Thread Peter Eisentraut
On 2020-11-16 18:30, Tom Lane wrote: In this case, I see one use of the constant TRUE in collationcmds.c, but I wonder how come that's there given that we deprecated upper-case TRUE some time ago. In 2eb4a831e5fb5d8fc17e13aea56e04af3efe27b4, I intentionally left that there because it was the d

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-17 Thread Condor
On 17-11-2020 11:00, Thomas Munro wrote: On Tue, Nov 17, 2020 at 8:02 PM Condor wrote: I try to compile postgres again with (cd src/backend/commands; sed 's/TRUE/true/' collationcmds.c > collationcmds.c; ) and it's compiled but get new error on linking: Doesn't that produce an empty file coll

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-17 Thread Thomas Munro
On Tue, Nov 17, 2020 at 8:02 PM Condor wrote: > I try to compile postgres again with (cd src/backend/commands; sed > 's/TRUE/true/' collationcmds.c > collationcmds.c; ) and it's compiled > but get new error on linking: Doesn't that produce an empty file collationcmds.c? I think you want: sed 's/

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Condor
On 16-11-2020 22:18, Tom Lane wrote: I wrote: What's wrong with s/TRUE/true/ in get_icu_language_tag? I confirmed that that fixes the build with ICU 68.1, and pushed it. regards, tom lane Hello, I try to compile postgres again with (cd src/backend/commands; sed 's

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Tom Lane
I wrote: > What's wrong with s/TRUE/true/ in get_icu_language_tag? I confirmed that that fixes the build with ICU 68.1, and pushed it. regards, tom lane

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Tom Lane
I wrote: > A larger issue is that it looks like ICU68 may insist on importing > in some headers. That's fine on the platforms where we > use anyway, but it's distinctly not fine elsewhere. Meh. I went to see if I could test that, and didn't get much further than this on ICU's downloads page:

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Tom Lane
Laurenz Albe writes: > On Mon, 2020-11-16 at 12:30 -0500, Tom Lane wrote: >> In this case, I see one use of the constant TRUE in collationcmds.c, >> but I wonder how come that's there given that we deprecated upper-case >> TRUE some time ago. I find it hard to believe that sprinkling "#include >>

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Laurenz Albe
On Mon, 2020-11-16 at 12:30 -0500, Tom Lane wrote: > Thomas Munro writes: > > It looks like something happened to ICU's boolean macros . See this > > commit in FreeBSD ports: > > https://github.com/freebsd/freebsd-ports/commit/81a88b4506ec06d07be10d199170ef4003eb0e30 > > It'd be so nice if peopl

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Tom Lane
Thomas Munro writes: > It looks like something happened to ICU's boolean macros . See this > commit in FreeBSD ports: > https://github.com/freebsd/freebsd-ports/commit/81a88b4506ec06d07be10d199170ef4003eb0e30 It'd be so nice if people would tell us about their problems, instead of just hacking-

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Laurenz Albe
On Mon, 2020-11-16 at 22:17 +1300, Thomas Munro wrote: > On Mon, Nov 16, 2020 at 10:10 PM Laurenz Albe > wrote: > > > On Mon, 2020-11-16 at 09:15 +0200, Condor wrote: > > > collationcmds.c: In function ‘get_icu_language_tag’: > > > collationcmds.c:467:51: error: ‘TRUE’ undeclared (first use in t

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Condor
On 16-11-2020 11:10, Laurenz Albe wrote: On Mon, 2020-11-16 at 09:15 +0200, Condor wrote: unable to compile Postgresql 13.0 and 13.1 on Slackware current x64. Here is gcc -v: Reading specs from /usr/lib64/gcc/x86_64-slackware-linux/9.3.0/specs COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/libexec/gc

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Thomas Munro
On Mon, Nov 16, 2020 at 10:10 PM Laurenz Albe wrote: > On Mon, 2020-11-16 at 09:15 +0200, Condor wrote: > > collationcmds.c: In function ‘get_icu_language_tag’: > > collationcmds.c:467:51: error: ‘TRUE’ undeclared (first use in this > > function); did you mean ‘IS_TRUE’? > >467 | uloc_toLangu

Re: Unable to compile postgres 13.1 on Slackware current x64

2020-11-16 Thread Laurenz Albe
On Mon, 2020-11-16 at 09:15 +0200, Condor wrote: > unable to compile Postgresql 13.0 and 13.1 on Slackware current x64. > Here is gcc -v: > > Reading specs from /usr/lib64/gcc/x86_64-slackware-linux/9.3.0/specs > COLLECT_GCC=gcc > COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-slackware-linux/9.3.0/

Unable to compile postgres 13.1 on Slackware current x64

2020-11-15 Thread Condor
Hello, unable to compile Postgresql 13.0 and 13.1 on Slackware current x64. Here is gcc -v: Reading specs from /usr/lib64/gcc/x86_64-slackware-linux/9.3.0/specs COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-slackware-linux/9.3.0/lto-wrapper Target: x86_64-slackware-linux Configur