Re: using pg_basebackup for point in time recovery

2018-06-25 Thread Michael Paquier
On Mon, Jun 25, 2018 at 12:51:10PM -0400, Bruce Momjian wrote: > FYI, in recent discussions on the docs list: > > > https://www.postgresql.org/message-id/CABUevEyumGh3r05U3_mhRrEU=dfacdrr2hew140mvn7fsbm...@mail.gmail.com I did not recall this one. Thanks for the reminder, Bruce. > There

Re: using pg_basebackup for point in time recovery

2018-06-25 Thread Bruce Momjian
On Thu, Jun 21, 2018 at 04:50:38PM -0700, David G. Johnston wrote: > On Thu, Jun 21, 2018 at 4:26 PM, Vik Fearing > wrote: > > On 21/06/18 07:27, Michael Paquier wrote: > > Attached is a patch which includes your suggestion.  What do you think? > > As that's an improvement, only HEAD

Re: using pg_basebackup for point in time recovery

2018-06-21 Thread Michael Paquier
On Thu, Jun 21, 2018 at 04:50:38PM -0700, David G. Johnston wrote: > Generally only actual bug fixes get back-patched; but I'd have to say > this looks like it could easily be classified as one. Everybody is against me here ;) > Some comments on the patch itself: > > "recover up to the wanted re

Re: using pg_basebackup for point in time recovery

2018-06-21 Thread Michael Paquier
On Thu, Jun 21, 2018 at 04:42:00PM -0400, Ravi Krishna wrote: > Same here even though I use Mac mail. But it is not yahoo alone. > Most of the web email clients have resorted to top posting. I miss > the old days of Outlook Express which was so '>' friendly. I think > Gmail allows '>' when you c

Re: using pg_basebackup for point in time recovery

2018-06-21 Thread David G. Johnston
On Thu, Jun 21, 2018 at 4:26 PM, Vik Fearing wrote: > On 21/06/18 07:27, Michael Paquier wrote: > > Attached is a patch which includes your suggestion. What do you think? > > As that's an improvement, only HEAD would get that clarification. > > Say what? If the clarification applies to previous

Re: using pg_basebackup for point in time recovery

2018-06-21 Thread Vik Fearing
On 21/06/18 07:27, Michael Paquier wrote: > Attached is a patch which includes your suggestion. What do you think? > As that's an improvement, only HEAD would get that clarification. Say what? If the clarification applies to previous versions, as it does, it should be backpatched. This isn't a

Re: using pg_basebackup for point in time recovery

2018-06-21 Thread Ravi Krishna
> > > >You should avoid top-posting on the Postgres lists, this is not the > >usual style used by people around :) > > Will do, but Yahoo Mail! does not seem to like that, so I am typing the > > myself > Same here even though I use Mac mail. But it is not yahoo alone. Most of the web email c

Re: using pg_basebackup for point in time recovery

2018-06-21 Thread Pierre Timmermans
Hi Michael On Thursday, June 21, 2018, 7:28:13 AM GMT+2, Michael Paquier wrote: >You should avoid top-posting on the Postgres lists, this is not the >usual style used by people around :) Will do, but Yahoo Mail! does not seem to like that, so I am typing the > myself >Attached is a pat

Re: using pg_basebackup for point in time recovery

2018-06-20 Thread Ron
On 06/21/2018 12:27 AM, Michael Paquier wrote: [snip] Attached is a patch which includes your suggestion. What do you think? As that's an improvement, only HEAD would get that clarification. You've *got* to be kidding. Fixing an ambiguously or poorly worded bit of *documentation* should obvi

Re: using pg_basebackup for point in time recovery

2018-06-20 Thread Michael Paquier
Hi Pierre, On Wed, Jun 20, 2018 at 08:06:31AM +, Pierre Timmermans wrote: > Hi Michael You should avoid top-posting on the Postgres lists, this is not the usual style used by people around :) > Thanks for the confirmation. Your rewording removes the confusion. I > would maybe take the opport

Re: using pg_basebackup for point in time recovery

2018-06-20 Thread Pierre Timmermans
Hi Michael Thanks for the confirmation. Your rewording removes the confusion. I would maybe take the opportunity to re-instate that pg_dump cannot be used for PITR, so in the line of "These are backups that could be used for point-in-time recovery if combined with a WAL archive able to recover up

Re: using pg_basebackup for point in time recovery

2018-06-19 Thread Michael Paquier
Hi Pierre, On Tue, Jun 19, 2018 at 12:03:58PM +, Pierre Timmermans wrote: > Here is the doc, the sentence that I find misleading is "There are > backups that cannot be used for point-in-time recovery", also > mentioning that they are faster than pg_dumps add to confusion (since > pg_dumps cann