Re: On Judging the Value of Tests

2017-11-23 Thread Michael Paquier
On Fri, Nov 24, 2017 at 10:27 AM, Jankirk.Vincent., Jamison wrote: > I will take note of all your advice. I think it's because I've noticed that a > lot of functions and lines are still not covered by tests > (https://coverage.postgresql.org/), so I feel like I want to work on tests > first whi

RE: On Judging the Value of Tests

2017-11-23 Thread Jankirk.Vincent., Jamison
1. How do you judge when a test suite is acceptable to be added to Postgres OSS source code? (How do you judge the value of a test suite?) >>> >>> Make your argument for it, and see if others agree. There's no formal >>> process. > > Yeah. Also realize that we've been accreti

Re: On Judging the Value of Tests

2017-11-21 Thread Tom Lane
Craig Ringer writes: > On 22 November 2017 at 08:43, Jankirk.Vincent., Jamison < > k.jami...@jp.fujitsu.com> wrote: >> 1. How do you judge when a test suite is acceptable to be added to >> Postgres OSS source code? (How do you judge the value of a test suite?) > Make your argument for it, an

Re: On Judging the Value of Tests

2017-11-21 Thread Michael Paquier
On Wed, Nov 22, 2017 at 10:31 AM, Craig Ringer wrote: > On 22 November 2017 at 08:43, Jankirk.Vincent., Jamison > wrote: >> I am entirely very new to PG development. >> >> Currently, I’m studying the test suites, and I feel the more experienced >> PG devs here could provide some insights on testi

Re: On Judging the Value of Tests

2017-11-21 Thread Craig Ringer
On 22 November 2017 at 08:43, Jankirk.Vincent., Jamison < k.jami...@jp.fujitsu.com> wrote: > Dear PG Experts, > > > > I am entirely very new to PG development. > > Currently, I’m studying the test suites, and I feel the more experienced > PG devs here could provide some insights on testing because