Re: REINDEX VERBOSE unknown option

2019-12-18 Thread Josef Šimánek
My patch was partially merged at https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=52dcfda48778d16683c64ca4372299a099a15b96 . Thanks to everyone involved in this discussion. pá 13. 12. 2019 v 2:11 odesílatel Josef Šimánek napsal: > I was thinking about this problem and possible

Re: REINDEX VERBOSE unknown option

2019-11-21 Thread Peter J. Holzer
On 2019-11-21 16:48:14 +, Geoff Winkless wrote: > On Thu, 21 Nov 2019 at 15:32, Peter J. Holzer wrote: > > On 2019-11-21 09:43:26 +, Geoff Winkless wrote: > > > It wasn't meant to be insulting, I meant "esoteric" in the strict > > > sense: that you need to have specific knowledge to parse

Re: REINDEX VERBOSE unknown option

2019-11-21 Thread Geoff Winkless
On Thu, 21 Nov 2019 at 15:32, Peter J. Holzer wrote: > On 2019-11-21 09:43:26 +, Geoff Winkless wrote: > > It wasn't meant to be insulting, I meant "esoteric" in the strict > > sense: that you need to have specific knowledge to parse them. > > I didn't understand it as insulting (why would I?)

Re: REINDEX VERBOSE unknown option

2019-11-21 Thread Peter J. Holzer
On 2019-11-21 09:43:26 +, Geoff Winkless wrote: > On Wed, 20 Nov 2019 at 22:48, Peter J. Holzer wrote: > > > > On 2019-11-19 11:37:04 +, Geoff Winkless wrote: > > > Even if you do that you're still requiring the user to parse syntax > > > according to esoteric rules. > > > > Oh, please. Th

Re: REINDEX VERBOSE unknown option

2019-11-21 Thread Geoff Winkless
On Wed, 20 Nov 2019 at 22:48, Peter J. Holzer wrote: > > On 2019-11-19 11:37:04 +, Geoff Winkless wrote: > > Even if you do that you're still requiring the user to parse syntax > > according to esoteric rules. > > Oh, please. Those "esoteric rules" have been in wide-spread use for > decades.

Re: REINDEX VERBOSE unknown option

2019-11-20 Thread Peter J. Holzer
On 2019-11-19 11:37:04 +, Geoff Winkless wrote: > Even if you do that you're still requiring the user to parse syntax > according to esoteric rules. Oh, please. Those "esoteric rules" have been in wide-spread use for decades. If you look at any manual which tries to explain the syntax of a pro

Re: REINDEX VERBOSE unknown option

2019-11-19 Thread Michael Paquier
On Tue, Nov 19, 2019 at 11:37:04AM +, Geoff Winkless wrote: > It's bad enough that you have the inconsistency that REINDEX VERBOSE > requires parentheses while the more recent REINDEX CONCURRENTLY does > not (presumably to match the syntax of CREATE INDEX CONCURRENTLY), > without insisting that

Re: REINDEX VERBOSE unknown option

2019-11-19 Thread Geoff Winkless
On Mon, 18 Nov 2019 at 22:24, Peter J. Holzer wrote: > > On 2019-11-18 12:24:40 +, Geoff Winkless wrote: > > On Mon, 18 Nov 2019 at 11:46, Michael Paquier wrote: > > > On Mon, Nov 18, 2019 at 10:27:24AM +0100, Josef Šimánek wrote: > > > > This is clear once you understand what does it mean. I

Re: REINDEX VERBOSE unknown option

2019-11-18 Thread Peter J. Holzer
On 2019-11-18 12:24:40 +, Geoff Winkless wrote: > On Mon, 18 Nov 2019 at 11:46, Michael Paquier wrote: > > On Mon, Nov 18, 2019 at 10:27:24AM +0100, Josef Šimánek wrote: > > > This is clear once you understand what does it mean. I was aware of > > > VERBOSE > > > option of EXPLAIN and tried t

Re: REINDEX VERBOSE unknown option

2019-11-18 Thread Geoff Winkless
On Mon, 18 Nov 2019 at 11:46, Michael Paquier wrote: > On Mon, Nov 18, 2019 at 10:27:24AM +0100, Josef Šimánek wrote: > > This is clear once you understand what does it mean. I was aware of VERBOSE > > option of EXPLAIN and tried to use it without needed parentheses (the same > > way EXPLAIN can u

Re: REINDEX VERBOSE unknown option

2019-11-18 Thread Michael Paquier
On Mon, Nov 18, 2019 at 10:27:24AM +0100, Josef Šimánek wrote: > This is clear once you understand what does it mean. I was aware of VERBOSE > option of EXPLAIN and tried to use it without needed parentheses (the same > way EXPLAIN can understand it). In the parameter list of REINDEX, it is > still

Re: REINDEX VERBOSE unknown option

2019-11-18 Thread Josef Šimánek
po 18. 11. 2019 v 7:42 odesílatel Michael Paquier napsal: > On Sun, Nov 17, 2019 at 04:41:59AM +0100, Pavel Stehule wrote: > > Documentation patch is good idea. > > The documentation is rather clear about the need to of parenthesis > when using the VERBOSE option, and that it is not a mandatory o

Re: REINDEX VERBOSE unknown option

2019-11-17 Thread Michael Paquier
On Sun, Nov 17, 2019 at 04:41:59AM +0100, Pavel Stehule wrote: > Documentation patch is good idea. The documentation is rather clear about the need to of parenthesis when using the VERBOSE option, and that it is not a mandatory option: REINDEX [ ( VERBOSE ) ] { INDEX | TABLE | SCHEMA | DATABASE |

Re: REINDEX VERBOSE unknown option

2019-11-16 Thread Pavel Stehule
so 16. 11. 2019 v 18:43 odesílatel Josef Šimánek napsal: > Ahh, I just tried to do the same with reindexdb cli tool and the > actual syntax is REINDEX (VERBOSE) TABLE sales; Sorry for unnecessary > question. Anyway maybe we can add this to documentation as a example. I can > prepare patch for thi

Re: REINDEX VERBOSE unknown option

2019-11-16 Thread Josef Šimánek
Ahh, I just tried to do the same with reindexdb cli tool and the actual syntax is REINDEX (VERBOSE) TABLE sales; Sorry for unnecessary question. Anyway maybe we can add this to documentation as a example. I can prepare patch for this if welcomed. so 16. 11. 2019 v 18:40 odesílatel Josef Šimánek n

REINDEX VERBOSE unknown option

2019-11-16 Thread Josef Šimánek
Hello, according to https://www.postgresql.org/docs/11/sql-reindex.html VERBOSE option is valid for REINDEX command for 11.3 PostgreSQL server. Anyway I'm getting error using VERBOSE option. project_production=# REINDEX VERBOSE TABLE sales; ERROR: syntax error at or near "VERBOSE" LINE 1: REINDE