Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Barry Walker
> Now you tell us? > > If that's the case, I wonder whether probes.o is getting built > correctly and included in the link. The relevant bits are in > src/backend/Makefile ... they don't look that easy to mess up, > but maybe. I thought I mentioned it in my original message but it wasn't super cl

Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Tom Lane
Barry Walker writes: > Yes it was. My thinking though is that I am getting this error with every > probe, not just the ones in xact.c Now you tell us? If that's the case, I wonder whether probes.o is getting built correctly and included in the link. The relevant bits are in src/backend/Makefil

Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Barry Walker
>I'd read > > https://www.postgresql.org/docs/current/dynamic-trace.html#DEFINING-TRACE-POINTS > > >and then go see if those tracepoints are fully conforming to the >coding rules in the modified version. A plausible bet is that >their entries in probes.d don't entirely match up with the calls >in

Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Barry Walker
> Was the customization done under version control? Yes it was. My thinking though is that I am getting this error with every probe, not just the ones in xact.c so I suspect there is something more than just a code change to the file. I compared the common makefiles and don't see any changes that w

Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Adrian Klaver
On 10/20/24 12:02, Barry Walker wrote: Unfortunately the people remaining are just as lost as me. No one has attempted to build with dtrace so I'm in uncharted territory. Was the customization done under version control? If so then as last resort use bisect or equivalent to find the breaking

Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Tom Lane
Barry Walker writes: > I have compiled vanilla pg16.4 with the same flags and the probes got > created and linked as expected with no issues so I'm assuming there is some > difference in the custom version that is causing the errors but I'm having > a hard time tracking it down. I'm wondering if a

Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Barry Walker
Unfortunately the people remaining are just as lost as me. No one has attempted to build with dtrace so I'm in uncharted territory. A diff of the object file doesn't give any useful information, the custom version has a lot of differences since there have been a number of changes from stock. postg

Re: Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Adrian Klaver
On 10/20/24 09:30, Barry Walker wrote: Hey folks, I have compiled vanilla pg16.4 with the same flags and the probes got created and linked as expected with no issues so I'm assuming there is some difference in the custom version that is causing the errors but I'm having a hard time tracking

Help Resolving Compiler Errors With enable-dtrace Flag

2024-10-20 Thread Barry Walker
Hey folks, I'm working on a custom version of Postgres that is roughly in line with 16.4 but has customizations in it. I'm trying to compile this custom version (on Linux) with `--enable-dtrace` but I'm running into an issue during the linker stage. I've done a clean and full rebuild but that does