Re: Error messages on duplicate schema names

2021-01-19 Thread Michael Paquier
On Tue, Jan 19, 2021 at 05:37:51PM -0300, Alvaro Herrera wrote: > I guess you could make the case that the CCI call should be in the > callers where we actually loop (SetDefaultACLsInSchemas, > RemoveRoleFromObjectACL), but it's hard to get excited about the added > clutter. Yeah, that matches my

Re: Error messages on duplicate schema names

2021-01-19 Thread Alvaro Herrera
On 2021-Jan-15, Michael Paquier wrote: > On Wed, Jan 06, 2021 at 07:15:24PM +0200, Andrus wrote: > > Should duplicate schema names accepted or should their usage throw better > > error messages. > > This means that we are one call of CommandCounterIncrement() short for > such queries, and similar

Re: Error messages on duplicate schema names

2021-01-14 Thread Michael Paquier
On Wed, Jan 06, 2021 at 07:15:24PM +0200, Andrus wrote: > Should duplicate schema names accepted or should their usage throw better > error messages. This means that we are one call of CommandCounterIncrement() short for such queries, and similar safeguards already exist in this area for GRANT/REV

Error messages on duplicate schema names

2021-01-06 Thread Andrus
Hi! ALTER DEFAULT PRIVILEGES IN SCHEMA public,public   GRANT all ON TABLES TO testoig; Throws strange error Tuple already updated by self In other case which I posted duplicate schema causes another strange error duplicate key value violates unique constraint "pg_default_acl_role_nsp_obj_i