On Fri, Sep 12, 2025 at 9:35 PM Dominique Devienne wrote:
>
> On Fri, Sep 12, 2025 at 3:29 PM Dominique Devienne
> wrote:
> > On Fri, Sep 12, 2025 at 3:24 PM Dominique Devienne
> > wrote:
> > > On Fri, Sep 12, 2025 at 3:11 PM Dominique Devienne
> > > wrote:
> >
> > > So I don't see how my `.
On Sat, 2025-09-13 at 17:00 -0400, Tom Lane wrote:
> Laurenz Albe writes:
> > I came up with the attached patch set.
>
> I did some more work on the comments, adjusted a couple of places that
> could be simplified, and pushed it.
Thank you!
> > I used two separate patches for clarity and ease o
On Fri, 2025-09-12 at 21:53 -0400, Tom Lane wrote:
>
> Ah, got it. But this logic definitely deserves more comments.
> What do you think of something like
>
> if (pchar == ']' && charclass_start > 2)
> {
> /* found the real end of a bracket pair */
>
On Fri, 2025-09-12 at 20:12 -0400, Tom Lane wrote:
> I had not particularly studied the new charclass-parsing logic.
> Looking at it now, this bit further down (lines 871ff) looks
> fishy:
>
> if (pchar == ']' && charclass_start > 2)
> charclass_depth--;
> e
